[00:42] <robert_ancell> GunnarHj, I'm not sure about other desktops, but when I looked into fixing the XDG_CURRENT_DESKTOP usage it seemed that very few (if any) of them make sense anyway.
[00:42] <robert_ancell> So if we fix those first we'll be able to see what remains.
[00:42] <robert_ancell> I think the answer is if it is being used by other desktops it still makes sense to show all the options
[00:55] <GunnarHj> robert_ancell: Of course, as long as we aren't sure that it won't be used by other desktops, it makes sense to keep the options. I suppose that it's a little late in the cycle to figure it out. I'll try this weekend to make an MP which fixes the tests so they handle cases like "GNOME-Flashback:Unity" properly. And also make sure that u-c-c does not override an existing XDG_CURRENT_DESKTOP value, but only sets "Unity" as a fallba
[00:55] <GunnarHj> ck if XDG_CURRENT_DESKTOP is empty for some reason.
[00:56] <robert_ancell> GunnarHj, I think it's been set because some of the panels have OnlyShowIn=Unity. Which seems to me like they should just be fixed to either have a list of desktops or u-c-c should show them regardless of what desktop it is in.
[00:57] <robert_ancell> I'm fixing GTK+ at the moment
[01:04] <GunnarHj> robert_ancell: If I understand it correctly, the panels will be shown in the case of OnlyShowIn=Unity as long as Unity is one of the elements in XDG_CURRENT_DESKTOP's colon separated list. So in the example I mentioned (GNOME-Flashback:Unity) the panels should be shown. (But I haven't tested yet.) In that case, it's the remaining XDG_CURRENT_DESKTOP tests within u-c-c which need to be modified (split on ":" etc.).
[03:00] <robert_ancell> attente, ping?
[03:01] <robert_ancell> attente, oh, now I get it. No problem.
[05:53] <hikiko> hi
[06:46] <didrocks> good morning
[08:19] <andyrock> good morning
[08:47] <darkxst> GunnarHj, late reply to your XDG_CURRENT_DESKTOP comment, the desktop files are not an issue, yes OnlyShowIn=Unity works fine with GNOME-Flashback:Unity
[08:51] <pitti> seb128: bonjour ! comment ça va?
[08:51] <seb128> salut pitti, ça va bien et toi ?
[08:52] <pitti> seb128: je vais mieux, merci
[08:52] <seb128> super !
[08:52] <pitti> seb128: gnome-desktop got removed in Debian; we still have one rdepends, banshee
[08:52] <seb128> how did Debian fix that?
[08:53] <pitti> https://tracker.debian.org/news/712556
[08:54] <pitti> seb128: that's a newer upstream version, though
[08:54] <seb128> right, i was going to say
[08:54] <pitti> seb128: (doing process-removals today, and it's depressing..)
[08:54] <pitti> seb128: so, do we want to merge and follow along? or keep that old stuff?
[08:54] <seb128> (why? less to maintain is good no?)
[08:55] <pitti> seb128: well, once you can *actually* remove packages, yes :) but I'm running into countless cases of "one rdepends left in Ubuntu which hasn't been merged/updated in ages"
[08:55] <pitti> I did a few, but this is a ratsnest :)
[08:56] <seb128> I've no idea about banshee, I never really used it and didn't look at it for years
[08:56] <pitti> right, i. e. do we still actually want to keep it}
[08:56] <pitti> ?
[08:56] <seb128> if the new version is only in experimental there might be a reason
[08:56] <seb128> I assume we do
[08:56] <pitti> seb128: ah no, unstable has https://tracker.debian.org/news/712782
[08:57] <seb128> having things in universe doesn't cost us much, we can as well keep it
[08:57] <pitti> which also dropped the deps
[08:57] <seb128> nice
[08:57] <pitti> well, it's still growing tech debt
[08:57] <seb128> let's just do that then
[08:57] <pitti> Version: 2.9.0+really2.6.2-3ubuntu1
[08:57] <seb128> it's not like universe was close from not have all sort of old unmaintained things
[08:57] <pitti> so at some point we wanted to go back, but I don't have the details any more
[08:57] <seb128> having*
[08:57] <seb128> or had ever been
[08:57] <pitti> at some point we had ubuntuone integration and all that, perhaps that's all obsolete
[08:58] <seb128> yeah
[08:58] <pitti> Downgrade to 2.6.1 -- 2.9.x is unstable and 3.0 won't arrive in time for
[08:58] <pitti>     release
[08:58] <pitti> (09 Feb 2014)
[08:59] <seb128> if somebody wants to update it/clean patches they can go for it
[08:59] <pitti> I suppose that's still true :)
[08:59] <pitti> well, that's the thing -- nobody does it
[08:59] <seb128> I wouldn't spend efforts on universe things
[08:59] <seb128> right
[08:59] <pitti> (and no, I've already touched too many KDE packges to pile up even more TIL)
[08:59] <seb128> like for some other 10k packages in universe
[08:59] <seb128> I would just ignore it
[08:59] <willcooke> morning all
[08:59] <seb128> hey willcooke
[08:59] <willcooke> TheMuso, be with you in 5
[09:00] <pitti> seb128: this all started with me cleaning up some wx2.8 stuff for removing gst 0.10; shouldn't have done this :)
[09:00] <TheMuso> willcooke: No worries.
[09:00]  * TheMuso waves to everybody else. :)
[09:00]  * pitti waves back to TheMuso
[09:01] <seb128> pitti, good man, trying to fight the universe ;-)
[09:01] <Laney> morning!
[09:01] <pitti> hey Laney
[09:01] <seb128> hey TheMuso
[09:01] <seb128> hey Laney
[09:01] <pitti> seb128: do I look green and really musculous yet?
[09:02] <darkxst> Hey Laney seb128 willcooke
[09:02] <seb128> we need a sprint or UDS so I can tell you :p
[09:02] <seb128> hey
[09:02] <Laney> what's up?
[09:03] <pitti> http://vignette1.wikia.nocookie.net/vsbattles/images/8/88/AoU_Hulk_0004.png/revision/latest?cb=20150608160344 ← me running process-removals
[09:04] <seb128> pitti, going to clean up libgnome gnome-vfs etc from the archive next, right? ;-)
[09:04]  * seb128 hides
[09:04] <pitti> seb128: the cleaning isn't the problem :)
[09:04] <darkxst> enjoying the wet weather for a change ;)
[09:05] <darkxst> good time to do a pilot shift when you can't physically leave the house ;)
[09:08] <seb128> indeed!
[09:08] <pitti> checking for Mono 2.0 GAC for Mono.Cairo.dll... not found
[09:08] <pitti> configure: error: missing required Mono 2.0 assembly: Mono.Cairo.dll
[09:08] <pitti> ^ awesome, banshee is FTBFS
[09:09] <pitti> so at some point doko will haunt you anyway :)
[09:09] <seb128> pitti, how did you manage to get a vivid upload to xenial?
[09:09] <seb128> "xchat-indicator (0.3.11-0ubuntu7) vivid; urgency=medium"
[09:09] <seb128> "  * Add hexchat-indicator."
[09:09] <seb128> that's confusing
[09:09] <pitti> wut?
[09:09] <seb128> on xenial-changes
[09:10] <pitti> ah sorry, part of cleaning up xchat, just noise
[10:10] <willcooke> Trevinho, hikiko - Shadows vs CSD fixes....
[10:10] <willcooke> So hikiko is close to landing a fix for shadows in Compiz which will fix it for all apps not just Gtk
[10:10] <willcooke> hikiko, you think it will be finished today?
[10:11] <willcooke> and how much work is there still to do on E Zoom?
[10:11] <hikiko> I hope so willcooke
[10:11] <hikiko> on ezoom I am blocked at an issue
[10:11] <hikiko> transformation stack
[10:11] <hikiko> I use compiz transformations with nux but there's something that doesn't work
[10:11] <hikiko> if I fix tha
[10:11] <hikiko> that
[10:12] <hikiko> then it's like 2 days work
[10:12] <hikiko> the trick there is to pass the compiz ezoom transformation to all the nux components
[10:12] <hikiko> but for some reason some of them misbehave
[10:12] <Trevinho> hikiko: as I said, if you can figure out that ezoom thing, it would be cool... As it helps in a11y. As for gtk apps I think we're all set now. Not the best fix, but it's good enough and we can then try to fix it better later (and in case SRU to xenial), but the one we've now to me is fine.
[10:12] <hikiko> and I am looking for that "reason" :.
[10:12] <hikiko> :/
[10:13] <hikiko> well, the thing is that the proper fix is almost done and will work with all transparent windows
[10:13] <hikiko> if qt decides to have transparency
[10:13] <hikiko> that will work too
[10:13] <hikiko> your hack is cool but works only with gtk
[10:14] <hikiko> so, depends on how much we want to support everything
[10:14] <hikiko> or just gtk
[10:14] <Trevinho> yeah, but it's all we need for now... as transparent windows are in general something that should care about their shadows by design.
[10:15] <Trevinho> I've seen a branch on compiz side, which is only gtk related, but we can't do that without changing the whole compiz geo system (which is something we can't do now)
[10:15] <Trevinho> instead if you can extract alpha from windows and get its shape it would be cool, but still we can't apply that to all windows... Since we can't be sure that a window is already providing a shadow (and thus double-shadowing it). I think to cairo-dock for example
[10:16] <hikiko> you mean that we don't need a general solution that supports all the windowxs?
[10:16] <hikiko> what do you mean?
[10:16] <hikiko> we have 1- rectangular windows (supported)
[10:16] <hikiko> 2- shaped windows (supported)
[10:17] <hikiko> 3- windows that are not shaped - not rectangular and have alpha (under construction)
[10:17] <hikiko> how it comes and we double shadow them?
[10:18] <Trevinho> Yeah, 3 is fine, but as I said if you try apps like cair-dock, or many other alpha windows around, they already provide their own shadow. Since being alpha is a contract with compositor that says: "I'm caring about my own shadows". So, for gtk ones or anyone supporting us, we can say "Ok, I'm alpha, but I still want your shadows". we unfortunately can't
[10:18] <Trevinho> apply that to any window, without risking regressions
[10:19] <Trevinho> Anyway, if you can get 3 on is nice, but I think we can now delay that compared to ezoom.
[10:19] <hikiko> 1 day? :p
[10:19] <Trevinho> If you have some code I can look at, I might help anwyay
[10:19] <Trevinho> ok
[10:21] <willcooke> ok, hard dead line is midday UTC tomorrow.  If it's not done, then work stops there and we move to E Zoom.  How's that sound hikiko, Trevinho?
[10:21] <hikiko> fine for me
[10:21] <Trevinho> k
[10:25] <willcooke> the clock is ticking . . . . . .
[10:25] <willcooke> ;)
[10:25] <willcooke> good luck!
[10:39] <muktupavels> hikiko, https://code.launchpad.net/~albertsmuktupavels/compiz/add-gtk-frame-extents-to-net-supported/+merge/257303
[10:49] <Trevinho> muktupavels: we can't have that without proper geometry rework... And it's too tricky to get it done with few lines unforunately
[10:50] <Trevinho> anyway....
[10:50] <hikiko> lol https://code.launchpad.net/~hikiko/compiz/compiz.black-dots-fix
[10:50]  * Trevinho drives back to Florence
[10:50] <hikiko> ok he did it first I approve it in a sec
[10:50] <Trevinho> hikiko: no, please...
[10:50] <hikiko> why not?
[10:51] <hikiko> it doesn't seem to damage anything else?
[10:51] <Trevinho> hikiko: enabling that, changes the way gtk exposes their area. And it creates a bigger input area which breaks things for us
[10:51] <Trevinho> https://code.launchpad.net/~albertsmuktupavels/compiz/add-gtk-frame-extents-to-net-supported/+merge/257303/comments/680812
[10:51] <muktupavels> Trevinho, I posted link because hikiko branch had same fix and it had some comments...
[10:52] <Trevinho> yeah, hikiko see the comments
[10:52] <hikiko> sec
[10:52] <Trevinho> so without fixing the compiz geometry we can't land that.
[10:53] <Trevinho> and removing these borders from compiz geo seems to be harder than expected. I spent more than a week on that, but it's problematic
[10:53] <hikiko> I know what you mean
[10:53] <hikiko> that the pixmap
[10:54] <hikiko> has some space for decorations around
[10:54] <hikiko> well we can just clip the image to remove it isn't it?
[10:57] <Trevinho> hikiko: yeah, but I failed in doing that
[10:59] <Trevinho> anyway, for removing the black dotsit's not a problem patching gtk and using a rgba surface in unity, so, we can live without that change
[10:59]  * Trevinho has to go
[10:59] <muktupavels> Trevinho, hikiko: does not gtk+ add bigger input area only when window-frame has margin != 0 and/or box-shadow != none. If Ambiance does not add that css then should not be problem.
[10:59] <hikiko> I was going to clip the pixmap on unity anyway because I need that for the shadows
[10:59] <hikiko> +1 muktupavels
[11:00] <hikiko> I think so, I'll test that
[12:48] <bregma> willcooke, did you get that ask from the ubuntu-docs team about desktop change notes for 16.04?
[12:50] <willcooke> bregma, I didn't, but strangely enough I sent an email out about 10 mins ago to start gathering release notes
[12:51] <willcooke> davmor2, cyphermox - do you know - are we supposed to inhibit the screensave during a dist-upgrade?
[12:52] <willcooke> davmor2, I forgot to disable the screensaver, and not I'm stuck at the prompt again.  Sigh.  Start again.
[12:52] <willcooke> *now
[12:52] <davmor2> willcooke: there was mention of it I think in one of the logs
[12:53] <willcooke> bregma, oh, maybe I misunderstood the question?
[12:54] <bregma> willcooke, sound like you're on it, just crossing the task off my list
[12:55] <willcooke> bregma, oki cool.  Very strange timing though, like I thought of it minutes before you mentioned it.  Maybe be have a physic link?
[12:55] <willcooke> what's that?  Take a hammer from the shed?
[12:56] <davmor2> willcooke: 2016-03-10 11:46:23,912 DEBUG Removing 'xscreensaver' (ubuntu-desktop PostUpgradeRemove rule) I'd say that was a pretty brutal way to ensure that the screensaver didn't kick in :)
[12:57] <willcooke> nah, that wont stop it running though
[12:58] <willcooke> there is a "nice" way to inhibit it
[12:58] <willcooke> but perhaps we shouldnt have to
[14:44] <cyphermox> willcooke: screensaver or not should not make a difference in the upgrade, things shouldn't crash as a result of the upgrade.
[14:44] <willcooke> cyphermox, oki
[14:45] <willcooke> trying again with screensaver etc turned off
[14:45] <willcooke> just to see if I can find the exact moment it dies
[14:48] <willcooke> ah
[14:49] <willcooke> I wonder if this is why we're not getting GUI prompts davmor2
[14:50] <willcooke> Something about debconf needs a screen at least 13 lines high, blah blah, falling back to readline
[14:50] <willcooke> I'm running the install on a vbox
[14:50] <willcooke> with a poor resolution
[14:50] <willcooke> that might explain that issue anyway.
[14:57] <cyphermox> willcooke: readline should be "sufficient" and the prompts would then show in the attached terminal window
[14:57] <willcooke> cyphermox, yeah, thats what happens
[14:57] <cyphermox> I mean, I see that the install on davmor's machine i stuck waiting for input for ssl, but I don't think that's the issue -- the no X is more of a problem
[14:58] <cyphermox> that said, I'm logged on SSH on dave's machine, and I'll try to debug compiz live maybe?
[14:58] <cyphermox> did we have a crash dump for it yet?
[14:59] <willcooke> dont think so
[15:07] <willcooke> okay
[15:08] <willcooke> the point at which the upgrader UI crashes is about here...
[15:08] <willcooke> Preparing to unpack .../xfonts-base_1%3a1.0.4+nmu1_all.deb ...
[15:08] <willcooke> Unpacking xfonts-base (1:1.0.4+nmu1) over (1:1.0.3) ...
[15:08] <willcooke> Preparing to unpack .../xfonts-scalable_1%3a1.0.3-1.1_all.deb ...
[15:08] <willcooke> Unpacking xfonts-scalable (1:1.0.3-1.1) over (1:1.0.3-1) ...
[15:08] <willcooke> Preparing to unpack .../xinit_1.3.4-3_amd64.deb ...
[15:08] <willcooke> Unpacking xinit (1.3.4-3) over (1.3.2-1) ...
[15:08] <willcooke> Preparing to unpack .../xinput_1.6.2-1_amd64.deb ...
[15:09] <willcooke> and then the upgrade seems to stop here:
[15:09] <willcooke> Setting up python-debtagshw (2.0.1ubuntu6) ...
[15:09] <willcooke> Setting up ureadahead (0.100.0-19) ...
[15:09] <willcooke> Setting up perl-modules-5.22 (5.22.1-8) ...
[15:09] <willcooke> and it kicked me out of one of my SSH sessions
[15:10] <cyphermox> ok
[15:11] <cyphermox> that was using the graphical release-upgrader?
[15:11] <willcooke> that was using "update-manager -d"
[15:11] <cyphermox> (ie. not do-release-upgrade -d in a terminal)
[15:11] <cyphermox> ok
[15:11] <cyphermox> I probably wouldn't make a difference, but just in case
[15:11] <willcooke> so I had top running in another ssh session
[15:12] <willcooke> and it kicked me out of that session at about  15:05:58
[15:12] <willcooke> I still have one ssh session open some hout
[15:12] <willcooke> how
[15:12] <willcooke> and in syslog
[15:12] <willcooke> Mar 10 15:05:22 test14to16 ModemManager[28639]: <info>  Couldn't find support for device at '/sys/devices/pci0000:00/0000:00:03.0': not supported by any plugin
[15:12] <willcooke> Mar 10 15:05:57 test14to16 dbus[394]: [system] Reloaded configuration
[15:12] <willcooke> Mar 10 15:06:00 test14to16 dbus[394]: message repeated 2 times: [ [system] Reloaded configuration]
[15:12] <willcooke> Mar 10 15:06:00 test14to16 dbus[394]: [system] Activating service name='org.freedesktop.UDisks2' (using servicehelper)
[15:12] <willcooke> Mar 10 15:06:00 test14to16 udisksd[29495]: udisks daemon version 2.1.7 starting
[15:12] <willcooke> Mar 10 15:06:00 test14to16 dbus[394]: [system] Activating service name='org.freedesktop.PolicyKit1' (using servicehelper)
[15:12] <willcooke> Mar 10 15:06:00 test14to16 polkitd[29500]: started daemon version 0.105 using authority implementation `local' version `0.105'
[15:14] <willcooke> oh, and I had disabled the lock and the screensaver before running this upgrade
[15:15] <willcooke> last thing in dpkg.log:
[15:15] <willcooke> 2016-03-10 15:06:26 status installed libgtkmm-3.0-1v5:amd64 3.18.0-1
[15:18] <willcooke> ummmm
[15:18] <willcooke> I wonder
[15:18] <willcooke> apt.log:
[15:18] <willcooke> MarkDelete python3.4 [ amd64 ] < 3.4.3-1ubuntu1~14.04.3 > ( python ) FU=0
[15:19] <cyphermox> willcooke: gtkmm is not typically something that would break everything
[15:19] <willcooke> I wonder if the installer has removed python from underneath the installer?
[15:19] <cyphermox> though a GLib / Gtk upgrade at the wrong time might cause crashes
[15:20] <cyphermox> willcooke: I thought all of X crashed?
[15:20] <willcooke> oh, right yeah
[15:20] <willcooke> yeah my X session is dead now
[15:21] <willcooke> nothing in /var/crash
[15:21] <willcooke> xorg log:
[15:21] <willcooke> [  6323.283] (EE) FBDEV(0): FBIOBLANK: Invalid argument
[15:21] <willcooke> [  6323.297] (EE) FBDEV(0): FBIOBLANK: Invalid argument
[15:24] <willcooke> restarted lightdm
[15:25] <willcooke> init: Error while reading from descriptor: Bad file descriptor
[15:25] <willcooke> instead of a greeter
[15:34] <GunnarHj> darkxst: Thanks for confirming about multidesktop XDG_CURRENT_DESKTOP values and .desktop files.
[15:53] <davmor2> willcooke, cyphermox: I think it just hates us :'(
[15:54] <willcooke> :((
[15:55] <davmor2> oh Laney looks like you might actually be able to detach the hdmi lead from the xps now without kernel panicking the system \o/ I don't want to try it again incase it was pure fluke :D
[16:48] <Laney> davmor2: :-o
[17:10] <attente> Laney: hey, is there some way to ask someone (aptdaemon/packagekit) over dbus to do an apt update? i tried org.debian.apt.RefreshCache but that didn't populate /var/lib/app-info/
[17:16] <Laney> attente: I'm not sure, I would ask juliank in #ubuntu-devel - he's more likely to know
[17:17] <attente> ok, thanks
[17:17] <Laney> maybe that function does it in some different way that doesn't run the Post-Update-Success hook
[17:18] <attente> Laney: it's hard to tell what that function does at all. it seems to do nothing afaict
[17:19] <Laney> what does (e.g.) software-properties use?
[17:31] <attente> Laney: ok, desrt just helped me out here. apparently i have to create a transaction and call GetUpdates on it
[17:33] <Laney> cool
[17:33] <Laney> sorry I don't know those APIs very well & I'm in the middle of my quest to kill juju
[17:42] <desrt> Laney: we kinda want to expand your original bug
[17:42] <desrt> and make it so that we do a refresh on startup any time we detect that the last time 'apt update' was run is more than 1 day ago (or never)
[17:43] <desrt> it turns out that the timestamp on /var/cache/apt is a pretty good place to start -- but it's a bit complicated if this directory was created during install and nobody actually ran 'apt update' yet
[17:43] <Laney> desrt: as long as you fix the bug then you can expand whatever you want
[17:43] <Laney> the rest is a matter for robert_ancell
[17:43] <desrt> it would also be ideal if we could plumb this through packagekit...
[17:44] <desrt> well, fixing it is easy enough now that we found the right set of APIs
[17:44] <Laney> sehr gut
[17:44] <desrt> but "first install and user didn't apt update yet" is not the only place where apps may be missing
[17:44] <desrt> could be nobody ran "apt update" in months and apps got added in the meantime
[17:45] <Laney> update-manager is updating for you
[17:45] <desrt> just not right after install :p
[17:45] <Laney> right
[17:45] <desrt> can we fix that? :D
[17:46] <Laney> not for the general 'sudo apt install gnome-software' case
[17:46] <desrt> i ate you
[17:47] <desrt> actually, i'm kinda hungry
[17:47] <Laney> I think that ximion said that g-s already does have this timed refresh thing
[17:47] <Laney> just not the always-do-it-if-empty case
[17:47] <desrt> ya... i think it stores the timestamp int he user session tho
[17:47] <desrt> we could do the same here....... just seems ugly to have 100 copies of timestamps stored per user for the same thing (which is really system-wide)
[17:48] <Laney> for apt it is...
[17:48] <desrt> like, even separate copies of it stored for the same user, even
[17:48] <desrt> true.
[17:48]  * desrt snaps her fingers
[17:48] <Laney> anyways!
[17:48] <desrt> ya.  a bit of a sidetrack here
[17:48] <Laney> As long as updaters have it working
[17:48] <desrt> seems that the easiest thing to do now is to fix the bug as filed, using the dbus api
[17:48] <Laney> any extra coolness is cool too
[17:49] <ximion> Laney: that timed refresh doesn't happen though if you patch out the g-s daemon mode
[17:49] <desrt> it's cool to be cool!
[17:49] <desrt> kaj mojoseco mojosas
[17:49] <Laney> ximion: ok I didn't track what they did on the client side to be honest
[17:49] <ximion> Laney: AFAIr removed that feature ^^
[17:50] <ximion> (but better check for that, don't take my word for it)
[17:51] <attente> we disabled daemon mode except in the case where it's explicitly run with --gapplication-service
[17:51] <desrt> is it DBusActivatable?
[17:51] <attente> yes
[17:52] <desrt> so then it's always run with --gapplication-service...
[18:08] <willcooke> g'nigth all
[18:08] <willcooke> night
[18:12] <Laney> me too, see you
[18:15] <seb128> night Laney & co
[19:46] <desrt> good night europeans
[20:58] <robert_ancell> tkamppeter, I'm looking at the unity-settings-daemon code and the print notification plugin seems completely disabled. Does that make sense? I'm going to drop all the code for it if that's the case.
[21:06] <Trevinho> Mh, with recent changes I did, I'm about to think that all the apps we patched to get headerbar would just look better as native... 🙊
[21:06] <Trevinho> starting from https://code.launchpad.net/~3v1n0/ubuntu-themes/toolbar-mode-headerbar-gradient/+merge/288701 (and related gtk patch)
[21:07] <robert_ancell> Trevinho, yeah, they look nice now
[21:07] <Trevinho> robert_ancell: about that.... can you give a look at the gtk branch? 😃
[21:08] <robert_ancell> Trevinho, which branch?
[21:08] <Trevinho> robert_ancell: https://code.launchpad.net/+branch/~3v1n0/gtk/unity-maximized-headerbar-buttons-hide
[21:09] <robert_ancell> Trevinho, you have an unused local variable "unity_environment" in the patch
[21:09] <Trevinho> I do use it...
[21:09] <robert_ancell> Trevinho, you use priv->unity_environment
[21:10] <robert_ancell> oh, duh
[21:10] <robert_ancell> reading the patch wrong
[21:10] <Trevinho> :)
[21:10] <robert_ancell> I thought that was at the top of the function
[21:10] <robert_ancell> Reviewing patches really feels wrong
[21:10] <robert_ancell> It's like we have a better system for all this... version control?
[21:10] <Trevinho> Actually I should probably change it so that it only hides the title if != from toplevel window title
[21:10] <robert_ancell> ;)
[21:11] <Trevinho> Maybe somneone could set an headerbar title that is different...
[21:12] <robert_ancell> Trevinho, yeah, I was thinking that might even be likely. Do HeaderBar apps even set the traditional title?
[21:13] <robert_ancell> Also, the placement of the title is probably significant (i.e. being centered)
[21:13] <robert_ancell> Or does Unity handle that
[21:50] <Trevinho> robert_ancell: placement shouldn't be a problem,...
[21:51] <Trevinho> robert_ancell: I've updated the patch to care about window title, though.
[22:20] <tkamppeter> robert_ancell, I did not really have a look at the print notifications on the desktop. CUPS produces notifications on D-Bus which I have already made use of in cups-browsed (making use of some code snippets of larsu's printer-indicator).
[22:21] <tkamppeter> robert_ancell, I think it is a good idea to have some kind of notifications, so that users can access their jobs and know which printers are currently free.
[22:21] <robert_ancell> tkamppeter, I think g-s-d had some notification system that we disabled, so it's no longer required in u-s-d
[22:23] <tkamppeter> robert_ancell, could be either the printer indicator showing a printer at the top right and having a menu to reach the print queues or like in mpt's printing design a printer in the launcher on the left, doing more or less the same thing.
[22:24] <tkamppeter> robert_ancell, if both g-s-d and u-s-d are running, then only one needs to handle printing notification (to avoid duplicates), so if both contain the code, it can be dropped in one.
[22:24] <tkamppeter> robert_ancell, and g-s-d is probably the better place as it is running in both Unity and GNOME desktops.
[22:25] <robert_ancell> tkamppeter, u-s-d checks if it is running in Unity and disables the code. I just wanted to check you didn't expect u-s-d to provide this functionality
[22:27] <tkamppeter> robert_ancell, I did not code anything of the print notification functionality for the desktop, we only should make sure not to duplicate functionality to ease maintaining the code and make sure that all users get notifications, both of GNOME and of Unity.