=== Saviq_ is now known as Saviq [08:51] Mirv: ping [09:00] pstolowski: rebuild silo! [09:02] tsdgeos: pong [09:03] Mirv: how convincing do i have to be to get https://codereview.qt-project.org/#/c/151559/ into our packages? [09:10] tsdgeos: filing a Launchpad bug would be enough [09:12] tsdgeos, 71? [09:13] pstolowski: filters, 54? [09:13] Mirv: ok, doing [09:23] tsdgeos, ok, I can, just remember Saviq has a new one with filters in it and plethora of other unity8 stuff (silo 41) [09:23] ah yeah [09:23] i just was going to tell you that [09:23] i was just reading his email :D [09:23] https://requests.ci-train.ubuntu.com/#/ticket/1105 [09:23] tsdgeos, do you need silo 54 still for any testing? [09:23] guess not [09:23] can anyone retrigger that silo or has to be mzanetti? [09:24] I'm here [09:24] mzanetti: can you rebuild https://requests.ci-train.ubuntu.com/#/ticket/1105 ? [09:24] tsdgeos, i could but don't want to get in the way, not sure what's happening to that silo [09:24] just merged a few branches [09:24] tsdgeos, fwiw, everyone that has approved lander status can. so you can do too [09:24] but no prob. I'll do [09:24] tsdgeos, will keep 54 around for a while just in case we need to test/fix something quickly [09:24] pstolowski: k [09:25] mzanetti: k [09:30] man Saviq goes away for a day and the CI already broke :D [09:30] * tsdgeos retriggers all jobs [09:33] haha [09:35] Mirv: https://bugs.launchpad.net/ubuntu/+source/qtdeclarative-opensource-src/+bug/1556842 [09:35] Launchpad bug 1556842 in qtdeclarative-opensource-src (Ubuntu) "Backport patch so that forceLayout calls layout on more occasions" [Undecided,New] [09:37] tsdgeos: thank you === shuduo is now known as shuduo-afk [10:52] mzanetti, please let me know when you guys sort out the issues Saviq mentioned in the email & silo 41 is ready for proper testing (i'd like to check filters once again in this silo) [10:53] pstolowski, ack [11:10] mzanetti: do you know who are we supposed to tell about all those errors on our CI? they seem like network unstability [11:11] tsdgeos, if it's something in the surrounding network, I guess opening a ticket is way to go. [11:11] however, there's a #jenaas irc channel [11:11] try asking there if others have the same issues [11:11] #jenkaas [12:12] pstolowski, that dependency issue is not fixed yet, however, the silo is built and the code should be the final edition. you can test the scopes stuff [12:14] mzanetti, k thanks [12:26] So qtmir got infected again "799 tag(s) updated" [12:26] * dandrader runs script on it === alan_g is now known as alan_g|lunch [13:14] tsdgeos, pstolowski, is there anything from a user point of view to be tested in regard to filters? [13:16] mzanetti: not *strictly* filters, but it comes with a new department navigation [13:17] so the click scope navigation is different [13:17] s/navigation/departmnet navigation/ [13:17] right... departments vanished [13:17] they did not [13:17] they are on the serach popup [13:17] ah [13:17] ack. all clear [13:18] mzanetti: filters there's a test scope that pstolowski has around that can be usde for testing [13:18] tsdgeos, there seems to be sonething odd in the pressed highlight [13:18] but afaik there's no "real" scope using them yet [13:20] tsdgeos, sent you a pic via telegram [13:20] lol [13:20] PEBKAC [13:21] or maybe not [13:21] I'm totally confused [13:21] i'll flash and try to reproduce [13:24] mzanetti, yeah, as tsdgeos says. atm we should check if we haven't regressed. only my test scope uses filters [13:24] mzanetti: silo 41, right? [13:27] tsdgeos, yes [13:32] what is 'pressed highlight? i guess it's not ubuntu store highlight? [13:33] pstolowski, http://imgur.com/BOGFJ2G [13:34] mzanetti, hmm how did you do that? [13:35] pstolowski, press, drag a little and release [13:35] tsdgeos, cimi, pstolowski: I believe this is a bug of the old ListItems. Have seen this in other places too [13:36] we might want to consider moving to the new ListItem? [13:36] mzanetti, ok, got it. yeah, i don't think it's related to our changes [13:37] i can't repro :/ [13:37] now [13:38] tsdgeos, big effort to move to the new ListItem? [13:38] I'm afraid the old ListItems won't ever get fixed any more [13:38] which one are you using? ListItems.Standard ? [13:39] mzanetti, tsdgeos if this is a lot of work then i suggest we log a bug and fix that separately [13:41] mzanetti, i found one minor issue with music scope, will try to fix that [13:42] mzanetti: i object to blocking on that, that code is the same it was before this, so the bug already existed [13:42] * tsdgeos reflashes without the silo to try to reproduce [13:43] odd, I can't repro on my dogfooding (rc-proposed) phone [13:44] but I figure the code of the actual list should not have changed [13:44] weird thing is, once I have an item in that state, I can't even click it any more [13:44] and not recover from it [13:45] actually [13:45] i think i changed from ListItem.Standard to ListItem [13:45] well, I can recover by clicking the cancel button [13:45] so it's the new one that regresses it seems [13:45] oh really [13:45] well, not denying that [13:46] yep [13:46] see https://code.launchpad.net/~aacid/unity8/optionselector_filter_visual_improvements/+merge/277138 [13:46] line 128 [13:46] meh [13:46] so can't object now [13:46] should not have trusted the sdk people :D [13:46] or whoever convinced me to use the new stuff [13:48] lol [13:48] well, usually the new ListItem is quite a lot better than the old ones [13:48] just tried to create a standalone testcase [13:48] it doesn't seem to have a pressed highlight [13:55] mzanetti: yeah no idea where that highlight comes from euther [13:56] mzanetti: seems to be a default behaviour [13:57] tsdgeos, yeah, but I just created a standalone example at doesn't do it... [13:58] mzanetti: did you set a color: ? [13:58] ah... it only does when a onClicked handler is assigned [13:58] ah wait i'm not either [13:59] and I can reproduce the bug [13:59] with this: http://paste.ubuntu.com/15384113/ [13:59] ok... definitely an SDK issue then [14:00] tsdgeos, we might want to try to use ListItems.Empty for now then as I don't believe the SDK will manage to do another landing before OTA-10 [14:00] lemme talk to zsombi [14:00] oh, he's here in this channel [14:00] mzanetti: ? [14:00] found a bug in ListItem [14:01] zsombi, this snippet: http://paste.ubuntu.com/15384113/ [14:01] (the onClicked handler is the important bit) [14:01] zsombi, when that's around, it will have some onPressed highlight [14:01] that gets stuck and makes the item not interactive any more [14:01] reproducible with the above snippet [14:02] mzanetti: with touch or mouse? [14:02] both === alan_g|lunch is now known as alan_g [14:02] just run the above in qmlscene, then start dragging the list with mouse/touch but only for a tiny bit and release it again [14:02] eventually the pressed highlight will get stuck [14:03] it is considerably easier to trigger it with thouch [14:03] but I've managed with mouse too [14:04] mzanetti: ok, so I have to start dragging it a bit... [14:05] yes [14:06] zsombi, easier if you longpress and then drag a bit [14:07] mzanetti: ok, then the long press messes it in [14:07] not sure what the exact trigger is [14:07] but with the new scopes departments in silo 41 I am triggering all the time when trying to naviage through it === dandrader_ is now known as dandrader|afk [14:12] mzanetti: so do i go back to listitem.standard ? [14:13] tsdgeos, this fixes it for me: http://paste.ubuntu.com/15384174/ [14:14] tsdgeos, maybe add a fixme. lemme report a bug for the sdk [14:17] zsombi, tsdgeos: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1556971 [14:17] Launchpad bug 1556971 in ubuntu-ui-toolkit (Ubuntu) "ListItem pressed highlight gets stuck when scrolling" [Undecided,New] [14:17] mzanetti: is it ok if i make it a new branch on top? [14:19] yeah, I guess [14:20] * mzanetti contiues with silo testing [14:20] tsdgeos, please test that patch too... not sure if it breaks other things or so... [14:20] yes === dandrader|afk is now known as dandrader [14:38] mzanetti: https://code.launchpad.net/~aacid/unity8/listitemworkaround/+merge/288933 [14:50] tsdgeos, thanks [15:18] mzanetti, similar to your findings on mock issues: https://code.launchpad.net/~dandrader/unity8/duplicateMirSurfaceSignals/+merge/288938 [15:19] dandrader, heh, yeah... those hit in the darkest moments === maxb_ is now known as maxb [15:26] pstolowski, hey, would you confirm that the OSK is a bit odd with silo 41? [15:26] I frequently hit the key above the one I try to press [15:27] hmm... went away after a reboot now.. but it was hitting me on 2 boots already [15:28] have it again [15:28] dafuq [15:28] mzanetti, doh, you're right. doesn't happen too often [15:28] but i just reproduced [15:40] mterry, did "make tryTutorial" ever worked? [15:40] dandrader, I think so? [15:41] mterry, crashes with a mysterious error now. no idea what's going on... [15:42] dandrader, in trunk or tutorial-redesign? [15:42] mterry, trunk. hold a sec, something likely wrong with my build. am rebuilding from scratch [15:50] dandrader, you see a crash in trunk or tutorial-redesign? [15:51] mterry, there's something wrong... "make tryShell" is also crashing with trunk. Can you reproduce it? [15:51] dandrader, yeah... "ASSERT failure in QList::operator[]: "index out of range", file /usr/include/x86_64-linux-gnu/qt5/QtCore/qlist.h, line 518 [15:51] Aborted [15:51] " [15:52] mterry, yes, that's what I get [15:52] so something broke a number of tryFoo targets in the latest release I suppose [15:55] pstolowski, I'm afraid I can't repro that issue with trunk [15:55] tsdgeos, ^ [15:55] pstolowski, but I've really no clue atm which branch could be the culprit [15:55] mterry, got a backtrace. there's MirSurfaceItem::setSurface in it. weill keep digging [15:55] dandrader: mterry: that's fixed by me [15:55] dandrader: mterry: https://code.launchpad.net/~aacid/unity8/makeMakeTryOrientedShellWork [15:56] tsdgeos, ah, great! will try that [15:56] mzanetti, we have various 'kbdLayout' MPs in that silo..? [15:56] pstolowski, they should only affect the physical keyboard [15:57] "should" [15:57] pstolowski: mzanetti: yeah osk weird, sure it's silo 41? [15:57] yeah.. i don't see have filters could affect osk [15:57] * how [15:57] * tsdgeos reflashes withous silo 41 [15:57] tsdgeos, so far I haven't managed to repro with trunk [15:57] tsdgeos, eek. huge prereq [15:58] * dandrader cherry-picks [15:58] dandrader: the prereq has landed ;) [15:58] dandrader, that prereq has landed [15:58] tsdgeos, can you repro the weird OSK too? [15:59] mzanetti: yes [15:59] darn [15:59] a gave me q [15:59] or well... [15:59] better easy to repro [15:59] on places it seemed to me should give me a [15:59] yep [15:59] tsdgeos, mzanetti right :) [15:59] mzanetti: we should add https://code.launchpad.net/~aacid/unity8/makeMakeTryOrientedShellWork/+merge/288743 to https://requests.ci-train.ubuntu.com/#/ticket/1105 [16:00] ok [16:00] so... now we need to figure what's wrong with the OSK tho [16:02] ltinkl, ^ [16:02] you might have an idea? [16:02] don't see how the physical kbd layout would affect it either, but atm I'm still in the dark [16:03] yep defenitely seems silo 41 related [16:03] I wonder if the shell_chrome stuff might do something... it seems to move surfaces between fullscreen and not [16:03] wow this silo is massive [16:03] pstolowski, no... 64 was massive... this is just biggish [16:03] :D [16:03] i'm going to random point to the shell-chrome branches :D [16:03] * pstolowski too scared to ask what was in silo 64 [16:04] pstolowski, 60+ branches [16:04] phew [16:05] mzanetti: can we create a second silo and add group of features until we found otu what's the one that seems to cause it? [16:05] mzanetti, OSK broken in that silo? pff but the keymapSwitching stuff has (almost) definitely nothing to do with it [16:06] tsdgeos, you mean a bisecting silo? [16:06] mzanetti: yeah [16:06] yeah, I guess we could... not sure if that's really faster tho [16:07] dednick, hey, you did the most work of the shell_chrome branches, right= [16:07] mzanetti: yes [16:07] right=true [16:08] dednick, could you imagine them having affect on the OSK surface? it seems input is a few grid units lower than it should be [16:08] dednick, i.e. pressing "a" gives us "q" [16:08] those branches mess with fullscreen. and the offset seems pretty much the panel height [16:09] interesting point, it only happens the second time the OSK shows [16:09] the first time it's fine [16:10] i.e. adb reboot -> trigger OSK -> good -> hide and show OSK -> bad [16:10] mzanetti: um, it could do maybe. [16:10] mzanetti: the panel hint hack. [16:11] * mterry is now on irccloud, hopefully this is more reliable [16:12] mzanetti: is there a silo for it? [16:12] dednick, 41 [16:12] this totally explains why the heck I have not been able to enter 2 identical passwords testing the OOBE before :D [16:12] :) [16:13] didnt seem to be a problem at mwc though... :/ [16:13] that i heard about anyway [16:13] dednick, I'm not saying it is those branches... atm I'm still in the dark and those look like the most suspicious ones to me... [16:14] mzanetti: phone mode? [16:14] staged [16:14] dednick, yeah, tested on nexus4 [16:16] mterry, ltinkl, Mirv could fix the 8.13 bump in the silo. should we or are you relying on the fact that it's bumped to 8.13 already? [16:18] mzanetti: hrm, "could fix?" -- I bumped in that branch because we moved files, so needed a version for debian/control [16:19] mzanetti: dandrader: happens on arale here too fwiw [16:19] mterry, what version are we reyling now on with the breaks/replaces? [16:19] mterry, so you manually bump it to 8.13 somewhere now? [16:20] tsdgeos, what? [16:20] mzanetti, to 8.12 [16:20] dandrader: meh, that was for dednick [16:20] mzanetti: dednick: happens on arale here too fwiw [16:20] ltinkl, mterry, right, but the silo builds 8.13, not 8.12 [16:20] mzanetti: I manually bumped in https://code.launchpad.net/~unity-team/unity8/sessionIndicatorForDevices/+merge/288940 [16:21] mterry, still 8.12 :D [16:21] mterry, the silo would give us 8.13 [16:21] mzanetti: oh sorry. I meant 8.12 [16:21] mzanetti: did anyone bump to 8.13? [16:21] so I ask Mirv to clear the packages and we do a clean rebuild. that would give us 8.12 [16:22] mzanetti: sure? You mean clear the silo of packages? my changes shouldn't need that, but ok [16:22] mterry, the OOBE branches did have a 8.13 but it was reverted. however, PPAs reject lower versions and silos seem to be clever enough to just bump it on their own in that case [16:22] ah [16:22] mzanetti: got it. So no, not relying on 8.13 [16:22] mzanetti: only relying on 8.12 [16:24] mterry, should be still fine right to rely on << 8.12? [16:24] even if we "skip" it [16:24] tsdgeos, bisecting silo 35 building [16:25] tsdgeos, so far only with the chrome branches [16:25] ltinkl: yeah [16:26] mzanetti: dash is all white on 41 :( [16:27] mzanetti: you had started reviewing https://code.launchpad.net/~unity-team/unity8/tutorial-redesign/+merge/288839 back in the day. Do you want to finish that, or shall I pass that off to dednick? [16:27] mzanetti: so sounds like "go ahead"? [16:27] to remove unity8 packages temporarily from the silo and rebuild in half an hour to see what happens [16:28] dednick: what? [16:29] tsdgeos: hang on, i'm cleaning device and will check again. [16:29] might have had some of my code on there. [16:29] could have had some occlusion stuff still on it. [16:35] mzanetti: I did that, so please try rebuilding unity8 in 041 in around 30 mins to give LP a bit of time to update whatever it might want to update. I also removed it from train's packages (it will come back since there are MP:s for it). if that doesn't help, then only silo switch would help. [16:36] mterry, if dednick has the time, please [16:36] Mirv, ack === francisco is now known as Guest95587 === pstolowski is now known as pstolowski|bbl === dandrader is now known as dandrader|afk [16:45] pstolowski|bbl, about the fix for filters you mentioned, did you push that somewhere? what do I need to rebuild? [16:50] dednick: ^ got time for tutorial-redesign when done with geonames? [16:51] mterry: i've got to look at problem mzanetti is seeing with osk, but after that yes [16:51] dednick: cool thanks [16:52] dednick, silo41 is not installable atm... we had to delete the unity8 packages. but will be there in a bit. I can upload them somewhere to if you want to test now [16:52] or not... apt cache is cleared [16:53] mzanetti: seemed to install for me. [16:53] really [16:53] mzanetti: and can confirm shift. [16:53] ok... you might installed it before we nuked the packages then. great [16:53] perhaps [16:53] dednick, ok. cool [17:12] ltinkl: do you have review cycles? https://code.launchpad.net/~mterry/phablet-tools/tutorial-redesign/+merge/277764 is a relatively small one in our silo that isn't approved yet [17:13] mterry, sure, can do after I've finished the keymapSwitching stuff [17:18] mzanetti: tsgeos snuck lp:~aacid/unity8/listitemworkaround into silo 41. Was that expected? [17:18] mzanetti: just want to make sure if I should review it or not [17:23] greyback: and same for lp:~nick-dedekind/qtubuntu/shell_chrome -- looks like it just needs final stamp [17:23] yep [17:24] oh and u8 too. OK, you must know all this :) [17:24] greyback: hey are your eyes fully restored now? [17:24] mterry, yeah, it fixes an issue that I found in silo testing [17:25] mzanetti: ok cool, will review then [17:25] mterry, read the linked bug report, it should be clear from that [17:25] mterry: things a little blurry still - text not sharp for example. As day goes on, eyes tire more so it gets worse. But am still able to get most things done [17:26] mzanetti: only 11 unapproved branches by my count now [17:26] haha [17:26] mterry, well, most of them have been looked at, tested well before [17:26] greyback: good! Do you love not needing glasses so far? [17:27] mzanetti: yeah some for sure have [17:27] mterry, like all the OOBE, I would just skim over them to see if lukas fixed the things I mentioned in the last review [17:27] mterry: yeah, it's a small thing, but it is nice [17:28] greyback: I can feel my eyes slipping. I'm guessing I'll eventually need glasses / get some laser work done myself [17:29] so far everyone I've been talking to has said that the laser thing has been the best thing ever [17:31] I'll not be that encouraging, there's nothing wrong with wearing glasses. They can make you look more dignified/sophisticated [17:31] greyback: I don't know if my face could stand being any more dignified [17:32] mterry: indeed. They'll be carving it into a mountain fairly soon [17:32] you Americans like doing that [17:33] greyback: I've known Mt Rushmore as a done-thing all my life. But how fricking nuts of an idea that must have been originally. Shocked they went through with it [17:33] yeah. Have always found it a bit much [17:33] but then, why not [17:34] they did it in lord of the rings universe at lot too [17:34] greyback: because it's a beautiful mountain as is! :) [17:34] will give people thousands of years from now puzzlement [17:38] mzanetti: i've fixed that bug with osk. not sure why it was working previously and not now though. It was something specific i added to get it not to do that same issue! [17:38] but seems to have backfired now. [17:38] dednick, oh, cool! [17:38] I was still prepping the bisecting silo to confirm it's really those branches [17:39] I guess I can throw that away then [17:39] dednick, which packages to rebuild? [17:39] mzanetti: qtubuntu [17:39] ta [17:39] * mzanetti does [17:39] there must have been a change elsewhere in the mwc code which required it... :/ [17:40] so it'll probably come back! [17:45] ltinkl, mterry, 8.13 it'll be... not going to completely destroy and re-setup the silo [17:46] ltinkl, mterry, your code should still work with that, right? [17:46] yeah [17:46] mzanetti: ^ [17:47] ok... unity8, indicator-session and qtubuntu builds on the way... [17:51] actually. Mirv's hack helped! === jhodapp is now known as jhodapp|errand [18:04] ltinkl: indicator-session built in silo, nice === pstolowski|bbl is now known as pstolowski [19:00] mzanetti, still there? === jhodapp|errand is now known as jhodapp === dandrader|afk is now known as dandrader [19:17] Mirv: you did something to clear out the 8.13 version of unity8 from the silo 41 ppa? [19:17] It still seems to be in the ppa (though isn't showing up in LP) [19:18] specifically, only for unity8-common and unity8-schemas packages [19:20] ltinkl: ^ u8 in the silo isn't even building unity8-common and unity8-schemas... [19:20] mterry, no idea why is that happening... [19:20] ltinkl: ah... because those are built by the amd64 build [19:20] ltinkl: which failed to upload because 8.13 packages are still somehow in the silo? [19:22] Mirv: so I guess back to you -- do you know why the 8.13 packages are still in the silo? What did you do besides press "delete packages" in the LP ui? [19:42] pstolowski, hey === boiko_ is now known as boiko