| liuxg | does anyone know where to find all of the theme names for ubuntu phone in the QML. I know there are names like Ubuntu.Components.Themes.Ambiance, what else? | 04:27 |
|---|---|---|
| === _salem is now known as salem_ | ||
| nik90 | Elleo, hey, if I use DownloadManager{} instead of SingleDownload{}, is it still possible to show it in the indicator? If so, how? | 11:54 |
| nik90 | I understand that "downloads" is a list of all the stuff that is going to be downloaded by the download manager. However I need a SingleDownload object to set its metaData | 11:55 |
| nik90 | I looked at the web browser app code, at http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/Downloader.qml | 12:01 |
| nik90 | It seems they create dynamical SingleDownload{} objects, but I don't see any place where these objects get destroyed/cleaned up. | 12:01 |
| nik90 | I would expect they cleaned up when the download finishes | 12:02 |
| nik90 | oSoMoN, Can you explain this if you're free ^^ | 12:02 |
| Marin_ | Is anyone here to help with snappy-ubuntu-core | 12:03 |
| ogra_ | Marin_, try #snappy | 12:03 |
| Marin_ | first time here thanks | 12:03 |
| oSoMoN | nik90, Elleo wrote that code so he’s more capacitated than me to explain it, but let me take a look anyway | 12:04 |
| nik90 | oSoMoN, I think I have a vague idea, but I cannot form a complete picture of how the various components are connected. | 12:08 |
| nik90 | I don't mind waiting for Elleo if you have other things to attend to. | 12:08 |
| Elleo | nik90: the downloads list in the DownloadManager component will contain downloads you create via SingleDownload as well | 12:09 |
| Elleo | nik90: it's basically a list of all downloads created by your app, regardless of how they were created | 12:10 |
| nik90 | Elleo, true, but I need to migrate from SingleDownload to DownloadManager to handle multiple downloads in Podbird. Otherwise it will stop downloading after the very first download (while the app is backgrounded). | 12:10 |
| nik90 | So when I use DownloadManager, I am unable to understand, how to set the metaData of individual downloads in DownloadManager | 12:11 |
| Elleo | nik90: you can create multiple SingleDowlnoad components dynamically | 12:11 |
| Elleo | nik90: they'll automatically be queued by DownloadManager for you | 12:11 |
| Elleo | nik90: in the order that they were created | 12:11 |
| nik90 | Elleo, ah ok...so something like http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/Downloader.qml | 12:12 |
| nik90 | Elleo, and when I received the onFinished signal from the SingleDownload component, I can then destroy it? | 12:12 |
| Elleo | nik90: yeah, but don't listen for onFinished in SingleDownload, listen for onDownloadFinished in DownloadManager, that way it'll also support the app being closed and the download still finishing | 12:13 |
| Elleo | nik90: that provides you with both the path and the relevant SingleDownload component that finished | 12:14 |
| nik90 | Elleo, ack. When I use the onDownloadFinished signal, I will need to compare the finished download ID with the list of temporary singleDownload objects to see which one it was and destroy that? | 12:15 |
| nik90 | DownloadManager gives me the relevant SingleDownload component as well with the onfinished signal? | 12:15 |
| nik90 | s/onfinished/ondownloadfinished | 12:16 |
| Elleo | nik90: yeah, it gives you "download" which a SingleDownload and "path" which is where it ended up | 12:16 |
| nik90 | cool, thnx | 12:16 |
| Elleo | nik90: http://bazaar.launchpad.net/~phablet-team/webbrowser-app/trunk/view/head:/src/app/webbrowser/DownloadHandler.qml <-- this shows what the browser does there, there are other similar signals you can listen to for paused/resumed/etc. | 12:17 |
| nik90 | Elleo, I saw that file earlier..What does DownloadsModel refer to? | 12:17 |
| nik90 | I don't see that as a listed property in DownloadManager | 12:17 |
| nik90 | nvr mind, that comes from the webbrowserapp.private 0.1 import | 12:18 |
| Elleo | nik90: that's just a webbrowser thing, it's basically the webbrowser's own sqlite db listing all old downloads | 12:18 |
| Elleo | yeah | 12:18 |
| nik90 | I can just say download.destroy() | 12:18 |
| nik90 | Elleo, thnx..this makes it clear. | 12:19 |
| Elleo | nik90: yep, also iirc you can set autoRemove on the DownloadManager and it'll get rid of them for you when finished | 12:19 |
| nik90 | Elleo, I only see cleanDownloads property in DownloadManager which just clears up the list. I can't be sure it also cleans up the SingleDownload object | 12:20 |
| Elleo | nik90: yeah, I should probably do another little video explaining how SingleDownload and DownloadManager can be used together, good to have these questions asked and see where we need to improve docs | 12:21 |
| Elleo | nik90: ah yeah, you may be right there | 12:21 |
| nik90 | Elleo, oh man, those videos are freaking awesome. | 12:22 |
| Elleo | nik90: regardless what you do it does actually automatically clean up the real internal download object, so all you're left with is a tiny SingleDownload component keeping the relevant properties in memory (id, state, error, etc.) | 12:23 |
| Elleo | nik90: so there's only a few kbs memory hit if a dev doesn't manually destroy the object | 12:23 |
| nik90 | Elleo, agree | 12:23 |
| Elleo | nik90: thanks :) been away the past few days but going to do some more as soon as I get a free evening | 12:24 |
| Elleo | nik90: I had a play with the dev version of podbird before I left (haven't tried the very latest version yet), seemed really good, only two things I wasn't sure on; one was the removal of the fuzzy background image at the top of the podcast pages; it looks good without it for some podcasts, but not as good for others (e.g. where their logos don't have such well defined edges), so we might want to chat with Kevin a bit about that | 12:26 |
| Elleo | nik90: and I'm really not keen on losing the "Add new podcast" page, the interaction of pressing the "+" to get to a new page with identical header actions seems wierd to me | 12:27 |
| Elleo | nik90: plus I'm planning on expanding that page a lot | 12:27 |
| Elleo | nik90: so that when it's in the empty state it shows charts and recommendations from the podbird.org services | 12:27 |
| Elleo | nik90: which seems more natural to reach via the "Add new podcast" menu option | 12:28 |
| Elleo | at least to me anyway :) | 12:28 |
| Elleo | but overall everything seemed really great | 12:29 |
| Elleo | I'll give the .5 release a go this evening to see what else has changed while I was away | 12:29 |
| nik90 | Elleo, the fuzzy background removal was part of kevin's new design spec at https://drive.google.com/file/d/0B8NjAHEq9cvEY2VZb1lGczRKMVE/view. Although I have to agree that I liked the fuzzy background as well :) | 12:37 |
| nik90 | I see your point regarding the add podcast page. I agree. The headers are too similar at the moment. I will bring that back to the old way. But I like to keep the EpisodesTab as the way it is if you like it. | 12:38 |
| nik90 | Elleo, I think the most cool part is that we have playlists support in 0.7.5..so you should really try that out. | 12:38 |
| Elleo | nik90: awesome, look forward to giving that a go :) | 12:48 |
| Elleo | nik90: and yeah, episodes tap looks really good | 12:51 |
| Elleo | nik90: nice having a way to access all the downloaded episodes from all podcasts mixed together | 12:51 |
| Elleo | tab* | 12:52 |
| nik90 | Elleo, I was thinking of integrating the in-progress downloads to the downloads view. This way users can cancel individual downloads, pause them if required etc. That was another thing that users reported bugs about. | 12:53 |
| nik90 | that and the files indicator integration is my focus atm. | 12:53 |
| Elleo | nik90: yeah, that sounds good | 12:53 |
| === charles_ is now known as charles | ||
| t1mp | zsombi: so, I have a fix for the XFAIL, https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/apl-dont-change-page-geometry/+merge/289054 | 14:46 |
| t1mp | zsombi: current staging tests it with the old header, and your branch with the new | 14:46 |
| t1mp | zsombi: should we test both? | 14:46 |
| zsombi | t1mp: I wouldn't bother tbh... | 14:47 |
| zsombi | t1mp: we don't have resources to maintain both anyway | 14:47 |
| t1mp | zsombi: the whole error was there because we are trying to support both headers in a single APL anyway | 14:47 |
| zsombi | t1mp: :( | 14:47 |
| t1mp | zsombi: anyway, the fix turns out to be not so difficult | 14:48 |
| t1mp | zsombi: it broke because the updates are not in the ideal order | 14:48 |
| zsombi | I see | 14:48 |
| zsombi | t1mp: I cannto get yr MR | 14:48 |
| t1mp | what do you mean with "cannot get"? | 14:49 |
| zsombi | t1mp: this MR is agains staging... so we shoudl get this prior to the APL MR | 14:58 |
| t1mp | zsombi: it works independently from the APL MR | 15:00 |
| zsombi | t1mp: ok, let's hope CI will wake up and lat it go | 15:01 |
| t1mp | zsombi: I tested it with your MR too | 15:01 |
| zsombi | t1mp: me too :) | 15:01 |
| zsombi | t1mp: happroved | 15:01 |
| t1mp | thanks | 15:01 |
| zbenjamin | bzoltan_: so your script listed loads of packages... i decided to do a clean install | 15:01 |
| zbenjamin | bzoltan_: even kernels ... | 15:02 |
| bzoltan_ | zbenjamin: my script? | 15:02 |
| zbenjamin | bzoltan_: the one that lists packages that are not from the archive? | 15:02 |
| bzoltan_ | zbenjamin: check it if you do not believe :) | 15:02 |
| zbenjamin | bzoltan_: i do believe, but as i said i had a huge list of packages that came from nowhere. I guess broken or not completely removed ppa'S | 15:03 |
| beuno | there's an outage going on, FWIW | 15:03 |
| zbenjamin | bzoltan_: the system was in a very very weird state | 15:03 |
| bzoltan_ | zbenjamin: I figured :) | 15:03 |
| zbenjamin | bzoltan_: clean install can not hurt from time to time ;) | 15:04 |
| bzoltan_ | zbenjamin: yes | 15:04 |
| bzoltan_ | zbenjamin: indeed many of the packages on a continously upgraded system fall out of the controll net | 15:06 |
| zbenjamin | woah, new xenial did boot up so fast! | 15:07 |
| balloons | rest in pieces my jenkins friend | 15:07 |
| balloons | ahayzen, you about? | 15:07 |
| nik90 | Elleo, I have an issue. I was able to successfully migrate Podbird to DownloadManager. The integration went fine without breaking any existing thing. However, when I tried to batch download a group of episodes using a JS function, Podbird crashes. And now everytime I open Podbird I cannot download any episode since the internal SingleDownload{} objects still persist. Printing downloads.length shows 18 and I cannot do anything to clear it. | 15:54 |
| nik90 | I already have cleanDownloads variable set to true. | 15:54 |
| nik90 | I deleted the mp3 files manually, but not sure how to reset DownloadManager despite several times of reopening podbird. | 15:55 |
| === chihchun is now known as chihchun_afk | ||
| balloons | nik90, since you are about, can I get your opinion on always running qml tests on build? | 15:59 |
| nik90 | balloons, hi | 16:00 |
| nik90 | sure | 16:00 |
| balloons | checkout https://code.launchpad.net/~nskaggs/ubuntu-clock-app/run-qml-tests-on-build/+merge/289065. This means jenkins will always run tests, but so will you on your desktop with this change | 16:00 |
| balloons | is this a 'good' thing, or should we make things more explicit within jenkins and run make test after? | 16:00 |
| * nik90 tests | 16:01 | |
| nik90 | balloons, It affects the way I run and build clock app on the phone. The tests are failing because I develop using 14.04 and run it on the phone. Since I am running on 14.04, all qml tests will fail since the sdk libs are unavailable. Also I get QXcbConnection: Could not connect to display | 16:04 |
| Elleo | nik90: odd, you could try killing the ubuntu-download-manager process, it'd be good if you could push the code somewhere so I can give it a try (might not get to it until tomorrow now though), sounds like something might be going wrong in download manager somewhere | 16:04 |
| Elleo | nik90: although I'm not sure why it isn't effecting the browser then | 16:04 |
| nik90 | balloons, so this forces app devs to only use 16.04 or later | 16:04 |
| nik90 | Elleo, sure, I will also provides steps to reliably reproduce it. FWIW restarting the phone fixed it. | 16:05 |
| Elleo | nik90: okay, thanks | 16:05 |
| balloons | nik90, well you could toggle it off, but I'm concerned that tests will fail, and running by default might upset people | 16:05 |
| balloons | but it would also ensure the tests are run when people are coding :-) | 16:06 |
| balloons | nik90, the build should still finish though right, even though the tests faill | 16:06 |
| balloons | nik90, obviously I don't want to force anyone into running new stuff | 16:06 |
| nik90 | balloons, for me the build fails when the tests fail -> http://paste.ubuntu.com/15392814/ | 16:07 |
| nik90 | the test failures are being considered as errors rather than warnings by qtcreator | 16:07 |
| balloons | ok, well I have some concerns. I wish cmake made this a little easier | 16:08 |
| balloons | so I think I will make it explicit inside jenkins and reject this | 16:09 |
| nik90 | balloons, Yes. I am fully aware of cmake's abilities..it could have a ignore option while printing out the errors. But I can't say for sure. | 16:10 |
| nik90 | not fully* | 16:10 |
| ahayzen | balloons, what's up ? | 16:12 |
| balloons | I'll try doing it another way. It was more hoops and harder, but forcing it seems to make things painful, which is what I wanted to know | 16:12 |
| ahayzen | t1mp, is there a silo for https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/fasterWindowColor/+merge/288661 yet? | 16:12 |
| balloons | ahayzen, see above with nik90. I was going to mention how I'm implementing unit testing within jenkins | 16:13 |
| ahayzen | balloons, ok! :-) | 16:13 |
| balloons | the answer is, we'll make an explicit call. That does I suppose make things a bit harder and puts things back into your court perhaps | 16:13 |
| balloons | it means back to playing with cmake | 16:13 |
| balloons | ahayzen, secondly, how's the changes coming for weather and music? | 16:13 |
| ahayzen | balloons, slowly, i'm coming up to coursework season :-( | 16:14 |
| ahayzen | half way through the last semester of uni \o/ :') | 16:14 |
| balloons | right, no worries. Just thought I'd ask again. | 16:14 |
| faenil | ahayzen: wow...keep tight! ) | 16:15 |
| ahayzen | balloons, so i'd like to have them running each time a dev builds/runs, but as with nik90 i suspect most/all music tests would fail for me due to there being no QtMultimedia 5.6 on Wily | 16:15 |
| ahayzen | balloons, so probably best for just explicitly on jenkins, until we get a snappy desktop :') | 16:15 |
| nik90 | + | 16:16 |
| ahayzen | balloons, can we have a build configuration for running the tests or something? so that it appears as an option in QtC ? | 16:17 |
| t1mp | ahayzen: no silo yet for that MR | 16:17 |
| t1mp | ahayzen: I wanted to have the fix for this one first https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1555797 | 16:17 |
| ubot5 | Launchpad bug 1555797 in ubuntu-ui-toolkit (Ubuntu) "Theme loads MainViewStyle 1.2 when MainView has a dark backgroundColor set." [High,In progress] | 16:17 |
| balloons | ahayzen, an alternate cmake target might do that? | 16:17 |
| ahayzen | balloons, so then if i was running on xenial/latest release ... then i could select to use that config and run the tests while developing | 16:18 |
| t1mp | ahayzen: so the fasterWindowColor MR is still landing in our staging now | 16:18 |
| ahayzen | balloons, and then jenkins could use that build config | 16:18 |
| balloons | that would be ideal. I'm not positive, but I'll try | 16:18 |
| ahayzen | balloons, i spotted coreapps like reminders have loads of configs (or whatever they are actually called) | 16:18 |
| ahayzen | t1mp, ok thanks :-) i'll watch out for a silo so i can test :-) | 16:19 |
| t1mp | ahayzen: okay. But a silo is the last step. First we verify that everything works, then we land it to staging, then we get a silo to land it in the image (with more testing) | 16:20 |
| ahayzen | balloons, like this https://drive.google.com/file/d/0B3XynHVKfrvMc0NlTENvdWRKZmc/view?usp=sharing you can see the different Autopilot ones and reminder ones | 16:21 |
| t1mp | Mirv: where could we find the tgz that has the device deb files for this MR? https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/fasterWindowColor/+merge/288661 | 16:21 |
| ahayzen | balloons, if there was a 'jenkins' one | 16:21 |
| t1mp | Mirv: ^ I got a bit lost with all the jenkins results and I cannot find the tgz any more | 16:21 |
| ahayzen | t1mp, i you can point me to some debs i could test as well :-) | 16:21 |
| balloons | ahayzen, right, got it | 16:21 |
| ahayzen | balloons, do you think that is the best way ? | 16:21 |
| nik90 | Elleo, you can find the branch and steps to reproduce the bug at https://code.launchpad.net/~nik90/podbird/migrate-to-download-manager/+merge/289069 | 16:23 |
| balloons | I think it would be the nice yes. However, jenkins first, then sdk, heh | 16:24 |
| ahayzen | nik90, what do you think? could a run configuration be enough ? | 16:24 |
| ahayzen | :-) | 16:24 |
| t1mp | Mirv: ah, I think I found one :) | 16:24 |
| t1mp | ahayzen: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/502/artifact/artifacts/copy-to-phone-fasterWindowColor-1895.tar | 16:24 |
| ahayzen | t1mp, \o/ i'll try and have a play in a bit | 16:24 |
| nik90 | ahayzen, yes I think that would be best. This way we can use that particular build configuration last when fixing the tests after fixing a bug/implementing a feature and not all the time. | 16:25 |
| ahayzen | yeah agreed | 16:27 |
| Mirv | t1mp: please report back too if it works alright, I recently added the new qml-module-* packages | 16:27 |
| Mirv | which are now needed | 16:28 |
| Elleo | nik90: great, thanks; will take a look at that once I've finished off this current bit of work (might not be until tomorrow) | 16:28 |
| nik90 | Elleo, no worries, I will work on something else until then | 16:31 |
| ahayzen | balloons, any idea why this wasn't picked up by jenkins? https://code.launchpad.net/~vthompson/music-app/fix-1549557/+merge/288871 | 17:04 |
| balloons | ahayzen, still about? | 19:22 |
| balloons | if so, time for a little jenkins lesson | 19:22 |
| ahayzen | balloons, o/ i'm about for a few minutes, otherwise i'm around tomorrow | 19:23 |
| ahayzen | balloons, maybe best tomorrow :-) | 19:24 |
| balloons | ahayzen, just note the red jobs on https://core-apps-jenkins.ubuntu.com/computer/ | 19:27 |
| balloons | ahayzen, if you see things like that, it's safe to cancel them. They generate again. That's why jenkins isn't running on music | 19:27 |
| ahayzen | so it's got struct trying to acquire a lock | 19:27 |
| ahayzen | ah ok thanks :-) | 19:28 |
| balloons | you are welcome -- you can cancel them right? | 19:28 |
| * ahayzen tries | 19:28 | |
| ahayzen | balloons, yeah i've managed to cancel the music ones \o/ | 19:29 |
| ahayzen | can see it rerunning now | 19:29 |
| balloons | you can cancel them all, but ;-) Awesome, now you now | 19:29 |
| * ahayzen adds to his jenkins doc :-) | 19:29 | |
| balloons | https://wiki.ubuntu.com/Touch/CoreApps/Jenkins#Troubleshooting now has a picture to go with #2 ;-) | 19:33 |
| nik90 | Elleo, I figured it out :D .. well atleast have a faint idea why. There is this episode "Weekly Tech New - March 5, 2016" from the Podcast "Daily Tech News Show". That episode when you try to play/download it, causes Podbird to crash regardless of whether you use SingleDownload{} or DownloadManager{}. | 20:23 |
| nik90 | Elleo, that said, I think in the event of an app crash, it is still important that UDM destroys its internal objects. | 20:23 |
| nik90 | It could be that the URL is buggy. maybe not encoded correctly ..not sure | 20:24 |
| nik90 | Elleo, more specifically (after further testing), it turns out that episode has a blank url. On creating a sample template app, I noticed that if you do downloadmanager.download(""), it causes the app to crash :P | 20:30 |
| nik90 | that's the reason. I just need to check if the url is blank or not before sending it to download manager. | 20:31 |
| === salem_ is now known as _salem | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!