=== shuduo-afk is now known as shuduo
mzanettidednick, good morning09:57
mzanettidednick, I think the shell_chrome branches have quite a lot of failing tests still09:58
dednickmzanetti: i'll take a look.10:00
dednickmzanetti: have you got a link for the test run?10:02
mzanettidednick, check your email10:07
mzanetti(have just been in a meeting with like every manager, asking me when silo 41 lands and then the color palette fixes)10:07
dednickmzanetti: oobe doesnt seem to even be reviewed yet...10:14
mzanettidednick, it is10:15
mzanettidednick, just needs the final stamp but mike and me reviewed it already and we tested it like a 100 times10:16
cimipstolowski, could you put the social card branches on top of the filters one? I guess the filters will land first so it kinda make sense10:18
pstolowskicimi, ok10:18
tsdgeosmzanetti: i'm a bit scared you mentioned silo 41 is all or nothing, it'd seem to me filters could land even if the rest wasn't ready, no?10:32
mzanettitsdgeos, we have to get all the things ready... it works fine now. it's "just" about fixing the tests10:33
mzanettiwe really want the side stage stuff, and the oobe too...10:33
mzanettiif anything, I guess the shell chrome could be dropped for now...10:34
dednicksidestage broke a few tests. recursive touchPress function10:34
mzanettidednick, yeah... are they just to be fixed or is there a bigger issue with it?10:34
dednickmzanetti: no, it's easy. i just called the wrong function within the UnityTestCase impl.10:35
mzanettiok, cool10:35
dednickwhen i added multiTouchPress10:35
mzanettifwiw, things passed in my manual testing on phone and tablet now...10:35
mzanettidesktop looked mostly ok too, need to check out some details still10:36
mzanettiI'm fixing some more color palette issues, please let me know when something is to be rebuilt and tests ran on it10:37
mzanettihmmm... I have the greenish background now in the panel too10:39
dednicki've never seen that10:41
* ltinkl neither10:42
tsdgeosmzanetti: do you know if make tryNotifications is how the notifications really look on the phone? if so probably need some fixing since it's almost black on black10:53
ltinkltsdgeos, got a branch on that10:54
tsdgeosah cool10:54
ltinkltsdgeos, https://code.launchpad.net/~lukas-kde/unity8/fixNotificationsColorWithNewUitk/+merge/28886910:54
ltinkltsdgeos, I even added an "Inverse mode" checkbox to the controls so that you can really see how they look like10:55
tsdgeoscool, daniel is taking care of that branch, right?10:55
tsdgeosmzanetti: are we including ↑↑↑ on the landing for ota10?10:56
ltinkltsdgeos, yeah, mterry mostly10:56
ltinkltsdgeos, the fixes should be done in a silo following silo 41, still for OTA1010:58
mzanettitsdgeos, the color fixes? yes11:01
mzanettitsdgeos, yeah, prepping a silo with that atm11:01
mzanettiit's in 2711:01
tsdgeosah so we'll still be landing another silo11:09
tsdgeosjust 41 is FFE11:09
tsdgeosgot it11:09
mzanetticimi, ok, I think we've fixed all unity related things from this bug: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/155461611:21
ubot5Launchpad bug 1554616 in unity8 (Ubuntu) "Shell and dash visual issues with new UITK and palette" [Critical,In progress]11:21
mzanetticimi, any findings on the green panel?11:21
cimimzanetti, haven't started yet - is critical enough to stop doing code reviews and move to that?11:21
mzanettidepends on the code reviews. if they are for somthing in silo 41, then no, otherwise yes11:22
cimialso do we have a proper bug report?11:22
pstolowskicimi, so i merged filters changes in unity-api & shell plugin in silo 71. you will need to do the same for unity8 if you want this silo in a working state11:22
cimipstolowski, gotcha11:22
cimimzanetti, ok I will stop code review, was for something else11:23
cimimzanetti, do we have a bug report?11:23
mzanetticimi, do't think so11:25
mzanetticimi, but I count that into the palette issues11:25
mzanettias it seems to have started breaking with that11:26
cimimzanetti, so I'll test it with silo 4111:31
mzanetticimi, the color issues?11:31
cimiyes indeed11:31
mzanetticimi, use silo 27 rather11:32
mzanettiltinkl, nick had some comment about the touched files not having 2016 in the copyright. please update that. I'm about to approve the branch11:34
mzanettiit looks ok and tests well11:34
ltinklmzanetti, ok, will update the (c)11:34
ltinklmzanetti, done11:39
dpmafternoon Saviq. Quick question: would it be possible to get an up-to-date .pot file for the unity8 and indicator-session in silo 41? The reason I'm asking is because bq are preparing a translated manual, and they are waiting for translations for new strings in that silo. Without them being in LP, it makes it a bit difficult to do them, so I've thought I could manually upload the new .pot files to Launchpad and thus we don't need to block on the landing11:45
dpm to do the translations11:45
mzanettia criss-cross in side stage11:46
mzanettidednick ^11:46
dednickmzanetti: eh. i'm updating sidestage now.11:47
dednickmzanetti: oh. hm. sidestage.11:47
mzanettidpm, Saviq is out11:47
dednicki'm fixing chrome now...11:47
mzanettidpm, I'll take care of it11:47
dednickone sec11:47
dpmmzanetti, awesome, thanks!. All I need is the resulting .pot files for the unity8 and indicator-session builds in the branches of silo4111:48
mzanettidednick, let me know when you go back to the side stage branch so I can explain how to do it, and what you do wrong so you get criss-cross merges all the time11:48
mzanettiltinkl, can you update the .pot file in your indicator-session branch11:49
dednickmzanetti: i've just pushed11:49
ltinklmzanetti, ah right, ok11:49
dednickmzanetti: i didnt do anything... ltinkl updated oobe11:50
mzanettidednick, so... the problem is that you have merged it with trunk11:50
mzanettidednick, the history says "merge with trunk"11:50
mzanettiyeah, I think you only pushed that today, could that be?11:50
dednickdont think so.11:50
mzanettidednick, in any case, once your branch has a prerequisite set, you must *never* again merge it with trunk11:51
mzanettidednick, always merge it with the prerequisite it has11:51
dednickmzanetti: ok11:51
mzanettiif you need to get trunk in somehow, merge the prerequisite with trunk (or it's prereq) and get changes through the chain like that11:52
mzanettiok, now lets see how to get out of this again11:52
cimimzanetti, complaining about missing unity-shell-scopes when trying to compile more-palette-fixes, which package version you have installed?11:53
ltinkldpm, indicator-session doesn't contain any POT file, how does that work? :)11:53
dpmltinkl, it gets created on build11:53
mzanetticimi, 1011:54
cimimzanetti, of the deb package11:54
ltinkldpm, right, with "make pot"; do you want that file?11:55
dpmltinkl, exactly11:55
cimimzanetti, you have any silo installed?11:59
cimiI also need 54?11:59
cimisorry 4112:00
tsdgeosloading the search icon on my desktop takes 1696 stat calls until it finds the correct one :D12:03
tsdgeosperformance \o/12:03
greybacktsdgeos: worth logging a UITK bug about that12:04
greybacktheir icon loading logic could definitely improve12:04
tsdgeosnot sure if it's glib related though12:05
tsdgeoslet me try it on the phone and see how many hits the phone gets12:05
ltinklgreyback, tsdgeos: remember a lengthy ML thread about KIconLoader... we used to have the same issue... ages ago12:05
greybackltinkl: heh, why am I not surprised12:06
ltinkltsdgeos, there is no glib code involved afaik, just QFile,QDir & co., all in nice loops :)12:06
ltinklsee? :)12:07
greybacklots of loops! O(n^2) at least12:07
ltinklQSettings in a foreach loop, nice12:07
mzanetticimi, don't think so, no...12:08
tsdgeoson the phone it's only 101612:09
mzanettiltinkl, ?12:10
mzanettinot sure why everyone keeps on picking on QSettings12:11
mzanettiit caches all the stuff and is very lightweight to create12:11
mzanettieven for write access it caches things and write them to disk when idle12:11
mzanettibeing clever enough to sync through memory if in between another instance is created and ready that value12:12
ltinklmzanetti, ok, it's just that those nested loops feel heavy12:12
mzanettithe only place where QSettings becomes slow is with a huge amount of ungrouped keys or endless bytearrays in values...12:13
mzanettithat can really take it down12:13
mzanettibut creating/destroying it is not the issue12:13
dpmmzanetti, ltinkl, do you happen to know which package the "Displays" string in here http://i.imgur.com/VzhS2bE.png comes from? It doesn't seem to be in indicator-session12:20
ltinkldpm, you shouldn't see that indicator12:20
mzanettidpm, where do you see that string?12:20
dpmmzanetti, it's on a screen capture bq sent us while they are preparing the m10 manual12:21
mzanettiright... that was the MWC image12:22
dpmand pointed out to us they need translations for those strings (while they haven't landed, they'll photoshop the translated strings on the screen caps)12:22
mzanettithis has changed. that string should not be around any more12:22
dpmoh, what does it look like now?12:22
mzanettiit's in the session indicator now12:22
davmor2dpm: a dead parrot12:23
mzanettione sec, will get you a screenie12:23
dpmmzanetti, awesome, thanks12:23
davmor2dpm: man mzanetti spoils all my fun :)12:23
dpmdavmor2, well, not quite dead yet, the rest of strings are in indicator-session. A half-dead one :)12:23
mzanettiwell, I can still send him a picture of a parrot I guess12:23
mterrymzanetti: good morning!  I see your email, is the situation basically the same?12:24
mzanettimterry, it should be a bit better by now, but yes12:25
mzanettimterry, good morning12:25
mzanettimterry, I might just have found another issue for you tho... when booting the tablet, it starts up with "Try again" in the login field12:25
mzanettimterry, requires 2 taps to be able to enter the password12:25
mterrymzanetti: OK...  sounds like a post silo 41 bug though12:26
mzanettidpm, not sure if you saw it... the screenshot is in your telegram inbox12:28
dpmgot it , thanks!12:29
mzanettimterry, oh... and... you don't want to hear it12:30
mzanettibut... it just doesn't pick up that username for me12:30
mterrymzanetti: you said that!  I don't get it12:30
mterrymzanetti: another post silo issue I guess12:30
mzanettiyeah... at least that's not a regression...12:31
mzanettiI'm not sure about the double tap tho12:31
mzanettia bit worried QA will block us on that12:31
dednickmzanetti: ok, i think i've got all the side-stage low-chrome test fixes. pushed.12:31
mzanetticool!!! thanks a lot dednick. kicking abuild12:31
mterrymzanetti: oh really?  OK, I can look into that then12:31
mterrymzanetti: shall I also remove camera-app, gallery-app, and mediaplayer-app from the ppa?  I see you dropped the MPs12:35
mzanettimterry, yes, please12:36
mterrymzanetti: is there any way for me to fake tablet mode these days on my phone, without editing qml?12:47
mterrymzanetti: (to reproduce the "try again" bug)12:47
mterrythese days == with silo 4112:48
mzanettimterry, /etc/ubuntu/devices.conf12:50
mzanettimterry, add a section:12:50
mzanettiwait, gotta create a pastebin12:51
mterrymzanetti: /etc/ubuntu/ doesn't exist for me, I assume that's normal12:52
mzanettimterry, http://paste.ubuntu.com/15401213/12:52
mzanettimterry, yeah, create it12:52
mzanettimterry, replace krillin with mako or whatever you have12:52
dandradermzanetti, what's the ETA for the current silo?12:52
mzanettidandrader, when the tests are passing12:52
dandradermzanetti, something like mid next week?12:53
dandradermzanetti, or you expect this week already?12:54
mzanettidefinitely this week12:54
dandradermzanetti, ok12:54
mterrymzanetti: that didn't fix it for me, will just edit qml12:54
mzanettiQA is just waiting for this12:54
mzanettilets see, got a build running. I expect there might be some more tests failing, but shouldn't be many any more12:54
mzanettitsdgeos, what would be the best approach to update teh .pot? check out the merged silo 41 branch, run the update script and then copy the po/ folder over to a checkout of trunk?12:56
=== alan_g is now known as alan_g|lunch
tsdgeosmzanetti: but the pot gets updated on landing, no?13:09
tsdgeosmzanetti: or you mean locally update it?13:09
tsdgeoswhat do you need it for?13:09
mzanettidos it?13:10
tsdgeosyes it does13:10
tsdgeosthere's a hoook for it13:10
mzanettiok. problem solved... dpm asked me to do so13:10
mterrymzanetti: how reliable is the "try again" issue for you?  I got it once testing on my mako, but can't reproduce now13:10
tsdgeosmzanetti: "override_dh_auto_clean:" in debian/rules13:10
mzanettimterry, I see it all the time basically13:10
mzanettimterry, steps to repro:13:11
mzanetti* unlock the device13:11
mzanetti* lock it (power button presS)13:11
mzanetti* wake it up, all is fine13:12
mzanetti* turn screen off again13:12
mzanetti* wake it up => issue triggered13:12
mterrymzanetti: ooohhhh, it's not on boot?  i thought I had read that13:12
mzanettimterry, I guess there too... not sure13:12
mzanettimterry, thing is, for me the screen wake up on his on very often because of telegram notifications13:13
mzanettimterry, so I might just bootet it and by the time I looked at it the screen had been on/off twice already13:13
mterrymzanetti: ok, reproduced with your steps, thanks13:14
mhall119morphis: ping, I'm just checking in again to see if aethercast is any closer to working on the Nexus 4 this week13:30
mterrymzanetti: I see why this 'retry' bug is happening, trying to figure out best fix13:31
dandradermzanetti, is the new screenshotting scheme part of that silo?13:31
mzanettimterry, do you confirm it is a regression of the silo?13:31
mterrymzanetti: you sure it's a regression?13:31
mzanettidandrader, no13:31
mterrymzanetti: my guess is that's it's been there.  Let me check on another phone13:31
mzanettimterry, heh, I'm not 100% sure, but I noticed it last night for the first time13:31
dandradermzanetti, too late to the party?13:31
mzanettidandrader, yes13:31
mzanettidandrader, really trying to tie down the very last bits in this silo13:32
mzanettidandrader, in theory we wouldn't be allowed to land this atm as there is the Feature Freeze for OTA-10 going on. However the things in this silo have an exception granted already13:32
mzanettidandrader, so even if I wanted I can't add other features now... and have like 10 people staring at me and asking when this silo will land13:32
mzanettimterry, flashing my flo with trunk now to see if it's there too13:33
dandradermzanetti, sure, just asking :)13:33
mzanettidandrader, yeah, no prob, just wanted to explain the situation instead of just saying "no - go away"13:34
dandradermzanetti, right, thanks13:34
mzanettimterry, confirming the issue on trunk13:40
mzanettimterry, you're off the hook :)13:40
mterry mzanetti, looks like the devices.conf trick doesn't work anymore since your better-windowed-logic branch, fyi13:40
mterrymzanetti: awesome, you flash faster than me13:40
mterrymzanetti: I'll still work on it for post-silo though13:41
mzanettican't be :D13:41
mterrymzanetti: you dropped "return deviceConfiguration.category;" as a backup for usageScenario13:41
mzanettiuh oh13:41
mzanettiwell, but wait13:41
mzanettihow come the tablets are still tablets then?13:41
mzanettithe only reason for flo/frieza to show a side stage is because of the deviceconfig13:42
mterrymzanetti: ah, you check deviceConfiguration.category == "phone"13:42
mterrymzanetti: so the trick may still work... not sure why it didn't worked for me13:43
mzanettimterry, maybe I got you wrong syntax... I didn't try it tbh...13:43
mterrymzanetti: whatever, I just hacked qml13:43
mterryor maybe I screwed something else up (enabled windowed mode)13:43
mterrymzanetti: can I help with an autopilot test?  Do you know the latest set of failing ones?13:45
mzanettimterry, running the adt tests atm13:45
dpmmzanetti, tsdgeos, not yet solved. I got the indicator-session .pot from ltinkl, but I don't have the unity8 one. If you guys can point me to a branch where it's up-to-date, I can also grab it from there.14:00
tsdgeosdpm: why do you need it?14:01
dpmtsdgeos, bq are preparing a translated manual, and they are waiting for translations for new strings that are only in silo 41. Without them being in LP, it makes it a bit difficult to do them, so I've thought I could manually upload the new .pot files to Launchpad and thus we don't need to block on the landing14:02
tsdgeosdpm: you mean upload it to the unity8 codebase? or?14:07
dpmtsdgeos, no, upload it to translations.launchpad.net14:07
dpmor more specifically, to https://translations.launchpad.net/ubuntu-rtm/15.04/+source/unity814:08
dpmI can upload a .pot file there in advance of any packages landing, so that the strings are translatable without having to wait on the landing14:08
tsdgeosdpm: seems like a lot of hassle for somethign that will hopefully land soon, but ok, i guess14:08
tsdgeosmzanetti: will you revive the branch you created?14:08
mzanettidpm, lp:~mzanetti/unity8/silo-41-pot14:09
mzanettimterry, wheeee!14:11
mzanettimterry, https://unity8-jenkins.ubuntu.com/job/test-ppa-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/lastCompletedBuild/testReport/14:11
mzanettijust some tutorial ones left14:11
mzanettidavmor2, just 4 test failures (probably just one thing to change to make all 4 pass) and we're good with 4114:11
dpmmzanetti, thanks! Where can I find the .pot file in the branch, or do I need to build it?14:13
mzanettidpm, po/unity8.pot14:13
dpmmzanetti, argh, sorry, misread the output of ls, all good, thanks14:13
dpmmzanetti, perfect, that's all I need, thanks a lot!14:14
cimimzanetti, this branch seems like is kinda touching that code https://code.launchpad.net/~unity-team/unity8/indicator-color-fixes/+merge/28817514:21
cimimzanetti, I dont have a micro sim to test the call :/14:21
cimiI'll ask my gf to borrow me hers for a bit14:22
mzanetticimi, I've tested it14:22
mzanetticimi, but wait... what's with that branch?14:22
mzanettiah, you mean the green panel14:23
cimimzanetti, replaces fixed colors with colors from the palette14:23
mzanetticimi, still strange how it never reverts, no?14:25
mzanettiI can't see an assignment somewhere14:25
cimiand of course https://code.launchpad.net/~unity-team/unity8/palette-fixes/+merge/28856014:26
cimimzanetti, unless something doesnt work in the applicationmanager14:26
cimimzanetti, as you can see in active call hint14:26
mzanetticimi, I'm struggling a bit to follow your thinking tbh14:30
mzanettimterry, you about?14:31
mterrymzanetti: ye14:31
mterrymzanetti: sorry didn't see irc ping14:31
mterrymzanetti: I'm close to done with these tutorial failires14:31
mzanettiah ok, great14:31
mzanettisorry for being a pain today14:31
mterrymzanetti: no I get it  :)14:34
cimimzanetti, that if something broke recently, it might well be due to the only two branches that touched that code14:37
cimimzanetti, so we should try to reproduce without those branches no?14:37
mzanettifair enough14:37
cimimzanetti, if we can reproduce without those two branches, is worth investigating more14:39
dholbachI'm seeing https://launchpadlibrarian.net/235779719/ThreadStacktrace.txt with unity8 on a desktop (bug 1539614) and I've been seeing it for a while. Does anyone have an idea what it might be?14:49
ubot5bug 1539614 in unity8 (Ubuntu) "unity8-dash crashed with SIGABRT in QMessageLogger::fatal()" [Medium,Confirmed] https://launchpad.net/bugs/153961414:49
mterrymzanetti: ok, I think I fixed em all, final testing14:52
mzanettimterry, should I build yet?14:52
mterrymzanetti: not yet, will ping14:52
mzanettidholbach, seems you're running a debug build and hit a qFatal()14:52
mzanettidholbach, if this is when starting unity8, it's very weird. it seems to try to start as a client, not as a server14:55
dholbachmzanetti, I installed unity8-desktop-session-mir and ran it from there14:57
dholbachmzanetti, the debug output it simply because the dump was retraced in launchpad14:58
dholbach"ran it from there" = in lightdm, pick unity8 session, try to login14:58
mzanettidholbach, do you have multiple libmirserver.so.XX around?15:00
dholbachno, just so.3815:00
mzanettidholbach, ok.. is this a new user? or did you log in with unity7 on it already?15:01
dholbachmzanetti, it's my regular user, the one I use in unity7 too15:02
mzanettimterry, no....15:03
mterrymzanetti: nothing terrible, I just...  there's some timing issue.  Like some  waitForRendering call missing or something.  Having trouble finding the right spot15:03
mzanettioh ok...15:05
mzanettimterry, not in the mood for terrible things any more :D15:05
mterrymzanetti: I could disable this one test...  :-/  and fix it later, if I'm the last test waiting15:05
mterrytest works if I add a wait() call...15:05
mzanettimterry, I can help searching15:06
mzanettitell me which one15:06
dholbachmzanetti, is there anyone else I could ping about this?15:09
mterrymzanetti: tutorial-redesign, test_tutorialBottomOnlyCoversMainStageOnTablet15:09
mterrymzanetti: pull first to get my other test fixes15:09
mzanettidholbach, duflu usually knows quite a lot what's going on in that area15:09
mterrymzanetti: and if you disable all other test functions first, make sure to at least re-enable test_tutorialBottomFinish, this test only fails if it's not the first one...15:10
mterrybut I don't think it's a case of failure to reset state...15:10
dholbachthanks mzanetti15:11
mzanettihmpf... fails to build here locally... /home/micha/Develop/reviews/tutorial-redesign/plugins/Wizard/timezonemodel.cpp:215:69: error: ‘geonames_city_get_country_code’ was not declared in this scope15:17
mzanettiah, I guess I need teh patched geonames15:17
mterrysomething is focusing u8-dash on top of my dialer-app.  it appears to be a race on setup, but I check on setup that dash is focused....15:20
mterryhrm..  the mock AppManager is delaying dash focus...15:25
mzanettimterry, so... I've built your branch15:27
mzanettimterry, ran make xvfbtestTurotial15:27
mzanettiand have 0 failures15:27
mterrymzanetti: you might need the rest of silo 41 then...15:28
mterrymzanetti: I've been testing on top of full silo15:28
mterrymzanetti, dednick: how are app stages determined in silo 41?16:05
dednickmterry: all start in main stage. state gets saved when they close16:06
mterrymzanetti, dednick: (especially in test mode with our mocks).  Most seem to open main stage, and setStage seems to have odd sideffects16:06
mterrydednick: can I just call setStage on a mock object?  No other test does so16:06
mterry(other than tutorial)16:06
dednickmterry: mmm.16:06
dednickmterry: maybe...16:07
mterrydednick: how is this tested in the side stage tests?16:07
dednicknot sure it'll work. will probably get overwritten with loaded stage.16:07
mterrydednick: ah...  WindowStateStorage.saveStage16:08
mterryok... may have fix16:17
=== dandrader is now known as dandrader|lunch
=== shuduo is now known as shuduo-afk
mzanettimterry, please tell me :)16:22
mterrymzanetti: ok, pushed.16:23
mterrymzanetti: it's a little janky (relies on a requestFocus to workaround a focus race that I still don't understand).  But seems to work16:24
mterryAnd uses new more proper way to set stages16:24
ltinklmterry, you've seen my keymapSwitching tests? had to use requestFocus too...16:25
mterryltinkl: no, didn't notice16:25
ltinklmterry, https://code.launchpad.net/~unity-team/unity8/keymapSwitching/+merge/288842 at the very end16:25
mzanettimterry, hey, do you know why ubuntu-settings-components are in the silo?16:26
mterryltinkl: well there at least you use it for switching to apps like I'd expect16:26
mterryltinkl: in my case, I started an app and immediately have to request focus as well16:27
mzanettimterry, I mean, there's a package in the ppa, but no MP for it16:27
mterrymzanetti: ?16:27
mterrymzanetti: oh ubuntu-settings-component16:27
mterrymzanetti: ... no?16:27
mterrymzanetti: the diff in the silo points to some vpn changes16:28
mterrymzanetti: but the vpn stuff isn't landing in this silo16:28
mterryalso seems to be a reverse diff16:28
mzanettiyeah, that doesn't look right16:28
mterrymzanetti: I'll drop from ppa16:29
mterrymzanetti: also the silo probably should drop those manual click download urls16:29
mzanettimterry, also, the silo says camera-app etc in source package name16:29
mzanettimterry, not sure if they would land16:29
mzanettimterry, I thought they are just for testing16:29
mterrymzanetti: I don't know either16:29
mterrymzanetti: ok settings-component out16:30
mterrymzanetti: manually removed them from packages list too (and apps)16:31
mzanettimterry, ok... build running... when it's done, I'll do another quick check on my devices, run adt on it and if it passes, off to QA16:31
* mterry crosses fingers16:31
mterrymzanetti: I'm heading out to lunch16:33
mzanettithe silo build failed17:07
mzanettibut seems for a LP timeout17:08
=== dandrader|lunch is now known as dandrader
mzanettimterry, failed to build :'(17:32
mzanettinot sure yet why17:32
mzanettiLP keeps timing out17:32
mzanettiwhitespace test17:32
mzanettimterry, /«BUILDDIR»/unity8-8.12+16.04.20160316.3/tests/qmltests/Tutorial/tst_Tutorial.qml: bad whitespace in line 26617:33
mzanettimterry, I've fixed it17:36
mterrymzanetti: guh thanks, sorry17:42
mterryshould have run the test first17:43
mterryltinkl: oh I see why setting name isn't working -- wizard doesn't make right call.  Oddly enough, AS doesn't let you directly set those properties.  It makes you call a special method like SetRealName, so that it can use policykit to more tightly control access17:56
ltinklmterry, aha... did that come with the as-refactor?17:57
mterryltinkl: it shouldn't have?  That's just a property of how the AS server works17:57
mterryltinkl: I can whip up a fix17:58
mterryfor post silo 41, I'm guessing, but pre-ota1017:58
ltinklmterry, yeah I meant in the code where we talk to AS over DBUS17:58
ltinklmterry, thanks!17:58
* ltinkl bbl17:58
mterryltinkl: well did you have custom code for this before?  I'm guessing it never worked17:58
ltinklmterry, I guess I had... not sure really17:59
=== alan_g is now known as alan_g|EOD
dandradermzanetti, is lp:~unity-team/unity8/shell_chrome the top-most branch in silo 41?18:39
dandradermzanetti, hmm, actually I can just take the resulting diff with everything in it! https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_39a8dbb93caf4ec889f8a1b7f69885db/bileto-1105/2016-03-16_18:17:38/xenial/unity8/content.diff18:40
mzanettidandrader, you want ~ci-train-bot/unity8/unity8-ubuntu-xenial-landing-04118:46
dandradermzanetti, how did you get to this LP branch? How could I find it in https://requests.ci-train.ubuntu.com/#/ticket/110519:08
mzanettidandrader, https://code.launchpad.net/unity8/19:09
dandradermzanetti, nice19:09
dandraderah, easy. I got only 23 conflicting files on top of silo041 :)19:18
=== dandrader is now known as dandrader|afk
mterryltinkl: https://code.launchpad.net/~mterry/unity8/set-real-name/+merge/289284 (though LP doesn't seem to generate a sensible diff...)19:34
mterryltinkl: but you can look at the latest commit for diff19:34
ltinklmterry, thanks, so it was broken also for BackgroundFile?19:36
mterryltinkl: not in practice because we never had setters for BackgroundFile (outside of mocks)19:36
ltinklmterry, right, we didn't have that either for InputSources19:36
mterryltinkl: right, which is why we didn't catch it there19:37
ltinklmterry, ok, when we land silo 41 (unless mzanetti wants to still squeeze it in, which I doubt), I'll review it19:43
ltinklmterry, hopefully we can still put it in the next silo, for OTA 1019:43
mterryltinkl: yeah definitely post-4119:43
mzanettiwhich one is that?19:55
mzanettiah, the set real name19:56
mterrymzanetti: I noticed we missed a manual package from silo 33 -- dbus-property-service19:56
mzanettiyeah, next one19:56
mterrymzanetti: will copy over -- this is the change that lets us reset the entire list of tutorial edges that we've already done19:56
mterrymzanetti: only used by developers19:56
mzanettimterry, kk19:57
mzanettimterry, 1 test failure19:57
mzanettiI wonder which one it could be19:57
mterrymzanetti: I'm still poking and prodding on my mako.  I don't have a tablet, you might have to smoke test there19:59
mzanettimterry, looking at fixing that test...20:00
mzanettilooks like it's got to do with the side stage branches20:01
mzanettipasses on manta, fails on flo20:03
mzanettithat's nasty20:03
=== dandrader|afk is now known as dandrader
mterrymzanetti: uh...  silo 41 doesn't have anything to do with vpn, right?20:05
mzanettimterry, no20:05
mterrymzanetti: I go to the vpn tab in System Settings and I get a blank screen20:05
* ltinkl tries20:05
mzanettihmm... there is a systemsettings landing20:06
mzanettikenvandine, any hints? ^20:06
ltinklmterry, hmm, don't have a VPN tab with silo 41, where is that?20:06
mterryltinkl: under the "Network" options, next to Bluetooth20:07
mterryltinkl: though it's the fourth one, so on my screen it's on its own row20:07
ltinklmterry, just got 3, BT last20:07
mterryI just reflashed, so I don't think I have weird packages20:08
dandradermterry, confirmed20:08
mterrydandrader: with silo 41 or just bare?20:08
dandradermterry, with silo 04120:08
mterryOK, I'll reflash and just confirm we didn't mess something up20:08
dandradermterry, didn't try with bare20:09
ltinklmterry, my suspect would be our s-s branch in silo 41 (https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/hwKeyboardMinimal/+merge/281213) isn't up to date against their trunk20:09
mterryI don't know why that would affect vpn20:10
mterryBut I hear ya20:10
dandradermterry,  2016-03-16 20:06:11,342 - WARNING - file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.3/PageStack.qml:231:9: QML PageWrapper: (file:///usr/share/ubuntu/settings/system/qml-plugins/vpn/PageComponent.qml:27:1: module "Ubuntu.Settings.Vpn" is not installed20:10
dandrader    import Ubuntu.Settings.Vpn 0.120:10
dandrader    ^)20:10
mterrymzanetti: ^ that settings package we took out...20:10
ltinklmterry, don't you have a libsystemsettings held back by apt?20:10
mterryltinkl: can't check now, reflashing20:12
mterryltinkl: we had some ubuntu-settings-components package in our ppa that didn't have an attached MP.  We took it out, but maybe it was providing that missing package.  Don't know why our silo has anything to do with it though20:12
mzanettiyeah, same here20:13
ltinklcitrain doesn't downgrade, does it?20:13
mzanettithe phone not, no20:13
ltinklah, these are the VPN plugins: https://code.launchpad.net/~jonas-drange/ubuntu-settings-components/vpn/+merge/28635320:13
mzanettikenvandine, ping20:14
ltinklactually it's approved20:14
mterryit's merged!20:15
ltinklright... it's already merged :)20:16
mterrymzanetti: on bare flash (no silo 41), I don't see the vpn tab at all20:17
mterrymzanetti: so this is some sort of regression I guess20:17
mzanettibut where is the question20:17
ltinklwhen did we last rebuild system settings in our silo20:18
mterryI don't see the string "vpn" in our uss merge20:18
mterrykenvandine: thanks!20:18
mterrykenvandine: we're seeing an odd regression in our silo 41 with system settings20:18
mterrykenvandine: on bare image, I'm seeing no "vpn" entry20:18
mterrykenvandine: with silo 41, I'm seeing a vpn entry, and when opening it, it's just blank20:19
kenvandinenew panel that landed this morning20:19
mterryget an error about module "Ubuntu.Settings.Vpn" is not installed20:19
kenvandinethere's a new depends20:19
mterrykenvandine: only uss MP we have is https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/hwKeyboardMinimal/+merge/28121320:19
kenvandineshould be there20:19
mterrykenvandine: do you know specifics?  Like what version of what package provides it?20:20
mterrymzanetti: ah...  citrain might just be upgrading to new uss because of general apt-get upgrade20:20
kenvandineqtdeclarative5-ubuntu-settings-components (>> 0.7+15.04.20160310),20:20
mterrymzanetti: and might be missing new package because of Recommends not being pulled in20:20
kenvandineit's  a depends20:21
kenvandinenot recommends20:21
mterrykenvandine: ok20:21
mterrybut maybe it only upgrades packages in silo20:21
mterryso it gets new uss20:21
mterrybut not new components...20:21
kenvandineoh right it does something like that20:21
kenvandinebut it should fail then...20:21
mterrykenvandine: only if uss has tightly versioned depends?20:21
mzanettiI'm still a bit lost. so the VPN stuff should be in there?20:21
mterrymzanetti: looks like a uss landing that happened after last image was made20:22
mterrymzanetti: I'm guessing anyway20:22
kenvandineyeah, a few hours ago20:22
mzanettiI see20:22
mterryThe following NEW packages will be installed:20:22
mterry  gnome-desktop3-data libgeonames0 libgnome-desktop-3-1020:22
mterryThe following packages will be upgraded:20:22
mterry  dbus-property-service libsystemsettings1 libunity-api0 libunity-scopes320:22
mterry  login passwd qtdeclarative5-qtmir-plugin qtmir-android qtubuntu-android20:22
mterry  ubuntu-system-settings unity-plugin-scopes unity-scope-click20:22
mterry  unity-scope-click-departmentsdb unity8 unity8-common unity8-private20:22
mterrySo new u-s-s20:23
mterryBut no upgraded system-components20:23
mterryWhich would explain it20:23
mterrymzanetti: so not our fault, just weird citrain nonsense20:23
kenvandinewhy would app do that20:23
kenvandineinstall the components :)20:23
mterrykenvandine: citrain messes with the apt pinning20:23
mzanettimterry, also, libqtdbustest is in the silo, can prolly be dropped20:25
mterrykenvandine: looks like u-s-s only does "qtdeclarative5-ubuntu-settings-components (>> 0.7+15.04.20160310)"20:25
mterrykenvandine: which isn't tight enough to require new vpn stuff20:25
mterrymzanetti: ok will look and drop20:25
kenvandineit was a few days ago :)20:25
mterrymzanetti: where's all this stuff coming from?20:26
mzanettimterry, silo 6420:26
mzanettimterry, saviq copied it over in order to start building 41 before 64 landet20:26
mterrymzanetti: empty diff20:26
mterrymzanetti: ok20:26
mzanettiso in theory we can drop it or not, won't make a change20:27
mzanettiexcept that package updated in another silo in the meantime20:27
mterrymzanetti: gone20:27
mzanettiso yeah, better drop20:27
kenvandinemterry, silo 66 should be waiting for qa... but i don't see it on trello anymore20:27
mzanettimterry, soo.. about those tests... they don't fail locally here20:27
mterrymzanetti: hah20:27
mterrykenvandine: is that the one with geonames branches?20:27
kenvandineit was ready for testing a couple hours ago... but now the card has vanished :/20:28
mzanettikenvandine, does it add features? it's feature freeze now so they probably don't look at it atm20:28
mterrymzanetti: small wrinkle, silo 66 has a couple of the same geonames branches we had.  We didn't know which would land first, so we put them in both and were going to take them out after the other landed20:28
mzanettijust waiting on 41 as it has an exception :/20:28
kenvandineota10 bug fixes20:28
mterrymzanetti: but 66 just went into qa.  And we're about to20:28
kenvandineand it includes geonames20:28
mterryI don't know if it's actually a problem to have it in both silos20:29
mterrysame code, no conflicts20:29
mzanettishould be ok afaiu20:29
mterrywe have one more branch on top of silo 66's20:29
mterrykenvandine: I don't know if porting to geonames is truly a bugfix  :)20:29
kenvandinesilo 66 should have been an easy one to land...20:29
kenvandinei know :)20:30
mzanettiwell, if we have more, 66 needs to drop it if we come first. other way round, they should stay in both20:30
kenvandinebut the rest was bug fixes20:30
kenvandinemterry, actually we have a few bugs related to timezone searching20:30
kenvandinei bet geonames fixes those20:30
mterrythat would be nice20:30
kenvandineit's way better20:30
mterrybut I'm not betting20:30
kenvandineand if the wizard is switching to it... we should too20:30
mterrymzanetti: ok.  so we can ignore the little vpn dustup.  I'm still smoke testing?  did you figure out the test failure?20:31
mzanettimterry, no... can't repro still20:31
* mterry tries20:31
mterrymzanetti: which test again?20:31
mzanettimterry, https://unity8-jenkins.ubuntu.com/job/test-ppa-autopkgtest/39/#showFailuresLink20:32
mzanettione on vivid, the other on xenial20:32
mzanettimterry, if you can't repro I make them skip20:35
mterrymzanetti: oh these are still qmltests  :)20:36
mzanettimterry, yes20:36
mterryI assumed autopilot again and was confused by what I was seeing20:36
mterrystill testing...20:40
mterrymzanetti: OrientedShell passed for me (but I'm running xenial, so not sure how great a test that was)20:42
mterrytrying Preview20:42
mterrymzanetti: Preview passed locally too20:42
mzanettisame here20:43
mzanettigonna disable them20:43
mzanettimterry, https://code.launchpad.net/~unity-team/unity8/disable-flaky-adt/+merge/28929420:46
mzanettiwait, forgot the prereq20:46
mterrymzanetti: 11k line test disable20:47
mzanettimterry, https://code.launchpad.net/~unity-team/unity8/disable-flaky-adt/+merge/28929520:47
mterrymzanetti: approved20:48
mzanettimterry, thanks20:51
mzanettilets hot I picked the right prereq20:51
mterrymzanetti: heh, 100% the other branches conflict20:51
mterrydandrader: fair point about declarative bits in keymapSwitching20:54
mzanettimterry, look like it merged20:56
mterrymzanetti: https://code.launchpad.net/~mterry/unity8/fix-greeter-retry/+merge/289299 and https://code.launchpad.net/~mterry/unity8/set-real-name/+merge/289284 -- they fix the "Retry" issue and the no-real-name issue.  For your next silo's consideration (or the one after the color changes)21:05
mzanettimterry, right, put them into 27 please21:06
mterrymzanetti: ok21:06

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!