[09:57] <mzanetti> dednick, good morning
[09:58] <mzanetti> dednick, I think the shell_chrome branches have quite a lot of failing tests still
[10:00] <dednick> mzanetti: i'll take a look.
[10:02] <dednick> mzanetti: have you got a link for the test run?
[10:07] <mzanetti> dednick, check your email
[10:07] <mzanetti> (have just been in a meeting with like every manager, asking me when silo 41 lands and then the color palette fixes)
[10:14] <dednick> mzanetti: oobe doesnt seem to even be reviewed yet...
[10:15] <mzanetti> dednick, it is
[10:16] <mzanetti> dednick, just needs the final stamp but mike and me reviewed it already and we tested it like a 100 times
[10:18] <cimi> pstolowski, could you put the social card branches on top of the filters one? I guess the filters will land first so it kinda make sense
[10:18] <pstolowski> cimi, ok
[10:32] <tsdgeos> mzanetti: i'm a bit scared you mentioned silo 41 is all or nothing, it'd seem to me filters could land even if the rest wasn't ready, no?
[10:33] <mzanetti> tsdgeos, we have to get all the things ready... it works fine now. it's "just" about fixing the tests
[10:33] <mzanetti> we really want the side stage stuff, and the oobe too...
[10:34] <mzanetti> if anything, I guess the shell chrome could be dropped for now...
[10:34] <dednick> sidestage broke a few tests. recursive touchPress function
[10:34] <mzanetti> dednick, yeah... are they just to be fixed or is there a bigger issue with it?
[10:35] <dednick> mzanetti: no, it's easy. i just called the wrong function within the UnityTestCase impl.
[10:35] <mzanetti> ok, cool
[10:35] <dednick> when i added multiTouchPress
[10:35] <mzanetti> fwiw, things passed in my manual testing on phone and tablet now...
[10:36] <mzanetti> desktop looked mostly ok too, need to check out some details still
[10:37] <mzanetti> I'm fixing some more color palette issues, please let me know when something is to be rebuilt and tests ran on it
[10:39] <mzanetti> hmmm... I have the greenish background now in the panel too
[10:41] <dednick> cool
[10:41] <dednick> i've never seen that
[10:42]  * ltinkl neither
[10:53] <tsdgeos> mzanetti: do you know if make tryNotifications is how the notifications really look on the phone? if so probably need some fixing since it's almost black on black
[10:54] <ltinkl> tsdgeos, got a branch on that
[10:54] <tsdgeos> ah cool
[10:54] <ltinkl> tsdgeos, https://code.launchpad.net/~lukas-kde/unity8/fixNotificationsColorWithNewUitk/+merge/288869
[10:55] <ltinkl> tsdgeos, I even added an "Inverse mode" checkbox to the controls so that you can really see how they look like
[10:55] <tsdgeos> cool, daniel is taking care of that branch, right?
[10:56] <tsdgeos> mzanetti: are we including ↑↑↑ on the landing for ota10?
[10:56] <ltinkl> tsdgeos, yeah, mterry mostly
[10:58] <ltinkl> tsdgeos, the fixes should be done in a silo following silo 41, still for OTA10
[11:01] <mzanetti> tsdgeos, the color fixes? yes
[11:01] <mzanetti> tsdgeos, yeah, prepping a silo with that atm
[11:01] <mzanetti> it's in 27
[11:09] <tsdgeos> ah so we'll still be landing another silo
[11:09] <tsdgeos> just 41 is FFE
[11:09] <tsdgeos> got it
[11:21] <mzanetti> cimi, ok, I think we've fixed all unity related things from this bug: https://bugs.launchpad.net/ubuntu/+source/unity8/+bug/1554616
[11:21] <mzanetti> cimi, any findings on the green panel?
[11:21] <cimi> mzanetti, haven't started yet - is critical enough to stop doing code reviews and move to that?
[11:22] <mzanetti> depends on the code reviews. if they are for somthing in silo 41, then no, otherwise yes
[11:22] <cimi> also do we have a proper bug report?
[11:22] <pstolowski> cimi, so i merged filters changes in unity-api & shell plugin in silo 71. you will need to do the same for unity8 if you want this silo in a working state
[11:22] <cimi> pstolowski, gotcha
[11:23] <cimi> mzanetti, ok I will stop code review, was for something else
[11:23] <mzanetti> ok
[11:23] <cimi> mzanetti, do we have a bug report?
[11:25] <mzanetti> cimi, do't think so
[11:25] <mzanetti> cimi, but I count that into the palette issues
[11:26] <mzanetti> as it seems to have started breaking with that
[11:31] <cimi> mzanetti, so I'll test it with silo 41
[11:31] <mzanetti> cimi, the color issues?
[11:31] <cimi> yes indeed
[11:32] <mzanetti> cimi, use silo 27 rather
[11:34] <mzanetti> ltinkl, nick had some comment about the touched files not having 2016 in the copyright. please update that. I'm about to approve the branch
[11:34] <mzanetti> it looks ok and tests well
[11:34] <ltinkl> mzanetti, ok, will update the (c)
[11:39] <ltinkl> mzanetti, done
[11:40] <mzanetti> ta
[11:45] <dpm> afternoon Saviq. Quick question: would it be possible to get an up-to-date .pot file for the unity8 and indicator-session in silo 41? The reason I'm asking is because bq are preparing a translated manual, and they are waiting for translations for new strings in that silo. Without them being in LP, it makes it a bit difficult to do them, so I've thought I could manually upload the new .pot files to Launchpad and thus we don't need to block on the landing
[11:45] <dpm>  to do the translations
[11:46] <mzanetti> really....
[11:46] <mzanetti> a criss-cross in side stage
[11:46] <mzanetti> dednick ^
[11:47] <dednick> mzanetti: eh. i'm updating sidestage now.
[11:47] <dednick> mzanetti: oh. hm. sidestage.
[11:47] <mzanetti> dpm, Saviq is out
[11:47] <dednick> i'm fixing chrome now...
[11:47] <mzanetti> dpm, I'll take care of it
[11:47] <dednick> one sec
[11:48] <dpm> mzanetti, awesome, thanks!. All I need is the resulting .pot files for the unity8 and indicator-session builds in the branches of silo41
[11:48] <mzanetti> dednick, let me know when you go back to the side stage branch so I can explain how to do it, and what you do wrong so you get criss-cross merges all the time
[11:49] <mzanetti> ltinkl, can you update the .pot file in your indicator-session branch
[11:49] <dednick> mzanetti: i've just pushed
[11:49] <ltinkl> mzanetti, ah right, ok
[11:50] <dednick> mzanetti: i didnt do anything... ltinkl updated oobe
[11:50] <mzanetti> dednick, so... the problem is that you have merged it with trunk
[11:50] <mzanetti> dednick, the history says "merge with trunk"
[11:50] <dednick> yesterday
[11:50] <mzanetti> yeah, I think you only pushed that today, could that be?
[11:50] <dednick> dont think so.
[11:50] <dednick> maybe...
[11:51] <mzanetti> dednick, in any case, once your branch has a prerequisite set, you must *never* again merge it with trunk
[11:51] <mzanetti> dednick, always merge it with the prerequisite it has
[11:51] <dednick> mzanetti: ok
[11:52] <mzanetti> if you need to get trunk in somehow, merge the prerequisite with trunk (or it's prereq) and get changes through the chain like that
[11:52] <mzanetti> ok, now lets see how to get out of this again
[11:53] <cimi> mzanetti, complaining about missing unity-shell-scopes when trying to compile more-palette-fixes, which package version you have installed?
[11:53] <ltinkl> dpm, indicator-session doesn't contain any POT file, how does that work? :)
[11:53] <dpm> ltinkl, it gets created on build
[11:54] <mzanetti> cimi, 10
[11:54] <cimi> mzanetti, of the deb package
[11:55] <ltinkl> dpm, right, with "make pot"; do you want that file?
[11:55] <mzanetti> 7.107+16.04.20160223-0ubuntu1
[11:55] <dpm> ltinkl, exactly
[11:59] <cimi> mzanetti, you have any silo installed?
[11:59] <cimi> I also need 54?
[12:00] <cimi> sorry 41
[12:02] <tsdgeos> wow
[12:03] <tsdgeos> loading the search icon on my desktop takes 1696 stat calls until it finds the correct one :D
[12:03] <tsdgeos> http://paste.ubuntu.com/15401036/
[12:03] <tsdgeos> performance \o/
[12:04] <greyback> tsdgeos: worth logging a UITK bug about that
[12:04] <greyback> their icon loading logic could definitely improve
[12:05] <tsdgeos> not sure if it's glib related though
[12:05] <tsdgeos> let me try it on the phone and see how many hits the phone gets
[12:05] <ltinkl> greyback, tsdgeos: remember a lengthy ML thread about KIconLoader... we used to have the same issue... ages ago
[12:06] <greyback> ltinkl: heh, why am I not surprised
[12:06] <ltinkl> tsdgeos, there is no glib code involved afaik, just QFile,QDir & co., all in nice loops :)
[12:07] <greyback> http://bazaar.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/trunk/view/head:/src/Ubuntu/Components/plugin/unitythemeiconprovider.cpp
[12:07] <ltinkl> see? :)
[12:07] <greyback> lots of loops! O(n^2) at least
[12:07] <ltinkl> QSettings in a foreach loop, nice
[12:08] <mzanetti> cimi, don't think so, no...
[12:09] <tsdgeos> on the phone it's only 1016
[12:10] <mzanetti> ltinkl, ?
[12:11] <mzanetti> not sure why everyone keeps on picking on QSettings
[12:11] <mzanetti> it caches all the stuff and is very lightweight to create
[12:11] <mzanetti> even for write access it caches things and write them to disk when idle
[12:12] <mzanetti> being clever enough to sync through memory if in between another instance is created and ready that value
[12:12] <mzanetti> reads
[12:12] <ltinkl> mzanetti, ok, it's just that those nested loops feel heavy
[12:13] <mzanetti> the only place where QSettings becomes slow is with a huge amount of ungrouped keys or endless bytearrays in values...
[12:13] <mzanetti> that can really take it down
[12:13] <mzanetti> but creating/destroying it is not the issue
[12:20] <dpm> mzanetti, ltinkl, do you happen to know which package the "Displays" string in here http://i.imgur.com/VzhS2bE.png comes from? It doesn't seem to be in indicator-session
[12:20] <ltinkl> dpm, you shouldn't see that indicator
[12:20] <mzanetti> dpm, where do you see that string?
[12:21] <dpm> mzanetti, it's on a screen capture bq sent us while they are preparing the m10 manual
[12:22] <mzanetti> right... that was the MWC image
[12:22] <dpm> and pointed out to us they need translations for those strings (while they haven't landed, they'll photoshop the translated strings on the screen caps)
[12:22] <dpm> yeah
[12:22] <mzanetti> this has changed. that string should not be around any more
[12:22] <dpm> oh, what does it look like now?
[12:22] <mzanetti> it's in the session indicator now
[12:23] <davmor2> dpm: a dead parrot
[12:23] <mzanetti> one sec, will get you a screenie
[12:23] <dpm> mzanetti, awesome, thanks
[12:23] <davmor2> dpm: man mzanetti spoils all my fun :)
[12:23] <dpm> davmor2, well, not quite dead yet, the rest of strings are in indicator-session. A half-dead one :)
[12:23] <mzanetti> well, I can still send him a picture of a parrot I guess
[12:24] <davmor2> :D
[12:24] <davmor2> hahaha
[12:24] <mterry> mzanetti: good morning!  I see your email, is the situation basically the same?
[12:25] <mzanetti> mterry, it should be a bit better by now, but yes
[12:25] <mzanetti> mterry, good morning
[12:25] <mzanetti> mterry, I might just have found another issue for you tho... when booting the tablet, it starts up with "Try again" in the login field
[12:25] <mzanetti> mterry, requires 2 taps to be able to enter the password
[12:26] <mterry> mzanetti: OK...  sounds like a post silo 41 bug though
[12:28] <mzanetti> dpm, not sure if you saw it... the screenshot is in your telegram inbox
[12:29] <dpm> got it , thanks!
[12:30] <mzanetti> mterry, oh... and... you don't want to hear it
[12:30] <mzanetti> but... it just doesn't pick up that username for me
[12:30] <mterry> mzanetti: you said that!  I don't get it
[12:30] <mterry> mzanetti: another post silo issue I guess
[12:31] <mzanetti> yeah... at least that's not a regression...
[12:31] <mzanetti> I'm not sure about the double tap tho
[12:31] <mzanetti> a bit worried QA will block us on that
[12:31] <dednick> mzanetti: ok, i think i've got all the side-stage low-chrome test fixes. pushed.
[12:31] <mzanetti> cool!!! thanks a lot dednick. kicking abuild
[12:31] <mterry> mzanetti: oh really?  OK, I can look into that then
[12:35] <mterry> mzanetti: shall I also remove camera-app, gallery-app, and mediaplayer-app from the ppa?  I see you dropped the MPs
[12:36] <mzanetti> mterry, yes, please
[12:37] <mterry> done
[12:47] <mterry> mzanetti: is there any way for me to fake tablet mode these days on my phone, without editing qml?
[12:47] <mterry> mzanetti: (to reproduce the "try again" bug)
[12:48] <mterry> these days == with silo 41
[12:50] <mzanetti> mterry, /etc/ubuntu/devices.conf
[12:50] <mzanetti> mterry, add a section:
[12:51] <mzanetti> wait, gotta create a pastebin
[12:52] <mterry> mzanetti: /etc/ubuntu/ doesn't exist for me, I assume that's normal
[12:52] <mzanetti> mterry, http://paste.ubuntu.com/15401213/
[12:52] <mzanetti> mterry, yeah, create it
[12:52] <mzanetti> mterry, replace krillin with mako or whatever you have
[12:52] <dandrader> mzanetti, what's the ETA for the current silo?
[12:52] <mzanetti> dandrader, when the tests are passing
[12:53] <dandrader> mzanetti, something like mid next week?
[12:54] <dandrader> mzanetti, or you expect this week already?
[12:54] <mzanetti> definitely this week
[12:54] <dandrader> mzanetti, ok
[12:54] <mterry> mzanetti: that didn't fix it for me, will just edit qml
[12:54] <mzanetti> QA is just waiting for this
[12:54] <mzanetti> lets see, got a build running. I expect there might be some more tests failing, but shouldn't be many any more
[12:56] <mzanetti> tsdgeos, what would be the best approach to update teh .pot? check out the merged silo 41 branch, run the update script and then copy the po/ folder over to a checkout of trunk?
[13:09] <tsdgeos> mzanetti: but the pot gets updated on landing, no?
[13:09] <tsdgeos> mzanetti: or you mean locally update it?
[13:09] <tsdgeos> what do you need it for?
[13:10] <mzanetti> dos it?
[13:10] <tsdgeos> yes it does
[13:10] <tsdgeos> there's a hoook for it
[13:10] <mzanetti> ok. problem solved... dpm asked me to do so
[13:10] <mzanetti> thanks
[13:10] <mterry> mzanetti: how reliable is the "try again" issue for you?  I got it once testing on my mako, but can't reproduce now
[13:10] <tsdgeos> mzanetti: "override_dh_auto_clean:" in debian/rules
[13:10] <mzanetti> mterry, I see it all the time basically
[13:11] <mterry> humph
[13:11] <mzanetti> mterry, steps to repro:
[13:11] <mzanetti> * unlock the device
[13:11] <mzanetti> * lock it (power button presS)
[13:12] <mzanetti> * wake it up, all is fine
[13:12] <mzanetti> * turn screen off again
[13:12] <mzanetti> * wake it up => issue triggered
[13:12] <mterry> mzanetti: ooohhhh, it's not on boot?  i thought I had read that
[13:12] <mzanetti> mterry, I guess there too... not sure
[13:13] <mzanetti> mterry, thing is, for me the screen wake up on his on very often because of telegram notifications
[13:13] <mzanetti> mterry, so I might just bootet it and by the time I looked at it the screen had been on/off twice already
[13:14] <mterry> mzanetti: ok, reproduced with your steps, thanks
[13:30] <mhall119> morphis: ping, I'm just checking in again to see if aethercast is any closer to working on the Nexus 4 this week
[13:31] <mterry> mzanetti: I see why this 'retry' bug is happening, trying to figure out best fix
[13:31] <dandrader> mzanetti, is the new screenshotting scheme part of that silo?
[13:31] <mzanetti> mterry, do you confirm it is a regression of the silo?
[13:31] <mterry> mzanetti: you sure it's a regression?
[13:31] <mzanetti> dandrader, no
[13:31] <mterry> mzanetti: my guess is that's it's been there.  Let me check on another phone
[13:31] <mzanetti> mterry, heh, I'm not 100% sure, but I noticed it last night for the first time
[13:31] <dandrader> mzanetti, too late to the party?
[13:31] <mzanetti> dandrader, yes
[13:32] <mzanetti> dandrader, really trying to tie down the very last bits in this silo
[13:32] <mzanetti> dandrader, in theory we wouldn't be allowed to land this atm as there is the Feature Freeze for OTA-10 going on. However the things in this silo have an exception granted already
[13:32] <mzanetti> dandrader, so even if I wanted I can't add other features now... and have like 10 people staring at me and asking when this silo will land
[13:33] <mzanetti> mterry, flashing my flo with trunk now to see if it's there too
[13:33] <dandrader> mzanetti, sure, just asking :)
[13:34] <mzanetti> dandrader, yeah, no prob, just wanted to explain the situation instead of just saying "no - go away"
[13:34] <dandrader> mzanetti, right, thanks
[13:40] <mzanetti> mterry, confirming the issue on trunk
[13:40] <mzanetti> mterry, you're off the hook :)
[13:40] <mterry>  mzanetti, looks like the devices.conf trick doesn't work anymore since your better-windowed-logic branch, fyi
[13:40] <mterry> mzanetti: awesome, you flash faster than me
[13:40] <mzanetti> whaaaat?
[13:41] <mterry> mzanetti: I'll still work on it for post-silo though
[13:41] <mzanetti> can't be :D
[13:41] <mterry> mzanetti: you dropped "return deviceConfiguration.category;" as a backup for usageScenario
[13:41] <mzanetti> uh oh
[13:41] <mzanetti> well, but wait
[13:41] <mzanetti> how come the tablets are still tablets then?
[13:42] <mzanetti> the only reason for flo/frieza to show a side stage is because of the deviceconfig
[13:42] <mterry> mzanetti: ah, you check deviceConfiguration.category == "phone"
[13:43] <mterry> mzanetti: so the trick may still work... not sure why it didn't worked for me
[13:43] <mzanetti> mterry, maybe I got you wrong syntax... I didn't try it tbh...
[13:43] <mterry> mzanetti: whatever, I just hacked qml
[13:43] <mterry> or maybe I screwed something else up (enabled windowed mode)
[13:45] <mterry> mzanetti: can I help with an autopilot test?  Do you know the latest set of failing ones?
[13:45] <mzanetti> mterry, running the adt tests atm
[14:00] <dpm> mzanetti, tsdgeos, not yet solved. I got the indicator-session .pot from ltinkl, but I don't have the unity8 one. If you guys can point me to a branch where it's up-to-date, I can also grab it from there.
[14:01] <tsdgeos> dpm: why do you need it?
[14:02] <dpm> tsdgeos, bq are preparing a translated manual, and they are waiting for translations for new strings that are only in silo 41. Without them being in LP, it makes it a bit difficult to do them, so I've thought I could manually upload the new .pot files to Launchpad and thus we don't need to block on the landing
[14:07] <tsdgeos> dpm: you mean upload it to the unity8 codebase? or?
[14:07] <dpm> tsdgeos, no, upload it to translations.launchpad.net
[14:08] <dpm> or more specifically, to https://translations.launchpad.net/ubuntu-rtm/15.04/+source/unity8
[14:08] <dpm> I can upload a .pot file there in advance of any packages landing, so that the strings are translatable without having to wait on the landing
[14:08] <tsdgeos> dpm: seems like a lot of hassle for somethign that will hopefully land soon, but ok, i guess
[14:08] <tsdgeos> mzanetti: will you revive the branch you created?
[14:09] <mzanetti> kk
[14:09] <mzanetti> dpm, lp:~mzanetti/unity8/silo-41-pot
[14:11] <mzanetti> mterry, wheeee!
[14:11] <mzanetti> mterry, https://unity8-jenkins.ubuntu.com/job/test-ppa-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/lastCompletedBuild/testReport/
[14:11] <mzanetti> just some tutorial ones left
[14:11] <mzanetti> davmor2, just 4 test failures (probably just one thing to change to make all 4 pass) and we're good with 41
[14:13] <dpm> mzanetti, thanks! Where can I find the .pot file in the branch, or do I need to build it?
[14:13] <mzanetti> dpm, po/unity8.pot
[14:13] <dpm> mzanetti, argh, sorry, misread the output of ls, all good, thanks
[14:13] <mzanetti> kk
[14:14] <dpm> mzanetti, perfect, that's all I need, thanks a lot!
[14:21] <cimi> mzanetti, this branch seems like is kinda touching that code https://code.launchpad.net/~unity-team/unity8/indicator-color-fixes/+merge/288175
[14:21] <cimi> mzanetti, I dont have a micro sim to test the call :/
[14:22] <cimi> I'll ask my gf to borrow me hers for a bit
[14:22] <mzanetti> cimi, I've tested it
[14:22] <mzanetti> cimi, but wait... what's with that branch?
[14:23] <mzanetti> ah, you mean the green panel
[14:23] <cimi> mzanetti, replaces fixed colors with colors from the palette
[14:25] <mzanetti> cimi, still strange how it never reverts, no?
[14:25] <mzanetti> I can't see an assignment somewhere
[14:26] <cimi> and of course https://code.launchpad.net/~unity-team/unity8/palette-fixes/+merge/288560
[14:26] <cimi> mzanetti, unless something doesnt work in the applicationmanager
[14:26] <cimi> mzanetti, as you can see in active call hint
[14:30] <mzanetti> cimi, I'm struggling a bit to follow your thinking tbh
[14:31] <mzanetti> mterry, you about?
[14:31] <mterry> mzanetti: ye
[14:31] <mterry> mzanetti: sorry didn't see irc ping
[14:31] <mterry> mzanetti: I'm close to done with these tutorial failires
[14:31] <mzanetti> ah ok, great
[14:31] <mzanetti> sorry for being a pain today
[14:34] <mterry> mzanetti: no I get it  :)
[14:37] <cimi> mzanetti, that if something broke recently, it might well be due to the only two branches that touched that code
[14:37] <cimi> mzanetti, so we should try to reproduce without those branches no?
[14:37] <mzanetti> fair enough
[14:39] <cimi> mzanetti, if we can reproduce without those two branches, is worth investigating more
[14:49] <dholbach> I'm seeing https://launchpadlibrarian.net/235779719/ThreadStacktrace.txt with unity8 on a desktop (bug 1539614) and I've been seeing it for a while. Does anyone have an idea what it might be?
[14:52] <mterry> mzanetti: ok, I think I fixed em all, final testing
[14:52] <mzanetti> mterry, should I build yet?
[14:52] <mterry> mzanetti: not yet, will ping
[14:52] <mzanetti> dholbach, seems you're running a debug build and hit a qFatal()
[14:55] <mzanetti> dholbach, if this is when starting unity8, it's very weird. it seems to try to start as a client, not as a server
[14:57] <dholbach> mzanetti, I installed unity8-desktop-session-mir and ran it from there
[14:58] <dholbach> mzanetti, the debug output it simply because the dump was retraced in launchpad
[14:58] <dholbach> "ran it from there" = in lightdm, pick unity8 session, try to login
[14:59] <mzanetti> right...
[15:00] <mzanetti> dholbach, do you have multiple libmirserver.so.XX around?
[15:00] <dholbach> no, just so.38
[15:01] <mzanetti> dholbach, ok.. is this a new user? or did you log in with unity7 on it already?
[15:02] <dholbach> mzanetti, it's my regular user, the one I use in unity7 too
[15:02] <mzanetti> ok
[15:02] <mterry> guhh
[15:03] <mzanetti> mterry, no....
[15:03] <mterry> mzanetti: nothing terrible, I just...  there's some timing issue.  Like some  waitForRendering call missing or something.  Having trouble finding the right spot
[15:05] <mzanetti> oh ok...
[15:05] <mzanetti> mterry, not in the mood for terrible things any more :D
[15:05] <mterry> mzanetti: I could disable this one test...  :-/  and fix it later, if I'm the last test waiting
[15:05] <mterry> test works if I add a wait() call...
[15:06] <mzanetti> mterry, I can help searching
[15:06] <mzanetti> tell me which one
[15:09] <dholbach> mzanetti, is there anyone else I could ping about this?
[15:09] <mterry> mzanetti: tutorial-redesign, test_tutorialBottomOnlyCoversMainStageOnTablet
[15:09] <mterry> mzanetti: pull first to get my other test fixes
[15:09] <mzanetti> dholbach, duflu usually knows quite a lot what's going on in that area
[15:10] <mterry> mzanetti: and if you disable all other test functions first, make sure to at least re-enable test_tutorialBottomFinish, this test only fails if it's not the first one...
[15:10] <mterry> but I don't think it's a case of failure to reset state...
[15:11] <dholbach> thanks mzanetti
[15:17] <mzanetti> hmpf... fails to build here locally... /home/micha/Develop/reviews/tutorial-redesign/plugins/Wizard/timezonemodel.cpp:215:69: error: ‘geonames_city_get_country_code’ was not declared in this scope
[15:17] <mzanetti> ah, I guess I need teh patched geonames
[15:20] <mterry> something is focusing u8-dash on top of my dialer-app.  it appears to be a race on setup, but I check on setup that dash is focused....
[15:25] <mterry> hrm..  the mock AppManager is delaying dash focus...
[15:27] <mzanetti> mterry, so... I've built your branch
[15:27] <mzanetti> mterry, ran make xvfbtestTurotial
[15:27] <mzanetti> and have 0 failures
[15:28] <mterry> mzanetti: you might need the rest of silo 41 then...
[15:28] <mterry> mzanetti: I've been testing on top of full silo
[15:29] <mzanetti> right...
[16:05] <mterry> mzanetti, dednick: how are app stages determined in silo 41?
[16:06] <dednick> mterry: all start in main stage. state gets saved when they close
[16:06] <mterry> mzanetti, dednick: (especially in test mode with our mocks).  Most seem to open main stage, and setStage seems to have odd sideffects
[16:06] <dednick> s/state/stage
[16:06] <mterry> dednick: can I just call setStage on a mock object?  No other test does so
[16:06] <mterry> (other than tutorial)
[16:06] <dednick> mterry: mmm.
[16:07] <dednick> mterry: maybe...
[16:07] <mterry> dednick: how is this tested in the side stage tests?
[16:07] <dednick> not sure it'll work. will probably get overwritten with loaded stage.
[16:08] <dednick> test_applicationLoadsInCorrectStage_data
[16:08] <mterry> dednick: ah...  WindowStateStorage.saveStage
[16:17] <mterry> ok... may have fix
[16:22] <mzanetti> mterry, please tell me :)
[16:23] <mterry> mzanetti: ok, pushed.
[16:24] <mterry> mzanetti: it's a little janky (relies on a requestFocus to workaround a focus race that I still don't understand).  But seems to work
[16:24] <mterry> And uses new more proper way to set stages
[16:25] <mzanetti> kk
[16:25] <ltinkl> mterry, you've seen my keymapSwitching tests? had to use requestFocus too...
[16:25] <mterry> ltinkl: no, didn't notice
[16:25] <ltinkl> mterry, https://code.launchpad.net/~unity-team/unity8/keymapSwitching/+merge/288842 at the very end
[16:26] <mzanetti> mterry, hey, do you know why ubuntu-settings-components are in the silo?
[16:26] <mterry> ltinkl: well there at least you use it for switching to apps like I'd expect
[16:27] <mterry> ltinkl: in my case, I started an app and immediately have to request focus as well
[16:27] <mzanetti> mterry, I mean, there's a package in the ppa, but no MP for it
[16:27] <mterry> mzanetti: ?
[16:27] <mterry> mzanetti: oh ubuntu-settings-component
[16:27] <mterry> mzanetti: ... no?
[16:28] <mterry> mzanetti: the diff in the silo points to some vpn changes
[16:28] <mterry> mzanetti: but the vpn stuff isn't landing in this silo
[16:28] <mterry> also seems to be a reverse diff
[16:28] <mzanetti> yeah, that doesn't look right
[16:29] <mterry> mzanetti: I'll drop from ppa
[16:29] <mzanetti> ack
[16:29] <mterry> mzanetti: also the silo probably should drop those manual click download urls
[16:29] <mzanetti> mterry, also, the silo says camera-app etc in source package name
[16:29] <mzanetti> right
[16:29] <mzanetti> mterry, not sure if they would land
[16:29] <mzanetti> mterry, I thought they are just for testing
[16:29] <mterry> mzanetti: I don't know either
[16:30] <mterry> mzanetti: ok settings-component out
[16:30] <mzanetti> cool
[16:31] <mterry> mzanetti: manually removed them from packages list too (and apps)
[16:31] <mzanetti> mterry, ok... build running... when it's done, I'll do another quick check on my devices, run adt on it and if it passes, off to QA
[16:31]  * mterry crosses fingers
[16:33] <mterry> mzanetti: I'm heading out to lunch
[16:33] <mzanetti> kk
[16:33] <mzanetti> enjoy
[17:07] <mzanetti> nooo
[17:07] <mzanetti> the silo build failed
[17:08] <mzanetti> but seems for a LP timeout
[17:32] <mzanetti> mterry, failed to build :'(
[17:32] <mzanetti> not sure yet why
[17:32] <mzanetti> LP keeps timing out
[17:32] <mzanetti> gaaaaaa
[17:32] <mzanetti> whitespace test
[17:33] <mzanetti> mterry, /«BUILDDIR»/unity8-8.12+16.04.20160316.3/tests/qmltests/Tutorial/tst_Tutorial.qml: bad whitespace in line 266
[17:36] <mzanetti> mterry, I've fixed it
[17:42] <mterry> mzanetti: guh thanks, sorry
[17:43] <mterry> should have run the test first
[17:56] <mterry> ltinkl: oh I see why setting name isn't working -- wizard doesn't make right call.  Oddly enough, AS doesn't let you directly set those properties.  It makes you call a special method like SetRealName, so that it can use policykit to more tightly control access
[17:57] <ltinkl> mterry, aha... did that come with the as-refactor?
[17:57] <mterry> ltinkl: it shouldn't have?  That's just a property of how the AS server works
[17:58] <mterry> ltinkl: I can whip up a fix
[17:58] <mterry> for post silo 41, I'm guessing, but pre-ota10
[17:58] <ltinkl> mterry, yeah I meant in the code where we talk to AS over DBUS
[17:58] <ltinkl> mterry, thanks!
[17:58]  * ltinkl bbl
[17:58] <mterry> ltinkl: well did you have custom code for this before?  I'm guessing it never worked
[17:59] <ltinkl> mterry, I guess I had... not sure really
[18:39] <dandrader> mzanetti, is lp:~unity-team/unity8/shell_chrome the top-most branch in silo 41?
[18:40] <dandrader> mzanetti, hmm, actually I can just take the resulting diff with everything in it! https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_39a8dbb93caf4ec889f8a1b7f69885db/bileto-1105/2016-03-16_18:17:38/xenial/unity8/content.diff
[18:46] <mzanetti> dandrader, you want ~ci-train-bot/unity8/unity8-ubuntu-xenial-landing-041
[19:08] <dandrader> mzanetti, how did you get to this LP branch? How could I find it in https://requests.ci-train.ubuntu.com/#/ticket/1105
[19:09] <mzanetti> dandrader, https://code.launchpad.net/unity8/
[19:09] <dandrader> mzanetti, nice
[19:18] <dandrader> ah, easy. I got only 23 conflicting files on top of silo041 :)
[19:34] <mterry> ltinkl: https://code.launchpad.net/~mterry/unity8/set-real-name/+merge/289284 (though LP doesn't seem to generate a sensible diff...)
[19:34] <mterry> ltinkl: but you can look at the latest commit for diff
[19:36] <ltinkl> mterry, thanks, so it was broken also for BackgroundFile?
[19:36] <mterry> ltinkl: not in practice because we never had setters for BackgroundFile (outside of mocks)
[19:36] <ltinkl> mterry, right, we didn't have that either for InputSources
[19:37] <mterry> ltinkl: right, which is why we didn't catch it there
[19:43] <ltinkl> mterry, ok, when we land silo 41 (unless mzanetti wants to still squeeze it in, which I doubt), I'll review it
[19:43] <ltinkl> mterry, hopefully we can still put it in the next silo, for OTA 10
[19:43] <mterry> ltinkl: yeah definitely post-41
[19:55] <mzanetti> which one is that?
[19:56] <mzanetti> ah, the set real name
[19:56] <mterry> mzanetti: I noticed we missed a manual package from silo 33 -- dbus-property-service
[19:56] <mzanetti> yeah, next one
[19:56] <mzanetti> ah
[19:56] <mterry> mzanetti: will copy over -- this is the change that lets us reset the entire list of tutorial edges that we've already done
[19:56] <mterry> mzanetti: only used by developers
[19:57] <mzanetti> mterry, kk
[19:57] <mzanetti> mterry, 1 test failure
[19:57] <mzanetti> appSupportingOnlyPrimaryOrientationWillOnlyRotateInLandscape
[19:57] <mzanetti> OrientedShell
[19:57] <mzanetti> I wonder which one it could be
[19:59] <mterry> mzanetti: I'm still poking and prodding on my mako.  I don't have a tablet, you might have to smoke test there
[20:00] <mzanetti> yes
[20:00] <mzanetti> mterry, looking at fixing that test...
[20:01] <mzanetti> looks like it's got to do with the side stage branches
[20:03] <mzanetti> passes on manta, fails on flo
[20:03] <mzanetti> that's nasty
[20:05] <mterry> mzanetti: uh...  silo 41 doesn't have anything to do with vpn, right?
[20:05] <mzanetti> mterry, no
[20:05] <mterry> mzanetti: I go to the vpn tab in System Settings and I get a blank screen
[20:05] <mzanetti> whaat
[20:05]  * ltinkl tries
[20:06] <mzanetti> hmm... there is a systemsettings landing
[20:06] <mzanetti> kenvandine, any hints? ^
[20:06] <ltinkl> mterry, hmm, don't have a VPN tab with silo 41, where is that?
[20:07] <mterry> ltinkl: under the "Network" options, next to Bluetooth
[20:07] <mterry> ltinkl: though it's the fourth one, so on my screen it's on its own row
[20:07] <ltinkl> mterry, just got 3, BT last
[20:08] <mterry> I just reflashed, so I don't think I have weird packages
[20:08] <dandrader> mterry, confirmed
[20:08] <mterry> dandrader: with silo 41 or just bare?
[20:08] <dandrader> mterry, with silo 041
[20:08] <mterry> OK, I'll reflash and just confirm we didn't mess something up
[20:09] <dandrader> mterry, didn't try with bare
[20:09] <ltinkl> mterry, my suspect would be our s-s branch in silo 41 (https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/hwKeyboardMinimal/+merge/281213) isn't up to date against their trunk
[20:10] <mterry> I don't know why that would affect vpn
[20:10] <mterry> But I hear ya
[20:10] <dandrader> mterry,  2016-03-16 20:06:11,342 - WARNING - file:///usr/lib/arm-linux-gnueabihf/qt5/qml/Ubuntu/Components/1.3/PageStack.qml:231:9: QML PageWrapper: (file:///usr/share/ubuntu/settings/system/qml-plugins/vpn/PageComponent.qml:27:1: module "Ubuntu.Settings.Vpn" is not installed
[20:10] <dandrader>     import Ubuntu.Settings.Vpn 0.1
[20:10] <dandrader>     ^)
[20:10] <mterry> mzanetti: ^ that settings package we took out...
[20:10] <ltinkl> mterry, don't you have a libsystemsettings held back by apt?
[20:12] <mterry> ltinkl: can't check now, reflashing
[20:12] <mterry> ltinkl: we had some ubuntu-settings-components package in our ppa that didn't have an attached MP.  We took it out, but maybe it was providing that missing package.  Don't know why our silo has anything to do with it though
[20:13] <mzanetti> yeah, same here
[20:13] <ltinkl> citrain doesn't downgrade, does it?
[20:13] <mzanetti> the phone not, no
[20:13] <ltinkl> ah, these are the VPN plugins: https://code.launchpad.net/~jonas-drange/ubuntu-settings-components/vpn/+merge/286353
[20:14] <mzanetti> kenvandine, ping
[20:14] <ltinkl> actually it's approved
[20:15] <mterry> it's merged!
[20:16] <ltinkl> right... it's already merged :)
[20:17] <mterry> mzanetti: on bare flash (no silo 41), I don't see the vpn tab at all
[20:17] <mterry> mzanetti: so this is some sort of regression I guess
[20:17] <mzanetti> but where is the question
[20:18] <ltinkl> when did we last rebuild system settings in our silo
[20:18] <mterry> I don't see the string "vpn" in our uss merge
[20:18] <mterry> kenvandine: thanks!
[20:18] <mterry> kenvandine: we're seeing an odd regression in our silo 41 with system settings
[20:18] <mterry> kenvandine: on bare image, I'm seeing no "vpn" entry
[20:18] <kenvandine> :/
[20:19] <mterry> kenvandine: with silo 41, I'm seeing a vpn entry, and when opening it, it's just blank
[20:19] <kenvandine> new panel that landed this morning
[20:19] <kenvandine> oh!
[20:19] <mterry> get an error about module "Ubuntu.Settings.Vpn" is not installed
[20:19] <kenvandine> there's a new depends
[20:19] <mterry> kenvandine: only uss MP we have is https://code.launchpad.net/~jonas-drange/ubuntu-system-settings/hwKeyboardMinimal/+merge/281213
[20:19] <kenvandine> should be there
[20:20] <mterry> kenvandine: do you know specifics?  Like what version of what package provides it?
[20:20] <kenvandine> checking
[20:20] <mterry> mzanetti: ah...  citrain might just be upgrading to new uss because of general apt-get upgrade
[20:20] <kenvandine> qtdeclarative5-ubuntu-settings-components (>> 0.7+15.04.20160310),
[20:20] <mterry> mzanetti: and might be missing new package because of Recommends not being pulled in
[20:21] <kenvandine> it's  a depends
[20:21] <kenvandine> not recommends
[20:21] <mterry> kenvandine: ok
[20:21] <mterry> but maybe it only upgrades packages in silo
[20:21] <mterry> so it gets new uss
[20:21] <mterry> but not new components...
[20:21] <kenvandine> oh right it does something like that
[20:21] <kenvandine> but it should fail then...
[20:21] <mterry> kenvandine: only if uss has tightly versioned depends?
[20:21] <mzanetti> I'm still a bit lost. so the VPN stuff should be in there?
[20:22] <mterry> mzanetti: looks like a uss landing that happened after last image was made
[20:22] <mterry> mzanetti: I'm guessing anyway
[20:22] <kenvandine> yeah, a few hours ago
[20:22] <mzanetti> ok
[20:22] <mzanetti> I see
[20:22] <mterry> The following NEW packages will be installed:
[20:22] <mterry>   gnome-desktop3-data libgeonames0 libgnome-desktop-3-10
[20:22] <mterry> The following packages will be upgraded:
[20:22] <mterry>   dbus-property-service libsystemsettings1 libunity-api0 libunity-scopes3
[20:22] <mterry>   login passwd qtdeclarative5-qtmir-plugin qtmir-android qtubuntu-android
[20:22] <mterry>   ubuntu-system-settings unity-plugin-scopes unity-scope-click
[20:22] <mterry>   unity-scope-click-departmentsdb unity8 unity8-common unity8-private
[20:23] <mterry> So new u-s-s
[20:23] <mterry> But no upgraded system-components
[20:23] <kenvandine> odd
[20:23] <mterry> Which would explain it
[20:23] <mterry> mzanetti: so not our fault, just weird citrain nonsense
[20:23] <kenvandine> why would app do that
[20:23] <kenvandine> yeah
[20:23] <kenvandine> install the components :)
[20:23] <mterry> kenvandine: citrain messes with the apt pinning
[20:25] <mzanetti> phew
[20:25] <mzanetti> mterry, also, libqtdbustest is in the silo, can prolly be dropped
[20:25] <mterry> kenvandine: looks like u-s-s only does "qtdeclarative5-ubuntu-settings-components (>> 0.7+15.04.20160310)"
[20:25] <mterry> kenvandine: which isn't tight enough to require new vpn stuff
[20:25] <kenvandine> sigh
[20:25] <mterry> mzanetti: ok will look and drop
[20:25] <kenvandine> it was a few days ago :)
[20:26] <mterry> mzanetti: where's all this stuff coming from?
[20:26] <mzanetti> mterry, silo 64
[20:26] <mzanetti> mterry, saviq copied it over in order to start building 41 before 64 landet
[20:26] <mterry> mzanetti: empty diff
[20:26] <mterry> mzanetti: ok
[20:27] <mzanetti> so in theory we can drop it or not, won't make a change
[20:27] <mzanetti> except that package updated in another silo in the meantime
[20:27] <mterry> mzanetti: gone
[20:27] <mzanetti> so yeah, better drop
[20:27] <mzanetti> thanks
[20:27] <kenvandine> mterry, silo 66 should be waiting for qa... but i don't see it on trello anymore
[20:27] <mzanetti> mterry, soo.. about those tests... they don't fail locally here
[20:27] <mterry> mzanetti: hah
[20:27] <mterry> kenvandine: is that the one with geonames branches?
[20:27] <kenvandine> yes
[20:28] <kenvandine> it was ready for testing a couple hours ago... but now the card has vanished :/
[20:28] <mzanetti> kenvandine, does it add features? it's feature freeze now so they probably don't look at it atm
[20:28] <mterry> mzanetti: small wrinkle, silo 66 has a couple of the same geonames branches we had.  We didn't know which would land first, so we put them in both and were going to take them out after the other landed
[20:28] <mzanetti> just waiting on 41 as it has an exception :/
[20:28] <kenvandine> ota10 bug fixes
[20:28] <mterry> mzanetti: but 66 just went into qa.  And we're about to
[20:28] <kenvandine> and it includes geonames
[20:29] <mterry> I don't know if it's actually a problem to have it in both silos
[20:29] <mterry> same code, no conflicts
[20:29] <mzanetti> should be ok afaiu
[20:29] <mterry> we have one more branch on top of silo 66's
[20:29] <kenvandine> yeah
[20:29] <mterry> kenvandine: I don't know if porting to geonames is truly a bugfix  :)
[20:29] <kenvandine> silo 66 should have been an easy one to land...
[20:30] <kenvandine> i know :)
[20:30] <mzanetti> well, if we have more, 66 needs to drop it if we come first. other way round, they should stay in both
[20:30] <kenvandine> but the rest was bug fixes
[20:30] <kenvandine> mterry, actually we have a few bugs related to timezone searching
[20:30] <kenvandine> i bet geonames fixes those
[20:30] <mterry> that would be nice
[20:30] <kenvandine> it's way better
[20:30] <mterry> but I'm not betting
[20:30] <kenvandine> and if the wizard is switching to it... we should too
[20:30] <mterry> agreed
[20:31] <mterry> mzanetti: ok.  so we can ignore the little vpn dustup.  I'm still smoke testing?  did you figure out the test failure?
[20:31] <mzanetti> mterry, no... can't repro still
[20:31]  * mterry tries
[20:31] <mterry> mzanetti: which test again?
[20:32] <mzanetti> mterry, https://unity8-jenkins.ubuntu.com/job/test-ppa-autopkgtest/39/#showFailuresLink
[20:32] <mzanetti> one on vivid, the other on xenial
[20:35] <mzanetti> mterry, if you can't repro I make them skip
[20:36] <mterry> mzanetti: oh these are still qmltests  :)
[20:36] <mzanetti> mterry, yes
[20:36] <mterry> I assumed autopilot again and was confused by what I was seeing
[20:40] <mterry> still testing...
[20:42] <mterry> mzanetti: OrientedShell passed for me (but I'm running xenial, so not sure how great a test that was)
[20:42] <mterry> trying Preview
[20:42] <mterry> mzanetti: Preview passed locally too
[20:43] <mzanetti> same here
[20:43] <mzanetti> gonna disable them
[20:46] <mzanetti> mterry, https://code.launchpad.net/~unity-team/unity8/disable-flaky-adt/+merge/289294
[20:46] <mzanetti> wait, forgot the prereq
[20:46] <mterry> looking
[20:47] <mterry> mzanetti: 11k line test disable
[20:47] <mzanetti> haha
[20:47] <mzanetti> easy
[20:47] <mzanetti> mterry, https://code.launchpad.net/~unity-team/unity8/disable-flaky-adt/+merge/289295
[20:48] <mterry> mzanetti: approved
[20:51] <mzanetti> mterry, thanks
[20:51] <mzanetti> lets hot I picked the right prereq
[20:51] <mterry> mzanetti: heh, 100% the other branches conflict
[20:54] <mterry> dandrader: fair point about declarative bits in keymapSwitching
[20:56] <mzanetti> mterry, look like it merged
[21:05] <mterry> mzanetti: https://code.launchpad.net/~mterry/unity8/fix-greeter-retry/+merge/289299 and https://code.launchpad.net/~mterry/unity8/set-real-name/+merge/289284 -- they fix the "Retry" issue and the no-real-name issue.  For your next silo's consideration (or the one after the color changes)
[21:06] <mzanetti> mterry, right, put them into 27 please
[21:06] <mterry> mzanetti: ok