[00:00] anyone know if we are going to drop the legacy HTTP endpoints for 2.0? [00:00] see https://github.com/juju/juju/blob/master/apiserver/apiserver.go#L432 [00:09] perrito666: thanks, fingers crossed this time [00:09] axw: quick question about cloud credentials schema, have a sec? [00:10] perrito666: in 1:1, sorry [00:10] no worrries [00:51] perrito666: had to do school drop off, I'm back now if you're still around [00:52] axw: solved it :) [00:52] tx anyway [00:52] perrito666: glad to be of service ;) [00:52] autoload-credentials was ignoring my ~/.novarc but it works with my env variables, will file a bug later [01:19] perrito666: i did test it with ~/.novarc [01:19] i wonder what went wrong [01:20] wallyworld: perhaps my novarc lacks the expected format? [01:20] you sure the contents are correct? [01:20] it looks for the same things as env vars [01:21] is a bash file full of exports [01:21] odd [01:21] maybe be a problem, not sure [01:21] weill have to retest [01:21] axw: i'm about to propose the interactive add-credentials with the CredentialSchema ordering fix. but i'm wondering if the password entry should echo * as characters are typed or pasted [01:21] wallyworld: are you sure your env was clean when you tested? [01:22] prtetty sure [01:22] i'll have a look ina bit [01:22] * perrito666 finally gets a k3 bootstrap [01:22] with magic auth_url auto discovery :) [01:22] yay [01:23] wallyworld: no, I don't think so. knowing the length of the password isn't great [01:23] wallyworld: you're using readpass, right? [01:23] axw: yep [01:23] is just a personal preference [01:23] i want feedback that i'm typing something [01:23] wallyworld: it's nice for visual feedback, but it is a security flaw [01:24] a small one [01:24] hard to count * :-) [01:24] wallyworld: not if it's a short password [01:24] and who uses short passwords? [01:24] surely everyone uses a pw manager [01:24] wallyworld: lol :) [01:24] if not they deserve wgat they get [01:25] (half joking) [01:37] Bug #1558333 opened: juju's logging the literal "$cmd" instead of value of $cmd

[01:45] perrito666: the issue with .novarc is that juju doesn't strip the export bit. my tests didn't have that [01:45] so the export bit is not valid? it sure seems [01:46] the export bit should be supported by juju [01:46] axw: since u r OCR, could u PTAL http://reviews.vapour.ws/r/4193/ [01:46] ie juju should strip it out [01:46] axw: it's a critical for 1.25 [01:46] anastasiamac_: sure, looking [01:46] axw: thanks :D [01:47] wallyworld: cant yout source the file into an env and read the env? sounds like you could save a lot of future pains with that [01:47] anastasiamac_: were there any changes to the changes required? [01:48] perrito666: sourcing the file is a shellism [01:48] anastasiamac_: (i.e. did you just cherry pick without having to modify?) [01:48] axw: ? no cherry-pick was not possible [01:48] anastasiamac_: I see, you said re-work [01:48] nps [01:48] axw: the commits have other stuff in them like lxd for eg.. [01:48] perrito666: i was hoping to avoid execing shell command [01:49] right, of course [01:49] axw: however, the related code is exactly as onmaster [01:49] anastasiamac_: okey dokey [01:49] axw: except for renaming model stuff :P [01:50] wallyworld: I would expect to be a way to wrap that into go by running a child env and do whatever that env supports as source (but then again, I am guessing, a lot) [01:50] i didn't see an obvious way, maybe there is [01:51] it's easy enough to tweaks what there already to work [01:54] anastasiamac_: LGTM, thanks [01:54] axw: \o/ [01:58] wallyworld: axw credentials schema fields cannot be made optionals? [01:59] perrito666: they can as of recently [01:59] wallyworld: is that on master? [01:59] Optional: true [01:59] yes [01:59] perrito666: i did it just for you [02:00] to support keystone 3 [02:00] you are wonderful, pint me to plz? [02:00] EPARSEERROR [02:01] if you grab master tip, you can use Optiona: true in credential schema [02:01] grrrreat [02:19] axw: fyi, ignore the charm-minvers feature branch pr, that's s merge into master i'm landing now [02:19] wallyworld: ok, thanks [02:25] k I have it working and almost fixed the joyous openstack live tests to reflect that, my brain is out of order for the day, see you all tomorrow [02:26] wallyworld: axw anastasiamac_ I would love a review of https://github.com/go-goose/goose/pull/19 during the night [02:26] cheers [02:26] our night or yours? [02:27] perrito666: will see how I go, got lots to review today [02:27] i can look [02:27] perrito666: nite \o/ [02:28] wallyworld: yours I need to et all this merged tomorrow [02:28] no sorry mine [02:28] mybrain is dead [02:28] perrito666: i was being facecious :-) [02:29] i knew what you meant :-) [03:38] axw: can I get one more quick review on the stringmap thing? realized I was missing handling an error case: https://github.com/juju/cmd/pull/32 [03:40] natefinch: looking [03:40] axw: thanks [03:41] natefinch: done [03:42] axw: thanks! [04:05] and now to figure out how to finagle these full stack tests to succeed when the server doesn't actually support this endpoint... [04:23] /win12 [04:30] axw: this is pretty horrible but necessary: https://github.com/juju/juju/pull/4766 PTAL [04:31] * axw braces [04:33] menn0: is there a bug filed for that on go-yaml? [04:34] natefinch: not yet, but I've just created a card for myself on our board to do that [04:34] menn0: is it worthwhile back porting to 1.25... I think that the bug would be awesome too \o/ [04:34] anastasiamac_: are we supporting go 1.6 for 1.25? [04:35] Bug # changed: 1499781, 1504578, 1526926, 1529126 [04:35] natefinch: it's an involved bug report to write up so I'll do it next week [04:35] anastasiamac_: the code that was relying on private embedded types only exists in Juju 2.0 [04:35] anastasiamac_: we'd know about it if we were relying on this elsewhere [04:35] menn0: then no need for 1.25 :D [04:36] * menn0 has lost hours on this [04:36] menn0: what's the deal with all the trailing underscores? [04:36] menn0: but for reference, I can see CI tests that run against 1.25 with go 1.6 [04:36] axw: they give you a place to rest your mouse when your arm gets tired [04:37] nani [04:37] axw: Tim came up with that as a way to avoid collisions between field names and the method names he wanted to use [04:37] natefinch: such small mouse tho :D [04:37] menn0: ah, right, ok [04:38] axw: i've continued with the trend [04:39] menn0: reviewed [04:39] axw: thanks [04:40] axw: I clearly didn't re-run the tests after removing that debugging Dump method :) [04:40] :) [05:59] axw: davecheney: I pushed a small update because of a case I found in Juju (we were calling AddCleanup during SetUpSuite()), can you give it one more quick look? [06:02] jam: LGTM. there's a bug somewhere (I think rogpeppe filed it) suggesting that we should just have AddCleanup, and DTRT whether we're in SetUpSuite or in/after SetUpTest [06:02] jam: probably need to change tests to do that tho [06:02] axw: I could do that here, with just checking if s.testSuite is nil [06:03] axw: does that sound sane? [06:03] jam: yeah, I'm just not sure if anything is relying on current behaviour [06:03] axw: if it is, its broken [06:03] assuming AddCleanup during a Suite level operation will be cleaned up after the first test run... [06:03] we could keep AddSuiteCleanup as an explicit thing [06:04] but calling it in a Test context and assuming it will last the rest of the Suite is also broken behavior [06:04] One test should not set global state for another test to expect [06:04] axw: then again, if the Juju test suite *does* have those bugs, I don't know how many I can fix :) [06:04] jam: indeed :) [06:05] jam: I'd be happy to drop AddSuiteCleanup and have AddCleanup add suite-level things when called in SetUpSuite, and test-level things otherwise [06:05] it's just a sed command to rename AddSuiteCleanup to AddCleanup after that [06:06] jam: if you want to defer removing/renaming, that's fine though. we can do that later [06:06] axw: trying to think how to write the tests for it. [06:06] I think making it safe and easy to use is best [06:07] so users don't have to think "Can I call it now"? [06:07] (heirarchy of good API, "make the obvious thing correct" vs "make the wrong thing hard to do" [06:07] ) [06:07] axw: it also leads to helpers like PatchValue where you can't control whether it is Suite level or Test level. [06:07] jam: just read your latest email; the bug I was thinking of was actually about PatchValue. same sort of deal though [06:08] axw: yeah, the fact that BaseSuite itself had this bug [06:08] means we can *easily* have lots of tests that are actually doing Outbound tests [06:08] :\ [06:08] and we didn't notice because we thought we were protected by BaseSUite [06:18] wallyworld: we're still using CompatSalt in cloudconfig/instancecfg, and I don't think there's any reason to. The hash is a temporary, derived password - we shouldn't need to use a fixed salt [06:19] axw: yeah, i figured that change was a separate pr [06:19] wallyworld: ok [06:42] axw: can you look at the pull? [06:42] http://github.com/juju/testing/pull/92 [06:42] jam: looking [06:42] thx [06:42] or davecheney^^ [06:44] axw: interestingly "home_test" was a case where we were setting up another test suite, and calling SetUpTest but not SetUpSuite [06:50] jam: LGTM, thanks. there's a couple of odd SetUpTest calls in home_test, but just style issues really [06:50] and preexisting at that [06:51] home_test is trying to test the test itself by creating another test object. [06:51] but it is calling SetUpTest without ever calling SetUpSuite [06:51] jam: ah, I see. [06:51] and we're now at... a whole lot of failures in Juju proper... [06:51] :/ [06:52] FakeHomeSuite is doing something bad. [06:52] jam: because they were swept under the rug? [06:52] lots of tests use it [06:52] lots of outbound connections? :) [06:52] oh home suite [06:53] investigating, because I don't see anything bad yet [06:53] FakeJujuXDGDataHomeSuite calls SetUpTest during TearDownSuite ? [06:54] axw: testing/environ.go line 107 [06:54] why is TearDownSuite calling Suite.SetUpTest() ? [06:55] I think that's just a copy&paste typo [06:55] jam: heh, yep, I'd say so [06:56] jam: since 2014 :) [06:56] axw: love it when our base infrastructure has some weird bugs in it. [06:57] axw: SetUpSuite is *also* calling SetUpTest instead of SetUpSuite [06:58] lol [06:58] and JujuOSSuite doesn't implement either SetUpSuite or TearDownSuite, so we don't need to write our own anymay [06:58] anyway [06:59] axw: or is it better to have one and just a line that says "this other one doesn't need to be called cause it doesn't exist" ? [07:00] jam: I've not found one way or the other to be much better [07:00] leaving it out is probably OK [07:00] jam: I'd love to write a static analyser one of these days to check that they're all wired up correctly [07:00] axw: yeah, the main problem is that once someone does introduce a SetUpSuite then we should call it, but neither way is going to catch that on its own [07:01] * axw nods [07:19] so it looks like we do have at least 1 failure in Provisioning suite [07:19] where it is actually reading cloud-images somehow [07:21] though it is failing in the opposite way I was expecting [07:22] maybe FakeXDGHome was accidentally making it harder to get outside access by calling SetUpTest all the time? [07:32] axw: i'm off to soccer soonish, i've reposnded to some of the comments on the add credentials review. i'll finish the interactive prompt for replace when i get back [07:33] wallyworld: thanks, I'm just responding now [07:33] enjoy [07:33] leaving in 20 minutes r so [07:33] will do [07:34] axw: ugh. we have test suites that want to call PatchValue before they call their Base type's SetUpTest because SetUp does work that they want to patch out [07:36] jam: ugh indeed [07:36] jam: example? [07:36] provider/lxd/ [07:37] testing_test.go [07:37] there is a BaseSuiteUnpatched and a BaseSuite [07:37] and BaseSuite embeds BaseSuiteUnpatched which embeds IsolationSuite [07:37] so BaseSuite patches an object, then calls BaseSuiteUnpatched.SetUp [07:38] line 277 [07:38] axw: ^^ [07:39] provider/joyent/joyent_test.go calls envtesting.PatchAttemptStrategies() before calling base .SetUpSiet() [07:39] SetUpSuite() [07:39] jam: yup. I think in the lxd case it could be moved to BaseSuite.SetUpSuite [07:40] jam: that one's a bit different, it's not involving the suite [07:40] axw: provider/joyent/local_test.go line 155 [07:40] calls PatchValue for 2 things before calling providerSuite.SetUpSuite() [07:42] jam: AFAICT, it doesn't need to [07:42] that also looks like it was honestly broken because the lifetime of that PatchValue should be wrong [07:42] * axw digs [07:42] true [07:42] my "go test ./...." is 5000 lines with this change to AddCleanup... [07:44] jam: yeah, those 2 patches can come after SetUpSuite [07:44] jam: 5000 lines? huh? [07:45] panic tends to create a fair bit of traceback [07:45] and SetUp failures fail on all the associated tests [07:45] so it is bigger than probably it seems [07:45] but its a fair bit to dig through [07:47] axw: provider/joyent/local_test.go adds a *AddSuiteCleanup* that patches the attempt strategies to ShortAttempt [07:47] I don't see it patch them to something longer first. [07:48] my rabbit hole has gotten too deep, I think [07:48] :) [07:49] jam: probably just cruft, but I don't know for sure [07:50] axw: I *did* finally hit tests that are going to cloud-images [07:50] and failing now because they can't [07:50] localLiveSuite.TestStartStop for provider/ec2 [07:51] "signature made by unknown entity" [07:52] jam: yep, SetUpSuite calls PatchOfficialDataSources which calls PatchValue [07:53] * axw has to go feed children [07:54] axw: have a good evening [07:55] need to get out a swear jar... [08:57] * frobware wakes up to find maas-spaces2 has merged. \o/ [09:31] dimitern: about to push your branch as upstream/maas-spaces-multi-nic-containers [09:33] frobware, great! and I've seen maas-spaces2 get merged! cheers [09:33] dimitern: if we don't do lxc then CI tests will fail. How do we not do this for the moment is not clear (to me at least). [09:34] frobware, well lxc-broker is still there, so .. [09:35] dimitern: we need to bung this branch (@ 07693b816c207bc6e3fa9d7dd3f76784a695908e) to the OS folks for testing... [09:36] dimitern, voidspace: upstream/maas-spaces-multi-nic-containers is now soliciting commits... :) [09:38] mgz, sinzui: please can we add upstream/maas-spaces-multi-nic-containers to the CI jobs (assuming something explicitly needs to be setup). thanks! [09:40] frobware: cool [09:40] frobware, I have some commits in mind to add :) [09:41] voidspace, frobware, we should also delete maas-spaces2 from upstream soon [09:45] frobware: pushing it into the juju namespace is all that's needed [09:46] mgz: thanks [09:47] frobware, about that fancycheck - it was temporary, now it can be dropped [09:47] frobware, and we should do that before the CI run right? [09:48] dimitern: submit a PR, we can now review, commit in the usual way. ;) [09:49] frobware, on it [09:52] dimitern: frobware: is maas-spaces2 landing on master today then? [09:52] voidspace, it already landed yesterday [09:53] dimitern: hah, cool [09:58] morning saphires o/ *yawn* [09:58] TheMue, hey o/ morning [10:00] TheMue: 0/ [10:01] voidspace, frobware, http://reviews.vapour.ws/r/4210/ [10:03] team meeting anyone? [10:04] * TheMue currently not *lol* [10:10] dimitern: frobware: I'm down to 11 failures on my branch (from 33 yesterday) - several of them about to be fixed by a change to gomaasapi [10:11] (gomaasapi test server) [10:13] morning all [10:14] natefinch: is there anyone in the tm? [10:15] perrito666: a efw people [10:16] perrito666: me, william, michael, and dimiter [10:17] dimitern, voidspace: sorry, was otp. Want to do a quick standup? [10:17] frobware: in team meeting [10:28] jam, I would love to help you with IsolationSuite horrors, but... probably not today [10:29] dimitern: want to drop back in for standup? [10:29] voidspace, sure [10:30] voidspace, frobware, I'm the only one there though [10:31] dimitern: we stayed in the team meeting room... [10:31] dimitern: as we were there already [10:31] ah [10:31] hence "drop back in" [10:56] Btw, Happy St Patricks Day [11:20] down to 7 failures and deleted more code [11:21] some unused production code some unused test helpers [11:37] thanks fwereade. I'm going to try and get some more of my LXD stuff done, but I did make a bit more progress on the Isolation stuff. Its actually closer than I was worried it would be. [12:41] before I go spelunking... can anyone suggest a foolproof way of inducing a StartSync on... whatever *state.State in the background is *actually* driving events for a hosted model running under a jujud test? [12:42] jam, dimitern, axw, wallyworld perhaps? ^^ [12:42] juju's PPA needs to be updated, currently throwing warnings on Xenial due to https://bugs.launchpad.net/ubuntu/+source/apt/+bug/1558331 [12:42] Bug #1558331: After upgrading to apt 1.2.7 in Xenial, PPAs and most other third-party repositories become unusable with "The repository is insufficiently signed by key (weak digest)" [12:42] fwereade: isn't there a StartSync() method or something to trigger a sync? [12:44] wallyworld, yeah... but you need to call it on the right *State [12:44] that is correct, it can be confusing [12:44] wallyworld, we have access to .BackingState [12:45] wallyworld, but I have a horrible feeling that the state that's backing the apiserver we talk to is hidden away in a statepool somewhere out of reach [12:45] i haven't looked at that stuff in ages. i do recall it being somewhat funky. i have not good answer for you [12:45] wallyworld, (.BackingState is the one for the controller model, but it doesn't cause hosted models to get events [12:45] ) [12:46] wallyworld, no worries, looks like I need to go hunting [12:46] yeah, sorry [13:30] frobware, ping [13:38] I am sad that juju controllers is not an alias for juju show-controllers [13:38] natefinch: list-controllers? [13:38] ty [13:39] it's show-controllers [13:39] oh, I guess it's both [13:39] show-controller is against once controller? [13:39] it gives metadata for one, the other is the listing [13:39] oh that is confusing [13:40] show-X is "give me details of one" and list- "give me a table of them" [13:40] alexisb: pong [13:40] heya frobware see private chat [13:40] rick_h__: but then why is there a show-controllers (note plural)? [13:40] natefinch: not sure on that one [13:41] natefinch, it may be that the alias still exists on that one [13:41] I owuld have to go look [13:41] rick_h__: looks like you can pass in multiple controller names and it'll show you details for all [13:41] at first we were doing both the single and plural case for everything [13:41] s/all/each [13:42] if you pass in 0 controller names, it shows you details for just the current [13:42] show vs. list is very confusing IMO. [13:42] but it looks like we have a lot of each [13:43] yes, it's one of the base principles of it. Very common across all nouns can be shown or listed [14:13] frobware, voidspace, http://reviews.vapour.ws/r/4212/ fixes an issue found with multi-nic support [14:18] I swear I am never ever ever going to get used to bootstrap having the name first [14:18] natefinch: don't get used to it, branch changing that lands soon hopefully [14:18] rick_h__: oh thank goodness [14:19] natefinch: oh, sorry you mean the cli [14:19] that's not changing, though tyou meant the name of the first model [14:19] lol, in which case sorry [14:19] aww! [14:20] how come when I juju bootstrap mylocal lxd ... it creates a juju controller named local.mylocal? [14:21] the local is for multi-user situation. You might add controllers from other users that already have that name [14:22] rick_h__: but if I don't... then you've just munged my namespace for no reason [14:22] natefinch: you should be able to leave it off and we can visit ways of streamlining [14:22] but had to design for the big case and work backwards [14:30] voidspace, frobware, we should get it in to have a chance of a blessed ci run [14:30] ^^ [14:30] dimitern: looking now [14:30] frobware, cheers [14:48] dimitern: reviewed [14:48] frobware, thanks - updated, pushed, and set to merge [14:48] dimitern: did you see the ci results of the first one? [14:49] * natefinch needs to make an auto-dependencies.tsv merge tool [14:49] frobware, yeah - as expected pretty much - the fancycheck [14:49] frobware, and most of the other issues should be resolved by the last fix [14:50] frobware, btw I managed to repro the empty mac address at setInstanceInfo for containers, looking into it [14:50] dimitern: I was in 2 minds about whether to push the branch this morning; I didn't think the CI run would happen that quickly given all the other feature branches that are being tested. [14:50] dimitern: oooh. And, btw, the reason the attach failed is I didn't start the remote end as root. [14:50] frobware, they made some changes recently - there was a mail about it [14:51] frobware, ah! :) [14:51] dimitern: what was the macaddr issue? [14:51] frobware, I have a suspicion why it might be happening [14:52] dimitern: ok, going to ignore that and look at profiles again [14:52] frobware, the MACAddress coming from PrepareContainerInterfaceInfo gets lost when trying to set the container devices in state [14:52] frobware, +1 [15:03] Bug #1558608 opened: maas-spaces-multi-nic-containers cannot bootstrap

[15:06] Bug #1558608 changed: maas-spaces-multi-nic-containers cannot bootstrap

[15:15] Bug #1558608 opened: maas-spaces-multi-nic-containers cannot bootstrap

[15:15] Bug #1558612 opened: creating hosted model config: maas-agent-name is already set; this should not be set by hand

[15:45] Bug #1558608 changed: maas-spaces-multi-nic-containers cannot bootstrap

[16:15] Bug #1558087 changed: TestInvalidFileFormat fails on windows because of /

[16:31] voidspace, btw I've found out the main reason why discoverspaces worker seems to make a lot of calls [16:31] voidspace, it does call CreateSpaces and AddSubnets once for each space / subnet [16:32] voidspace, I'm testing a patch now which takes advantage of the bulk nature of both api methods, so calls each of them once per handleSubnets() call [16:33] should make the discovery much quicker hopefully, and resolve some issues where subnets might be missing when trying to use them (e.g. for machine devices' addresses) [16:38] frobware: that test passes" [16:38] I meant ! [16:38] dimitern: I didn't know it seemed to make a lot of calls [16:38] dimitern: but cool [16:39] dimitern: I'm down to 1 failing test on drop-maas-1.8 [16:39]