| natefinch | perrito666: ship it | 00:14 |
|---|---|---|
| natefinch | perrito666: re: http://reviews.vapour.ws/r/4233/ | 00:14 |
| ericsnow | natefinch: https://github.com/juju/charmrepo/pull/78 :) | 00:27 |
| natefinch | lol charmstore_going_away.go | 00:28 |
| katco | natefinch: what's the key in the map[string][]params.Resource that ListResource returns in charmrepo? | 00:29 |
| natefinch | katco: the charmID.String() | 00:30 |
| katco | natefinch: really? | 00:30 |
| katco | var results map[string][]params.Resource | 00:30 |
| katco | if err := c.Get(path, &results); err != nil { | 00:30 |
| natefinch | katco: I keep meaning to update the comments on that method.. took me forever to figure it out too | 00:30 |
| natefinch | katco: yeah | 00:30 |
| katco | natefinch: i assumed it would be some http thing stuffed in there b/c it's parsing the response | 00:30 |
| katco | natefinch: that is super intuitive. | 00:30 |
| natefinch | katco: ....yeah | 00:31 |
| ericsnow | natefinch, katco: hey, at least you don't have to make your own HTTP GET call... | 00:31 |
| ericsnow | <wink> | 00:31 |
| natefinch | haha | 00:32 |
| katco | natefinch: ericsnow: i'm just renaming the "results" var to "charmID2resources" | 00:32 |
| ericsnow | :) | 00:32 |
| natefinch | katco: 👍 | 00:33 |
| natefinch | wow that is a tiny thumbs up | 00:33 |
| katco | ericsnow: natefinch: someone give me a high five shipit | 00:36 |
| katco | https://github.com/juju/charmrepo/pull/79 | 00:36 |
| natefinch | katco: can you update the comment to describe it, too? | 00:37 |
| katco | natefinch: what would you like the comment to say | 00:37 |
| natefinch | katco: like, comment on the function that is | 00:37 |
| natefinch | / ListResoruces retrieves the metadata about resources for the given charms. It returns a map of charmurl to resources. | 00:39 |
| katco | natefinch: done | 00:40 |
| natefinch | katco: shipit | 00:42 |
| perrito666 | ok EOW, have a nice night | 00:44 |
| katco | perrito666: tc | 00:44 |
| natefinch | see ya perrito666 | 00:44 |
| natefinch | ahhh... charm.Url *has* a channel | 00:53 |
| ericsnow | natefinch: I wouldn't count on that sticking around | 00:55 |
| natefinch | we should bring it up, though... if it's already there, why not use it? | 00:56 |
| ericsnow | +1 | 01:03 |
| * katco cries quietly | 01:10 | |
| katco | the full stack tests | 01:10 |
| natefinch | right? | 01:10 |
| katco | suites... suites upon suites... all the way down | 01:10 |
| natefinch | the real kicker is that charmrepo tests import charmstore, and the charmstore imports charmrepo | 01:11 |
| natefinch | and both charmrepo and charmstore use dependencies.tsv.... so... good luck | 01:11 |
| cherylj | katco: did you still need something? | 01:27 |
| katco | cherylj: yeah, sent email | 01:27 |
| katco | cherylj: ty for checking in ^.^ | 01:28 |
| cherylj | katco: is feature-resources the only branch your team is aiming to get merged? | 01:31 |
| katco | cherylj: yep, that's it | 01:31 |
| cherylj | katco: awesome, thanks. I'll add it to the list of branches ready for merging (pending CI run) | 01:31 |
| katco | cherylj: ty! please keep us updated on the results | 01:31 |
| cherylj | sure thing | 01:32 |
| mup | Bug #1559381 opened: Container not on the same network as host <ci> <lxc> <lxd> <network> <regression> <juju-core:Incomplete> <juju-core maas-spaces-multi-nic-containers:Triaged> <https://launchpad.net/bugs/1559381> | 02:34 |
| mup | Bug #1559382 opened: windows cannot be deployed with maas-spaces-multi-nic-containers <ci> <maas-provider> <regression> <windows> <juju-core:Incomplete> <juju-core maas-spaces-multi-nic-containers:Triaged> <https://launchpad.net/bugs/1559382> | 02:34 |
| mup | Bug #1559400 opened: TestManageModelRunsRegisteredWorkers is flaky <intermittent-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1559400> | 05:47 |
| mup | Bug #1559402 opened: cmdControllerSuite.TestCreateModel is flaky <intermittent-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1559402> | 05:47 |
| === akhavr1 is now known as akhavr | ||
| === akhavr1 is now known as akhavr | ||
| === ses is now known as Guest17049 | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!