[00:14] perrito666: ship it [00:14] perrito666: re: http://reviews.vapour.ws/r/4233/ [00:27] natefinch: https://github.com/juju/charmrepo/pull/78 :) [00:28] lol charmstore_going_away.go [00:29] natefinch: what's the key in the map[string][]params.Resource that ListResource returns in charmrepo? [00:30] katco: the charmID.String() [00:30] natefinch: really? [00:30] var results map[string][]params.Resource [00:30] if err := c.Get(path, &results); err != nil { [00:30] katco: I keep meaning to update the comments on that method.. took me forever to figure it out too [00:30] katco: yeah [00:30] natefinch: i assumed it would be some http thing stuffed in there b/c it's parsing the response [00:30] natefinch: that is super intuitive. [00:31] katco: ....yeah [00:31] natefinch, katco: hey, at least you don't have to make your own HTTP GET call... [00:31] [00:32] haha [00:32] natefinch: ericsnow: i'm just renaming the "results" var to "charmID2resources" [00:32] :) [00:33] katco: 👍 [00:33] wow that is a tiny thumbs up [00:36] ericsnow: natefinch: someone give me a high five shipit [00:36] https://github.com/juju/charmrepo/pull/79 [00:37] katco: can you update the comment to describe it, too? [00:37] natefinch: what would you like the comment to say [00:37] katco: like, comment on the function that is [00:39] / ListResoruces retrieves the metadata about resources for the given charms. It returns a map of charmurl to resources. [00:40] natefinch: done [00:42] katco: shipit [00:44] ok EOW, have a nice night [00:44] perrito666: tc [00:44] see ya perrito666 [00:53] ahhh... charm.Url *has* a channel [00:55] natefinch: I wouldn't count on that sticking around [00:56] we should bring it up, though... if it's already there, why not use it? [01:03] +1 [01:10] * katco cries quietly [01:10] the full stack tests [01:10] right? [01:10] suites... suites upon suites... all the way down [01:11] the real kicker is that charmrepo tests import charmstore, and the charmstore imports charmrepo [01:11] and both charmrepo and charmstore use dependencies.tsv.... so... good luck [01:27] katco: did you still need something? [01:27] cherylj: yeah, sent email [01:28] cherylj: ty for checking in ^.^ [01:31] katco: is feature-resources the only branch your team is aiming to get merged? [01:31] cherylj: yep, that's it [01:31] katco: awesome, thanks. I'll add it to the list of branches ready for merging (pending CI run) [01:31] cherylj: ty! please keep us updated on the results [01:32] sure thing [02:34] Bug #1559381 opened: Container not on the same network as host

[02:34] Bug #1559382 opened: windows cannot be deployed with maas-spaces-multi-nic-containers

[05:47] Bug #1559400 opened: TestManageModelRunsRegisteredWorkers is flaky

[05:47] Bug #1559402 opened: cmdControllerSuite.TestCreateModel is flaky

=== akhavr1 is now known as akhavr === akhavr1 is now known as akhavr === ses is now known as Guest17049