[13:51] Bug #1559701 opened: kill-controller manual provider broken [13:51] Bug #1559704 opened: can't load package: package github.com/axw/fancycheck: [14:03] Bug #1559706 opened: TestFinalizeCredentialInvalidFilePath fails on windows [14:33] Bug #1558158 changed: Restore fails with no instances found [14:33] Bug #1559708 opened: TestMinVersionLocalCharm unexpected non-nil error [14:33] Bug #1559712 opened: Backup-restore: could not start prepare restore mode [15:03] Bug #1559715 opened: restore-backup is unreliable [16:15] Bug #1559730 opened: TestMongoErrorNoCommonSpace timed out [17:46] The default vagrant box for juju does not work behind proxy. Where can i have a look how is built on the CI server to make appropriate adjustments ? [20:55] <_thumper_> :-( === _thumper_ is now known as thumper [20:56] menn0: looking at merging master into model-migration [20:56] one simple conflict [20:56] but state/toolstorage doesn't exist any more [20:56] * thumper goes to see where it went [21:00] found it [21:00] state/binarystorge [21:00] oh ffs [21:00] where did version go? [21:01] juju/version! [21:01] nate emailed about that [21:06] * thumper hasn't read emails yet [21:07] mwhudson: found it btw... [21:08] * thumper headdesks [21:08] * thumper takes a deep breath [21:08] someone has removed refactorings I added to state for model migrations to work [21:09] thumper: this is one reason why I don't like feature branches any more [21:09] yeah... [21:09] definitely has drawbacks [21:09] thumper: it's too easy for stuff like that to happen in the mega merges that result [21:10] * thumper nods [21:10] I think I'm beginning to side with that [21:10] thumper: I was a big fan of the idea when we started using them but I definitely it's been a failed experiment [21:10] * thumper sobs quietly in the corner [21:10] ipaddressesC is gone [21:11] thumper: that will affect model descriptions right? [21:11] still digging [21:12] dealing with changes to read only users right now [21:12] thumper: which reminds me... instances have status now [21:12] thumper: model descriptions need to be updated to handle that [21:12] thumper: I've done the bare minimum to get it compiling again [21:12] \o/. [21:12] thumper: but it skips over instance status [21:13] sounds like a bug fix [21:13] thumper: there's a card for that [21:13] thumper: yep :) [21:15] oh... [21:15] good [21:15] I hadn't done ipaddressesC yet [21:22] menn0: ugh... [21:22] how we retrieve tools has all changed too [21:22] the tools migration doesn't currently compile [21:23] * thumper is still investigating [21:27] got it now [21:27] running tests [21:32] menn0: this is painful [21:32] thumper: need help? [21:32] nah [21:32] I think I have it now [21:32] just lots of paper cuts [21:35] * thumper found some more cuts [21:53] ok... [21:53] I have now fixed description, migration, and state to work with changes [21:53] now running full test suite [21:54] I think I need another coffee [21:54] at least I have time... [22:29] huh... [22:30] found an intersting error in the cmd/jujud/reboot tests... [22:30] fork/exec /usr/bin/virsh: too many open files [22:30] github.com/juju/juju/cmd/jujud/reboot/reboot.go:96: failed to list containers [22:37] Bug #1559789 opened: lxd container not removed [22:40] menn0: just submitted branch to merge master into model-migrations [22:40] * thumper goes to look at the failures for MADE-model-workers [22:40] thumper: great stuff [22:52] Bug #1559789 changed: lxd container not removed [22:58] Bug #1559789 opened: lxd container not removed [23:01] ... [23:01] wat? [23:01] * thumper digs [23:03] menn0, axw, thumper: fairly simple change in preparation for something which I need to land tomorrow... fancy a review? http://reviews.vapour.ws/r/4249/ [23:04] o/ rogpeppe3 [23:04] thumper: o/ === rogpeppe3 is now known as rogpeppe [23:04] thumper: how's tricks? [23:04] I want to smash my face into this desk [23:04] you? [23:04] thumper: that'll be tomorrow morning [23:05] thumper: tonight i'm on the sofa, so no desk available [23:07] rogpeppe: LGTM [23:07] axw: ta! [23:09] axw: oh well, looks like we can't land anything on master anyway [23:09] aw, crap [23:09] axw: thanks for the review anyway [23:09] rogpeppe: np [23:10] * rogpeppe hits $$merge$$ anyway, on the off-chance... [23:10] bah humbug [23:11] ugh... [23:11] I have to work out how to start the windows vm again [23:12] i wish that master was gated on windows tests passingf [23:13] if anyone manages to unblock master, you'd be doing me a great favour by hitting $$merge$$ on https://github.com/juju/juju/pull/4807. but i guess it probably can't get unblocked for about 4 days now until CI runs again... :-\ [23:15] wallyworld: you sent me a PGP-encrypted blank email? :) [23:15] ffs, i'll resend [23:17] :( [23:17] I have forgotten the password I used for my windows vm [23:17] is it a standard admin password? [23:17] thumper: looks like line 609 should be "file": filepath.FromSlash("/some/file"), [23:18] thumper: with an associated change in the test condition [23:18] thumper: 'cos under windows, filepath.IsAbs("/foo") will return false [23:18] rogpeppe: is this for a blocker? [23:18] I've not looked [23:19] thumper: yeah [23:19] rogpeppe: ta, I'll get on it [23:19] thumper: although... the filepath code says i'm wrong. maybe in an older version of Go. [23:21] it would be great to remember this password... [23:24] thumper: ah no it doesn't. under windows, /some/file isn't absolute because it doesn't mention a drive. [23:25] thumper: so my fix is wrong, but in the right general direction. [23:27] thumper: i guess you could just use a known-absolute path such as the result of os.TempDir(). Or have a windows-specific test. Ugh. [23:31] wallyworld: https://bugs.launchpad.net/juju-core/+bug/1559706 [23:31] Bug #1559706: TestFinalizeCredentialInvalidFilePath fails on windows [23:31] wallyworld: this is blocking master [23:31] wallyworld: can you look at it? [23:32] thumper, wallyworld: i've commented on the bug [23:32] rogpeppe: cheers [23:32] thumper: already am [23:32] wallyworld: thanks [23:32] wallyworld: what's my windows password, I've forgotten [23:33] wallyworld, thumper: thanks for looking at this. it would make me a lot happier if juju was unblocked within the next 7 hours :) [23:33] * rogpeppe goes to bed [23:34] it will be [23:34] wallyworld, thumper, axw, menn0: g'night all [23:34] see ya [23:34] night rogpeppe [23:34] night [23:35] wallyworld: has someone recently been doing work on ec2 security groups? [23:36] not that i am aware [23:36] but we have always had issues with how e have used them IIRC [23:36] wallyworld: any ideas? http://reports.vapour.ws/releases/3788/job/functional-ha-backup-restore/attempt/3476 [23:37] the security group spam? [23:38] that's started showing up of late [23:38] i think it's a circular dependency thing [23:38] it also happens in master IIAMN [23:42] menn0: for the good news, it seems that none of the failures on MADE-model-workers are specific to that branch [23:42] just a bunch of other intermittent test failures [23:42] however the bad news is that we have a bunch of intermittent test failures [23:43] menn0: ping me when you have some time to talk about what next [23:49] wallyworld: gotta go downstairs for a while, fix for azure is up for review [23:49] awesome ty [23:50] wallyworld: has been tested live [23:50] even betta [23:51] thumper: trivial fix http://reviews.vapour.ws/r/4251/ [23:52] * thumper looks [23:53] wallyworld: who deletes the temp dir? [23:53] thumper: c.MkDir() is used as the root path [23:53] so it gets cleaned up automatically [23:53] ok, cool [23:53] shipit [23:53] ta [23:54] thumper: was having lunch. back now. [23:55] menn0: hangout? [23:55] thumper: isn't today otago day ? [23:55] davecheney: yes [23:55] so why are you working ? [23:55] davecheney: but due to deadlines, busy things... I'm working today [23:55] will swap later [23:55] right, [23:55] sorry, i should have come to stand up then [23:55] but I thought it would just be me [23:55] np [23:56] * menn0 and mwhudson aren't in otago so davecheney wouldn't have been by himself anyway [23:57] otago isn't the whole country [23:57] is it only the south island ? [23:57] only the bottom bit of the south island [23:57] and not even all of that [23:57] but has waigani and me [23:58] right, dunedin day, got it [23:58] did I mention it was ashfield day on tuesday ? :)