/srv/irclogs.ubuntu.com/2016/03/21/#juju-dev.txt

thumperwallyworld: added a comment to that review...00:03
wallyworldok00:03
wallyworldthumper: it needs to be a file, not a dir00:04
thumperfilepath.Join(c.MkDir(), "somefile"),00:04
wallyworlddoh00:04
wallyworldsigh00:05
wallyworldfair point00:05
mupBug #1559280 changed: creating hosted model config: opening model: endpoint: expected string, got nothing <bootstrap> <ci> <juju-core:New> <juju-core admin-controller-model:Triaged> <https://launchpad.net/bugs/1559280>00:29
mupBug #1559285 changed: creating hosted model config: opening model: storage-endpoint: expected string, got nothing <bootstrap> <ci> <juju-core:New> <juju-core admin-controller-model:Triaged> <https://launchpad.net/bugs/1559285>00:29
wallyworldthumper: that bug is fix committed, i wonder if we could remove the blocker tag to unblock master01:07
cheryljkatco: can you review?  http://reviews.vapour.ws/r/4247/01:15
axwwallyworld: guessing wildly, I'm wondering if the --config CI is passing has an "authorized-keys" with an empty string value01:21
axwwallyworld: in controller/modelamanager we don't update the attrs if there's an existing key01:22
axwwallyworld: we don't check if the value is empty tho01:22
wallyworldaxw: i suspect the same - i am updating the code to account for that - i have passing tests but it is still failing in live testing bit i am close01:22
axwwallyworld: ok cool01:22
davecheneylucky(~/src/github.com/juju/juju) % juju kill-controller testing01:23
davecheneyerror: controller testing not found01:23
davecheneylucky(~/src/github.com/juju/juju) % juju bootstrap --upload-tools testing aws/ap-southeast-201:23
davecheneyERROR cannot create controller "local.testing" info: model info already exists01:23
davecheneyis it deleted or not !?!?01:23
cheryljthere's already a bug for that, davecheney.  I've had to manually delete things out of cache.yaml to work around it01:24
davecheneythanks01:24
wallyworldaxw: it's failing because jujud bootstrap command is getting passed a controller model config which still has authorized-keys-path and it creates a cfg using NoDefaults which means this is not stripped out and causes havoc further down the line01:29
axwwallyworld: argh, of course01:29
wallyworldaxw: i wonder if bootstrap jujud should be using WithDefaults01:30
axwwallyworld: where?01:30
wallyworldjujud/bootstrap.go Run()01:31
axwwallyworld: i don't think so. by that stage, it should have a complete config01:31
wallyworldbut there i think it is simply using what was passed from the bootstrap cmd01:31
wallyworldso may not be complete01:32
wallyworldi could be wrong01:32
axwwallyworld: pretty sure it shouldn't be, possibly broken during changes. will look01:32
wallyworldaxw: so what we should be doing is stripping authorized-keys-path on the bootstrap client side when we read the keys, i'm guessing we don't do that01:34
axwwallyworld: yep01:34
axwwallyworld: atm on server we'll ignore authorized-keys if authorized-keys-path is set01:35
=== ses is now known as Guest16952
axwwallyworld: so we should remove authorized-keys-path after reading01:35
wallyworldyep01:35
axwfrom hosted model config01:35
axwwallyworld: actually we do remove after reading, just not from hosted model config01:35
wallyworldaxw: that is done if UseDefaults is used01:35
wallyworldin my case though host model config does not have that key i don't think01:36
wallyworldhosted01:37
axwwallyworld: if bootstrap config has authorized-keys-path, it must've come from --config. everything in --config will be added to hosted model config01:37
wallyworldyeah01:38
wallyworldaxw: here's a fix http://reviews.vapour.ws/r/4252/02:07
thumperwallyworld: what was your thinking on unblocking?02:14
wallyworldthumper: i think we should02:14
thumperwallyworld: have you personally run the tests on windows?02:15
wallyworldno, don't have windows02:15
thumperI'd like to wait until at least someone has run the windows tests02:15
wallyworldok02:15
axwwallyworld: reviewed02:16
wallyworldta02:16
natefinchwallyworld: is the timestamp in a bzr commit ref reliable?  e.g. ian.booth@canonical.com-20141121040613-ztm1q0iy9rune3zt ?  can I parse that timestamp and trust that if I compare two of them, the later one definitely comes from a later ref?02:31
natefinchwallyworld: context - I'm trying to write an automated dependencies.tsv merge tool02:32
wallyworldnatefinch: i think so02:32
wallyworldnatefinch: for bzr , the rev id is monotonic02:32
wallyworldally increasing02:33
wallyworldso simplier to use that i think02:33
natefinchI wasn't sure if the id was reliable... either one is fine, I just want to be able to tell which one is later02:33
natefinchsince basically every time I merge dependencies.tsv I just pick whichever commit is later02:33
axwwallyworld: I've repro'd the "cannot obtain provisioning script" bug, digging in now02:45
wallyworldaxw: what did you do to repro?02:45
axwwallyworld: bootstrapped lxd provider, added another lxc machine OOB and did "add-machine ssh:.."02:46
wallyworldaxw: hmmm, ok. i basically did the same thing except my bootstrap machine manual02:46
axwwallyworld: yeah I think I did that last time I tested and that worked02:46
wallyworldok, at least then it is explainable02:47
axwwallyworld: hrm, CI definitely is bootstrapping with manual tho03:14
wallyworldyeah, go figure03:14
axwwallyworld: anyway, *seems* to be related to ControllerInstances not returning any instances03:14
davecheneythumper: http://reviews.vapour.ws/r/4254/03:15
wallyworldaxw: i'm also at a loss as to why show-controller is failing in the restore job03:15
wallyworldi've asked for more info like the yaml files and args passed to show-controller03:15
axwwallyworld: ok, haven't gotten to that one yet. I think I see the problem with manual03:16
axwwallyworld: we're setting use-sshstorage too late now03:16
axwwallyworld: (dumb config attr name, but still required)03:17
wallyworldaxw: does that explain why it works sometimes?03:17
menn0thumper: http://reviews.vapour.ws/r/4255/ pls03:17
axwwallyworld: it would work if the controller machine were able to ssh to itself as ubuntu03:17
wallyworldwhich i think it could for me03:18
wallyworldas i copied my ssh keys across03:18
axwwallyworld: that'll do it. also, the machine agent will write the "system" public key03:19
axwbut asynchronously, so it's racy03:19
wallyworldjoy03:19
wallyworldaxw: i've gone through the python CI scripts for the restore job and everything appears ok. i though we may have had an issue with default-model name was the same as the controller name which is what the scripts do but i tested that and show-controller worked03:19
wallyworldso it appears the scripts bootstrap, do some stuff, then attempt to call show-controller and that fails03:20
axwwallyworld: is the script swallowing stderr? I don't see any error messages, just the backtrace03:21
wallyworldyeah, that's part of the issue, i haven't checked but it must be03:21
wallyworldthere's not much to go on03:22
wallyworldaxw: can we rename that use-sshstorage attribute then if you are in the area and we need to retain it for 2.0?03:28
axwwallyworld: yup03:28
wallyworld\o/03:28
axwwallyworld: the issue with lxd is that we're filtering machines by hosted model UUID, and not controller model UUID03:40
wallyworldaxw: for which issue?03:40
axwwallyworld: so ControllerInstances fails if you call it with the hosted model config03:40
wallyworldah the ssh-storage one03:41
axwwallyworld: no, related, but different03:41
axwwallyworld: lxd as controller vs manual as controller03:41
axwyou can't add-machine ssh with either03:41
wallyworldright, both causes affect the ProvisioningScript03:41
axwyup03:42
axwwallyworld: I think I might simplify the ProvisioningScript code a bit. we get the Environ to get the addresses ... but we already store addresses in state03:42
axwso I'll just have it grab them out of state03:42
wallyworldsgtm03:42
axwwallyworld: https://github.com/juju/juju/pull/481604:30
wallyworldlooking04:31
wallyworldaxw: hoow does that simplifcation work around the bug?04:40
axwwallyworld: environs.APIInfo calls ControllerInstances. ControllerInstances is broken for lxd and manual when called with hosted model config04:40
axwpossibly other providers too04:40
wallyworldah right, that's the bit i was missing, that APIInfo called ControllerInstances04:41
mupBug #1559706 changed: TestFinalizeCredentialInvalidFilePath fails on windows <blocker> <ci> <regression> <unit-tests> <windows> <juju-core:Fix Released by wallyworld> <https://launchpad.net/bugs/1559706>04:53
axwwallyworld: no rush, PR to drop use-sshstorage: https://github.com/juju/juju/pull/481705:04
wallyworldok, will look in 505:04
wallyworldaxw: small one also http://reviews.vapour.ws/r/4260/05:11
axwwallyworld: LGTM05:13
wallyworldta05:13
mupBug #1555744 changed: kill-controller / destroy-controller prevents reuse of controller name <docteam> <juju-release-support> <juju-core:Invalid by wallyworld> <https://launchpad.net/bugs/1555744>05:44
mupBug #1559844 opened: InvalidVolumme.NotFound error destroying aws environment <juju-core:Triaged> <https://launchpad.net/bugs/1559844>05:44
axwwallyworld: last one: https://github.com/juju/juju/pull/481905:46
wallyworldok05:46
wallyworldaxw: lgtm05:54
axwwallyworld: ta05:54
axwwallyworld: see my reply to your comment?05:55
wallyworldno, looking05:55
wallyworldyeah probably05:55
wallyworldaxw: do you have a recollection of an destroying aws environment and getting an InvalidVolume.NotFound error as per the bug above? i seem to recall we had seen that and may it was supposed to be fixed06:05
axwwallyworld: I don't recall anything specific, sorry06:06
wallyworldsure, np06:06
wallyworldaxw: our cleanup after failed bootstrap still could leave inconsisent metadata; this pr partially addresses that http://reviews.vapour.ws/r/4262/08:02
axwwallyworld: you can't environs.Prepare with an existing controller name, so most of that doesn't make sense. it works because you're reinstating old stuff, but it would be simpler to just check if the environs.Prepare error is not "AlreadyExists", and revert only then08:30
axwI mean, it makes sense, but it's not very straight forward08:30
axwwallyworld: actually, it doesn't do the right thing in that case. I'll just comment on the PR08:32
axwwallyworld: just need to write some tests for login itself, then I can propose the basics09:25
wallyworldaxw: sgtm, admin controller branch currently in CI09:31
TheMuemorning09:44
dimiternvoidspace, ping10:02
mupBug #1542206 changed: space discovery still in progress <ci> <intermittent-failure> <joyent-provider> <precise> <regression> <juju-core:Invalid> <juju-core maas-spaces-multi-nic-containers:Invalid> <https://launchpad.net/bugs/1542206>10:09
voidspacedimitern: got someone with me, be free about 11'ish10:21
dimitern voidspace ok, ping me then please10:25
voidspacedimitern: ping11:04
voidspacedimitern: actually, gimme 5  - gonna reboot11:04
dimiternvoidspace, sure11:04
voidspacedimitern: half my windows have dissappeared and won't return *grrr*11:04
voidspacedimitern: aaaaand back11:07
voidspacedimitern: you wanna hangout?11:07
dimiternvoidspace, hey, omw11:10
jamespagedimitern, morning - do we have any other flags on network-get other than primary-address?11:45
jamespageI could really do with understanding the cidr for a binding as well11:45
jamespagethat is discoverable - but just wondered...11:45
dimiternjamespage, not yet, but more args are planned11:47
dimiternjamespage, well, it wasn't really possible to report back anything but the address until the multi-nic work11:47
dimiternjamespage, so now I guess we can give you the full proposed YAML/JSON output, as discussed in the network-get spec?11:48
jamespagedimitern, well we can parse a yaml OK :-)11:49
jamespagedimitern, is that already accessible?11:49
jamespageor is that work for you?11:50
dimiternjamespage, now almost the complete information about machine's interfaces and addresses is available in state and to network-get11:51
jamespagedimitern, ok - so I just need to parse that11:51
jamespageright-oh11:51
dimiternjamespage, just a sec, let me paste a straw-man proposal of what network-get can return without --primary-address11:52
dimiternjamespage, how does this look ? http://paste.ubuntu.com/15455682/11:59
voidspacedimitern: https://github.com/juju/juju/pull/482212:05
voidspacedimitern: http://reviews.vapour.ws/r/4264/12:05
jamespagedimitern, is cidr-address the ip address with the netmask? or the subnet cidr?12:06
dimiternvoidspace, LGTM12:07
dimiternjamespage, yeah, like in /e/n/i: address 10.20.19.100/2312:07
dimiterns/\23/\24/12:07
dimiternjamespage, please note there are potentially multiple devices that will be returned for a given binding12:09
voidspacedimitern: thanks12:09
lqhttp://linkcash.co/2Zn12:14
jamespagedimitern, why would multiple bindings be returned?12:15
jamespagesorry devices, not bindings?12:15
dimiternjamespage, well, if you have 2 addresses from the same subnet of the same device12:17
dimiternjamespage, or alternatively - 2 devices each with addresses from the same space the binding is on12:18
dimiternjamespage, s/each with addresses/each with an address/12:18
axwwallyworld: replied to your PR if you want to take another look12:32
wallyworldsure12:32
wallyworldaxw: so it ensures that current account value is correct for example?12:33
axwwallyworld: yep. current account is per controller12:33
axwwallyworld: remove the controller and it doesn't make sense anymore, so we remove that info12:34
wallyworldright, but then we should ensure it is reset to what it was12:34
wallyworldi guess that happens when we reset the current controller12:35
axwwallyworld: there's two possibilities: you just created hte controller, or you didn't. if you created it, there was no value. if you didn't, attempting to create the controller again fails12:35
axw(and you don't update models/accounts/bootstrap-config)12:36
wallyworldand it decorateAndWrite fails half way through, restting current controller should be enough12:36
axwwallyworld: resetting current-controller and removing the controller from ClientStore12:37
wallyworldyes12:37
* axw nods12:37
wallyworldwe remove current controller but don't currently reset12:37
axwwallyworld: so: move defer up, like you did; reset current-controller; don't remove controller if errors.IsAlreadyExist(err)12:38
axwwallyworld: agree?12:38
wallyworldaxw: yep, i've already fixed the error check12:38
axwcool12:39
wallyworldaxw: should be good to go12:44
axwwallyworld: still a bit weird: cannot destroy newly created controller details "my-controller" info12:46
axwwallyworld: "controller %q details" would be less weird to me12:46
axwdropping info12:47
wallyworldffs, i'm tired12:47
wallyworldfixing12:47
axwno doubt12:47
axwwallyworld: LGTM, thanks12:48
wallyworldso as of now, i can't quite see the failure mode that would lead to people not being able to bootstrap with the same controller name after a failed attempt. there's a bug or two on that. maybe we have fixed stuff the past week or two12:48
axwwallyworld: you mean with that fix?12:49
axwwallyworld: if environs.Prepare fails half way through then you're buggered (without that fix)12:49
wallyworldyeah, once this goes in, plus i think there's been other small cleanips12:49
wallyworldi was more hoping out loud we'd be ok now12:50
axwwallyworld: yeah, otherwise it's down to hitting ctrl-c or power out at the wrong time12:50
axwwallyworld: I think kill-controller should be expected to work if environs.Prepare returns successfully12:51
wallyworldaxw: i think so too12:51
axwwallyworld: it would be nice if we had some way to do the prepare transactionally/atomically12:51
wallyworldyup12:51
axwwallyworld: write to a separate directory and slide the symlink or something12:52
wallyworldjuju 2.1 :-)12:52
axwwallyworld: yeah, inclined not to worry about that for now12:52
wallyworldwe got to get this farking adminbranch landed12:52
jamespagedimitern, which golang version do I need for lxd support?13:15
mgzjamespage: 1.3 or later13:17
jamespagemgz, ta13:17
natefinchjamespage: One thing to keep in mind - if you're using the client built for trusty, it won't have LXD, since it wasn't built with 1.3+13:22
jamespagenatefinch, yes I just hit that13:23
jamespagenatefinch, rebuilding with 1.313:23
jamespageits in backports afterall13:23
natefinchcool13:23
dimiternjamespage, on trusty you'll need to add trusty-backports to /etc/apt/sources.list and then do apt-get update13:26
axwwallyworld: for the morning: https://github.com/juju/juju/pull/482313:29
wallyworldok, ty13:29
* axw away13:30
katcomorning all13:59
natefinchmorning14:00
rick_h_morning katco14:01
katconatefinch: how's the family?14:01
katcorick_h_: heyo14:01
katcorick_h_: hey, i was wondering this over the weekend: are you a full stack guy, or a unit test guy?14:01
natefinchkatco: good.  snow day today14:02
katconatefinch: uh oh14:02
rick_h_katco: both!14:02
katconatefinch: we woke up sat. morning to heavy snow, 1" on the ground. by noon it was all gone and sunny.14:02
rick_h_katco: I cringe when there's a PR that doesn't address both ends imo14:02
rick_h_katco: hah, gotta love first day of sprint14:02
rick_h_spring14:02
rick_h_damn, been working here too long to s/sping/sprint14:03
katcorick_h_: where do you feel full-stacks should live? ci?14:03
katcorick_h_: lol14:03
natefinchkatco: yeah, it's like 5 inches here... gonna be 40° later, but still gotta snowblow or it'll take forever to melt14:03
rick_h_katco: yes, in a perfect world they're in CI and part of gating landing14:03
katcorick_h_: cool14:03
rick_h_katco: only when they take too long to run, should they not be gating landings, and then there's a push to figure out why/speed up14:03
rick_h_katco: imo and all that :)14:03
katcorick_h_: hey, everyone's got an elbow ;)14:04
rick_h_e.g. can we gate on a test on a single platform/etc so that they can be part of the gating process still14:04
rick_h_but yea, I've seen too many unit tests break an API that isn't noticed because nothing full stack was run that used it.14:05
rick_h_katco: kind of like updating the mock, and missing that updating the mock means the real things needs an update14:05
katcorick_h_: yeah, that is definitely an antipattern14:08
rick_h_katco: that being said, I like it when unit tests break right at the point of function X and say "oh, yea...that got an unexpected arg" and fixing things is much simpler/etc14:08
rick_h_katco: and with tons more of those, it's much more bitesize/managable to work on a smaller chunk of code14:09
katcorick_h_: yeah me too. i like it even better when the unit test that tests the actual api meets your interfaces breaks when you change your interface ;)14:09
rick_h_:)14:10
katcorick_h_: so when do you get the new camper?14:12
rick_h_katco: hopefully April sometime14:14
rick_h_katco: my luck, right before sprints start :P14:14
katcorick_h_: doh... well maybe you can get it prepped and then go for a get-away when you get back ;)14:14
rick_h_katco: actually, so think I figured out my camper guy's trip this summer. Figure on heading to St Lious14:15
rick_h_my wife doens't have an iterest, but taking the boy to the arch would be cool, and we go by chicago14:15
katcorick_h_: dude! if you make the trip, definitely keep me in the loop!14:15
katcorick_h_: no pun intended14:15
katcorick_h_: we have some fantastic natl. parks around here14:16
rick_h_katco: yea, I think we'll head past chicago, stay somewhere there, hit up chicago for a day, crash, go on to your area. Crash, see the arch/etc. And head back. It's like 8hrs so split between two days makes for a relaxing week trip.14:17
katcorick_h_: yeah that sounds like a fun trip14:18
jamespagedimitern, force of habit - I keep creating lxc containers, not lxd ones...14:19
jamespagedimitern, also noted that lxd in s bundle always creates trusty machines14:20
jamespagedimitern, resulting in a mismatch when the service is then deployed to them...14:20
natefinchjamespage: the always trusty thing may just be a problem with configuration.  You need to import non-trusty images and alias them as ubuntu-<series>14:23
natefinchjamespage: so, like from https://jujucharms.com/docs/devel/config-LXD#images - lxd-images import ubuntu xenial amd64 --sync --alias ubuntu-xenial14:24
jamespagenatefinch, with the maas provider?14:24
jamespageI'm running from a branch right now....14:24
natefinchjamespage: sorry, no, I was talking about the lxd provider, sorry, I may have misunderstood your comment.14:24
jamespagenatefinch, I keep doing "juju add-unit --to lxc:1"14:25
jamespagerather than lxd:114:25
* jamespage faceplants14:25
natefinchjamespage: oh, I see14:25
natefinchjamespage: heh yeah14:25
dimiternjamespage, sorry, was afk - did you managed to sort it out?14:26
jamespagedimitern, yeah14:31
jamespagedimitern, ok - so seeing some oddness with lxd containers14:37
jamespagespecifically14:37
jamespageI've had a container come up without a default route14:37
jamespageand two subsequent ones come up without and interfaces...14:37
mupBug #1559293 changed: show-controller fails <ci> <show-controller> <juju-ci-tools:Triaged> <juju-core:Invalid> <juju-core admin-controller-model:Invalid> <https://launchpad.net/bugs/1559293>14:40
dimiternjamespage, so we've seen issues like that and that's why we do ifup -a || true at the end of the runcmds generated for container userdata14:40
dimiternjamespage, so I suspect those containers with the issues will recover after cloud-init has completed?14:40
jamespagedimitern, it never completes afaict14:41
jamespageas it can't download juju tools...14:41
dimiternjamespage, is the container on trusty?14:42
jamespagedimitern, no its all on xenial14:42
dimiternjamespage, anything useful in /var/lib/lxd/ ? e.g. cloud-init-output.log?14:43
dimiternjamespage, I've seen an issue with the xenial image my vmaas had (apt-get update was failing with unsigned index or something like that), so I did update the images in my vmaas and retried - this time was ok14:45
jamespagedimitern, I'm not having trouble with physical xenial hosts - just the containers...14:45
dimiternjamespage, so the provisioning does not complete for any lxd containers?14:48
jamespagedimitern, it managed one but that was then missing a default route14:48
jamespagedimitern, then other ones did not have any configured network interfaces - and nothing in the lxd profile either - let me recheck that14:49
dimiternjamespage, if you can paste some logs from the host machine I'll have a look14:49
Guest_98765Allah is doing14:50
jamespagedimitern, http://paste.ubuntu.com/15463715/14:50
Guest_98765sun is not doing Allah is doing14:51
Guest_98765moon is not doing Allah is doing14:51
jamespagedimitern, http://paste.ubuntu.com/15463718/14:51
Guest_98765stars are not doing Allah is doing14:51
jamespagelxd profile for machine14:51
Guest_98765planets are not doing Allah is doing14:51
Guest_98765galaxies are not doing Allah is doing14:52
Guest_98765oceans are not doing Allah is doing14:52
Guest_98765mountains are not doing Allah is doing14:52
Guest_98765trees are not doing Allah is doing14:52
Guest_98765mom is not doing Allah is doing14:52
Guest_98765dad is not doing Allah is doing14:53
Guest_98765boss is not doing Allah is doing14:53
Guest_98765job is not doing Allah is doing14:53
Guest_98765dollar is not doing Allah is doing14:53
Guest_98765degree is not doing Allah is doing14:53
Guest_98765medicine is not doing Allah is doing14:53
Guest_98765customers are not doing Allah is doing14:54
dimiternjamespage, ok, that was useful - it fails to store br-eth1.2667 for machine-2  :(14:54
dimiternjamespage, can you also paste the log of machine-0 please ?14:54
Guest_98765you can not get a job without the permission of allah14:54
jamespagedimitern, sure one sec14:54
Guest_98765you can not get married without the permission of allah14:54
Guest_98765nobody can get angry at you without the permission of allah14:55
Guest_98765light is not doing Allah is doing14:55
dimiternjamespage, also a paste of "ifconfig -a" on machine-2 will hopefully explain why br-eth1.2667 was not added14:55
katconatefinch: so you're working on the rest of that bug now... eta?14:55
Guest_98765fan is not doing Allah is doing14:55
Guest_98765businessess are not doing Allah is doing14:55
Guest_98765america is not doing Allah is doing14:55
Guest_98765fire can not burn without the permission of allah14:56
natefinchkatco: this afternoon.  Mostly propagated all the changes needed, just need to throw in some more tests14:56
Guest_98765knife can not cut without the permission of allah14:56
katconatefinch: awesome, ty.14:56
Guest_98765rulers are not doing Allah is doing14:56
Guest_98765governments are not doing Allah is doing14:57
Guest_98765sleep is not doing Allah is doing14:57
Guest_98765hunger is not doing Allah is doing14:57
Guest_98765food does not take away the hunger Allah takes away the hunger14:57
Guest_98765water does not take away the thirst Allah takes away the thirst14:58
Guest_98765seeing is not doing Allah is doing14:58
Guest_98765hearing is not doing Allah is doing14:58
Guest_98765seasons are not doing Allah is doing14:58
Guest_98765weather is not doing Allah is doing14:58
Guest_98765humans are not doing Allah is doing14:59
Guest_98765animals are not doing Allah is doing14:59
rick_h_hmm, no one has ops here eh?14:59
Guest_98765the best amongst you are those who learn and teach quran14:59
katcorick_h_: it's never come up14:59
natefinchheh15:00
rick_h_katco: yea, reaching out to IS on how to fix it, what practice we have there15:00
natefinchI just ignored the guy15:00
Guest_98765one letter read from book of Allah amounts to one good deed and Allah multiplies one good deed ten times15:00
katcosame15:00
natefinchbut it would be nice to be able to punt people so we don't all have to do that15:00
Guest_98765hearts get rusted as does iron with water to remove rust from heart recitation of Quran and rememberance of death15:01
Guest_98765heart is likened to a mirror15:01
Guest_98765when a person commits one sin a black dot sustains the heart15:01
TheMueIt's no guy, it's just a bot.15:02
jamespagedimitern, http://paste.ubuntu.com/15463811/15:03
jamespagedimitern, and http://paste.ubuntu.com/15463817/15:03
dimiternjamespage, thanks, unfortunately the logging level is not high enough to understand the problem - can you please try this:15:08
dimiternjamespage, first run $ juju set-model-config logging-config='<root>=TRACE'15:09
dimiternjamespage, and then bounce all jujud processes on machine-0, and paste the log again?15:09
mupBug #1560061 opened: Eth0 device type determined to be "" <ci> <deploy> <juju-core:Incomplete> <juju-core maas-spaces-multi-nic-containers-with-master:Triaged> <https://launchpad.net/bugs/1560061>15:10
katcoericsnow: natefinch: btw, https://github.com/juju/juju/pull/4805 very good work guys. you should be super proud :)15:13
ericsnowkatco, natefinch: +115:14
natefinchmy baby's all grown! *sniff*15:21
katcoericsnow: natefinch: finishing up the tests for the charm list-resources and then we're just doing bug fixes!15:22
dimiternjamespage, any luck?15:23
katcocherylj: speaking of which, tyvm for landing that15:25
ericsnowcherylj: yeah, thanks!15:26
cheryljkatco, ericsnow my pleasure!15:26
natefinchcherylj: ditto! :)15:26
natefinchkatco: reading the card I'm working on... it seems like the scope is a little vague.  "add channels wherever we use charm.URL"  I had only been adding channels to the calls required for list-resources.  I can add it elsewhere as well, but it's the sort of change that spiders out to a lot of code.15:27
cheryljI wanted to get it in there while there were no conflicts :)15:27
natefinchgood thinking15:27
katcocherylj: hehe15:27
katconatefinch: does the stand-alone charm command support formatting flags?15:28
natefinchkatco: looks like it, yes15:29
natefinchkatco: looks like they use the formatter stuff just like juju uses15:29
ericsnownatefinch: really all that matters for channels is the code that interacts with the charm store (relative to resources)15:31
ericsnownatefinch: so the touches to that code will bleed through the API too15:32
natefinchericsnow: yeah15:32
natefinchericsnow: and stuff like add pending resources15:32
ericsnowthe only other bit is the updates poller, which we still haven't sorted out15:32
ericsnownatefinch: sorry the card wasn't more clear15:33
natefinchericsnow: right, so I have changes to use a charmstore.Charm type (url + channel) propagated through a lot of the code here: https://github.com/juju/juju/pull/4790/files15:37
ericsnownatefinch: I'll take a look15:37
natefinchof course, maybe we should just be using the channel value on charm.Url :/15:38
natefinchrogpeppe: charm.URL has a Channel field.. should we just use that for tracking the channel a URL is assigned to?15:38
rogpeppenatefinch: no, you should never use it15:38
rogpeppenatefinch: it's going to be deleted15:39
ericsnowrogpeppe: I had a hunch :)15:39
natefinchrogpeppe: well, so, Eric and I were lamenting that we have to change the signature of 1000 methods that used to take charm.URL to now take a URL + channel... why would we not just use the channel field on URL?15:39
rogpeppenatefinch: you only need to change that for methods that can take an unresolved url15:40
natefinchrogpeppe: yes, but it propagates out through the code more than you might think15:40
rogpeppenatefinch: for example?15:41
rogpeppenatefinch: this is in cmd/juju/service?15:42
natefinchrogpeppe: everywhere we use charmstore.Charm here (and some API methods I havent' fixed yet, but that's not going to be affected by changing charm.URL): https://github.com/juju/juju/compare/feature-resources...natefinch:list-resources-channels?expand=115:43
natefinchrogpeppe: basically any time we have a URL that needs to be passed to the charmstore, we need the channel as well15:44
jamespagedimitern, sorry been otp15:44
rogpeppenatefinch: any time you have an unresolved URL, right?15:44
ericsnowrogpeppe: my "unresolved url" you mean those without a revision (e.g. revision -1)?15:44
dimiternjamespage, np15:44
natefinchrogpeppe: we need it even for specifically revisioned urls, because different channels can have different resources associated with the same revision of the charm15:45
rogpeppeericsnow: yes15:45
jamespagedimitern, http://paste.ubuntu.com/15464291/15:45
ericsnowrogpeppe: I was under the impression that a "resolved" url may still be available in different channels15:46
rogpeppenatefinch: oh really? oh no.15:46
natefinchrogpeppe: and we'd need to store the channel for a service, so we know which channel to look for updates to the charm15:46
ericsnow(aside from "unpublished")15:46
rogpeppethis model is totally broken15:46
natefinchrick_h_: ^15:46
dimiternjamespage, cheers, looking15:47
* rick_h_ tries to parse the traceback15:47
natefinchrick_h_: rogpeppe is surprised that the same rev of a charm can have different resources in different channels15:47
rick_h_natefinch: ugh15:47
natefinchrogpeppe: you can publish mysql-3 with resource-1 to dev and with resource-2 to stable, in theory15:48
rogpeppenatefinch: that goes against the whole notion of dev vs stable AFAICS15:49
natefinchrogpeppe: well, think about it.. .you publish mysql-3 & resource-1 to stable... then you want to update the resource, so you publish mysql-3 & resource-2 to dev for CI to test....15:51
rick_h_rogpeppe: dev vs stable is just a tag on a revision15:51
rick_h_rogpeppe: every charm revision can have the latest blessed set of resources/charm.15:51
rick_h_rogpeppe: the whole point of resources is you update them, and get a new stable set, without needing to update the charm revision15:52
rogpepperick_h_: and if an old revision doesn't work with one of the newly published resources?15:52
natefinchrogpeppe: resources are keyed off channel + charm-rev15:53
rick_h_rogpeppe: older revision of the charm?15:53
rick_h_rogpeppe: publishing will require the resource revisions15:53
rick_h_rogpeppe: so updating resources requires a new publish with the previous charm revision + the new resource revisions15:54
rick_h_rogpeppe: it's a forward rolling set, if the older revision doesn't work, it's ok because it was published with a different revisioned resource that at one time did work15:54
rogpepperick_h_: i am still deeply concerned about these semantics15:55
rick_h_rogpeppe: then let's chat about them please because they're getting delivered and quickly as we get the feature out the door15:55
rogpepperick_h_: i would be very happy to have a chat about them15:56
rick_h_natefinch: are you free in 20?15:56
rick_h_natefinch: will invite you into the chat I've got with the ui team then plkease15:56
natefinchrick_h_: I can be. yes15:56
ericsnowkatco: ^^^15:56
dimiternjamespage, can you also paste the /e/n/i on machine-0 ?15:57
katcorick_h_: yeah toss me an invite as well if you don't mind15:57
rick_h_katco: rgr15:57
katcorick_h_: ta15:57
jamespagedimitern, erm 'destroy-controller' just executed - have to free up the env for my eod15:57
ericsnowrick_h_: me too :)15:57
rick_h_ericsnow: :)15:57
dimiternjamespage, ah, ok then15:58
dimiternjamespage, we something's odd about the created bridges there - br-eth1 does not seem to appear, and that's causing the issues15:58
dimiterns/we/well/15:58
redirmorning katco, cherylj16:00
cheryljhey there redir!  Welcome aboard :)16:00
redirthanks16:00
cheryljredir: how are you finding your first day?16:01
rick_h_redir: hey, you're not started yet have you? I thought it was april?16:01
redirfirst order of business is to fill out the new starter stuff16:01
cheryljfun stuff16:01
katcoredir: hey there!16:01
redirrick_h_: it was. but things went much more smoothly than expected16:01
rick_h_redir: awesome to hear, welcome back to the party16:01
redirthanks!16:01
katcoericsnow: natefinch: perrito666: this is a new member of tanazanite, Reed Simpson, aka redir16:02
ericsnowredir: welcome!16:02
redircherylj: so far, 2 minutes in it is awesome:)16:02
katco:)16:02
redirthanks, ericsnow:)16:03
katcoredir: be sure to reach out if you need any help with the new starter task16:04
redirkatco: will do16:04
katcoericsnow: natefinch: perrito666: wow, i misremembered his last name. what a welcome :( this is Reed O'Brien16:05
alexisbredir, welcome!16:05
redirno worries, I always wanted to be a famous hockey player16:06
katco:)16:06
alexisb:)16:06
redirthanks alexisb, everyone:)16:06
lazyPowero/ redir16:10
lazyPowerwelcome aboard16:10
redirthanks lazyPower16:11
katcoredir: lazyPower is on our ecosystems team. they do a lot of charming and community outreach. he's a great person to know and generally awesome16:11
lazyPowerwoo16:11
lazyPoweri dont know that i can live up to that description, but hey o/ :D16:11
lazyPowerhave a charm question? i'll help ya whip it into shape or get you in touch with the ppl that can make it happen16:12
* redir gets notepad16:12
lazyPowerkatco is elnode finished? :D16:12
katcolazyPower: it is not... last problem i ran into was emacs specific though. getting emacs to start with no stdin or something16:13
lazyPowernext sprint we should make that a bounty and have a hack session on it16:14
redirhow many teams are there?16:15
redirquick what are they?16:15
lazyPowertanzanite, sapphire, moonstone, onyx and uhh16:15
katcolazyPower: bzzzzz! incorrect16:15
rick_h_someone doesn't read the juju mailing list :P16:15
katcolazyPower: redir: there are 2: tanzanite (your team) and onyx16:15
lazyPoweroh right16:16
rick_h_:)16:16
lazyPowerthe great restructuring of the minerals16:16
redirdiamonds await16:16
lazyPowerwelp nothing to do here16:16
* lazyPower jetpacks away16:16
redirso 2 teams: black and blue16:17
natefinchwelcome redir!16:17
redir:)16:17
redirthanks natefinch16:17
redirwhich color is ecosystems?16:17
katcoredir: that's an entirely different macro-team16:19
katcoredir: tanzanite and onyx are sub-teams of juju-core16:19
rediris there a map?16:19
redir:)16:19
rick_h_only in our heads :)16:20
natefinchthere used to be moonstone and sapphire, but they've been merged into tanzanite and onyx16:20
mgzI think eco uses colourless mana16:20
katcomgz: +116:20
redirI see16:20
* redir imagines ecosystems to be earth, wind, and fire.16:21
natefinchredir: mostly fire :)16:21
* natefinch doesn't even know what that means.16:22
* redir doesn't either but they are colourless16:22
hatchwb redir :D16:23
redirthanks, hatch16:23
rick_h_natefinch: ericsnow katco and optionally redir please join https://plus.google.com/hangouts/_/canonical.com/ui-daily?authuser=116:28
rick_h_updating authuser as required16:28
mupBug #1559844 changed: InvalidVolumme.NotFound error destroying aws environment <juju-core:Triaged> <https://launchpad.net/bugs/1559844>16:34
mupBug #1560107 opened: juju client doesn't pass version and other useful metadata to api calls <juju-core:New> <https://launchpad.net/bugs/1560107>16:34
mupBug #1542206 opened: space discovery still in progress <ci> <intermittent-failure> <joyent-provider> <precise> <regression> <juju-core:Triaged> <juju-core maas-spaces-multi-nic-containers:Invalid> <https://launchpad.net/bugs/1542206>16:37
mgzhas some one added redir to github/lp grouos yet?16:42
alexisbmgz, probably not yet, there will be some delay in official registration stuff for redir, given his start date got bumped up16:43
mgzalexisb: I was just doing it for niedbalski and wondered if I could save effort :)16:44
mgzredir: what's your github username?16:44
cheryljhey redir, I'm working on getting you a room for the QA sprint next week.  Would you want to attend all 5 days?  (I personally won't fly in until Monday evening)16:46
redirmgz reedobrien16:52
redircherylj: whatever you want me there for16:52
redirI can do all five days or partial if you prefer16:53
mgzredir: github has sent you an email, accept that, then go to github.com/orgs/juju/people and set your membership to public16:54
redirI am trying to reset my lp account. I have 2FA setup on it, but it doesn't like my 2FA codes16:54
redirany way to get someone to clear that?16:54
redirmgz: done16:55
katcoericsnow: natefinch: https://github.com/juju/charmstore-client/pull/616:56
ericsnowkatco: k16:57
katcoericsnow: natefinch: note that i've had to subvert the full-stack tests since the charmstore doesn't yet support resources16:57
mgzredir: did you do the reset sequence?16:58
* katco heats up some lunch16:58
mupBug #1542206 changed: space discovery still in progress <ci> <intermittent-failure> <joyent-provider> <precise> <regression> <juju-core:Triaged> <juju-core maas-spaces-multi-nic-containers:Invalid> <https://launchpad.net/bugs/1542206>16:58
mgzredir: if you tried that and it didn't work, er... I always bugged selene or someone, I think the right channel is...16:58
mgzredir: #canonical-support on the canonical network16:59
redirmgz: I tried to resync17:01
redirmgz: I don't see a way to reset the sequence17:01
redirmgz: not on the canonical network yet17:01
mgzalexisb: bug 154220617:01
mupBug #1542206: space discovery still in progress <ci> <intermittent-failure> <joyent-provider> <precise> <regression> <juju-core:Triaged> <juju-core maas-spaces-multi-nic-containers:Invalid> <https://launchpad.net/bugs/1542206>17:01
redirI'll try a little more then bail until I have access there17:02
alexisbmgz, looking17:02
mupBug #1542206 opened: space discovery still in progress <ci> <intermittent-failure> <joyent-provider> <precise> <regression> <juju-core:Triaged> <juju-core maas-spaces-multi-nic-containers:Invalid> <https://launchpad.net/bugs/1542206>17:04
ericsnowkatco: PR reviewed (mostly LGTM)17:10
natefinchkatco, ericsnow: well, I was reviewing the PR until.... No server is currently available to service your request.17:14
katconatefinch: getting that too :(17:15
natefinchyou know it's bad when you can't even get to the status page17:15
katconatefinch: status.github.com is even down17:15
natefinchkatco: heh17:15
natefinchkatco: http://i.cubeupload.com/D6bRPx.png17:16
redirbuh17:17
katconatefinch: status seems to be up. looking at several graphs with a shelf in the last minute or so :p17:18
natefinchoh yeah, so it is17:19
* natefinch puts away his sword.17:19
cheryljnatefinch: back in my day, that used to say "Compiling!"17:19
cherylj;)17:19
cheryljand when I worked in AIX, it was a legitimate excuse17:20
natefinchcherylj: for Juju it should say "running unit tests"17:20
cheryljtook over an hour to build a kernel on our POS machines17:20
cheryljnatefinch: ha, no kidding17:20
katcoericsnow: natefinch: fyi, i copy/pasted the help text from core's help text17:20
natefinchkatco: hmm... I wonder if our help text is wrong, too, then17:21
redircherylj: point of sale machines? :)17:21
cheryljredir: no, no IBM sold that off long ago17:22
cherylj;)17:22
cheryljtoshiba - those suckers17:22
redirso the other PoS machines17:22
cheryljredir: so, should I book your room for a checkin  Sunday, checkout Friday?17:22
redircherylj: sounds perfect17:23
redirthanks17:23
cheryljredir: kk, I'll submit a request to the sprint organizer17:23
rick_h_redir: ok, does your login work?17:23
alexisbdimitern, ping17:24
dimiternalexisb, pong17:24
alexisbheya dimitern happy monday :)17:24
alexisbon bug 1542206, cheryl's last comment...17:25
mupBug #1542206: space discovery still in progress <ci> <intermittent-failure> <joyent-provider> <precise> <regression> <juju-core:Triaged> <juju-core maas-spaces-multi-nic-containers:Invalid> <https://launchpad.net/bugs/1542206>17:25
alexisbit looks like juju is failing the bootstrap17:25
alexisbcould that potentially be a bug in the spaces work for providers that dont currently support spaces?17:25
dimiternalexisb, :)17:25
redirrick_h_: yes!17:25
cheryljalexisb, dimitern : in all fairness, it could also be completely unrelated to spaces :)17:26
cheryljand that error is a red herring17:26
dimiternalexisb, I suspect that's an issue with joyent17:26
alexisbdimitern, ok, can we please work with cheryl to dig a bit17:26
dimiternalexisb, as there's no other issue recently related to that on any other cloud17:26
alexisbit is important to get beta3 out this week17:26
dimiterncherylj, alexisb, sure17:26
alexisbthanks dimiter17:28
tvansteenburghhey guys, can the value for 'series' in metadata.yaml be a string, or must it be a list?17:28
cheryljoh hell.  mgz I see the model migration test failed in a different spot that passed in the previous run17:28
mgzcherylj: hm, but still a 20m timeout17:29
cheryljyes17:29
mgzcherylj: it's the how-good-are-you-at-reading-deadlock-gopanics test!17:30
mgzis the the same one, is it a different one? :)17:30
natefinchtvansteenburgh: always a list I believe17:31
tvansteenburghnatefinch: ta17:31
mgzcherylj: well, that sucks17:32
cheryljmgz: yeah.  They're in completely separate packages17:33
mgzlatest one is useless, it's in the parent process17:33
mgzso, no clue to what caused the actual test binary to fail17:33
cheryljyeah17:33
mgz(fail to exit)17:33
dimiternmgz, can you get the cloud-init-output.log and machine-0.log of a joyent bootstrap instance that failed?17:36
dimiternmgz, with --keep-broken I guess..17:36
mgzdimitern: yeah, with the issue it's intermittent17:37
dimiternmgz, hmm I'm now beginning to suspect that was caused due to the MADE-state-workers changes17:37
cheryljoh boy17:42
cheryljmgz, dimitern I think it's related to the same change that broke restore17:42
cheryljhttps://github.com/juju/juju/commit/104e75494e9fc97cb2a0084b4384936abcee962217:43
dimiterncherylj, uh oh that definitely looks promising as a cause17:44
mgz...yup, that seems likely17:45
cheryljso, we can revert just the joyent part of that change17:46
cheryljor we can figure out why sometimes the filter doesn't work in joyent17:46
dimiterncherylj, it looks like one attempt passed ok though: http://reports.vapour.ws/releases/3791/job/joyent-deploy-trusty-amd64/attempt/192917:48
mgzdimitern: it is intermittent17:48
dimiternan that's without a bundle - just deploy17:48
cheryljdimitern: right, I suspect that there's some state where if we try to get the joyent instances that match our filter, we don't get a complete list17:49
mgzso likely an ordering issue or similar in the bootstrap process17:49
dimiternah, I see17:50
mgzdid the machine we just created appear in our list run after or something17:50
mgzsometimes yeay sometimes ney17:50
natefinchrogpeppe: so... about that Channel field on charm.URL.....17:59
rogpeppenatefinch: make a new type17:59
cheryljmgz ... so revert the joyent part?17:59
ericsnowrogpeppe: could we include the charm store macaroon on that type?  It would be optional.18:00
natefinchrogpeppe: Why not use the field?18:00
rogpeppenatefinch: because it's not part of the URL18:00
rogpeppenatefinch: it's very wrong to use it. please don't.18:00
natefinchrogpeppe: it not being part of the URL makes sense.  I guess this is a consequence of the URL no longer being a sufficient unique identifier18:02
rogpeppenatefinch: yes that's right18:02
mgzcherylj: I would be tempted to for beta3, but this probably needs some more serious bug fixing, admin-controller likely depends on storage being gone?18:02
rogpeppenatefinch: that's part of the reasons for my rant earlier18:02
natefinchrogpeppe: we were headed down that road already, I just wanted to make sure there wasn't a shortcut18:02
natefinchrogpeppe: yeah, I totally understand.18:02
cheryljmgz: we haven't completely removed storage - maas still uses it18:02
rogpeppenatefinch: BTW I don't think that the channel is sufficient either18:03
rogpeppenatefinch: you probably want to pass around the full tuple18:03
rogpeppenatefinch: because a channel + a URL doesn't uniquely identify things18:03
ericsnowrogpeppe: what about the charm store macaroon on that new type?18:03
rogpeppeericsnow: i guess it depends what you call the type18:04
ericsnowrogpeppe: the charm ID and the macaroon are pretty tightly coupled on the core side18:04
ericsnowrogpeppe: maybe it should just be a core type18:04
natefinchrogpeppe: I've made a github.com/juju/juju/charmstore.Charm type that contains the URL and the channel.  Probably adding the macaroon is a good idea.  I'm less certain about the resources.. channel+URL is unique-enough to get the expected resources (whether or not store resources are overridden is stored elsewhere)18:06
rogpeppenatefinch: i don't think the macaroon should be there really.18:06
redirrogpeppe!18:07
rogpepperedir: yo!18:07
rogpepperedir: you made it back!18:07
rogpepperedir: welcome again :)18:07
rogpeppenatefinch: what are you going to use it for?18:07
mgzcherylj: good/bad news on ppc64 failure... just more timing prone issues18:08
natefinchrogpeppe: authenticating with the charmstore.  It probably doesn't need to be on the type, since it's not really part of the identity of the charm18:08
rogpeppenatefinch: channel+URL is not unique enough to get the expected resources over time18:08
rogpeppenatefinch: sorry, my question was really: what are you going to use the Charm type for?18:08
redirthanks rogpeppe18:08
cheryljmgz: we could also have this "ErrNotBootstrapped" error be one of the ones we retry in the bootstrap (just like upgrade in progress)18:09
natefinchrogpeppe: mainly right now for querying the charmstore for updates to the charm and/or associated resources18:09
rogpeppenatefinch: and please don't call it Charm - it's not a charm but some kind of identifier for a charm18:09
ericsnowrogpeppe: +118:09
rogpeppenatefinch: do all resources get pulled into the environment when you deploy a charm?18:10
rogpeppes/environment/model/18:10
mupBug #1560152 opened: Local charm fails to deploy if it's too big <juju-core:New> <https://launchpad.net/bugs/1560152>18:10
natefinchrogpeppe: we grab all the metadata pre-emptively, grab bytes on-demand18:10
rogpeppenatefinch: so if you do juju deploy somecharm-5, then juju deploy somecharm-5 again and the default resources have changed, what will happen?18:12
cheryljperrito666: did you see bug 1557726?18:12
mupBug #1557726: Restore fails on some openstacks <backup-restore> <openstack-provider> <juju-core:Triaged> <https://launchpad.net/bugs/1557726>18:12
natefinchrogpeppe: you get different resources and when you look at juju list-resources, you'll be told the first deploy has updates available for its resources18:12
rogpeppenatefinch: so the service holds the whole tuple of charm + resources?18:13
natefinchrogpeppe: basically the same as if you deploy wordpress twice, and the charm gets updated in between18:13
natefinchrogpeppe: correct18:13
mupBug #1560152 changed: Local charm fails to deploy if it's too big <juju-core:New> <https://launchpad.net/bugs/1560152>18:13
cheryljhey mgz, I see that bug 1542206 was originally opened in Feb, which was before the change to joyent to use tags for controller instances18:15
mupBug #1542206: space discovery still in progress <ci> <intermittent-failure> <joyent-provider> <precise> <regression> <juju-core:Triaged> <juju-core maas-spaces-multi-nic-containers:Invalid> <https://launchpad.net/bugs/1542206>18:15
cheryljmgz: the link to the failures in the bug seem to start on Mar 1518:15
rogpeppenatefinch: so i guess you could just call it CharmURLWithChannel.18:16
rogpeppenatefinch: type CharmURLWithChannel struct {charm.URL; Channel Channel}18:16
mgzcherylj: I think we have some wrong symptom association18:16
cheryljmgz: yeah, I was hoping that was the case18:17
rogpeppenatefinch: bulky but accurate18:17
natefinchrogpeppe: I'd rather call it something that is somewhat more extensible, on the thought that we may add/change data in it later (if we decide we want to give a single number to a charm + resource tuple, for example). CharmID I think would work.18:17
mgzcherylj: I rejigged the rule to make it more specific18:17
mgzcherylj: so, it should now match just on this issue18:17
cheryljmgz: k, thanks.  Should I update the bug to be more specific?  (That the bootstrap fails with "model is not bootstrapped")18:18
mgzcherylj: yeah, that's a good idea18:18
rogpeppenatefinch: yeah, that would probably be ok.18:18
perrito666cherylj: hi, just coming today, was a bit ill, I see it, I seem to have introduced that with k3 support18:23
cheryljperrito666: :(  hope you're feeling better18:23
cheryljsorry to make things worse with that bug :)18:23
perrito666cherylj: sort of, lots of white rice18:23
perrito666simple fix, actually18:23
perrito666openstack should actually be returning 300 and its returning 20018:24
perrito666cherylj: how blocking this is? (do you need me to fix it now or can I fix it tomorrow?)18:25
mgzperrito666: we are probably talking about two bugs18:25
cheryljperrito666: it is not blocking18:25
mgzone is rackspace/keystone 3 the other is joyent/storage18:25
perrito666mgz: the response pasted in the bug is about opesntack returning an unexpected http code18:26
cheryljperrito666: yeah, I'm talking about the keystone 3 bug18:26
mgzalso *hugs*18:26
perrito666mgz: dont hug me or ill have to run to the bathroom18:26
mupBug #1560152 opened: Local charm fails to deploy if it's too big <juju-core:New> <https://launchpad.net/bugs/1560152>18:28
perrito666mgz: the links on the bug, actually the first, havent checked the second, are 404ing18:32
katcofwereade_: hey, is it true you prefer exported test suites?18:37
mgzperrito666: from the log?18:39
perrito666http://juju-ci.vapour.ws:8080/view/Juju%20Revisions/job/functional-backup-restore-jujuqa-stack/18:40
perrito666mgz: that one18:40
mgzperrito666: are you logged in with developer credentials from lp:cloud-city?18:40
mgz...not lp: but lp:etcetc/18:40
katcomarcoceppi: hey, our final patch to the charm cmd is under review: https://github.com/juju/charmstore-client/pull/618:41
katcomarcoceppi: it will be landed soon18:41
perrito666mgz: meh I was unlogged18:42
perrito666mgz: I would have expected more smart from jenkins18:42
mgzit's Security18:42
natefinchkatco: we should get rogpeppe to review that, though it's past EOD for him18:42
rogpeppenatefinch: i'm working late today18:42
rogpeppenatefinch: trying to get the deploy-with-channels stuff landed for you18:42
mgzeverything has to be a huh-dunno not a no-way or you leak the super-sekret test names18:43
natefinchrogpeppe: I figured that would be a big change.  I have some code that may help / complicate it for you18:43
marcoceppikatco: thanks, we'll need this and the charm-help pull req to complete this (and the store updated)18:43
rogpeppenatefinch: it's only big because i couldn't resist cleaning things up a bit18:43
perrito666mgz: ok, give me some guidance here :p18:43
katcomarcoceppi: what is required in the store?18:44
perrito666I see a build history whose newest build is feb 2718:44
marcoceppikatco: the latest charmstore deployed, it failed friday18:44
katcomarcoceppi: ahh18:44
rogpeppenatefinch: i might have got the wrong end of the stick and not done nearly as much as i need to though18:44
katcomarcoceppi: and what do you mean by a PR against charm-help?18:44
mgzperrito666: you don't have the creds to hand? lp:~juju-qa/+junk/cloud-city18:45
marcoceppikatco: https://github.com/juju/charmstore-client/pull/218:45
natefinchrogpeppe: here's what I have, which has the CharmID type: https://github.com/juju/juju/pull/4790/files18:45
katcomarcoceppi: ah ok. i thought you were asking me to do other things :)18:45
natefinchrogpeppe: I only did the part that was needed for juju charm list-resources, so there's a lot of other touches that would need to be made for general charm/channel usage, like deploy18:45
natefinchcherylj, katco: so if resources is merged, does that mean any new changes should go against master, or should we still be doing PRs versus the feature branch?18:46
katconatefinch: cherylj: good question. i think since they're bug fixes they can go against master?18:47
rogpeppenatefinch: ha, you've duplicated quite a bit of what i've already done today...18:57
natefinchrogpeppe: I was afraid of that18:57
natefinchrogpeppe: sorry I didn't ping you earlier today... I was still thinking of my change as being quite focused, though of course it spiraled out from the original intent of just supporting channels in one call.18:58
* redir goes to grab lunch. Taking some of the getting started reading ianb send to me.19:03
redirbbiab19:03
rogpeppenatefinch: this what i'm on currently (just the dependency update) https://github.com/juju/juju/pull/4807/files19:03
rogpeppenatefinch: just running the tests (all passing so far, but probably 3 hours to go until they're finished...)19:04
rogpeppenatefinch: i've added some ericsnow TODOs :)19:04
ericsnowrogpeppe: :)19:05
natefinchrogpeppe: 3 hours until the work on the tests is finished, or 3 hours until the tests finish running?19:09
rogpeppenatefinch: the latter19:09
rogpeppenatefinch: probably a slight exaggeration19:10
rogpeppenatefinch: but my machine does seem to be slow today19:10
natefinchrogpeppe: ok, good. I was gonna say, maybe compiling on your smart phone is not the best idea19:10
natefinchs/compiling/running tests19:11
rogpeppenatefinch: i should get a sodding great water cooled monster to run the tests on19:11
rogpeppenatefinch: ... alternatively maybe i should rig up a charm for parallelising the test running on ec219:12
natefinchrogpeppe: my 2.5 year old core i7 does ok... like 15-20 minutes19:12
natefinchrogpeppe: I do have a really fast (for 2.5 years ago) SSD which I think helps19:13
rogpeppenatefinch: mine's probably not that much longer than that tbh. it just feels like 3h.19:13
natefinchrogpeppe: certainly19:13
cheryljnatefinch, katco, yes if you have new changes / bug fixes for resources, please make them against master19:13
natefinchrogpeppe: have you tried Russ' gt?19:13
rogpeppenatefinch: i have a lovely 1TB SSD sitting on the shelf waiting for the day that I can waste upgrading to it19:13
rogpeppenatefinch: it didn't work so well for me19:13
natefinchrogpeppe: it worked at times for me, but was definitely flaky at times, too19:13
katcocherylj: cool, ty. ericsnow: natefinch: bug fixes go against master now19:14
katcocherylj: should we delete the feature branch?19:14
ericsnowkatco: k19:14
rogpeppenatefinch: i'd very much appreciate a review of the above PR BTW - what was originally reviewed was very different to what it is now19:18
natefinchrogpeppe: absolutely19:18
rogpeppenatefinch: thanks19:18
rogpeppei'm sure the ec2 tests didn't used to take 2 1/2 minutes to run19:19
rogpeppei wonder what's going on there19:19
rogpeppeooh, we're on w19:27
rogpeppenatefinch: yay! tests passed.19:28
rogpeppenatefinch: did you wanna take a look before I push it?19:29
natefinchrogpeppe: I'm looking19:35
redirback19:36
cheryljthumper: http://reviews.vapour.ws/r/4267/19:39
thumpercherylj: not bad, +8,634 −14619:40
thumpersmaller than I thought19:40
cheryljheh19:40
natefinchrogpeppe: lgtm... very nice to have all that bakery nonsense wrapped up in a reusable place19:42
katcocherylj: hey, do you know if we should delete our feature branch?19:42
cheryljkatco: not required, but you can if you'd like19:42
katcoericsnow: natefinch: any objections?19:43
cheryljkatco: I imagine we're going to do a bit of pruning after we ship 2.0.019:43
natefinchkatco: seems like a good idea so no one twiddles against it by accident19:43
ericsnowkatco: sounds good19:43
thumper+1 to deleting the merged feature branch19:43
katconatefinch: also going to delete nate-minver19:44
* cherylj is secretly paranoid that the merge didn't actually happen properly19:44
katcocherylj: looks like you can restore branches. plus i guarantee you we have copies floating around on people's local machines ;)19:44
natefinchkatco: glad to have it done with. :)19:44
cheryljhaha, ok thanks :)19:45
katcothumper: is there anything we can do to help out onyx?19:45
thumperyes19:46
thumperkatco: do you have some time now?19:46
katcothumper: 15m19:46
thumperyou can't do much in 15 minutes :)19:46
thumperI mean, does your team have spare capacity19:46
katcothumper: ericsnow has more time :) and i'll have time after19:46
cheryljhar har19:46
natefinchthumper: lol, spare capacity19:47
katcothumper: er strike that. i won't have time after. ericsnow does though19:47
thumperkatco: I think we need to think carefully about what we have committed to over the whole team19:47
thumperwe have already said that model migration won't be fully functional19:47
rogpeppenatefinch: thanks19:47
thumperis there something else that we have fully committed to that needs work?19:47
* katco scans feature list19:48
natefinchthumper: all the charmstore part of resources :/  I mean, we plan to do it, but it's not at all done yet.19:48
thumperkatco: probably best to sync up with alexisb and wallyworld19:48
katcothumper: planned on doing so in this afternoon's release standup19:48
thumpernatefinch: that would be a first focus then I guess19:48
thumperkk19:48
katcothumper: i was just referring to today's deadline19:48
thumperoh, just for today?19:49
thumperno19:49
thumperwe're good19:49
natefinchsorry, I should butt out, katco has it all under control.19:49
katcothumper: yes if you were trying to push for something19:49
* natefinch goes back to teh coding19:49
thumperwe are... but nothing that more hands will help in the short timeframe19:49
katcothumper: ok, just thought we'd check :)19:49
thumpercheers19:49
rogpeppeaargh, i'd forgotten you can't reply to reviewboard comments directly in the summary section19:55
katcorogpeppe: you can i think19:55
rogpeppekatco: i always do "Add comment" (thinking it's gonna reply) and it opens a new issue instead.19:56
katcorogpeppe: yeah i think you have to click on the comment in the gutter, then there's like an "add reply" or something19:56
rogpeppekatco: i'll look harder next time19:56
rogpeppeericsnow: i've made some replies to your review comments but they're all in the same place.19:57
ericsnowrogpeppe: k19:57
rogpeppes/same place/wrong place/19:57
rogpeppekatco: i don't think you can click the comment in the gutter from the overview mode, unless i'm missing something19:59
rogpeppeericsnow: are you ok with me landing it?20:00
katcorogpeppe: maybe i'm misinterpreting what overview mode is20:00
rogpeppekatco: the page you get by following the original review link20:01
ericsnowrogpeppe: yep20:01
rogpeppekatco: not the page with all the complete diffs on20:01
rogpeppeericsnow: ta20:01
natefinchkatco: I'm going to be a bit late on proposing my PR.  I spent a bunch of time doing code reviews and meetings etc.  But it should be done tonight.20:01
mupBug #1560191 opened: kill-controller is hinky without a model-controller behind it <juju-core:New> <https://launchpad.net/bugs/1560191>20:14
mupBug #1560192 opened: Restoring admin: model configuration has no admin-secret <backup-restore> <ci> <juju-core:Incomplete> <juju-core admin-controller-model:Triaged> <https://launchpad.net/bugs/1560192>20:14
mupBug #1560201 opened: The Client.WatchAll API command never responds when the model has no machines <juju-core:New> <https://launchpad.net/bugs/1560201>20:20
mupBug #1560203 opened: stringForwarderSuite.TestRace sometimes fails <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1560203>20:20
rogpeppeericsnow: while i'm looking at the code, can I ask you what the "Spec" in CharmstoreSpec stands for?20:22
ericsnowrogpeppe: specification20:23
ericsnowrogpeppe: really the for the client though :/20:23
rogpeppeericsnow: ok. thats... not what i expected.20:23
rogpeppeericsnow: i thought it might have been Specialization20:24
thumperdavecheney: wondering about your take on this bug: https://github.com/lxc/lxd/issues/178120:25
thumperdavecheney: due to pathological juju bug, created a very long path20:26
mupBug #1560201 changed: The Client.WatchAll API command never responds when the model has no machines <juju-core:New> <https://launchpad.net/bugs/1560201>20:29
mupBug #1560203 changed: stringForwarderSuite.TestRace sometimes fails <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1560203>20:29
cheryljthumper, menn0 model-migration is merged!20:36
thumper\o/20:37
* thumper does a little dance20:37
* fwereade_ cheers20:38
fwereade_thumper, I'm in the hangout20:38
alexisb:)20:38
thumperƪ(˘⌣˘)┐ ƪ(˘⌣˘)ʃ ┌(˘⌣˘)ʃ20:38
cheryljhey perrito666, looking back on bug 153679220:39
mupBug #1536792: Some providers release wrong resources when destroying hosted models <juju-core:In Progress> <https://launchpad.net/bugs/1536792>20:39
cheryljperrito666: why was joyent not fixed yet?20:39
cheryljperrito666: was it waiting for the change to use tags instead of storage?20:40
natefinchgah, people need to stop calling things resources when they're not *Resources* ... messes me up every time20:40
mupBug #1560201 opened: The Client.WatchAll API command never responds when the model has no machines <juju-core:New> <https://launchpad.net/bugs/1560201>20:44
mupBug #1560203 opened: stringForwarderSuite.TestRace sometimes fails <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1560203>20:44
natefinchman I hate external tests20:48
menn0cherylj, thumper : woot!21:10
perrito666cherylj: sorry I am back, I am not sure I know what you are talking about21:11
perrito666cherylj: oh, joyent was going to be done by an external21:16
cheryljhmm21:16
perrito666natefinch: you need to stop picking names extremely common in computers and repurposing them perhaps?21:17
natefinchperrito666: well, *someone* needs to stop picking those names... :)21:20
redirnatefinch: perrito666 they need to be more resourceful21:22
ericsnowredir: I see what you did there <wink>21:27
redir;)21:28
davecheneyumm, ++ /var/lib/jenkins/juju-ci-tools/ec2-run-instance-get-id21:56
davecheneyeuca-run-instances: error (InstanceLimitExceeded): Your quota allows for 0 more running instance(s). You requested at least 121:56
davecheneyCI just told me to go rewrite it in erlang21:56
mupBug #1559310 changed: bootstrap fails: "model is not bootstrapped" <bootstrap> <ci> <juju-core:Incomplete> <juju-core admin-controller-model:Triaged> <https://launchpad.net/bugs/1559310>21:56
rogpeppeericsnow: ping21:57
ericsnowrogpeppe: hey21:57
rogpeppeericsnow: so, when deploying with a channel, i can deploy the charm ok, but presumably we need some way to say what the channel was in the deploy API request, right? have you done that bit?21:58
ericsnowrogpeppe: we've done nothing like that21:58
rogpeppeericsnow: ah, so your resources stuff is assuming that the channel is in the state, but so far there's nothing to put it there?21:59
ericsnowrogpeppe: I believe that natefinch is still working on the bit that passes the channel for the resource-related API call22:00
rogpeppenatefinch: ok22:00
rogpeppeericsnow: ok22:00
rogpeppenatefinch: i'd be interested to hear your plans here22:03
ericsnowrogpeppe: I expect he'll be back later22:03
rogpeppeericsnow: do you know what the status of making changes to the API currently are?22:04
rogpeppeericsnow: am I allowed to add new API parameters to existing calls without creating a new version?22:04
ericsnowrogpeppe: not positive, but I believe so relative to the 2.0 release22:05
* ericsnow checks docs22:05
ericsnowrogpeppe: best I've found: https://github.com/juju/juju/blob/master/doc/design/juju-api-implementation-guide.md#versioning22:10
katcocherylj: available for a call?22:22
urulamarogpeppe: need a channel as a parameter?22:35
katcorogpeppe: ah i see the scrollback now. natefinch is assuming the channel will be there and is assuming published for now. no plans to do anything more than consume what's stored22:37
mupBug #1560237 opened: worker/peergrouper: intermittent data race <juju-core:New> <https://launchpad.net/bugs/1560237>22:53
axwwallyworld: my desktop has decided now would be a good time to start cutting out again23:00
axwso may be late to or drop out of standup23:00
anastasiamacaxw: ack23:00
rogpeppeericsnow, natefinch, katco: here's the PR (sketchy tests I'm afraid but I think worth it anyway) https://github.com/juju/juju/pull/483323:26
rogpeppeaxw: fancy a review? ^23:28
axwrogpeppe: in standup, a bit later sorry23:29
rogpeppeaxw: np23:29
rogpeppeplease, can someone review this branch? it's almost midnight here and I really need to get this landed. https://github.com/juju/juju/pull/483323:40
rogpeppeericsnow, natefinch, katco: ^23:40
rogpeppewallyworld: ^23:40
ericsnowrogpeppe: looking23:40
rogpeppeericsnow: thanks23:41
rogpeppeericsnow: please don't wait until the end of the review if you have some comments, so i can get on with fixing things23:46
ericsnowrogpeppe: nothing so far23:47
rogpeppeericsnow: cool23:47
ericsnowrogpeppe: just getting my bearing relative to some of the refactors you did (nice ones :)23:47
rogpeppeericsnow: in 1m20s i'm gonna turn into a pumpkin23:58
ericsnowrogpeppe: LGTM23:58
ericsnowha, what timing23:58
rogpeppeericsnow: phew!23:58
ericsnowrogpeppe: thanks for the hard work on this23:59
rogpeppeericsnow: saved from pumpkinhood23:59
rogpeppeericsnow: np23:59
ericsnowrogpeppe: there are still a few things we have to sort out still23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!