| dholbach | good morning | 08:26 |
|---|---|---|
| davidcalle | dholbach: FAIL: runTest (md_importer.tests.test_link_rewrite.TestLinkRewrite) -> AssertionError: u'/en/file2/' != '/file2' | 09:14 |
| davidcalle | Any idea? | 09:14 |
| davidcalle | (hero tour changes) | 09:14 |
| davidcalle | That rings a bell, but I don't remember what was going on | 09:16 |
| davidcalle | dholbach: I'm going to trust your machine on this one :) | 09:52 |
| dholbach | davidcalle, let me take a closer look first | 09:53 |
| dholbach | I just wanted to give you a first bit of feedback :) | 09:53 |
| davidcalle | dholbach: alright | 09:54 |
| dholbach | davidcalle, updated the MP | 10:23 |
| dholbach | and thanks for the review | 10:23 |
| dholbach | I know it was a bit hard to review since many individual changes came together in this branch | 10:23 |
| davidcalle | dholbach: hah: AssertionError: u'/en/file2/' not found in ['/file2', '/en/file2'] | 10:27 |
| davidcalle | Interesting = | 10:27 |
| dholbach | unicode vs str I guess | 10:28 |
| dholbach | but bizarre that I don't see any of this happening here | 10:28 |
| davidcalle | dholbach: yep, I think you should decode. Or encode. ;-) | 10:28 |
| dholbach | decode().encode().decode().encode().decode().encode().decode().encode().decode().encode().decode().encode() | 10:29 |
| davidcalle | dholbach: you missed an utf-8 somewhere | 10:29 |
| davidcalle | dholbach: since you can't reproduce, let me try | 10:29 |
| dholbach | it's the .rar.zip.tgz.jar.sit.xpi.exe of the python world :-) | 10:29 |
| dholbach | davidcalle, I think I know a cleaner way | 10:30 |
| davidcalle | dholbach: we need a universal method "deencode" that loops over strings until it works | 10:30 |
| dholbach | in a big try/except statement | 10:31 |
| davidcalle | several nested try/except* | 10:32 |
| dholbach | I'm sure we can make it work! :) | 10:32 |
| dholbach | davidcalle, ok, I'll let you try :) | 10:34 |
| === dpm_ is now known as dpm | ||
| davidcalle | dholbach: http://paste.ubuntu.com/15471176/ | 10:48 |
| davidcalle | wfm ^ | 10:48 |
| dholbach | wow | 10:49 |
| davidcalle | dholbach: startswith? :) | 10:49 |
| dholbach | I'll try your patch now and if it works, I'd say: ship it! | 10:51 |
| dholbach | there should be a nicer way to see if two links lead to the same thing, but *shrug* let's move on | 10:52 |
| dholbach | davidcalle, MP updated | 10:52 |
| dholbach | thanks for your help! | 10:52 |
| davidcalle | dholbach: np, merged! | 10:55 |
| === dpm is now known as dpm-afk | ||
| === nhandler_ is now known as nhandler | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!