[08:26] good morning [09:14] dholbach: FAIL: runTest (md_importer.tests.test_link_rewrite.TestLinkRewrite) -> AssertionError: u'/en/file2/' != '/file2' [09:14] Any idea? [09:14] (hero tour changes) [09:16] That rings a bell, but I don't remember what was going on [09:52] dholbach: I'm going to trust your machine on this one :) [09:53] davidcalle, let me take a closer look first [09:53] I just wanted to give you a first bit of feedback :) [09:54] dholbach: alright [10:23] davidcalle, updated the MP [10:23] and thanks for the review [10:23] I know it was a bit hard to review since many individual changes came together in this branch [10:27] dholbach: hah: AssertionError: u'/en/file2/' not found in ['/file2', '/en/file2'] [10:27] Interesting = [10:28] unicode vs str I guess [10:28] but bizarre that I don't see any of this happening here [10:28] dholbach: yep, I think you should decode. Or encode. ;-) [10:29] decode().encode().decode().encode().decode().encode().decode().encode().decode().encode().decode().encode() [10:29] dholbach: you missed an utf-8 somewhere [10:29] dholbach: since you can't reproduce, let me try [10:29] it's the .rar.zip.tgz.jar.sit.xpi.exe of the python world :-) [10:30] davidcalle, I think I know a cleaner way [10:30] dholbach: we need a universal method "deencode" that loops over strings until it works [10:31] in a big try/except statement [10:32] several nested try/except* [10:32] I'm sure we can make it work! :) [10:34] davidcalle, ok, I'll let you try :) === dpm_ is now known as dpm [10:48] dholbach: http://paste.ubuntu.com/15471176/ [10:48] wfm ^ [10:49] wow [10:49] dholbach: startswith? :) [10:51] I'll try your patch now and if it works, I'd say: ship it! [10:52] there should be a nicer way to see if two links lead to the same thing, but *shrug* let's move on [10:52] davidcalle, MP updated [10:52] thanks for your help! [10:55] dholbach: np, merged! === dpm is now known as dpm-afk === nhandler_ is now known as nhandler