[03:13] ximion, what code does the icon lookup for appdata? I'm wondering if it doesn't handle Icon=name.extension in .desktop files (see bug 1560550) [03:13] bug 1560550 in supertux (Ubuntu) "AppStream icon for supertux2.desktop" [Undecided,New] https://launchpad.net/bugs/1560550 [03:13] Note that skype seems to make the same mistake (of explicitly putting in an extension) [03:14] The spec suggests this is not valid (https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html) [03:14] But it seems everthing is currenly handling it [03:32] robert_ancell: the generator cheats in that case [03:32] and removes the extension [03:32] ximion, so is that bug invalid? [03:33] this only works with .png though, and is a hack - I was even thinking about removing it, to make people obey the spec ^^ [03:33] * ximion won't do that though, maybe later after a long priod of warning about it [03:35] hmm... this looks like a generator bug [03:35] or maybe not [03:36] in my experience things get harder to remove the longer they've been around :) [03:36] ximion, oh, the icon is in -data and the .desktop is in the main package [03:36] That's still an issue right? [03:37] robert_ancell: that shouldn't be a problem [03:37] but the icon being a symlink in 256x256 to a 48x48px icon in /usr/share/pixmaps is a problem [03:37] that should definitely be fixed, and I bet the problem will be solved then [03:38] aha [03:39] robert_ancell: the generator tells explicitly what the problem is :D [03:39] http://appstream.ubuntu.com/xenial/universe/issues/supertux.html [03:40] => The symbolic link points to a file which is in a different package - we don't follow those links [03:41] ximion, but it would work if there wasn't a link? [03:41] robert_ancell: yes - I suggest removing the bad link from the supertux package, and symlinking the file in the -data package at the same location [03:42] ximion, thanks [03:42] that will work, and will have no drawbacks [03:42] yw [03:42] I wonder why the symlink was in the other package in the first place... [03:43] oh, btw: adding a smaller icon size would be nice for DEs which currently downscale a 256x256 icon ^^ [03:43] (but that's optional) [03:45] ximion, can't solve all of upstreams issues :) [03:46] Hello ppl :) I need an advice... I'm getting an error "[*] Access file: 'access.conf' was not found." , while trying to start fwknop-server ... I've checked that the file exists in /etc/fwknop, also tried to chmod it to 777 and chgroup it to my username instead of root, but none of those usual things help... Any ideas ? [03:46] robert_ancell: when the new metadata generator is deployed at Debian, I will submit a patch to the Distro Tracker / PTS to display that information there [03:47] that should help to raise awareness that there are issues ^^ [03:47] (people need to explicitly go to appstream.d.o or appstream.u.o to find that information) [03:47] hexahive: hint: stick around for more than a minute after asking a question... [03:49] hexahive: http://sources.debian.net/src/fwknop/2.6.0-2.2/server/access.c/#L1018 [03:49] sarnold: thanks for advice, i've accidentaly exited ubuntu-server after asking ;) [03:49] hexahive: note that it tries to use the same pathname in stat() that it prints to the error log -- since it is just 'access.conf' that probably means it is looking in the current working directory for the file. Is the current working directory set to /etc when you run it? [03:51] ah, no... so your advice is to try starting it by first cd-ing to /etc or /etc/fwknop ? btw i run it with sudo service fwknop-server start [03:52] hexahive: or give a full pathname in the configuration file [03:53] giving the full pathname means you won't need to care about current working directory [03:55] sarnold: thanks, will try right away [05:11] Hi === Drac0 is now known as Guest21629 [07:55] morning all [07:59] Morning! [07:59] Hi willcooke [07:59] How's it going Trevinho ? [07:59] Good weekend>? [08:01] willcooke: yeah a longer one. And a good one, although weather didn't help much. [08:01] You? [08:01] same [08:01] :) [08:06] morning willcooke [08:06] hey happyaron [08:07] moin [08:07] morning Sweet5hark [08:24] willcooke, jibel - i thought the conclusion was that www.ubuntu.com will only list amd64 for 16.04 for desktop download images, but we will release i386 iso as usual. [08:25] xnox, I think I've missed some of the back-story but yeah, that makes sense I think. Seb will probably be cross, but I think it's logical to but the 32 bit image in the same place as the "alternates" [08:26] I have a meeting with the web team at lunchtime so I can check in with them then [08:27] Trevinho, are you aware of this one: https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1532226 [08:27] Launchpad bug 1532226 in unity (Ubuntu) "A significant number of fresh boots or restarts result in no menus for most apps" [High,Confirmed] [08:28] Trevinho, assigning to you to start with, please reassign as neeeded === mikedld|_ is now known as mikedld|w [08:39] willcooke, physical meeting, or virtual? [08:40] xnox, they'll be in Bluefin I'll be on via a HO [08:40] willcooke, when i used to be on the installer team, i'd go to bluefin to brush over all download pages to make sure they are aligned with what release team is planning to release. Not two cycles were the same yet =) [08:40] :) [08:40] willcooke, imho it should just be an orange download button, without any drop-downs for desktop download page, same as it is for server/cloud [08:41] and since this is an LTS release, just the LTS download section. [08:42] xnox, I agree. Will keep you posted [08:42] =) [08:59] willcooke: FYI, Make supports 35 frameworks as of now (4 more than my annual review comment last month ;)) [09:00] (replied to thibaut) [09:00] and hey! [09:00] thanks didrocks [09:00] yw === Drac0 is now known as Guest22004 [09:49] willcooke: ok looking at that bug, thanks. [09:50] thanks Trevinho - I haven't seen it yet, but I guess plenty of people have now [09:50] maybe davmor2_HOLS did too [09:50] hence it being in the iso tracker === hikiko is now known as hikiko|ln [11:00] hey === Guest7210 is now known as fredp === fredp is now known as Guest61010 [11:05] hi andyrock [11:05] willcooke: any news about the crash? [11:06] andyrock, yes! See: https://bugs.launchpad.net/ubuntu/+source/compiz/+bug/1555237 [11:06] Launchpad bug 1555237 in ubuntu-release-upgrader (Ubuntu) "Upgrade from 14.04.4→ 16.04 dies midway taking out the session." [Critical,In progress] === hikiko|ln is now known as hikiko === Drac0 is now known as Guest79345 === alan_g is now known as alan_g|lunch [12:06] Trevinho, hi, if a BamfApplication emits window-added providing the BamfWindow as argument I would assume that bamf_application_get_windows and bamf_application_get_xids lists that window already [12:07] Trevinho, It seems logical I am pretty sure it was so in the past and therefore a regression? [12:12] ricotz: mhmh. So it should happen. At lunch now. Looking at it soon. [12:17] Trevinho, thanks [12:50] word up [12:51] morning desrt [12:58] ricotz: soooooo... I don't get that here, but it looks like it something that could happen because of a race. The thing is that bamf_application_get_windows returns the cached-windows that is actually populated on child-added signal, not on window-adedd. Thus if that window-added signal arrives before than child-added, then the result might be broken [12:59] ricotz: however, while I see that possible for bamf_application_get_windows, it looks weird for bamf_application_get_xids , since this uses a list of xids that we populate on window-added signal [13:00] ricotz: http://pastebin.ubuntu.com/15551495/ [13:00] ricotz: so the list is populated, then we emit the signal. And cached_xids is returned if available when calling get_xids [13:03] ricotz: I think this might fix things for you though [13:03] http://pastebin.ubuntu.com/15551521/ === alan_g|lunch is now known as alan_g [13:10] In my opinion deprecating the window-added signal at daemon level would be just better, however... And just rely on the child-added one. Then generating the window-added/removed signals only at lib level [13:13] * desrt raises her eyebrow [13:18] Trevinho, using child-added with get_xids seems to work [13:19] it still seems something changed here [13:19] ricotz: not really recently. Probably 1.5 cycles ago? [13:20] ricotz: as I added some caching, and get_xids is not calling dbus methods everytime now [13:20] I am a bit puzzled that I would have missed the for so long [13:20] maybe some dbus/glib changes triggered some ordering change? [13:21] I don't think... Signals seems to be emitted properly in order. We didn't change that. [13:21] I see [13:21] but as I said, the fact that we depend on a cached list of xids now, might be the thing [13:21] also, this shouldn't show up on first child addition [13:21] ok [13:32] Trevinho, alright, please make those signals behave the same as you suggested === JMulholland_ is now known as JMulholland [15:22] ricotz: want to check https://code.launchpad.net/~3v1n0/bamf/windows-signal-merge/+merge/290325 ? [15:26] ricotz: can you also open a bug related to that? [15:30] meeting time [15:30] #startmeeting Desktop Team Meeting - 2016-03-29 [15:30] Meeting started Tue Mar 29 15:30:19 2016 UTC. The chair is willcooke. Information about MeetBot at http://wiki.ubuntu.com/meetingology. [15:30] Available commands: action commands idea info link nick === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: [15:30] \o [15:30] o/ [15:30] Roll call: andyrock, attente, desrt, dgadomski (hols), fjkong, happyaron (out), hikiko(out), laney(hols), qengho, seb128(hols), sweet5hark, themuso (out), tkamppeter, trevinho, robert_ancell (out) [15:30] Yay! [15:30] hihi [15:30] 0.0 [15:31] heya [15:31] Hello, my lovelies. [15:31] o/ [15:31] Lets roll... [15:31] #topic andyrock === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: andyrock [15:32] hey all [15:32] i worked on the upgrade crash and took some days off [15:32] now i'm working to update a branch afters Trevinho's review [15:33] thanks andyrock [15:34] Do you know if anything has changed on the upgrade bug today? [15:34] nope [15:34] but it's definitely not unity [15:34] neither compiz [15:35] oki, I'll speak to c__yphermox and see if he knows where we go next. Thanks for digging in to it [15:35] #topic attente === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: attente [15:36] shorter week due to long weekend, fixed some gnome-software bugs, looks like most of the low-hanging fruit is gone at this point though (eof) [15:36] thanks attente [15:36] could you hook up with Robert later on and see what's the next best one to work on? [15:36] sure [15:36] cheers! :) [15:37] #topic desrt === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: desrt [15:37] short week here as well [15:37] did reviews [15:37] also 3.20 gnome releases [15:37] also did a bit of tech-support this week in terms of helping with the snappification of gnome-tech-using software [15:37] eof. [15:37] thanks desrt [15:38] #topic FJKong === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: FJKong [15:38] 1 just working on new feature request about sogou IM [15:38] 2 testing decompression of skin file using libapng [15:38] 3 collecting new bug report from community user [15:38] eof [15:38] thanks FJKong [15:38] #topic happyaron === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: happyaron [15:38] 1. Sponsor uploads for Ubuntu Kylin [15:38] 2. Sprint with NUDT during Wed - Sat, for sogoupinyin and localization stuff [15:38] 3. Package new wallpapers [15:38] 4. Bugs. [15:38] #topic hikiko === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: hikiko [15:38] * bug #1555237: after some debug on X and some suspicious postinst [15:38] scripts that could be related to the issue, we found out that xserver [15:38] receives the SIGKILL by systemd and dies and it's not compiz or any [15:38] other desktop application that crashes it - slangasek is working on it now. [15:38] * ezoom (today): fixed another issue with the translation parts of the [15:39] compiz zoom matrix, fixed some problems related to the transformations [15:39] bug 1555237 in ubuntu-release-upgrader (Ubuntu) "Upgrade from 14.04.4→ 16.04 dies midway taking out the session." [Critical,In progress] https://launchpad.net/bugs/1555237 [15:39] order, working on the scaling bugs I have on nux/unity side... [15:39] EOF [15:39] #topic qengho === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: qengho [15:39] * New Chromium release, 49.0.2623.108. Less than a week after previous. Tested. Gave to #security [15:39] * Some progress on Snappy package crash of Chromium in dynamic linker. Still weird. In progress. [15:39] * Other snappy/snapcraft work. Thinking about cross-compilation features. [15:39] EOF [15:39] thanks qengho [15:39] #topic Sweet5hark === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: Sweet5hark [15:40] - two days holidays [15:40] - some tweaking of snap [15:40] - some QA/bug triage/admin [15:40] - some bug/regression fixing and code review [15:40] EOF [15:40] thanks Sweet5hark [15:40] #topic TheMuso === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: TheMuso [15:40] * Finally got all the pieces landed for accessibility profiles, and all working except for one small bug I overlooked which is addressed with a quick upload. [15:40] * More upgrade testing, still freezing, not sure whats going on, testing in a VM, may switch to testing on real hardware since I have some spare. [15:40] * Installer testing mostly for accessibility profile stuff, no showstoppers. [15:40] #topic tkamppeter === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: tkamppeter [15:42] hmm [15:42] #topic Trevinho === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: Trevinho [15:42] · Improving theming support for overlays [15:42] · Decorate launcher/panel when in spread mode [15:42] · Fixed and Landed gtk/theme branches for getting toolbar-mode headerbars when maximized [15:42] · Reviews [15:42] EOF [15:42] thanks Trevinho [15:42] #topic robert_ancell === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: robert_ancell [15:42] - GNOME Software work [15:42] - LightDM 1.18.0 stable release [15:42] - Sponsoring uploads [15:42] #topic willcooke === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: willcooke [15:42] Beta 2 out!!!! [15:43] Thanks to everyone for all your help getting it out [15:43] we had some snags along the way and it was pretty late in the day when it was released, but we got there [15:43] #topic any other business === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks | Desktop Team Meeting - 2016-03-29 | Current topic: any other business [15:43] Anyone got anything they want to talk about? [15:44] going once [15:44] Mh, not really... I think the we're quite on track... [15:44] Ah, there's that bug of menus not showing up... [15:44] let's end the meeting and talk about that... [15:45] thanks all [15:45] Which seems something like a race, maybe attente knowledge on unity-gtk-module might help at some point [15:45] #endmeeting === meetingology changed the topic of #ubuntu-desktop to: Home of the Desktop Team, https://wiki.ubuntu.com/DesktopTeam | For help or questions, try #ubuntu | Amaterasu watches over you benevolently | Tag "gtk318" for gtk 3.18 bugs please and thanks [15:45] Meeting ended Tue Mar 29 15:45:03 2016 UTC. [15:45] Minutes: http://ubottu.com/meetingology/logs/ubuntu-desktop/2016/ubuntu-desktop.2016-03-29-15.30.moin.txt [15:45] Trevinho: which bug? [15:46] attente: Bug 1532226 [15:46] bug 1532226 in unity (Ubuntu) "A significant number of fresh boots or restarts result in no menus for most apps" [High,Confirmed] https://launchpad.net/bugs/1532226 [15:46] Trevinho: also.. i'm not sure what happened, but when i tried to run gtk apps recently in jhbuild, theming seems kind of broken [15:46] attente: using upstream gtk? [15:47] Trevinho: yeah, but even if i check out an older version (like three months ago, i still see it, so i'm not sure what's happening) [15:48] attente: and by broken you mean? [15:48] i'll take a screenshot [15:50] hi [15:50] sorry for being late. [15:50] willcooke, I will send my stuff by mail in some minutes. [15:53] Trevinho: https://imgur.com/wVYEPwI [15:53] for the usual apps, everything looks ok [15:54] it's just when running through jhbuild, the decorations look bad [15:54] attente: are you using the gtk unity patch? [15:54] I mean have you applied that to jhbuild? [15:54] no, this is unpatched gtk [15:54] mh, it's weird though... Since nothing should change at theme level in this case [15:55] but for whatever reason when i check out gtk from 3 months ago, it still has this problem, so i have no real clue what changed [15:55] since we apply new rules to a class of headerbars only that is only exported if that patch is there [15:55] yeah... it's really weird [15:55] attente: that was caused by the last theme update? [15:56] Trevinho: really hard to tell, i did a dist-upgrade concurrently with a gtk+ checkout [15:56] mh [15:56] can you try old ubuntut hemes? [15:59] attente: ^ [15:59] Trevinho: sure [15:59] Trevinho: i'm not sure that's a unity-gtk-module bug if this is happening: https://launchpadlibrarian.net/245092360/Screenshot%20from%202016-03-02%2017-08-23.png [16:00] attente: it could be, what else could provide such menus? [16:01] attente: if you can give me gdbus call --session --dest com.canonical.Unity.Panel.Service.Desktop --object-path /com/canonical/Unity/Panel/Service --method com.canonical.Unity.Panel.Service.SyncOne 'libappmenu.so' [16:01] wnckprop --list [16:01] Trevinho: well in that situation, maybe u-p-s isn't getting any signal from bamf that the focused application changed? [16:02] attente: as per the fact that calculator app name is there, would say no. [16:02] Trevinho: i didn't replicate the problem yet, that's just a screenshot from the bug report you linked [16:02] attente: also we now exports all the menus around [16:02] Ah. [16:52] Trevinho, https://paste.debian.net/plain/422523 ? [16:53] ricotz: mh, no.. I'd keep the window-{added,removed} at lib level. I'd just bind them to the child ones [16:53] as in theory a bamf app could be a container of other views (not that this is the case anymore, but it used to be with webapps) [16:54] Trevinho, I see [16:54] still is there a reason for the chain-up? [16:55] not much right now, but I'd prefer to keep that API [16:56] ricotz: ah you mean on the daemon? [16:56] Trevinho, yes, then second part of the diff [16:57] ricotz: yeah, that is fine [16:57] ok, sorry, g2g [16:59] me too... Pushing your changes later === meetingology` is now known as meetingology === mfisch is now known as Guest28049 === desrt_ is now known as desrt === attente_ is now known as attente === alan_g is now known as alan_g|EOD [18:12] Trevinho: hey [18:13] are you looking into udisks2 for the upgrade from trusty? [18:14] andyrock could get involved here too ^ [18:14] cyphermox: I wasn't working on that... andyrock did [18:15] cyphermox: are we 100% sure it's udisks2? [18:15] looks like simply someone restarts dbus (which tears down the world with it) [18:16] ogra_: can we monitor who/what does that? [18:16] andyrock: I'm not 100% sure of anything, I was just looking at the upgrade bug again, looking to see if there's something for me to do there. [18:17] andyrock, i dont think so [18:17] dbus restarting is unfortunate but a reality when you need to update things like glibc too, etc. [18:17] but i'd expect some evil postinst or some such somewhere [18:17] cyphermox, well, but that kills lightdm [18:17] are you sure that's what kills lightdm? [18:17] ie. X crashes anyway, that's not dbus-related. [18:18] or if it doesn't crash, it stops in any case [18:18] cyphermox, stop dbus on your system and you will see lightdm stop [18:18] it definitely needs more looking into, that's for sure [18:18] ogra_: doesn't mean that's the issue [18:18] not, it could just be fallout [18:19] but there is indication tht dbus gets restarted somewhere in the bug [18:19] which will cause lightdm to die [18:20] too many people looking at this bug makes it full of useless garbage and red herrings [18:20] weather that is because dbus crashed due to something or because some evil postinst force-restarts it, that i dont know [18:21] i looked into it until we thought that unity/compiz was making x crashing [18:26] heh [18:28] i can keep working but we need more info on why dbus crashes [18:28] i can try to gdb it if it's possible [18:40] are you sure it even crashes ? === Guest28049 is now known as mfisch === mfisch is now known as Guest82454 [19:02] right, off now until EOW. Email me if you need anything === Guest82454 is now known as mfisch === shookees is now known as Guest59728 [21:48] robert_ancell: hi, are there any specific gs bugs you would like me to look at? i think a lot of the crashes might go away by taking 7fabe936f527ad53f0f51408da64bad80a126dc1 and 0ea65a85eb9fd2e71295f694aa4fb30aae773956 [21:48] attente, nothing specific really, just what looks the highest priority [21:49] attente, did you want to make a release so you're comfortable with the process? [21:50] robert_ancell: sure, i can give it a try [21:51] robert_ancell: i can just take diffs of each branch against the gnome-3-20 and use those for the debian patches? [21:51] attente, yes, but you might find some conflicts if you don't make your own rebased branch with them all [21:52] And rebasing will make it easier to generate the patches [21:53] attente, you should also generate a snapshot from gnome-3-20 because it has some fwupd patches that we need [21:53] ok [22:01] (or you can pull in each individual patch)