| dholbach | good morning | 06:27 |
|---|---|---|
| dholbach | davidcalle, I have another fix I need to get into trunk, it's for https://bugs.launchpad.net/developer-ubuntu-com/+bug/1565639 | 07:22 |
| ubottu | Launchpad bug 1565639 in Ubuntu Developer Portal "Two tests fail with postgres" [Undecided,New] | 07:22 |
| dholbach | davidcalle, and I suggest we add a "test all" command or something, which runs the tests both on postgres and sqlite | 07:22 |
| davidcalle | dholbach: +1, and in the meeting with the webteam, there was mention of a Jenkins instance (they would setup) in the future :) | 07:43 |
| dholbach | oh wow | 07:43 |
| dholbach | that'd be awesome | 07:43 |
| dholbach | new MP, code reviews, jenkins runs tests, deploy... or something :-P | 07:43 |
| davidcalle | Yes please :) | 07:44 |
| davidcalle | dholbach: btw, the db dump is on the server, I'll load it in th db in a few minutes | 07:50 |
| dholbach | cool | 07:50 |
| dholbach | I'll let you know once I fixed the issue(s) | 07:50 |
| dholbach | davidcalle, this might look oddly familiar to you: https://daniel.holba.ch/temp/:'-%28.png | 10:17 |
| dholbach | I'm trying to rebuild this in a test setting - the tests in postgres are already fixed | 10:17 |
| davidcalle | dholbach: is that a messed up tree? :( | 10:18 |
| dholbach | I vote we should go for local testing using nothing but postgres :) | 10:19 |
| dholbach | or it's what I should do | 10:19 |
| davidcalle | dholbach: I think we should change make dev to use postgre, indeed | 10:20 |
| dholbach | for now I created https://bugs.launchpad.net/developer-ubuntu-com/+bug/1565676 | 10:20 |
| ubottu | Launchpad bug 1565676 in Ubuntu Developer Portal "Add a test_all command" [High,Triaged] | 10:20 |
| dholbach | opinions and ideas welcome | 10:20 |
| dholbach | ok, the find_parent function is on crack | 10:28 |
| dholbach | time to add some more tests for it | 10:28 |
| === dholbach_ is now known as dholbach | ||
| dholbach | davidcalle, https://code.launchpad.net/~dholbach/developer-ubuntu-com/1565639/+merge/290855 | 14:08 |
| dholbach | problem solved AFAICS | 14:08 |
| dholbach | dpm, ^ :-) | 14:09 |
| dpm | \o/ | 14:09 |
| davidcalle | dholbach ! | 14:09 |
| davidcalle | You rock | 14:09 |
| davidcalle | dholbach: looking at it as soon as I'm done with the krita thing | 14:10 |
| dholbach | davidcalle, no worries | 14:11 |
| dholbach | let me give you a test-case | 14:11 |
| dholbach | dpm, that now leaves some time to look at the redirects thing :) | 14:12 |
| dpm | dholbach, excellent. Is the call later on too late for you? If not, we can talk about it there, or alternatively tomorrow morning | 14:13 |
| dholbach | dpm, it's fine | 14:14 |
| davidcalle | dholbach: by the way, I've been having troubles with loading the dbdump on staging, it's not just the "db content" we have been passed, but the whole db declaration, which conflicts a little with the staging db (user names, etc.). For the sake of rapidity, I'll quickly reproduce a basic snappy page layout instead, to test an import. | 14:14 |
| dholbach | sure | 14:15 |
| dholbach | I added instructions for testing | 14:16 |
| davidcalle | thanks | 14:17 |
| davidcalle | dholbach: I've a few issues when running the importer on the site: snapcraft reference doesn't generate: missing python3-requests, python3-docopt, and ultimately, it fails with http://paste.ubuntu.com/15613951/ | 14:52 |
| dholbach | what what | 14:53 |
| dholbach | ouch | 14:53 |
| dholbach | yeah, I have those installed locally :-( | 14:53 |
| davidcalle | dholbach: no worries, I'm more concerned about the pastebin | 14:53 |
| dholbach | feel free to leave out the reference generation for now | 14:54 |
| dholbach | I'll file a bug | 14:54 |
| davidcalle | Alright. I'm not trying with your branch yet | 14:54 |
| dholbach | just remove the post_checkout_command for now | 14:54 |
| davidcalle | Yep. Also, I can confirm I'm reproducing your trees issues :) WIll test with your branch in a short moment ;) | 14:55 |
| davidcalle | dholbach: your branch is working on staging \o/ | 15:18 |
| dholbach | <3 <3 <3 | 15:18 |
| dholbach | looks like it was worth ignoring everything else today ;-) | 15:18 |
| davidcalle | Indeed :D | 15:18 |
| dholbach | davidcalle, mhall119: I'm currently looking at implementing the small redirects app - and I'm struggling somewhat using the RedirectsView - maybe I'm doing the wrong thing? https://code.launchpad.net/~dholbach/developer-ubuntu-com/404-redirect/+merge/290887 (it's a mid-flight branch) | 15:26 |
| dholbach | oh... I just found https://docs.djangoproject.com/en/dev/ref/contrib/redirects/ | 15:35 |
| dholbach | I'll try that out instead :) | 15:35 |
| davidcalle | dholbach: woah, strange behaviour on staging. Run the importer once, it fills up. A second time, it empties everything (no more pages at all in snappy/). A third time, fills up again. | 15:35 |
| dholbach | let me see if I can reproduce this | 15:36 |
| dholbach | I actually added a couple of tests for running imports more than once | 15:36 |
| davidcalle | dholbach: wait, I'm wondering it the cache is not acting up... | 15:38 |
| dholbach | best to check locally then - I'll do it with a fresh db | 15:38 |
| dholbach | davidcalle, I ran it three times in a row, every single time the imported files were all there | 15:41 |
| davidcalle | dholbach: maybe I need to wait more between two runs | 15:42 |
| mhall119 | dpm: dholbach: have we let the folks supplying the chinese content know about the impending IA changes? | 15:42 |
| dholbach | mhall119, not AFAIK | 15:42 |
| davidcalle | mhall119: not yet afaik | 15:43 |
| dholbach | davidcalle, you're right :-(( | 15:43 |
| dholbach | I reproduced it | 15:43 |
| mhall119 | dholbach: are you sure about adding the RedirectView to the urlpatterns? I thought we were going to override the 404 handler to do this | 15:45 |
| dholbach | mhall119, I couldn't find a way to do this properly, and I just saw I need to fix something more important now :-/ | 15:46 |
| dholbach | and maybe https://docs.djangoproject.com/en/dev/ref/contrib/redirects/ would be an option too | 15:46 |
| davidcalle | dholbach: from my point of view, the redirect is more urgent than the importer. I can look into redirects if you want | 15:48 |
| davidcalle | 'cause I haven't, yet :) | 15:48 |
| mhall119 | dholbach: it doesn't look like the redirects middleware supports regex or base-path redirects, only 1:1 path matches | 15:48 |
| mhall119 | but it might be easier to fork that, rather than start from scratch | 15:49 |
| dholbach | davidcalle, ok, cool - I'll look into fixing this issue then | 15:50 |
| davidcalle | ok :) | 15:50 |
| davidcalle | dholbach: I'm merging your branch from today into trunk to make things easier, hold on | 15:51 |
| dholbach | ok, thanks | 15:52 |
| davidcalle | dholbach: done | 15:52 |
| * dholbach hugs davidcalle | 15:52 | |
| dpm | mhall119, davidcalle, dholbach, previous call running over | 16:06 |
| dholbach | thought so ;-) | 16:08 |
| dpm | mhall119, joining the desktop docs call? | 16:13 |
| mhall119 | dpm: sorry, got carried away with lunch | 16:49 |
| dpm | mhall119, got time for a quick hangout? We can reuse the same url as the previous call | 16:49 |
| mhall119 | sure | 16:50 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!