[07:18] davidcalle, I think I'm getting closer to finding the issue wrt dropping pages after import [07:18] lots of debug statements and lots of hard looking at terminal output has helped some [07:18] I'll keep you posted [07:27] Morning o/ [07:27] dholbach: my hunch is that it has to do with the diff checking. When there is no diff between the import and the current page, it drops the page. I haven't looked at it closer, though. [07:29] davidcalle, I was able to create a test-case for it, so I hope to have it resolved soon and we will never hear from the issue again [07:29] davidcalle, mhall119: let's have a call some time when things are a bit less crazy to move all of us to postgres for good :) [07:29] :) [07:30] dholbach: what, the plan is not to lobby the web team to get all sites moved to mysql? [07:30] sqlite for all the things! [07:31] \o/ [07:35] I love starting to work from something like: [07:35] FAILED (failures=1) [08:25] dpm: dholbach: does that look accurate to you? (new IA redirects) [08:25] davidcalle, on staging? [08:25] dholbach: dpm: link -> http://paste.ubuntu.com/15625545/ :) [08:27] My first iteration on this is quite simplistic. Check if the url starts with $lang/$from, replace with $lang/$to, check if new url exists, if yes: redirects. [08:27] davidcalle, it looks like it matches what's in proposal #1 [08:28] one thing we might want to think of is how we structure the "phone - get started" journey [08:28] davidcalle, looks good to me, not sure about bringing "web" one level deeper [08:30] anyway, we can talk about it in a minute in the call. We might actually need more than 30 mins if we want to go deep into the landing page and the redirects [08:30] davidcalle, you're a hero [08:31] dpm: dholbach: joining the call in 2 min, need to find a room. [08:32] ok [10:02] dholbach: https://code.launchpad.net/~davidc3/developer-ubuntu-com/redirects-on-404-1/+merge/290963 [10:05] davidcalle, checking [10:05] I don't like hardcoding them, but I haven't found a way to properly override 404 methods in Django CMS, so it's for the sake of having them asap [10:06] understood [10:12] nice work!° [10:12] very quickly done and just affects actually existing pages which are being redirected [10:12] for this we could write tests later on as well [10:13] not for this deployment, but along with an admin interface, this could be easy to test [10:13] dholbach: thanks, yes, I'm not sure if js redirection will be easy to test though [10:15] thinking out loud, but maybe the js code could live in another template, attached to a django redirect app, with a proper model and admin panel, then call it from the 404 template [10:15] Anyway, pushing to staging :) [10:19] mh, maybe not so easy to test :) [10:20] at least not with django.test.Client [10:20] anyway: good work! :) [10:23] *duc autopilot will fix everything* [10:32] <3 [11:52] davidcalle, I think I found the problem - let me see if it fixing it the most straight-forward way causes any other fallout :-) [11:53] dpm: can you set the size of the RT to XS and the urgency to uber-critical ;-) ? https://portal.admin.canonical.com/90349 [11:53] dholbach: what is it? [11:54] davidcalle, I think it is http://paste.ubuntu.com/15628202/ [11:54] ie when publishing ALWAYS return the public object, not the draft [11:54] just running the testsuite on both sqlite and postgres [11:55] that's the longest I ever spent on unindenting two lines of python code /o\ [11:55] lol [11:55] now let's hope it doesn't break anything else :-) [11:56] * davidcalle crosses fingers [11:57] dholbach: good luck ;) I'll start on creating /desktop [12:17] https://code.launchpad.net/~dholbach/developer-ubuntu-com/fix-double-imports/+merge/290978 [13:06] dholbach: what do you mean "move all of us to postgres for good"? [13:06] are you talking local development? [13:07] yes [13:42] davidcalle, which syntax do you generally use on d.u.c pages with CLI instructions? [13:44]
...
[13:44] dpm ^ [13:44] dholbach: does the ubucon deployment use a local pip-cache like devportal does? [13:44] thanks davidcalle [13:44] or will it pull and install from pypi? [13:44] mhall119, I found it impossible to work with the instructions that were provided [13:44] it didn't work at all for me [13:44] what didn't? [13:45] the juju layers stuff [13:45] so I just did what's in the new README.local.md file [13:45] ok....so is that a "no, it doesn't use pip-cache"? [13:45] that's a "I don't know" [13:46] I tried to understand it and replicate it locally, but I couldn't [13:46] mhall119, I think the issue is that after the website's deployment migration to juju layers no one knows how it all works [13:46] ok, where is the charm code? I'll take a look at it [13:46] mhall119, for me, the local deployment worked the last time a few months ago, but seeing that it's not working for dholbach, something must have changed in the meantime in juju [13:47] dholbach: is README.local.md in the charm code? [13:47] mhall119, check the other README.mdf [13:47] mhall119, check the other README.md [13:47] mhall119, no, that's added in my MP [13:47] ok [13:47] https://code.launchpad.net/ubucon-site [13:47] that's what I did to run it locally [13:47] the ubucon-layer series in there contains the juju code [13:49] ok, it doesn't *look* like it uses a local pip-cache, and even if it does it would be the django layer doing it, not our code, which is all I really needed to know to do this review [13:53] dholbach: does aldryn need libxml2-dev and libxslt-dev from apt-get? [13:53] thanks davidcalle, using that now [13:54] mhall119, I can't quite remember which of the pip bits needed these to compile [13:54] let me retry it [13:54] dholbach: but something does? If so, we need to have them added to the ubucon-layer branch [13:55] mhall119, I'll let you know in a minute [13:56] mhall119, it's aldryn-newsblog → lxml [13:56] which makes sense [13:57] ok, then those two need to be added to http://bazaar.launchpad.net/~ubucon-site-developers/ubucon-site/ubucon-layer/view/head:/django.yaml [13:59] not that I know what I'm doing, but I'll send an MP [14:02] I'll ping jcastro and marcoceppi [14:02] mhall119, thanks for helping to figure this out [14:03] mhall119, does a local test work for you or didn't you get that far? shall we merge it into trunk and then just leave the layers branch and the deployment to Marco? [14:07] mhall119, can you merge the branches - I'm not member of the team [14:07] dholbach: I haven't tried a local test [14:07] ok [14:07] dholbach: you are now :) [14:12] mhall119, that's not what I had in mind :-) [14:12] I know :) [14:17] do we want to land https://code.launchpad.net/~dholbach/developer-ubuntu-com/fix-double-imports/+merge/290978 too in this same deployment? or do we not want to confuse them? === dpm is now known as dpm-afk === dpm-afk is now known as dpm