| davidcalle | Morning o/ | 07:33 |
|---|---|---|
| dholbach | davidcalle, the page generation refactoring is looking good - the new test case for the disappearing articles (on the 2nd import) passes and there are only two out of 37 tests left to fix now | 07:43 |
| dholbach | I hope to have something up to test for staging in the next hour | 07:43 |
| davidcalle | dholbach: \o/ | 07:44 |
| dholbach | davidcalle, and it should help with the work of making Didier's full-tree imports easier | 07:47 |
| === yaili_ is now known as yaili | ||
| dholbach | at some stage it might make sense to look into speeding up the test suite (480.910s with postgres, 450.254s with sqlite) | 08:26 |
| dholbach | all tests pass now, next step: testing things manually | 08:27 |
| dholbach | davidcalle, is the JS redirect fix on prod already? | 09:22 |
| davidcalle | dholbach: it is | 09:22 |
| dholbach | cool, I'll file a bug for us to update the definitions, so we can drop old redirects, if that works for you | 09:23 |
| dholbach | https://bugs.launchpad.net/developer-ubuntu-com/+bug/1568760 | 09:29 |
| ubottu | Launchpad bug 1568760 in Ubuntu Developer Portal "Replace redirect pages with redirect logic in JS" [Undecided,New] | 09:29 |
| davidcalle | dholbach: good idea, but I would wait for a proper admin interface before adding "legacy" redirects. Hopefully I'll have time for this later this week. | 09:38 |
| dholbach | sure | 09:38 |
| dholbach | I'll update the bug | 09:41 |
| davidcalle | Thanks :) | 09:55 |
| dpm | davidcalle, on the syntax you pasted for me for CLI instructions the other day, do you tend to add </br> to the end of each command? | 09:56 |
| davidcalle | dpm: you don't, everything in <pre><code> uses linebreaks and indentations it finds in the source view. | 09:58 |
| dpm | ok, I wasn't sure, thanks for confirming! | 09:58 |
| davidcalle | np | 09:58 |
| dpm | davidcalle, do you have other examples of embedded TOC, such as the one in https://developer.ubuntu.com/en/start/ubuntu-for-devices/porting-new-device, or shall I use that one for the page I'm currently working on? | 11:13 |
| davidcalle | dpm: that's more or less the one used when it needs one, same goes for design docs actually | 12:38 |
| dpm | davidcalle, thanks, I ended up using it for the get-started page :) | 12:38 |
| dholbach | davidcalle, the tests were passing, but two consecutive manual imports still showed the same issue... I'm pretty certain I found the issue, I need to think about a fix for this...... | 12:51 |
| davidcalle | ouch :( *hugs* | 12:52 |
| dholbach | after the import we check if there are pages which were previously imported, but not part of the current import and delete them | 12:52 |
| dholbach | there's an issue with timestamps I think | 12:53 |
| dholbach | maybe articles which didn't need an update on the second import ... or something | 12:53 |
| dpm | davidcalle, argh, I've got an issue whereby when adding the link plugin and saving the page, it undoes all your changes :( | 13:00 |
| davidcalle | dpm: I have a trick for this! Don't use the link plugin :) | 13:00 |
| dpm | yeah, a bit late :) | 13:01 |
| dholbach | dpm, let's file a bug for this and see if a newer version fixes it and it not, let's report it upstream :-/ | 13:02 |
| dholbach | dpm, is it just any page where this happens? | 13:02 |
| davidcalle | dpm: more seriously, the issue I've seen is when copying a link plugin from on page to another. I don't use it because of this. | 13:03 |
| dpm | dholbach, I don't know, I've seen it just now on the page I'm editing, now twice. The first time I thought there might have been some cache issues, the second one I think I can track it to the link plugin. Either that, or pages are not getting saved at all, which I don't think it's the case | 13:04 |
| dpm | also, viewing the history of a page and clicking on one of the history links generates an error page | 13:05 |
| dpm | perhaps because my page is not yet published? | 13:06 |
| dholbach | maybe you can write down what you did in a bug report and we try to try to fix it as one of the next things? | 13:07 |
| dholbach | in any case it's something we would know how to work around, but probably not any of the people who edit dev.u.c just every now and then :/ | 13:07 |
| dholbach | davidcalle, I'm close to filing a bug for this issue and remove the tracking of 'stale pages' for now as a workaround :-) | 13:09 |
| dholbach | it'd let us bring the importer online | 13:09 |
| dholbach | ... and would give me a break from this problem ;-) | 13:09 |
| davidcalle | dholbach: what does it change to the process, if you remove the tracking of stale pages? | 13:17 |
| dholbach | davidcalle, we would need to delete stale pages, if e.g. a doc in snappy's branch gets deleted or renamed | 13:18 |
| dholbach | (which doesn't happen all that often) | 13:18 |
| dholbach | it'd let us deploy now and give us breathing room to fix the issue properly :) | 13:19 |
| davidcalle | Gotcha, yeah :) | 13:19 |
| dholbach | davidcalle, https://code.launchpad.net/~dholbach/developer-ubuntu-com/fix-double-imports/+merge/290978 updated | 13:42 |
| dholbach | mhall119, davidcalle, can we deploy ^ on staging and get a semi-recent db dump loaded? is that a lot of work to get going? | 15:13 |
| davidcalle | dholbach: db dump will take some time, but upload to staging when I'm out of the call and can fire the vpn :) | 15:41 |
| * dholbach hugs davidcalle | 15:42 | |
| dholbach | which part takes time? | 15:42 |
| davidcalle | dholbach: the format we got the dump in. It's basically a copy of the db and not an extract of the db content. I haven't figured a correct way to push it in the db. If we simply replace the db with it, the site doesn't connect (authentication error with the db). | 15:45 |
| dholbach | ok, I see | 15:47 |
| davidcalle | dholbach: deployment started, see you in 15 min :) | 16:03 |
| davidcalle | Juju crashed, starting again 0:-) | 16:05 |
| dholbach | ouch | 16:07 |
| davidcalle | dholbach: network is too slow right now apparently, it's going to take ages. I'm going to leave the server, let it run. If it fails, I'll do it again later, I need to drive home. I'll send you results :) | 16:13 |
| dholbach | no worries | 16:14 |
| * dholbach hugs davidcalle | 16:14 | |
| dholbach | thanks a lot for your help with this | 16:14 |
| * davidcalle hugs dholbach back | 16:14 | |
| dholbach | you're an absolute hero | 16:14 |
| davidcalle | dholbach: have a nice eod o/ :) | 16:14 |
| dholbach | thanks! | 16:14 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!