[06:16] manjo, there is not tags on unstable ... you'd be better off basing them on where you want them applied [07:10] please please take the virtualbox modules from xenial and put in kernel [07:10] serious fixes for xorg 1.18 and rootless mode [07:10] you don't need the xorg-legacy package anymore [07:10] (guest-modules of course) [07:11] you can even see the patch (diff from the -2 and -3) [07:23] Might be a bit late for that. [07:25] infinity, i guess i should at least queue those up in case there is any kind of respin for some other reaosn [07:25] * infinity nods. [07:26] apw: And test build it for sanity. The update is rather... Extensive. [07:26] sigh [07:26] we love extensive changes after freeze, please bring it on [07:26] Yup. [07:27] apw: I love how the update script tells you how to grab and unpack the deb instead of just, y'know, grabbing and unpacking the deb. [07:27] oh it has no version [07:28] If it took a version arg instead of a path, it could wget and unpack and import. [07:28] Or if could just pull-lp-source the latest from the current series with no args. [07:28] s/if/it/ [07:28] But whatever. I just always find it entertaining when the comments of a shell script are effectively more shell script. :) [07:29] yeah lazyness on my part for sure [07:29] "Execute these shell commands before calling this shell command." [07:31] Err, pull-lp-source wouldn't work. But you know what I mean. Query the version somehow and wget from the pool, I guess. [07:31] I wasn't being critical so much as amused, though. :) === mwhudson_ is now known as mwhudson === mwhudson is now known as Guest85752 === Guest85752 is now known as mwhudson [07:46] yep, it clearly should take a version at least [07:46] LocutusOfBorg, gads why is this about 10 billion lines [09:31] apw, I think the kernel module is not so extensive [09:31] unfortunately I had to take the whole patch, to be safe ;) [09:31] they had to implement a new driver, working with rootless xorg [09:31] otherwise it wouldn't work at all [09:36] looking at src/Vbox/Additions/linux changes, it isn't so scary [09:36] https://anonscm.debian.org/cgit/pkg-virtualbox/virtualbox.git/commit/?id=cc16e5049641855149fe9d6b091415bebcc58d3d [09:36] and many fixes are ifdefs for the kernel 4.6 (sigh I already got two bug reports about people not being able to build it damn) [09:37] Oh? [09:37] Built fine for me. [09:37] Won't insert, because I have secureboot enabled, but... :P [09:37] infinity, heh [09:41] https://bugs.launchpad.net/ubuntu/+source/virtualbox/+bug/1569989 [09:42] Launchpad bug 1569989 in virtualbox (Ubuntu) "virtualbox-dkms 5.0.16-dfsg-2: virtualbox kernel module failed to build for kernel 4.6 [error: implicit declaration of function ‘page_cache_release’]" [Undecided,Fix released] [09:42] I remember another one with the same issue, but on guest-dkms [09:44] it affect host and guest, by sharedfolders module as you can see with a find on the above commitid on virtualbox.git [09:44] that page_cache_release is used in three places [09:44] infinity, you might have built only the video driver? :) [11:40] infinity, LocutusOfBorg, ok build tested and pull-request out .. if we have a respin we can try and slip it in [11:41] <3 apw [12:24] apw, do you have any git link? I would like to one day understand more about the ubuntu kernel [12:24] and maybe ask pull-requests by myself :) [12:24] LocutusOfBorg, is on our kernel-team@ list [12:25] oh... no git? [12:25] the pull request contains the git [12:26] thanks [12:26] yeah [12:26] so you just grab the virtualbox-guest-source and commit the files? [12:27] BTW I'm not upstream, but meh :) [12:29] LocutusOfBorg, you are "my upstream" though [12:36] :) === ejat_ is now known as ejat === ghostcube_ is now known as ghostcube