| davecheney | here's a quick review, https://github.com/juju/juju/pull/5410 | 01:26 |
|---|---|---|
| anastasiamac | davecheney: reviewed | 01:40 |
| davecheney | ta | 01:43 |
| mup | Bug #1582463 opened: juju subordinate not allocating and can't be destroyed <canonical-bootstack> <juju-core:Triaged> <juju-core 2.0:New> <https://launchpad.net/bugs/1582463> | 01:57 |
| davecheney | it takes 16 minutes to run the state tests on my machine | 02:38 |
| natefinch | davecheney: I have a branch where I'm adding if testing.Short(){ c.Skip() } to all the longest tests until each package takes no more than 1 seconds to test. That should drop the time to run a smoke test dramatically. Not that it'll help when you really want to run the full suite. | 02:45 |
| natefinch | davecheney: it also does that to all mgosuites and jujuconn suites in the suitesetup, skipping the entire suite, because, seriously, no. | 02:45 |
| natefinch | brb | 02:46 |
| davecheney | natefinch: i only care about the tests taht CI runs | 02:46 |
| mwhudson | davecheney: are you testing against mongo 3.2 now? | 02:53 |
| mwhudson | hm, doubt it | 02:54 |
| davecheney | mwhudson: nope | 02:54 |
| davecheney | mwhudson: what i mean is | 02:56 |
| davecheney | my setup has not changed since 14.04 | 02:57 |
| davecheney | so whatever was happening before i went on leave when the state tests did pass | 02:57 |
| davecheney | is no longer happening | 02:57 |
| mwhudson | davecheney: oh right, of course | 02:58 |
| mwhudson | was just a stray thought anyway | 02:58 |
| davecheney | mwhudson: fwiw, CI doesn't run mongo 3.2 | 02:58 |
| davecheney | so, there's that | 02:58 |
| mwhudson | davecheney: yeah, i expect some tests still fail | 02:58 |
| davecheney | could someone who's a mod on the juju-dev mailing list please approve my message that is slightly larger than the 40kb message limit | 02:59 |
| natefinch | davecheney: but what about all those poor souls on their 2800 baud modems? | 03:17 |
| anastasiamac_ | natefinch: some ppl believe that terrible experiences enrich souls :-P | 03:18 |
| natefinch | anastasiamac_: I think some people just can't get out of the 1999 mindset | 03:20 |
| anastasiamac_ | natefinch: 1999? when was that? :-P | 03:20 |
| davecheney | wepl, ya'll miss out on my satorial wit | 03:22 |
| mup | Bug #1556442 changed: juju quickstart looks for network-bridge: "lxcbr0" in local environment <bootstrap> <quickstart> <juju-core:Expired> <https://launchpad.net/bugs/1556442> | 04:21 |
| mup | Bug #1557874 changed: juju behaviour in multi-hypervisor ec2 clouds <juju-core:Expired> <https://launchpad.net/bugs/1557874> | 04:21 |
| davecheney | here is a simple one https://github.com/juju/juju/pull/5413 | 06:03 |
| mup | Bug #1581748 opened: [2.0b7] add-credential no longer supports maas as a cloud type <cdo-qa> <credentials> <maas> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1581748> | 06:25 |
| thumper | o/ | 06:25 |
| thumper | davecheney: you should have an amusing email to read now | 06:25 |
| davecheney | thumper: :) | 06:26 |
| davecheney | are you a mod on juju-dev ? | 06:26 |
| davecheney | can you approve my less than amused email ? | 06:26 |
| thumper | yep | 06:26 |
| thumper | um... not the ubuntu juju-dev list, no | 06:26 |
| thumper | I think that is still just gustavo | 06:26 |
| elmo | thumper: no, it's Becky^WWilliam | 06:31 |
| thumper | elmo: oh, thanks | 06:31 |
| elmo | the mailing list moderation is a cluster - I'm going to arbitrarily drop all the held messages; some of them date back to 2013 | 06:35 |
| elmo | the majority are spam; and I can't believe the non-spam ones are still relevant | 06:35 |
| thumper | heh | 06:35 |
| dimitern | thumper: heh, it seems I dodged it but frobware got on that plane after all? | 06:45 |
| thumper | dimitern: he will be | 06:45 |
| dimitern | thumper: ah, not yet I see | 06:46 |
| dimitern | sometimes not having a visa might be good for a change | 06:47 |
| mup | Bug #1582555 opened: deploy cs:trusty/ubuntu deploys Xenial charm <juju-core:New> <https://launchpad.net/bugs/1582555> | 06:55 |
| dimitern | rogpeppe: ping | 07:42 |
| rogpeppe | dimitern: pong | 07:42 |
| dimitern | rogpeppe: hey, I'm seeing a consistent test failure in cmd/jujud/agent/machine_test.go:TestDyingModelCleanup - http://paste.ubuntu.com/16472327/ | 07:44 |
| rogpeppe | dimitern: and it might be because of my recent change? | 07:45 |
| dimitern | rogpeppe: I did a git bisect and surprisingly it turned out your PR #5404, commit https://github.com/juju/juju/commit/2a731745eb2bb75f5ed20a887f23d9f198c16259 is the first time it happens | 07:45 |
| rogpeppe | dimitern: interesting | 07:45 |
| dimitern | rogpeppe: surprisingly, because it doesn't seem your PR touched anything near cmd/jujud/agent | 07:46 |
| rogpeppe | dimitern: i don't think i believe that | 07:46 |
| rogpeppe | dimitern: i don't think gce is even linked in to those tests | 07:46 |
| dimitern | rogpeppe: well the only thing that comes to mind is ProviderSchema added in environs/interface.go, but not implemented by the dummy provider? | 07:47 |
| rogpeppe | dimitern: it's just an interface declaration | 07:47 |
| rogpeppe | dimitern: nothing uses it | 07:47 |
| dimitern | rogpeppe: yeah, that's why it's a mystery.. | 07:47 |
| dimitern | rogpeppe: can you try running cmd/jujud/agent$ go test -check.v -check.f MachineSuite.TestDyingModelCleanedUp on master tip and see if it passes? | 07:48 |
| dimitern | might be related to different go versions.. I'm on go1.6.1 linux/amd64 | 07:49 |
| rogpeppe | dimitern: ok, trying that | 07:52 |
| dimitern | rogpeppe: hmmm.. running the test on the only commit of that PR (2a73174) passes, it fails on the merge commit itself :/ (1439ead) | 07:52 |
| davecheney | elmo: i'm right here man | 07:53 |
| davecheney | please wait til i sign off before calling me mesage irellevant :( | 07:53 |
| rogpeppe | davecheney: yo! | 07:54 |
| davecheney | rogpeppe: hey | 07:54 |
| rogpeppe | davecheney: long time no see | 07:54 |
| rogpeppe | davecheney: "see" | 07:54 |
| davecheney | rogpeppe: your mate jeff hodges is looking for you | 07:54 |
| dimitern | davecheney: hey o/ | 07:54 |
| rogpeppe | davecheney: jeff hodges... name rings a bell | 07:54 |
| rogpeppe | davecheney: ah yes | 07:55 |
| davecheney | i think he wants you to make godep do something | 07:55 |
| davecheney | or godeps | 07:55 |
| rogpeppe | davecheney: i need to spend some time on godef | 07:55 |
| davecheney | that's the one | 07:55 |
| rogpeppe | davecheney: the guilt is nagging at me | 07:55 |
| rogpeppe | davecheney: but i've had no time | 07:55 |
| rogpeppe | davecheney: well, i guess i could've not gone for bike rides at the weekend but there are limits :) | 07:56 |
| davecheney | i think you've got your priorties set just right | 07:56 |
| rogpeppe | davecheney: along with all the other stuff i've wanted to do (fix encoding/xml, finish up my errgo proposal doc, rewrite juju etc, etc) | 07:57 |
| rogpeppe | dimitern: i suspect it might be some kind of race issue | 07:58 |
| rogpeppe | dimitern: FWIW i do see that test failing | 07:58 |
| dimitern | rogpeppe: ok, thanks for confirming! | 07:58 |
| dimitern | rogpeppe: it might be quite intermittent and that merge commit just happen to be a false positive, will dig further back | 07:59 |
| rogpeppe | dimitern: FWIW (showdeps -a github.com/juju/juju/cmd/jujud/agent | grep gce) prints nothing | 08:00 |
| rogpeppe | dimitern: i.e. none of the packages i changed in that PR are linked into those tests. | 08:00 |
| davecheney | holy fuck | 08:22 |
| davecheney | mongo failed three of my PR's that I submitted | 08:22 |
| davecheney | what is the story | 08:22 |
| davecheney | why hasn't that bag of shit been taken out behind the woodshed and been shot ? | 08:22 |
| frobware | dimitern: https://bugs.launchpad.net/juju-core/+bug/1581074 | 08:23 |
| mup | Bug #1581074: LXD container interface names don't align with parent interface names <lxd> <network> <juju-core:In Progress by frobware> <https://launchpad.net/bugs/1581074> | 08:23 |
| frobware | dimitern: https://bugs.launchpad.net/juju-core/+bug/1566801 | 08:24 |
| mup | Bug #1566801: LXD containers /etc/network/interfaces as generated by Juju gets overwritten by LXD container start <network> <juju-core:In Progress by frobware> <https://launchpad.net/bugs/1566801> | 08:24 |
| frobware | dimitern: https://github.com/frobware/juju/tree/master-lp1581074 | 08:25 |
| davecheney | fwereade: https://github.com/juju/juju/pull/5415 | 08:47 |
| fwereade | davecheney, LGTM, thanks | 08:49 |
| davecheney | 08:52 | |
| dimitern | voidspace: standup? | 09:01 |
| voidspace | dimitern: morning | 09:01 |
| mattyw | davecheney, morning dave - still up? regarding http://reviews.vapour.ws/r/4850/ ParseUnitTag is different | 09:38 |
| mup | Bug #1582620 opened: juju-upgrade-mondo typo <juju-core:New> <https://launchpad.net/bugs/1582620> | 09:44 |
| babbageclunk | dimitern: Ugh - any way in mongo to find out that a collection is a capped one? | 10:42 |
| dimitern | babbageclunk: I'm sure there is a way, but I don't know off hand | 10:43 |
| dimitern | babbageclunk: IIRC the txn collection is capped | 10:43 |
| babbageclunk | dimitern: certainly the log collections are. I can't see any way to get CollectionInfo in the mgo docs. | 10:54 |
| babbageclunk | dimitern: seems like I'll just have to check the error text - yay! And then guess the right size when I recreate. | 10:54 |
| dimitern | babbageclunk: it seems Collection.Create only returns CollectionInfo | 10:55 |
| babbageclunk | dimitern: I don't want to have to try to intercept the create calls so I can stash the infos somewhere. | 10:56 |
| lazyPower | my new favorite thing: juju debug-log --replay -T > bacon.log | 11:20 |
| lazyPower | you guys/gals are killin it. <3 | 11:21 |
| lazyPower | and if this was always there, i just found it and it feels like my birthday all over again | 11:21 |
| dimitern | lol lazyPower | 11:22 |
| lazyPower | o/ dimitern | 11:23 |
| dimitern | lazyPower: o/ it's always good to hear a happy user with all the issues we dealt with for 2.0 :) | 11:27 |
| lazyPower | its been a schlog, happy to spread the cheer when I can :D | 11:28 |
| lazyPower | I have some questions for you specific to spaces and how we can leverage them in k8s. I'd like to replace flannel with network-spaces in our kubernetes-core bundle. But we're a couple weeks out in terms of planning. I'll poke you in #juju when we're ready - prepare yourself ;) | 11:30 |
| dimitern | lazyPower: k8s ? | 11:31 |
| dimitern | aah :) | 11:31 |
| dimitern | lazyPower: well spaces are well supported mostly on maas, with some support on aws | 11:32 |
| lazyPower | ah right, its similar to storage in the fact its hamstrung by provider support | 11:32 |
| lazyPower | good point | 11:32 |
| lazyPower | welp thats something to think on | 11:37 |
| dimitern | lazyPower: yeah, we plan to add support for spaces to public clouds first, but it will take some time | 11:38 |
| mup | Bug #1582667 opened: i/o timeout when deploying/upgrading charm <juju-core:New> <https://launchpad.net/bugs/1582667> | 11:39 |
| lazyPower | dimitern completely understood. no pressure :) | 12:12 |
| lazyPower | i mean, networking is easy right? | 12:12 |
| lazyPower | said no-one ever | 12:12 |
| dimitern | lazyPower: :D indeed | 12:15 |
| mup | Bug #1582714 opened: worker/resumer: test failure during CI <juju-core:New> <https://launchpad.net/bugs/1582714> | 13:42 |
| mup | Bug #1582731 opened: github.com/juju/juju/state tests time out on centos <blocker> <centos> <ci> <regression> <test-failure> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1582731> | 13:51 |
| mup | Bug #1582731 changed: github.com/juju/juju/state tests time out on centos <blocker> <centos> <ci> <regression> <test-failure> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1582731> | 14:00 |
| mup | Bug #1582731 opened: github.com/juju/juju/state tests time out on centos and windows <centos> <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1582731> | 14:12 |
| katco | natefinch: hey just wanted to say thank you for getting that bug addressed | 14:27 |
| katco | natefinch: i'm sure ian is breathing a sigh of relief :) | 14:27 |
| natefinch | katco: welcome, yeah, I was glad to be able to fix it in a timely manner | 14:28 |
| natefinch | katco: trivial review of the deps change for that? http://reviews.vapour.ws/r/4852/ | 14:49 |
| katco | natefinch: tal | 14:49 |
| katco | natefinch: ship it | 14:49 |
| * perrito666 has sandpaper in his throat | 15:01 | |
| natefinch | perrito666: you should try eating food instead | 15:02 |
| perrito666 | natefinch: nah, I am too hardcore for that | 15:02 |
| perrito666 | I think Ill be making sign language for the next standup | 15:02 |
| mup | Bug #1582714 changed: worker/resumer: test failure during CI <juju-core:New> <https://launchpad.net/bugs/1582714> | 15:22 |
| natefinch | grep -r '"admin"' --include="*.go" . | wc -l | 15:54 |
| natefinch | 231 | 15:54 |
| natefinch | screw dry, I wish we could at least manage something less than soaking wet | 15:54 |
| natefinch | damp? moist? | 15:54 |
| katco | natefinch: now is your chance :) stick it somewhere sane | 15:55 |
| natefinch | katco: yep | 15:55 |
| thumper | histerical raisons | 15:55 |
| thumper | there is a testing.AdminUser | 15:55 |
| natefinch | oh, that's the best part. Half of these are usernames, not model names | 15:56 |
| natefinch | possibly more than half | 15:56 |
| perrito666 | natefinch: same happened with file urls | 15:56 |
| natefinch | I don't know because THEY'RE JUST STRINGS | 15:56 |
| perrito666 | there was a bunch constructed by hand | 15:56 |
| bdx | hows it going everyone? I feel like I'm missing something here ... is there a way around this -> https://github.com/juju/juju/issues/5411 ? | 15:57 |
| natefinch | (╯°□°）╯︵ ┻━┻ | 15:57 |
| * perrito666 touches natefinch with the "well fix it" wand | 15:57 | |
| natefinch | thumper: package testing? | 15:58 |
| perrito666 | bdx: hello, sorry I dont know | 15:58 |
| katco | bdx: we track our bugs on launchpad. here's a dupe with activity: https://bugs.launchpad.net/juju-core/+bug/1571593 | 15:58 |
| perrito666 | dimitern: voidspace any of you is familiar with that error? | 15:58 |
| mup | Bug #1571593: lxd bootstrap fails with unhelpful 'invalid config: no addresses match' <juju-release-support> <lxd-provider> <usability> <juju-core:Triaged> <https://launchpad.net/bugs/1571593> | 15:58 |
| thumper | github.com/juju/juju/testing | 15:58 |
| perrito666 | katco: mm, we should go around closing the ones in gh every now and then | 15:58 |
| katco | perrito666: we try. we need to turn off GH issues completely, but there always seems to be something more important to work on... :( | 15:59 |
| perrito666 | meh, I dont have supercow powers, I cant close the bug | 15:59 |
| perrito666 | I added the link to the lp one in the comments | 15:59 |
| * katco closed the bug | 16:00 | |
| bdx | Oh my bad, I should be filing those in lp huh | 16:00 |
| bdx | oops | 16:00 |
| bdx | thanks | 16:00 |
| katco | bdx: no worries, it's a common mistake. we don't make it clear at all | 16:00 |
| dimitern | perrito666: that's lxd related | 16:00 |
| perrito666 | bdx: it is, I just saw the address part | 16:00 |
| perrito666 | sorry to disturb you :) | 16:01 |
| dimitern | perrito666: it usually means lxdbr0 was misconfigured | 16:01 |
| bdx | perrito666: I'm doing everything I can to not use lxdbr0 | 16:01 |
| bdx | but I guess I should of scouted out the bugs further | 16:02 |
| bdx | shoot | 16:02 |
| bdx | ha | 16:02 |
| bdx | sorry | 16:02 |
| bdx | dimitern, perrito666: is it a bug with lxd then? | 16:04 |
| perrito666 | bdx: not really, there is a previous step to be done but apparently we are not documenting it? | 16:05 |
| perrito666 | bdx: run lxd init | 16:05 |
| perrito666 | and your problem should go away after networking setup | 16:05 |
| bdx | perrito666: yea, I've ran `lxd init` enough to no avail | 16:06 |
| perrito666 | mmm, very strange | 16:06 |
| perrito666 | try dpkg-reconfigure lxd and then restart lxd-bridge service | 16:08 |
| bdx | perrito666: I can bootstrap lxd just fine when using lxdbr0 | 16:08 |
| perrito666 | ah ok, then what do you do | 16:08 |
| perrito666 | to make it fail? | 16:08 |
| bdx | perrito666: any host only bridge works for me ... its when I try to configure lxd to use a bridge on an external interface that it fails | 16:09 |
| perrito666 | mm, my knowledge of lxd does not go that far sorry | 16:09 |
| perrito666 | ericsnow: ^ do you know more about that? | 16:10 |
| bdx | should the issue be raised with lxd then? | 16:10 |
| ericsnow | perrito666: not really; perhaps tych0? | 16:10 |
| perrito666 | ericsnow: he is not here :) | 16:10 |
| natefinch | thumper: sorry, my question was - why is a production value being defined in a testing package? | 16:11 |
| perrito666 | bdx: ill try to summon someone from lxd, otherwise, file the bug with juju since we are the ones that break in that case | 16:11 |
| mup | Bug #1582798 opened: After bootstrapping, juju gui isn't automatically deployed <cpe-sa> <juju-core:New> <https://launchpad.net/bugs/1582798> | 16:13 |
| mup | Bug #1582799 opened: Deploying from the cli api.jujucharms.com is not reachable <cpe-sa> <juju-core:New> <https://launchpad.net/bugs/1582799> | 16:13 |
| babbageclunk | dimitern: I've got the state tests working for mongo3.2 now, except for TestSetAdminPassword. | 16:16 |
| babbageclunk | thumper: ^^ | 16:16 |
| bdx | perrito666: the bug already exists .... its just not very specific to the nature of what actually happens -> https://bugs.launchpad.net/juju-core/+bug/1571593 | 16:16 |
| mup | Bug #1571593: lxd bootstrap fails with unhelpful 'invalid config: no addresses match' <juju-release-support> <lxd-provider> <usability> <juju-core:Triaged> <https://launchpad.net/bugs/1571593> | 16:16 |
| bdx | I'll add in my bits to it | 16:16 |
| dimitern | babbageclunk: awesome! | 16:16 |
| dimitern | babbageclunk: is it as fast as 2.4 ? | 16:16 |
| perrito666 | bdx: the error seems to be the same but they state a different cause | 16:17 |
| perrito666 | could yolu please describe your case in that bug as a follow up? | 16:17 |
| babbageclunk | dimitern, thumper: but this change between 2 and 3 means that I think Initialize will have to work differently: https://docs.mongodb.com/manual/core/security-users/#localhost-exception | 16:17 |
| babbageclunk | dimitern: need to rerun the whole package again now that I've whacked all the moles - hang on. | 16:18 |
| babbageclunk | dimitern: but within a minute of 2.4 definitely. | 16:18 |
| babbageclunk | dimitern: which is better than 100x | 16:19 |
| bdx | perrito666: surely | 16:19 |
| perrito666 | bdx: tx a lot | 16:19 |
| bdx | np | 16:20 |
| bdx | thank you | 16:20 |
| dimitern | babbageclunk: great news then! \o/ | 16:24 |
| babbageclunk | dimitern: But so my final problem: at the moment Initialize connects to localhost without auth and creates the collections and indexes from allCollections(), and then at some point in the future sets an admin password - is that right? | 16:24 |
| dimitern | babbageclunk: AIUI 'some point in the future' is at test(suite?) teardown/reset | 16:25 |
| babbageclunk | dimitern: No, I mean in a real bootstrapped controller. | 16:26 |
| babbageclunk | dimitern: almost all the tests run with auth turned off. | 16:26 |
| dimitern | babbageclunk: ah, so the process goes - bootstrap with generated pwd, then when the controller's jujud agent starts, it resets the admin pwd once | 16:26 |
| babbageclunk | ok - but in state.Initialize it does all of the collection and index creation before that, right? I think the admin password just needs to be done earlier. | 16:28 |
| babbageclunk | dimitern: oh, no - I've found it in agentbootstrap.InitializeState - it's setting the password first, isn't it. Ok, I just need to fix the test then. Sweet! | 16:30 |
| mup | Bug #1582801 opened: Juju debug-log returns error when using during bundle deployment <cpe-sa> <juju-core:New> <https://launchpad.net/bugs/1582801> | 16:43 |
| === Garyx_ is now known as Garyx | ||
| mup | Bug #1582818 opened: SSH Key in MAAS GUI not working <maas> <ssh> <juju-core:New> <https://launchpad.net/bugs/1582818> | 17:25 |
| elmo | davecheney: not sure what you mean; I approved your mail before flushing the queue | 17:44 |
| bdx | perrito666, dimitern: this would explain alot -> https://github.com/juju/juju/blob/master/tools/lxdclient/client.go#L232-233 | 17:58 |
| perrito666 | really? we are checking for eth0? that is quite easy to break | 18:00 |
| perrito666 | bdx: this check might be wrong https://github.com/juju/juju/blob/master/tools/lxdclient/client.go#L241-248 | 18:02 |
| natefinch | quick review anyone? http://reviews.vapour.ws/r/4854/ | 18:07 |
| bdx | yea, yea, I saw the whole part after the comments .... cry cry | 18:08 |
| redir | fwereade: yt? | 18:12 |
| natefinch | perrito666, katco, ericsnow: super easy, I promise: http://reviews.vapour.ws/r/4854/ | 18:13 |
| perrito666 | natefinch: rviewing | 18:14 |
| perrito666 | natefinch: what prompts this change? | 18:15 |
| ericsnow | natefinch: there, that wasn't so bad <wink> | 18:15 |
| natefinch | perrito666: Mark | 18:16 |
| perrito666 | say no more | 18:16 |
| natefinch | ericsnow: yeah, turns out there actually was a constant, it just was hard to find amongst all the other "admin" references | 18:17 |
| perrito666 | natefinch: reviewed | 18:17 |
| natefinch | perrito666: good catch on that comment https://pbs.twimg.com/media/B3qIJLFCcAEJLWm.jpg | 18:23 |
| perrito666 | natefinch: I believe that I lack the etnicity to catch that joke :p | 18:23 |
| tych0 | bdx: ericsnow: i think you have to use lxdbr0 right now | 18:23 |
| natefinch | perrito666: the label says rice, the container contains cookies | 18:24 |
| perrito666 | pass it through the I am southamerican filter | 18:24 |
| tych0 | there's no way to configure it otherwise | 18:24 |
| natefinch | perrito666: it's about comments being out of date | 18:24 |
| perrito666 | natefinch: I assumed they where rice cookies (things that happen when you live with celiac people) | 18:24 |
| perrito666 | by default I suspect of any sort of bakery product not made/bought by me to be rice based :p | 18:26 |
| natefinch | perrito666: fairly uncommon here | 18:30 |
| perrito666 | here, too, unless here==my house | 18:31 |
| mup | Bug #1582841 opened: remove check for lxdbr0 <juju-core:New> <https://launchpad.net/bugs/1582841> | 18:35 |
| bdx | tych0, perrito666, dimitern: I named the bridge on my external interface lxdbr0 .. this tricked juju, and lxd, and got me bootstrapped :-) | 18:44 |
| perrito666 | lol | 18:44 |
| bdx | so simple, so sweet | 18:44 |
| natefinch | just found our 15 month old in an awkward ball, face down in a chair, unresponsive.... turned out he'd just fallen asleep and kind of slumped into a pile. | 18:53 |
| natefinch | and unresponsive only because he was so tired | 18:53 |
| perrito666 | natefinch: and how is your panic attack? | 19:01 |
| natefinch | perrito666: fine once it was established he was sleeping, but geez | 19:07 |
| === redir is now known as redir_lunch | ||
| === redir_lunch is now known as redir | ||
| === admcleod_ is now known as admcleod | ||
| redir | when do I want to return errors.Trace(error) vs. error ? | 20:22 |
| redir | is there a rule of thumb? | 20:22 |
| redir | katco: natefinch ericsnow ^^ | 20:22 |
| katco | redir: .Trace just adds stack information to the underlying object | 20:22 |
| natefinch | redir: basically always trace | 20:22 |
| katco | redir: really not a reason to not use it | 20:22 |
| katco | redir: .Annotate et. al. will do it for you, so you don't need to wrap those in .Trace | 20:23 |
| redir | OK just modifying a func that does both and wasn't sure why. | 20:23 |
| mup | Bug #1582881 opened: destroying a subordinate returns an error but seems to work <juju-core:New> <https://launchpad.net/bugs/1582881> | 20:23 |
| natefinch | redir: probably started being written before we had the errors library | 20:23 |
| katco | redir: probably targeted fixes. .Trace is only ~2y old | 20:23 |
| redir | should I .Trace it in the drive by? | 20:24 |
| natefinch | redir: if it's not too many of them, that's fine. | 20:24 |
| katco | redir: yeah i'd say those are easy to review, so bring the function up to code (no pun intended) | 20:24 |
| * redir nods. just one of three...easy enough. | 20:26 | |
| natefinch | gah, why is it get-model-config and not show-model-config? :/ everything else is show :/ | 20:27 |
| tvansteenburgh | why doesn't `juju block` accept a -m arg? | 20:28 |
| tvansteenburgh | is it an oversight? am i right to assume that the block command does indeed apply to one specific model? | 20:31 |
| natefinch | tvansteenburgh: not sure | 20:31 |
| natefinch | tvansteenburgh: it definitely is per model according to the comments | 20:33 |
| tvansteenburgh | natefinch: okay, thanks | 20:33 |
| natefinch | tvansteenburgh: must be an oversight... I think because it's built as a super command (i.e. juju block destroy-model .. destroy model is a command, not an argument) | 20:34 |
| natefinch | tvansteenburgh: can you file a bug? | 20:37 |
| tvansteenburgh | natefinch: sure thing | 20:37 |
| ericsnow | anastasiamac_: ping | 21:21 |
| anastasiamac_ | ericsnow: o/ | 21:41 |
| anastasiamac_ | ericsnow: m making coffee - 7.40am.. bbiab | 21:43 |
| ericsnow | anastasiamac_: np | 21:43 |
| ericsnow | anastasiamac_: just thinking we may want to postpone our meeting until the syslog stuff is more settled | 21:43 |
| katco | anastasiamac_: was going to suggest the same | 21:54 |
| anastasiamac_ | katco: ericsnow: sounds good \o/ | 21:59 |
| * redir doesn't know about meeting | 21:59 | |
| anastasiamac_ | i'll move the meetings | 21:59 |
| mup | Bug #1582892 changed: `juju block` doesn't accept -m arg <juju-core:Invalid> <https://launchpad.net/bugs/1582892> | 22:00 |
| anastasiamac_ | ericsnow: katco: altho m not convinced that the user stories will actually change :D | 22:00 |
| anastasiamac_ | redir: i'll fill u in during standup | 22:00 |
| ericsnow | anastasiamac_: yeah, probably not :) | 22:00 |
| anastasiamac_ | redir: perrito666: m happy to have a standup earlier if it suits u | 22:00 |
| anastasiamac_ | ericsnow: m still keen to talk to u if u want :D but will move the actual meeting booking | 22:01 |
| perrito666 | anastasiamac_: works for me | 22:01 |
| anastasiamac_ | redir: want to do standup now-ish? | 22:02 |
| redir | anastasiamac_: fine by me, running tests now so I have time | 22:02 |
| redir | :) | 22:02 |
| perrito666 | I am in the room | 22:03 |
| mup | Bug #1582892 opened: `juju block` doesn't accept -m arg <juju-core:Invalid> <https://launchpad.net/bugs/1582892> | 22:03 |
| anastasiamac_ | redir: perrito666: m going to tanzanite now then \o/ | 22:03 |
| mup | Bug #1582799 changed: Deploying from the cli api.jujucharms.com is not reachable <cpe-sa> <juju-core:Invalid> <https://launchpad.net/bugs/1582799> | 22:06 |
| mup | Bug #1582892 changed: `juju block` doesn't accept -m arg <juju-core:Invalid> <https://launchpad.net/bugs/1582892> | 22:06 |
| mup | Bug #1582799 opened: Deploying from the cli api.jujucharms.com is not reachable <cpe-sa> <juju-core:Invalid> <https://launchpad.net/bugs/1582799> | 22:12 |
| mup | Bug #1582799 changed: Deploying from the cli api.jujucharms.com is not reachable <cpe-sa> <juju-core:Invalid> <https://launchpad.net/bugs/1582799> | 22:27 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
