/srv/irclogs.ubuntu.com/2016/05/23/#juju-dev.txt

davecheneyoh this fslock class01:48
davecheneyfunc (r *Reboot) checkForRebootState() error {01:48
davecheney        if r.machineLock.IsLocked() == false {01:48
davecheney                return nil01:48
davecheney        }01:48
davecheneyanother fun part is the way the reboot worked lets you provide it with a lock ...01:49
natefinchyeah, the fslock code is only half the problem, the other half is how the rest of the code is abusing it01:49
natefinchis there a trick to bootstrapping maas in 2.0?02:21
natefinch$ ./juju bootstrap maas maas --upload-tools02:21
natefinchERROR detecting credentials for "maas" cloud provider: credentials not found02:21
natefinch$ ./juju add-credential maas02:21
natefinchERROR cloud maas not valid02:21
rick_h_natefinch: I think it's the whole $maas/$IP thing that got added in02:21
natefinchrick_h_: I don't even see maas in juju list-clouds... is there help for this somewhere?02:22
rick_h_natefinch: in the release notes02:22
natefinchrick_h_: people who commit new functionality without proper help in the CLI make hulk angry02:24
anastasiamac_natefinch: i think u ned to add cloud of type maas first, then bootstrap it \o/02:25
natefinchug, this is a poor UX02:37
natefinch"MAAS works out of the box"   "Bootstrapping models using ... MAAS ... providers also Just Work"  ....lol no02:39
natefinchunless we have drastically different ideas of what "Just works" means.02:39
natefincha little ways down "For MAAS and OpenStack clouds, it's necessary to edit a clouds.yaml file."... ahh, ok.  Maybe we should remove the "just works" BS from mentioning MAAS?02:45
davecheneygreat, the worker/uniter test _require_ that BreakLock _always_ breaks the lock02:47
natefinch:wq02:52
natefinchheh02:52
davecheneyhmm, or maybe they don't pass at all02:53
davecheneynope, they just don't pass at all02:56
natefinchnice02:56
natefinchdavecheney: I do have a new fslock library mostly written.  I got stuck with an error message on windows having to do with overlapped IO, which is required to do the timeout in a non-terrible way... but since the linux code is already doing the timeout in a semi-terrible way, I could easily do windows the same way and have it read to go pretty quickly (or I could spend some time figuring out the windows error)02:58
natefinchdavecheney: I didn't look too carefully at what it would take to rip out all the garbage from juju's code that requires breaklock etc, however02:58
mupBug #1584565 opened: Documentation regarding user management is out of date <juju-core:New> <https://launchpad.net/bugs/1584565>03:01
natefinchdavecheney: there also appeared to be some BS About storing a message in the file and then reading the message to determine who had the lock, which I also assumed was just a Bad Idea, and therefore would probably not be hurt by just being ripped out.03:02
davecheneythat is a monsterous idea03:02
davecheneyit's not concurrency safe03:02
davecheneylock.ReadMessage() => "stale message"03:03
natefinchyawp03:03
davecheneyif you make a decision based on that data, that's a mistake03:03
natefinchit's possible it was only something as innocuous as a log message, still bad, but not fatal03:03
davecheneymaybe that's a way to approach it03:03
davecheneyremove the Message() method03:04
davecheneythat might give a more tractable hold on removing BreakLock03:04
natefinchdavecheney: https://github.com/juju/juju/blob/master/worker/uniter/uniter.go#L39403:05
davecheneystop, you'll make me cry03:11
natefinchand actually... anywhere at all that calls lock or lock with timeout or lock with func.... https://github.com/juju/utils/blob/master/fslock/fslock.go#L27903:12
natefinchwhich at least is apparently just for logging03:13
natefinchgah, what I wouldn't give for a dedicated maas environment that I could test on.03:42
davecheneygreat, c.Logf, doesn't log anything03:50
natefinchdon't you need either a failure or -checl.vv or something to get those to show up?03:52
natefinchthis is why I just use fmt.printf, because that just works03:53
natefinch(for debugging, obv)03:54
natefinchbedtime for me03:56
davecheneythanks, that worked03:59
davecheneythat's stupid03:59
davecheneyi want log output03:59
davecheneyi don't want to debug gocheck03:59
davecheneywhich is what -vv does03:59
davecheneyhttp://reviews.vapour.ws/r/4881/04:26
mupBug #1584616 opened: mtu configuration should not be moved to bridge interface <juju-core:New> <https://launchpad.net/bugs/1584616>07:08
mupBug #1584616 changed: mtu configuration should not be moved to bridge interface <juju-core:New> <https://launchpad.net/bugs/1584616>07:35
mupBug #1584626 opened: cmd/jujud/agent: MachineSuite.TestDyingModelCleanup is flaky and unreliable <intermittent-failure> <test-failure> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1584626>08:05
dimiternbabbageclunk: morning :) can you have a second look on http://reviews.vapour.ws/r/4871/ please?08:49
babbageclunkdimitern: sure! Looking now.08:50
dimiternbabbageclunk: ta!08:50
voidspacedimitern: http://reviews.vapour.ws/r/4874/09:17
frobwarevoidspace: did you want to chat. 1:1?09:48
voidspacefrobware: I need coffee!09:48
voidspacefrobware: anything you want to chat about?09:49
frobwarevoidspace: ok. top of the houor?09:49
frobwarehour09:49
voidspacesure09:49
dimiternbabbageclunk: the whole point of having "preferred" addresses is that once set, they cannot change (unless they get removed, then another "sticky" preferred will be picked)13:35
dimiternbabbageclunk: PrivateAddress() and PublicAddress() prefer to return IPv4 addresses if available, falling back to IPv6 otherwise (if any), finally returning NoAddressError13:36
babbageclunkdimitern: It seems like those are at odds - if a machine gets an IPv6 address first, and then later gets an IPv4 address, won't its preferred address change?13:37
dimiternbabbageclunk: AIUI your suggestion, it's about adding a PreferredPrivateAddress []address on machineDoc containing up to 2 addresses (1 for each type)13:38
babbageclunkdimitern: Yes, that's what I meant.13:38
dimiternbabbageclunk: well, the preferred addresses will settle long before the machine agent actually starts (or state transitions to started from pending), so no workloads will be running13:39
babbageclunkdimitern: ok, fair enough.13:39
dimiternbabbageclunk: that specific issue deals with racy DHCPv4 vs DHCPv6 in the lxd provider (either one can come first, but eventually we'd like to use IPv4 as preferred private/public)13:40
dimiternbabbageclunk: however, your suggestions make a lot of sense now that I'm looking at the implementation..13:40
babbageclunkdimitern: Sure, but I still don't understand why you can't implement the fallback logic on top of the addresses being stored in []address13:40
babbageclunkdimitern: Ok13:41
babbageclunkdimitern: :)13:41
dimiternbabbageclunk: so I'd try to use a slice of addresses or perhaps a map[type]address13:41
dimiternbabbageclunk: it might even work better at the end :)13:41
babbageclunkdimitern: yeah, I could see wanting a map instead - I wasn't sure about that.13:42
babbageclunkdimitern: The reason I didn't suggest that was that it's probably worse space and time wise with only two entries.13:43
babbageclunkdimitern: But it also makes the code a bit simpler, so maybe still worth it.13:43
dimiternbabbageclunk: I doubt it makes much difference - one is a nested doc the other is a nested array13:44
dimiternbabbageclunk: yeah13:44
=== babbageclunk is now known as babbageclunk|afk
mupBug #1584805 opened: Timeout in github.com/juju/juju/apiserver/service on windows <ci> <regression> <test-failure> <timeout> <unit-tests> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1584805>14:51
mupBug #1584815 opened: SSHSuite.TestSSHCommand fails on windows <ci> <regression> <test-failure> <unit-tests> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1584815>14:51
hoenirwho broke the upstream?15:03
hoenirhttp://paste.ubuntu.com/16633838/15:04
katcodooferlad: hey, are you feeling better/back yet?15:13
dooferladkatco: not really15:14
dooferladkatco: just catching up on email between sleeps15:14
* dooferlad had the flu15:14
katcodooferlad: ouch, i'm sorry to hear that :( i hope you feel better :(15:14
* dooferlad has a body that still doesn't work15:14
* katco understands15:14
mupBug #1576313 changed: windows: uniter tests fail because logs get dumped to stderr <ci> <regression> <test-failure> <windows> <juju-ci-tools:Triaged> <juju-core:Fix Released by bteleaga> <https://launchpad.net/bugs/1576313>15:21
mupBug #1584832 opened: payloads are not cleaned up when units are destroyed <juju-core:Triaged> <https://launchpad.net/bugs/1584832>15:21
=== babbageclunk|afk is now known as babbageclunk
babbageclunkdimitern, voidspace: sorry guys, I can't make the networking knowledge share this week - I have to get home to help with the baby.15:52
voidspacebabbageclunk: ok15:52
mupBug #1582798 changed: After bootstrapping, juju gui isn't automatically deployed <cpe-sa> <juju-core:Invalid> <https://launchpad.net/bugs/1582798>15:58
dooferladdimitern, voidspace, babbageclunk, frobware: is the networking call on?16:00
dimiterndooferlad, voidspace, frobware: omw, sorry - 2m16:04
voidspacealexisb: ping16:46
alexisbvoidspace, ping16:47
alexisbpong16:47
perrito666ah solo pingpong game16:47
=== redir_afk is now known as redir
lazyPowerThats when you know you're dealing with a pro16:54
natefinchlazyPower: http://i.imgur.com/A6VxL6d.gif16:56
lazyPowerit always comes back ot this for me https://www.youtube.com/watch?v=qHe6vhexm6g16:57
natefinchlazyPower: holy crap, is that real?16:58
lazyPowervery much so16:58
natefinchhmm... comments say it's an ad for a nokia phone16:59
lazyPowerdont take this away from me natefinch17:00
lazyPower;_;17:00
natefinchlol sorry17:01
katconatefinch: hey don't forget to flag that bug as incomplete if you can't repro17:36
mupBug # opened: 1584896, 1584897, 1584899, 1584900, 1584901, 1584903, 1584905, 158490618:04
* fwereade could use a review of http://reviews.vapour.ws/r/4873/ if anyone has some time18:06
perrito6664 pages?18:09
rick_h_katco: ping, did we end up with a download % indicator in the resources output?18:17
katcorick_h_: no i believe we deferred that. let me 2x check18:17
rick_h_katco: ty18:17
perrito666fwereade: I +1 but I want another set of eyes there18:19
katcorick_h_: yeah, we deferred. see your comment on the resource spec... last comment in the first thread in the doc18:24
katcorick_h_: (if that's not too confusing)18:24
rick_h_katco: rgr ty18:26
natefinchericsnow: why only alphanumerics and dashes for payload class?  Why only ascii?19:01
ericsnownatefinch: starting as minimal as possible; we can broaden it later19:01
perrito666I feel discriminated, I want "El Pailoád"19:01
fwereadeperrito666, thanks, appreciated19:02
perrito666fwereade: in principle, as you said, these seem like almost mechanical changes19:03
fwereadeperrito666, you have no idea how hard it was to keep it mechanical, but I think I really did19:03
fwereadeperrito666, the one change was to TestDyingModelCleanedUp and I think I called it out explicitly19:04
perrito666you did19:04
fwereadeperrito666, ok, cool -- and you're happy with the sanity of the high-level changes? that's the really important thing ;)19:05
perrito666fwereade: I am, I also celebrate that we have one thing less called test*19:05
fwereadeperrito666, cool, thanks :)19:06
cheryljnatefinch: are you still looking into bug 1537585?19:16
mupBug #1537585: machine agent failed to register IP addresses, borks agent <2.0-count> <blocker> <landscape> <network> <juju-core:Triaged by natefinch> <juju-core 1.25:Triaged by natefinch> <https://launchpad.net/bugs/1537585>19:16
katcocherylj: yes he is19:17
cheryljcool beans19:17
cheryljthanks, katco19:17
katconatefinch: you never responded to me... this ^^^ is why i asked you to mark the bug incomplete :)19:17
katcocherylj: np... fyi he's working with the landscape team because he can't repro19:17
natefinchkatco: crud, sorry, missed that somehow19:17
katconatefinch: no worries, i knew cherylj would come poking around ;)19:18
cheryljheh19:18
katconatefinch: maybe add a comment to that affect too19:18
* cherylj grabs her poking stick19:18
cheryljyeah, comments good19:18
* katco puts on her nerd mask19:18
natefinchkatco: that's no mask! ;)19:19
katcolol19:19
=== rogpeppe3 is now known as rogpeppe
natefinchericsnow: left a comment on the names.ValidatePayload review... I don't really see why we need to limit people to such a limited set of characters.  If there's a technical reason, then sure, but I would hope there's not, other than maybe some delimiter somewhere.19:50
ericsnownatefinch: why do we do it for all the other tags?19:51
* perrito666 sees tags a people in the same sentence and smells something weird19:51
natefinchericsnow: no idea19:51
natefinchericsnow: misplaced paternalistic instinct?19:52
natefinchericsnow: eurocentric standards of beauty? :)  Maybe ask fwereade.  Sounds like something someone Decided™ at some point.19:59
perrito666natefinch: is that limitation for tags?20:00
natefinchperrito666: yes20:00
perrito666tags hasve nothing to do with users, users talk in names20:01
natefinchperrito666: I hate our naming system :/20:02
perrito666a user will never ever see a tag20:02
perrito666if you check names for units there is a whole conversion of names to tags removing invalid chars20:02
natefinchperrito666: double checked the code, this is the20:05
natefinchperrito666: the  user-facing name, I think20:05
ericsnownatefinch: correct; it's the "ID"20:05
perrito666then there is no reason as long as you can encode whatever you have into a tag name20:06
perrito666(that might be the origin of the limitation btw)20:06
ericsnownatefinch: currently the only rationale I have for restricting the ID is that making it more restrictive later has a substantially higher cost that making it less restrictive later20:09
natefinchericsnow: are the tags for payloads new?  I don't see payloadtag in master20:09
ericsnownatefinch: no, I believe you added them last year20:10
perrito666natefinch: I have them inmaster20:10
natefinchericsnow: my reading skills just suck, evidently :)20:11
perrito666bbl, since I need to talk to some downunders if they show up today :)20:15
natefinchperrito666: anyone at the sprint will not be here today20:16
natefinchperrito666: even thought today is tomorrow for them20:16
perrito666you are so underestimating the workoholism of some people20:16
natefinchhmm, good point, Ian may be one20:17
natefinchon20:17
natefinchericsnow: I don't know... the id-tag-payloadclass thing still confuses the hell out of me.20:17
natefinchericsnow: as you said, it's easy to expand later20:18
perrito666beware of expanding names later20:18
perrito666you might end up having clashes after sanitization20:18
natefinchhave I mentioned I hate our naming system?  We have a real "let's encode way too much information into an ID" problem20:19
ericsnownatefinch: how strongly do you feel about that "payloadClass" const?  (I'd rather leave it)20:29
redirthere's only 2 things that are hard in computer science20:30
redircache invalidation, naming things, and off by 1 errors20:31
natefinchericsnow: meh... seems extraneous... but why not put ^ $ in the constant?20:44
ericsnownatefinch: habit I guess; often snippets like that are re-usable if you leave the ^ $ off20:47
natefinchericsnow: heh, I try to avoid using regexes in the first place ;)  Sure, that's fine.20:48
ericsnownatefinch: k, thanks :)20:48
thumperfwereade: sorry I missed our call this morning20:50
perrito666Thumper hey dunno if you are working today, but if so, could you see my answers In the acl doc to make sure stuff hasn't changed since the creation of that spec?20:59
thumperperrito666: I am, but I have quite a list ...20:59
perrito666I can put up a good impression of shreck's cat look :p21:02
fwereadethumper, haha, sorry so did I21:17
fwereadethumper, didn't quite expect you back and recovered, but I guess it's tuesday for you21:17
alexisbthumper, ping21:29
anastasiamac_is there something wrong with laning bot? I've asked it to merge my stuff 17mins ago and it did not respond :D21:47
anastasiamac_landing*21:47
davecheneylaunchpad is having problems21:57
davecheneyi just had a build fail because the launchpad.com/tomb package was 50321:57
katcodavecheney: we should look to migrate to the new version which i believe is hosted on github22:00
alexisbthumper, I am on our 1x1 HO when you are ready to join22:19
=== \b is now known as Guest49310
=== wwitzel3_ is now known as wwitzel3
wallyworldanastasiamac_: axw: perrito666: otp, running a bit late23:14
anastasiamac_wallyworld: perfect.. just spilled hot drink so love this xtra time to clean up.. ping when ready23:16
mupBug #1584979 opened: better container networking <juju-core:New> <https://launchpad.net/bugs/1584979>23:23
wallyworldaxw: anastasiamac_: in standup now23:38
davecheneykatco: yup, v1 and v2 are verys imilar23:48
davecheneyv2 has one extra method which we can ignore23:48

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!