thumper | ugh | 00:00 |
---|---|---|
thumper | how about we just fix the tests to not suck? | 00:00 |
=== rodlogic is now known as Guest47601 | ||
davecheney | thumper: http://reviews.vapour.ws/r/4920/ | 00:05 |
davecheney | review pls ? kai thx | 00:05 |
* thumper looks | 00:05 | |
anastasiamac | davecheney: morning \o/ r u working on bug 1586244? shall i mark it as in progress? | 00:54 |
mup | Bug #1586244: state: DATA RACE in watcher <2.0-count> <race-condition> <juju-core:New for dave-cheney> <https://launchpad.net/bugs/1586244> | 00:54 |
=== rodlogic is now known as Guest22370 | ||
axw | wallyworld: lol, 42 pages of diff | 01:19 |
axw | 840 files changed | 01:19 |
wallyworld | oh jeez | 01:19 |
wallyworld | i didn't look | 01:19 |
anastasiamac | \o/ | 01:19 |
wallyworld | didn't realise we had that many juju/name imports | 01:20 |
mup | Bug #1581966 changed: controller node need to be restart for comissionning new nodes or lxc .. <cpe-sa> <orange-box> <juju-core:Invalid> <https://launchpad.net/bugs/1581966> | 01:26 |
davecheney | anastasiamac: i had a look at it on friday | 01:30 |
davecheney | its not a simple bug to fix | 01:30 |
davecheney | but i believe it is restricted to tests only | 01:31 |
davecheney | because they mutate the results they get back from the state watcher | 01:31 |
davecheney | which the contract for Get says they must not | 01:31 |
anastasiamac | k. i marked as triaged and unassigned from u (until the time when u or someone else can pick it up). tyvm :D | 01:32 |
davecheney | np | 01:34 |
axw | wallyworld: reviewed | 01:37 |
wallyworld | ty and sorry | 01:37 |
wallyworld | axw: yeah, i forgot about the global key prefix, sigh another 1000000 files affected in the next branch | 01:40 |
mup | Bug # changed: 1482015, 1518131, 1540650, 1575469, 1577939, 1585300 | 01:56 |
davecheney | thumper: ping | 02:01 |
thumper | hey | 02:01 |
thumper | coming | 02:01 |
davecheney | np | 02:01 |
axw | menn0: you didn't make any changes to do with known_hosts at bootstrap time did you? still getting WARNING at bootstrap | 02:36 |
menn0 | axw: no I didn't do that. I created bug 1579593 to track that. | 02:37 |
mup | Bug #1579593: SSH host keys for bootstrap aren't checked <security> <juju-core:Triaged> <https://launchpad.net/bugs/1579593> | 02:37 |
axw | menn0: cool, thanks | 02:37 |
mup | Bug #1586880 opened: provider/lxd: instance names are overly long <blocker> <juju-core:Triaged> <https://launchpad.net/bugs/1586880> | 02:53 |
=== axw_ is now known as axw | ||
axw | wallyworld: can you PTAL at http://reviews.vapour.ws/r/4919/ | 04:05 |
wallyworld | sure | 04:05 |
mup | Bug #1586890 opened: Cloud/credentials details should be stored in state separate from model config <juju-core:Triaged> <https://launchpad.net/bugs/1586890> | 04:38 |
mup | Bug #1586891 opened: There is no command for removing clouds <blocker> <juju-core:In Progress by axwalk> <https://launchpad.net/bugs/1586891> | 04:38 |
=== rodlogic is now known as Guest26740 | ||
=== rodlogic is now known as Guest56639 | ||
=== rodlogic is now known as Guest13760 | ||
=== frankban|afk is now known as frankban | ||
dimitern | frobware: pinh | 07:29 |
dimitern | ping even | 07:29 |
mup | Bug #1578376 changed: Cannot add MAAS credentials through juju add-credential <juju-release-support> <maas-provider> <usability> <juju-core:Invalid> <https://launchpad.net/bugs/1578376> | 11:33 |
perrito666 | morning to those of you not on holidays | 16:21 |
=== frankban is now known as frankban|afk | ||
=== rodlogic is now known as Guest93573 | ||
thumper | fwereade: ping | 20:06 |
fwereade | thumper, joining | 20:07 |
thumper | kk | 20:07 |
=== rodlogic is now known as Guest37610 | ||
=== rogpeppe1 is now known as rogpeppe | ||
=== rodlogic is now known as Guest84043 | ||
thumper | holy moley I think I'm done... | 22:51 |
* thumper runs tests again | 22:51 | |
thumper | I am still finding issues with a few tests | 22:51 |
thumper | but I think at least one of them has a fix from davecheney racy | 22:52 |
thumper | is the reboot package still intermittently failing for others? | 22:52 |
* thumper should pull master and update | 22:52 | |
wallyworld | perrito666: could you please eyeball this mechanical change and +1 https://github.com/juju/charmrepo/pull/95 | 23:03 |
perrito666 | sure | 23:03 |
perrito666 | wallyworld: done, looks good, ship it | 23:05 |
wallyworld | ty | 23:05 |
perrito666 | their bot accepts a squirrel as parameter, we need that | 23:07 |
perrito666 | like now | 23:07 |
davecheney | perrito666: 🐘 for not lgtm | 23:09 |
davecheney | 😭 for really not lgtm | 23:09 |
davecheney | 💣 for LGTM and we'll fix the review comments in the next PR | 23:10 |
davecheney | (i hope the emomji is coming through) | 23:10 |
perrito666 | they are, but my chat client is using the standart-ish unicode ones | 23:10 |
perrito666 | which are not all that nice | 23:11 |
perrito666 | it is amazing how those things are actually googleable | 23:11 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!