[00:00] ugh [00:00] how about we just fix the tests to not suck? === rodlogic is now known as Guest47601 [00:05] thumper: http://reviews.vapour.ws/r/4920/ [00:05] review pls ? kai thx [00:05] * thumper looks [00:54] davecheney: morning \o/ r u working on bug 1586244? shall i mark it as in progress? [00:54] Bug #1586244: state: DATA RACE in watcher <2.0-count> === rodlogic is now known as Guest22370 [01:19] wallyworld: lol, 42 pages of diff [01:19] 840 files changed [01:19] oh jeez [01:19] i didn't look [01:19] \o/ [01:20] didn't realise we had that many juju/name imports [01:26] Bug #1581966 changed: controller node need to be restart for comissionning new nodes or lxc .. [01:30] anastasiamac: i had a look at it on friday [01:30] its not a simple bug to fix [01:31] but i believe it is restricted to tests only [01:31] because they mutate the results they get back from the state watcher [01:31] which the contract for Get says they must not [01:32] k. i marked as triaged and unassigned from u (until the time when u or someone else can pick it up). tyvm :D [01:34] np [01:37] wallyworld: reviewed [01:37] ty and sorry [01:40] axw: yeah, i forgot about the global key prefix, sigh another 1000000 files affected in the next branch [01:56] Bug # changed: 1482015, 1518131, 1540650, 1575469, 1577939, 1585300 [02:01] thumper: ping [02:01] hey [02:01] coming [02:01] np [02:36] menn0: you didn't make any changes to do with known_hosts at bootstrap time did you? still getting WARNING at bootstrap [02:37] axw: no I didn't do that. I created bug 1579593 to track that. [02:37] Bug #1579593: SSH host keys for bootstrap aren't checked [02:37] menn0: cool, thanks [02:53] Bug #1586880 opened: provider/lxd: instance names are overly long === axw_ is now known as axw [04:05] wallyworld: can you PTAL at http://reviews.vapour.ws/r/4919/ [04:05] sure [04:38] Bug #1586890 opened: Cloud/credentials details should be stored in state separate from model config [04:38] Bug #1586891 opened: There is no command for removing clouds === rodlogic is now known as Guest26740 === rodlogic is now known as Guest56639 === rodlogic is now known as Guest13760 === frankban|afk is now known as frankban [07:29] frobware: pinh [07:29] ping even [11:33] Bug #1578376 changed: Cannot add MAAS credentials through juju add-credential [16:21] morning to those of you not on holidays === frankban is now known as frankban|afk === rodlogic is now known as Guest93573 [20:06] fwereade: ping [20:07] thumper, joining [20:07] kk === rodlogic is now known as Guest37610 === rogpeppe1 is now known as rogpeppe === rodlogic is now known as Guest84043 [22:51] holy moley I think I'm done... [22:51] * thumper runs tests again [22:51] I am still finding issues with a few tests [22:52] but I think at least one of them has a fix from davecheney racy [22:52] is the reboot package still intermittently failing for others? [22:52] * thumper should pull master and update [23:03] perrito666: could you please eyeball this mechanical change and +1 https://github.com/juju/charmrepo/pull/95 [23:03] sure [23:05] wallyworld: done, looks good, ship it [23:05] ty [23:07] their bot accepts a squirrel as parameter, we need that [23:07] like now [23:09] perrito666: 🐘 for not lgtm [23:09] 😭 for really not lgtm [23:10] 💣 for LGTM and we'll fix the review comments in the next PR [23:10] (i hope the emomji is coming through) [23:10] they are, but my chat client is using the standart-ish unicode ones [23:11] which are not all that nice [23:11] it is amazing how those things are actually googleable