larsks | smoser: I think there is a bug in how growpart calls partx, and now partx has better error checking and blows up (see https://bugzilla.redhat.com/show_bug.cgi?id=1327337) | 15:59 |
---|---|---|
larsks | I am going to submit a fix on launchpad. | 15:59 |
smoser | larsks, so partx changed interface ? | 16:02 |
smoser | oh. i see your last comment there. | 16:02 |
larsks | I don't think so. I think the previuos command invocation was actually incorrect, based on my reading of the man page (even for earlier versions). | 16:02 |
larsks | I think it worked because of luck. | 16:02 |
smoser | well, not complete luck | 16:02 |
smoser | definitely it would have paid attention to the '1' in that call | 16:03 |
larsks | The man page says either "partx disk" or "partx partition [disk]", neither of which is what growpart is doing. | 16:03 |
smoser | previously, or growing growing a partition other than '1' would fail. | 16:03 |
larsks | The examples in the man page suggest either "partx --update /dev/vda1" or "partix --update --nr 1 /dev/vda" would be correct | 16:04 |
smoser | that is wierd. i agree. | 16:04 |
smoser | but it definitely does work. | 16:04 |
smoser | for lots of things | 16:04 |
larsks | Oh yeah, totally :) | 16:04 |
larsks | Heck, now I am extra confused... | 16:10 |
larsks | ...because looking at the sources we appear to be calling $part $dev, which should be fine. Ugh, maybe I misread some output somewhere? | 16:10 |
* larsks puts on his paying-attention glasses and checks again. | 16:11 | |
larsks | smoser: okay, patch submitted in lp. | 16:28 |
smoser | link ? | 16:31 |
smoser | larsks, i'm *that* lazy | 16:31 |
larsks | https://bugs.launchpad.net/cloud-utils/+bug/1587971 | 16:32 |
larsks | It's a...(counts)...5 character change. | 16:32 |
harlowja | smoser merge that stuff today righththtttttt | 17:09 |
harlowja | lol | 17:09 |
harlowja | (not joking, ha) | 17:10 |
smoser | harlowja, bzr+ssh://bazaar.launchpad.net/~smoser/cloud-init/trunk.fix-networking/ | 17:10 |
smoser | er.. | 17:10 |
smoser | https://code.launchpad.net/~smoser/cloud-init/trunk.fix-networking/ | 17:10 |
harlowja | whats that | 17:10 |
smoser | that is what i'm working on | 17:10 |
smoser | that has to et in | 17:10 |
harlowja | u broke stuff | 17:10 |
smoser | that fixes (soon) openstack config drive | 17:10 |
harlowja | kk | 17:11 |
harlowja | will look at | 17:11 |
harlowja | whats up with the renaming code? | 17:20 |
harlowja | does that run everytime cloud-init is ran? | 17:21 |
harlowja | that's the only part that seems to concern me :-/ | 17:23 |
smoser | harlowja, yeah, i know. its scary | 17:23 |
harlowja | didn't think that doing `ip set ` was a permeant change | 17:23 |
smoser | so yes. it runs every time. | 17:24 |
harlowja | :-/ | 17:24 |
harlowja | scary | 17:24 |
smoser | it has to because of 2 things | 17:24 |
smoser | a.) initramfs is out of date with respect to /etc/systemd/network/*.link files | 17:25 |
smoser | this is the case in any fresh instance as the initramfs that booted is either pristine or out of date | 17:25 |
smoser | b.) lxc container | 17:25 |
harlowja | doesn't everyone use initramfs, i didn't think say centos did and such | 17:26 |
smoser | there are no udev events in a container, so the systemd .link files do not get applied | 17:26 |
harlowja | *does everyone | 17:26 |
smoser | i'd suspect most things use an initramfs. | 17:26 |
harlowja | ah, just the normal initramfs, nothing special to cloudinit | 17:26 |
smoser | its possible they do nto in cloud images (where you could feasibly have a 'virtual' kernel that had block device drivers built in for all targetted root devices | 17:27 |
smoser | ) | 17:27 |
smoser | but even then, that means you can't boot with UUID= | 17:27 |
smoser | or LABEL= | 17:27 |
smoser | as its the initramfs that figures that part out | 17:27 |
harlowja | gotcha | 17:27 |
smoser | the reason that initramfs-out-of-date is a problem | 17:27 |
smoser | is because systemd .link refuses to rename devices that have been renamed | 17:28 |
harlowja | lol | 17:28 |
smoser | and the initramfs will not have any rules and rename 'eth0' to 'en1p2' or whatever the default is | 17:28 |
smoser | its kind of obnoxious really. | 17:28 |
harlowja | ya, seems like it | 17:28 |
smoser | smoser: please rename the device 'a' to 'b' | 17:29 |
smoser | systemd: ok, that sounds great. device 'a' is now 'b' | 17:29 |
smoser | smoser: please rename the device 'b' to 'c' | 17:29 |
harlowja | no soup for u | 17:29 |
harlowja | lol | 17:29 |
smoser | systemd: sorry, smoser, you need to think ahead more or update your initramfs and reboot | 17:29 |
harlowja | ya, that's stupid | 17:29 |
harlowja | lol | 17:29 |
smoser | harlowja, it wont run though if networking is disbled in cloud-init though | 17:30 |
smoser | so if user wants cloud-init out of the picture, they can disable networking (via cloud-config) and get that. | 17:30 |
smoser | on subsequent boots | 17:30 |
harlowja | ya, weird stuff, lol | 17:31 |
harlowja | i wonder if at some point we can just have the underlying system (sysconfig for example) have the right names in the first place | 17:34 |
harlowja | cause from my understanding sysconfig files have a name 'DEVICE=X' and `HWADDR` fields | 17:35 |
harlowja | so whats the point of renaming stuff if those 2 are right (but maybe i not understand something here, ha) | 17:35 |
harlowja | so in sysconfig land, is the renaming needed(?) | 17:36 |
smoser | so the renaming is to support when the datasource declares the names | 17:38 |
smoser | mgagne pointed out that in openstack currently they dont raelly declare the nic name. (id actually is the host nic's name :) | 17:38 |
harlowja | ya, good point, its crap like 'tap-blahblah' or ... | 17:39 |
harlowja | not eth0 or ethX | 17:39 |
smoser | but on other systems such as smartos and possibly in the future on openstack, the datasource (or even user) would like to declare the names for their nics | 17:39 |
smoser | internal0 | 17:39 |
smoser | or | 17:39 |
smoser | external0 | 17:39 |
smoser | to mean obviously useful things. | 17:39 |
harlowja | ya | 17:40 |
harlowja | is anyone in openstack (nova) land fixing the names of these things? | 17:40 |
* harlowja not it | 17:40 | |
harlowja | lol | 17:40 |
harlowja | to not have host nic junk names | 17:41 |
smoser | its not bad, they're just 'ids'. which is fine. they could be uuids | 17:42 |
smoser | but conceivably a user would quite possibly want to attach a nic to a system and provide the name that they'd like that thing to appear as. | 17:42 |
harlowja | sure, i guess, i like mine called eth0-pink-bunny | 17:43 |
harlowja | lol | 17:43 |
mgagne | I'm planning on opening a bug/change for that bad behavior | 17:43 |
harlowja | cool | 17:44 |
harlowja | smoser only think i can think of is to add more informational logging about what is about to be renamed (and not just the errors that may have resulted from the act of renaming/figuring out what to rename) | 17:50 |
smoser | harlowja, yeah, i'm working on that. | 17:50 |
harlowja | kk | 17:50 |
smoser | it is even more fun now in container | 17:50 |
smoser | than i thought | 17:50 |
harlowja | :-/ | 17:50 |
smoser | https://github.com/lxc/lxd/issues/2063 | 17:50 |
harlowja | is smartos going to use cloudinit now? | 17:50 |
smoser | you can't rename a nic that is up | 17:50 |
harlowja | now there own cloudinit | 17:50 |
harlowja | *not there own | 17:50 |
smoser | ubuntu on smartos (guests) have cloud-init | 17:51 |
harlowja | k | 17:51 |
smoser | since you can't rename a nic that is up | 17:51 |
smoser | and nics in containers *start* as up | 17:51 |
harlowja | 'why is my network device 'up' when nothing in my init system has configured it so' | 17:51 |
harlowja | lol | 17:51 |
harlowja | well that shit be weird | 17:52 |
smoser | so now i'm re-working that to allow for downing internfaces | 17:52 |
harlowja | lol | 17:52 |
mgagne | https://bugs.launchpad.net/nova/+bug/1588017 | 17:52 |
smoser | so it will be able to down it if it does not have any "real" addresses | 17:52 |
smoser | mgagne, interesting... | 17:53 |
harlowja | mgagne thx | 17:53 |
smoser | from the guests perspective, it shoudl be physical always | 17:53 |
mgagne | that's not what the spec mentions | 17:53 |
mgagne | either we respect spec or we propose an amendment and wait for it to merge before changing implementation details | 17:53 |
smoser | where do you see this ? | 17:54 |
mgagne | in the spec... | 17:54 |
smoser | i see only a single occurance of the word 'virtual' | 17:54 |
smoser | at http://specs.openstack.org/openstack/nova-specs/specs/liberty/implemented/metadata-service-network-info.html#rest-api-impact | 17:54 |
mgagne | Example of VIF | 17:54 |
mgagne | otherwise I don't know what the purpose of vif would be | 17:55 |
harlowja | ya, only think i can think of is for ironic, but idk | 18:15 |
harlowja | ironic though is different | 18:15 |
harlowja | smoser i guess otherwise, now that i understand that renaming stuff that fix looks ok | 18:38 |
harlowja | i can work it into the refactor i had when u merge it | 18:38 |
harlowja | smoser in ' def update_byname(bymac): | 21:43 |
harlowja | return {data['name']: data for data in bymac.values()}' | 21:43 |
harlowja | that no worky on py26 | 21:43 |
harlowja | just fyi | 21:44 |
harlowja | dict comprhension in 2.7+ | 21:44 |
=== jgrimm is now known as jgrimm-afk | ||
smoser | harlowja, oh yeah, i forgot i had to care about py226 | 23:57 |
smoser | er.. even py26 | 23:57 |
harlowja | :-P | 23:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!