[10:59] <dandrader> dednick, ping
[10:59] <dednick> dandrader: hey
[10:59] <dandrader> dednick, hi. got a fix for a critical bug I need you to review
[10:59] <dandrader> dednick, https://code.launchpad.net/~dandrader/unity8/promptsZOrder/+merge/296243
[11:01] <dednick> dandrader: ack. give me a minute to look at it.
[11:10] <dednick> dandrader: strange. i thought z order was maintained in order of declaration.
[11:11] <dednick> but perhaps the repeater messes it up.
[11:11] <dednick> ah. it's prepended...
[11:11] <dandrader> dednick, thing is the list of surfaces is organized so that the first one (index 0) is the top most
[11:11] <dandrader> dednick, yeah
[11:11] <dandrader> dednick, in qml the last one has the highest Z and thus get to be the top most visually
[11:11] <dednick> dandrader: got it.
[11:14] <Saviq> dandrader, to answer your question last night - no reason why not to land together, no
[11:14] <dandrader> Saviq, great
[11:15] <dednick> dandrader: comment attached.
[11:16] <dandrader> dednick, good catch.
[11:28] <dandrader> dednick, fixed. made a fix for qtmir as well. I guess it worked because MirSurfaceList.count property also changed, so the whole expression got reevaluated all the same
[11:28] <dednick> probably just because the list count was always 1 :)
[11:29] <Saviq> dandrader, only thing to remember is that you need to make sure that appropriate Depends/Breaks are there, because landing from a single silo does not ensure they will not be installed together
[11:31] <dandrader> Saviq, right
[11:31] <dednick> dandrader: no test we can do to make sure correct surface is on top?
[11:33] <dandrader> dednick, I can make one. But don't see much value in it as all it tests is the resul of a single qml expresion in code "z: surfaceContainer.z + (promptSurfacesRepeater.count - index)". Like tests better when the check for emerging behavior or other interactions that are not immediately assessed by looking at the code.
[11:34] <dandrader> dednick, writing a test
[11:35] <dednick> dandrader: yeah, but it was a regression; so thanks :)
[11:35] <dandrader> dednick, the biggest problem was that our Unity.Application mock wasn't mirroring what the real Unity.Application implementation from qtmir was doing
[11:35] <dednick> indeed
[11:39] <dednick> starting to wonder if things like MirSurfaceItem/SurfaceListModel should even be in qtmir. Since it's not "really" mir.
[11:39] <dednick> more "qtunity"
[11:40] <dandrader> dednick, yeah. would be awesome if we could mock only the mir layer in our unity8 qmltests
[11:40] <dednick> put it on the "rather long list"
[11:40] <dednick> :)
[12:32] <dandrader> dednick, done
[13:55] <dednick> dandrader: +1
[15:46] <tedg> mhall119: Do you have a set of tags for U8 desktop bugs?
[15:52] <mhall119> tedg: "avengers" is what I started using
[15:52] <mhall119> but I haven't kicked that off widely yet, so there's only a few
[15:53] <tedg> mhall119: K, it is probably a bit early for a dedicated campaign. I don't think we're at the "niggles" stage yet.
[15:53] <mhall119> tedg: we're at about where the phone was when we did the original avengers campaign
[15:54] <mhall119> granted, it requires more dedication to run it on your desktop
[15:54] <tedg> mhall119: I agree, and I think that one was too early. It generated a lot of bugs that we knew already.
[15:54] <tedg> mhall119: It become more noise than helpful as we were struggling to get things working.
[15:55] <mhall119> well, generating bug reports was only like 20% of the reason behind it, it was mostly for tracking them all togther
[15:56] <tedg> If only there was a database that had all the bugs in one place ;-)
[15:58] <mhall119> with a convenient way to filter them by some kind of tag....
[15:58] <mhall119> then all we'd need is a campaign for applying that tag to those bugs :)
[15:58] <tedg> The tag isn't as useful as the priority.
[15:59] <tedg> No reason to believe something for one form factory would be defacto more important than another.
[15:59] <tedg> form factor
[15:59] <tedg> Or something reported by a particular group of people.
[16:00] <mhall119> the tag is useful to group bugs from many different projects into a single view
[16:02] <tedg> That is true
[16:03] <tedg> Anyway, I filled mine as "avengers" we can rename or adjust later as needed.