/srv/irclogs.ubuntu.com/2016/06/08/#ubuntu-app-devel.txt

=== JanC is now known as Guest74845
=== JanC_ is now known as JanC
=== salem_ is now known as _salem
kalikianat1mp: Review? https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/visualGallery/+merge/296680 That's, as discussed, the gallery for browsing the unit tests, but this time just added to the existing tests/unit/visual and filtering for 1.308:29
t1mpkalikiana: ok08:31
t1mpkalikiana: I commented on https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/visualGallery/+merge/29668010:03
t1mpkalikiana: also CI failed for ARM... but it failed because of java.io.EOFException so I doubt it is caused by your changes.10:04
kalikianat1mp: "becomes" blue makes no sense to me. all I'm doing is onClicked and it's the same as it was before, I copied the code from the old MR10:05
kalikianaAnd what name, if gallery.sh may not be the best one? It's the most obvious one certainly..10:06
kalikianat1mp: And, yes, the filter *seems* random. It's not random because I tested that those tests work. Cleaning up our naming would be a good next step independent from this gallery.10:08
kalikiana(I'm replying to all of this in the MR also, just saying here for convenicne)10:08
t1mpkalikiana: so you selected a random subset of all tests, and verified that the random subset works :)10:11
t1mpkalikiana: how do you propose we add more tests after we test them, by renaming the test files?10:12
t1mpkalikiana: alternatively, we could list all filenames explicitly and add to that list10:14
t1mpbut that's a bit annoying10:14
kalikianat1mp: (Afaia) All new tests for some time now have a 13  suffix, and pretty much anything 1.3 can work10:16
kalikianaWe just need to be sure we do that consistently and possibly rename existing ones that have no suffix10:16
kalikianaThe subset is "1.3" really, not special criteria10:17
kalikianaAnd two tests I patched because they didn't show anything - but they still should be improved with actual manual testing in mind10:17
kalikianaI don't want to rewrite all tests in this MR10:18
kalikianat1mp: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/visualGallery/+merge/296680/comments/76245710:22
t1mpkalikiana: you didn't miss maybe one or two tests. I already gave a list of 7 that were missed, and I didn't go through the list to check which other tests should be added10:24
kalikianat1mp: You have a list? Where?10:25
kalikianaIt doesn't change my point, though10:25
t1mpin the inline comment "Plenty of (new) tests do not have 13 in the name, like actionbar, adaptivepagelayout, listitem, header, pageheader, sections, toolbar,..."10:25
kalikianaAre all of them 1.3?10:26
t1mpwe are not using the 13 suffix for new tests, only when there are multiple versions of a component with different versions10:26
kalikianaWe should fix that then :-)10:27
kalikianaNot having a suffix is confusing, without anything relying on the name10:27
kalikianaOnce we go to 1.4 this will be a mess10:27
t1mpkalikiana: ok, the list I gave was just a quick list of tests that I noticed. listitem is actually 1.2, and toolbar does not exist. The rest is 1.3 and maybe there are more10:28
t1mpkalikiana: okay10:28
t1mpkalikiana: I propose to suffixe the old tests (with 10, 11, 12) too then10:28
t1mp*suffix10:28
t1mpwe better do that in a separate MR, since it may require some changes in the code (for example if we also decide to rename MockKeyboard.qml to MockKeyboard12.qml)10:30
kalikianat1mp: Are you fine with my doing that in a separate branch? Then I'll add a suffix to all tests that have none10:30
t1mpyes10:30
kalikianaYeah, MockKeyboard should also get the suffix10:30
t1mpthere may be more10:31
t1mpkalikiana: ok, about the "blue" of the listitem, I have something similar with the gallery10:31
t1mpso the component gallery10:31
t1mphmz10:31
t1mpkalikiana: what about tests-gallery.sh ?10:32
t1mpalthough it is already in the test directory..10:32
kalikianat1mp: Yeah, I thought the same. And it is a "gallery" same as the component gallery10:34
kalikianaThey do the same thing, just different audience10:34
t1mpI guess I should blame qtc for my issue with identical filenames (it shows the beginning of the path, not the end, so with ctrl+K I don't see which file I will be opening)10:35
t1mpkalikiana: happroved10:37
kalikianat1mp: Turns out the AdaptivePageLayout actually works nicely in itself :-D11:35
=== _salem is now known as salem_
=== chihchun_afk is now known as chihchun
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== salem_ is now known as _salem

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!