=== JanC is now known as Guest74845
=== JanC_ is now known as JanC
=== salem_ is now known as _salem
[08:29] <kalikiana> t1mp: Review? https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/visualGallery/+merge/296680 That's, as discussed, the gallery for browsing the unit tests, but this time just added to the existing tests/unit/visual and filtering for 1.3
[08:31] <t1mp> kalikiana: ok
[10:03] <t1mp> kalikiana: I commented on https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/visualGallery/+merge/296680
[10:04] <t1mp> kalikiana: also CI failed for ARM... but it failed because of java.io.EOFException so I doubt it is caused by your changes.
[10:05] <kalikiana> t1mp: "becomes" blue makes no sense to me. all I'm doing is onClicked and it's the same as it was before, I copied the code from the old MR
[10:06] <kalikiana> And what name, if gallery.sh may not be the best one? It's the most obvious one certainly..
[10:08] <kalikiana> t1mp: And, yes, the filter *seems* random. It's not random because I tested that those tests work. Cleaning up our naming would be a good next step independent from this gallery.
[10:08] <kalikiana> (I'm replying to all of this in the MR also, just saying here for convenicne)
[10:11] <t1mp> kalikiana: so you selected a random subset of all tests, and verified that the random subset works :)
[10:12] <t1mp> kalikiana: how do you propose we add more tests after we test them, by renaming the test files?
[10:14] <t1mp> kalikiana: alternatively, we could list all filenames explicitly and add to that list
[10:14] <t1mp> but that's a bit annoying
[10:16] <kalikiana> t1mp: (Afaia) All new tests for some time now have a 13  suffix, and pretty much anything 1.3 can work
[10:16] <kalikiana> We just need to be sure we do that consistently and possibly rename existing ones that have no suffix
[10:17] <kalikiana> The subset is "1.3" really, not special criteria
[10:17] <kalikiana> And two tests I patched because they didn't show anything - but they still should be improved with actual manual testing in mind
[10:18] <kalikiana> I don't want to rewrite all tests in this MR
[10:22] <kalikiana> t1mp: https://code.launchpad.net/~ubuntu-sdk-team/ubuntu-ui-toolkit/visualGallery/+merge/296680/comments/762457
[10:24] <t1mp> kalikiana: you didn't miss maybe one or two tests. I already gave a list of 7 that were missed, and I didn't go through the list to check which other tests should be added
[10:25] <kalikiana> t1mp: You have a list? Where?
[10:25] <kalikiana> It doesn't change my point, though
[10:25] <t1mp> in the inline comment "Plenty of (new) tests do not have 13 in the name, like actionbar, adaptivepagelayout, listitem, header, pageheader, sections, toolbar,..."
[10:26] <kalikiana> Are all of them 1.3?
[10:26] <t1mp> we are not using the 13 suffix for new tests, only when there are multiple versions of a component with different versions
[10:27] <kalikiana> We should fix that then :-)
[10:27] <kalikiana> Not having a suffix is confusing, without anything relying on the name
[10:27] <kalikiana> Once we go to 1.4 this will be a mess
[10:28] <t1mp> kalikiana: ok, the list I gave was just a quick list of tests that I noticed. listitem is actually 1.2, and toolbar does not exist. The rest is 1.3 and maybe there are more
[10:28] <t1mp> kalikiana: okay
[10:28] <t1mp> kalikiana: I propose to suffixe the old tests (with 10, 11, 12) too then
[10:28] <t1mp> *suffix
[10:30] <t1mp> we better do that in a separate MR, since it may require some changes in the code (for example if we also decide to rename MockKeyboard.qml to MockKeyboard12.qml)
[10:30] <kalikiana> t1mp: Are you fine with my doing that in a separate branch? Then I'll add a suffix to all tests that have none
[10:30] <t1mp> yes
[10:30] <kalikiana> Yeah, MockKeyboard should also get the suffix
[10:31] <t1mp> there may be more
[10:31] <t1mp> kalikiana: ok, about the "blue" of the listitem, I have something similar with the gallery
[10:31] <t1mp> so the component gallery
[10:31] <t1mp> hmz
[10:32] <t1mp> kalikiana: what about tests-gallery.sh ?
[10:32] <t1mp> although it is already in the test directory..
[10:34] <kalikiana> t1mp: Yeah, I thought the same. And it is a "gallery" same as the component gallery
[10:34] <kalikiana> They do the same thing, just different audience
[10:35] <t1mp> I guess I should blame qtc for my issue with identical filenames (it shows the beginning of the path, not the end, so with ctrl+K I don't see which file I will be opening)
[10:37] <t1mp> kalikiana: happroved
[11:35] <kalikiana> t1mp: Turns out the AdaptivePageLayout actually works nicely in itself :-D
=== _salem is now known as salem_
=== chihchun_afk is now known as chihchun
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== salem_ is now known as _salem
=== _salem is now known as salem_
=== salem_ is now known as _salem