| Odd_Bloke | smoser: ;.; Forgive me. | 08:20 |
|---|---|---|
| smoser | Odd_Bloke, thank you for fixing | 13:56 |
| Odd_Bloke | smoser: Phil fixed it. :) | 13:57 |
| smoser | Odd_Bloke, what do you think about https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-up-cli/+merge/297409 | 14:17 |
| Odd_Bloke | smoser: I'm strongly +1 on the idea; I haven't reviewed the code. | 14:23 |
| Odd_Bloke | smoser: I think the reason I didn't do anything more invasive before is that I was fixing a trusty bug, but I can't remember exactly. | 14:23 |
| === Toger_ is now known as Toger | ||
| === Toger_ is now known as Toger | ||
| harlowja_ | https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-up-cli/+merge/297409 also fixes flake8 issues (so thats why some changes in that aren't just cli related) | 17:09 |
| harlowja_ | cause the code moved under cloudinit so now it got flake tested | 17:09 |
| harlowja_ | (if u were wondering) | 17:10 |
| harlowja_ | lol | 17:10 |
| smoser | harlowja_, yeah, i like it | 18:06 |
| smoser | does the packaging still work i woner. | 18:06 |
| smoser | harlowja_, my pep8 cries now | 18:10 |
| smoser | http://paste.ubuntu.com/17373169/ | 18:10 |
| smoser | http://paste.ubuntu.com/17374020/ seems needed for fixing that branch | 18:31 |
| smoser | all output in output/ | 18:32 |
| harlowja_ | hmmmm, will fix that, wonder why flake8 not find that | 18:52 |
| harlowja_ | smoser what pep8 is that | 19:12 |
| harlowja_ | *(what version) | 19:12 |
| smoser | 1.7.0-2 | 19:12 |
| harlowja_ | mine doesn't show anything, let's try that version, lol | 19:13 |
| harlowja_ | ok, got same issues, its because of patcher.pathc | 19:14 |
| harlowja_ | *patch | 19:14 |
| smoser | well, i did this: http://paste.ubuntu.com/17374020/ | 19:14 |
| harlowja_ | hmmm, or u can just do | 19:15 |
| harlowja_ | patcher.patch() # noqa | 19:15 |
| harlowja_ | :-P | 19:15 |
| harlowja_ | ok, https://code.launchpad.net/~harlowja/cloud-init/cloud-init-fix-up-cli/+merge/297409 updated with those | 19:19 |
| smoser | harlowja_, the patcher.patch.... | 19:33 |
| harlowja_ | ya | 19:33 |
| smoser | do you think its necessary that early ? | 19:33 |
| smoser | why not just move it down | 19:33 |
| smoser | assuming we dont stack trace in an 'import' that early, it should be ok, no ? | 19:33 |
| harlowja_ | it patches logging, which if we do it after we import cloud.log then i think it might not be working as we want | 19:34 |
| smoser | oh. ok. | 19:35 |
| smoser | well, short term, your solution with a comment is fine. | 19:35 |
| smoser | (# noqa) | 19:35 |
| harlowja_ | ya, long-term kill patching | 19:35 |
| harlowja_ | if we get git i can figure out the kill patching :-P | 19:37 |
| smoser | harlowja_, https://code.launchpad.net/~harlowja/cloud-init/cloud-init-net-sysconfig/+merge/297115 | 20:10 |
| smoser | comented tehre. | 20:10 |
| smoser | and yea, lets get to git | 20:11 |
| smoser | and /me is out | 20:11 |
| harlowja_ | lol | 20:25 |
| === jroll|dupe is now known as jroll | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!