| === natefinch-afk is now known as natefinch | ||
| stub | Can anyone confirm that relation-list no longer includes the departing unit in a -departed hook, and since which version of Juju? | 03:34 |
|---|---|---|
| stub | cory_fu: (^^ from your issue comment, which might help me in other ways) | 03:35 |
| Makyo|away | wallyworld: would it be alright to land https://github.com/juju/bundlechanges/pull/24 ? We've just about finished implementing the changes in the GUI | 06:47 |
| === Makyo|away is now known as Makyo | ||
| wallyworld | Makyo: that would be great | 07:17 |
| Makyo | wallyworld: ty! | 07:18 |
| wallyworld | Makyo: juju master pulls in a specific rev off that repo so I'll update the deps once that lands | 07:18 |
| Makyo | wallyworld: ah, thanks, that makes sense | 07:18 |
| Makyo | wallyworld: landed, ty | 07:22 |
| wallyworld | Makyo: awesome, thanks you for doin ght gui changes | 07:22 |
| === julenlar is now known as julenl | ||
| gennadiy | hi everybody, | 11:02 |
| gennadiy | does it windows support subordinate charms now? | 11:02 |
| xilet | Really juju newbie question, if I need to make one change to a single config file in an already deployed charm (adding a new parameter to nova.conf), what is the syntax to do that? Or do I just ssh in and change it manually? | 11:51 |
| jamespage | ChrisHolcombe, https://review.openstack.org/#/c/328374/3 | 11:58 |
| jamespage | some comments; I think we should bump the default as well if our reference deployments need a larger value than 300 seconds... | 11:59 |
| gennadiy | @xilet seems you should make new version of charm and upgrade it: juju upgrade-charm | 12:19 |
| jamespage | xilet, don't ssh and change it manually - the next time a config-changed runs (like on a reboot) your change will be overwritten | 12:20 |
| jamespage | xilet, what are you trying todo? | 12:20 |
| xilet | still working on the iscsi issue, so trying to add in volume_drivers=iscsi=nova.virt.libvirt.volume.LibvirtNetVolumeDriver | 12:20 |
| jamespage | gennadiy, I can't think why windows would not support subordinate charms | 12:20 |
| gennadiy | it doesn't work for me | 12:21 |
| jamespage | xilet, you might be about to poke that in using config-flags | 12:21 |
| gennadiy | ok for linux machine | 12:21 |
| jamespage | juju set nova-compute config-flags="volume_drivers=iscsi=nova.virt.libvirt.volume.LibvirtNetVolumeDriver" | 12:22 |
| jamespage | but that only writes to the DEFAULT section so it might not do the trick | 12:22 |
| jamespage | xilet, this is for the userspace iscsi support right? | 12:22 |
| xilet | yeah | 12:22 |
| xilet | ahh thanks, that is the syntax I was looking for | 12:22 |
| jamespage | xilet, this might make a nice first contribution for you to make it an offical feature | 12:22 |
| jamespage | juju set nova-compute userspace-iscsi=true | 12:23 |
| jamespage | is so much nicer! | 12:23 |
| xilet | if I can get this working, I will happily do so | 12:23 |
| jamespage | xilet, prove the theory and then if you'd like to work on a more formal config option let me know | 12:23 |
| jamespage | they are normally quite easy to add for this sort of thing | 12:23 |
| xilet | good to know, clearing out the old tests then will go through and see if it can access the disks from openstack | 12:32 |
| ionutbalutoiu | Hello! Can I configure Juju to boot new machines with a keypair via OpenStack provider ? Currently machines added to OpenStack via Juju do not have any keypair. | 12:33 |
| gennadiy | @ionutbalutoiu for linux machine or windows? | 12:37 |
| gennadiy | for linux machine it will add juju key | 12:37 |
| ionutbalutoiu | Either one don't get any nova keypair. But for Linux, I think the juju key is authorized via metadata. | 12:38 |
| ionutbalutoiu | But for Windows, you don't have any option. | 12:38 |
| gennadiy | juju uses keys from - ~/.local/share/juju/ssh/ | 12:38 |
| gennadiy | for windows - i have asked this question yesterday | 12:38 |
| gennadiy | http://ask.cloudbase.it/question/1239/jujuopenstack-how-to-get-windows-machine-password/ | 12:39 |
| gennadiy | also i have asked this question on juju mail list. | 12:40 |
| gennadiy | i have got this answer | 12:40 |
| gennadiy | You should be able to do something like: juju run --machine <machine-id> "net user JujuAdministrator <password>" | 12:40 |
| gennadiy | but i haven't tested it | 12:40 |
| gennadiy | now we use workaround - our charm add local admin | 12:40 |
| ionutbalutoiu | Yes. This is only possible only with Juju 2.0 | 12:40 |
| ionutbalutoiu | for for stable version 1.25.5 you cannot set/retrieve any password for a Windows machine unless you have access to console. | 12:41 |
| ionutbalutoiu | Juju run on Windows doesn't work on version of Juju < 2.0 | 12:41 |
| ionutbalutoiu | After you boot a Windows machine with Nova, you can retrieve the Admin password via "nova get-password <instance_name> <private_key>" | 12:42 |
| ionutbalutoiu | but that's possible only if you boot the machine with a keypair. Is would be nice if Juju could have a config option, so that every machine it boots, it uses that configured keypair. | 12:42 |
| gennadiy | yes, i know. | 12:44 |
| gennadiy | so our workaround - create own user on machine from charm | 12:44 |
| gennadiy | it's very easy - https://github.com/cloudbase/juju-powershell-modules | 12:45 |
| gennadiy | there are - New-LocalAdmin function | 12:45 |
| ionutbalutoiu | I know. I'm working at Cloudbase. :) | 12:45 |
| ionutbalutoiu | Still, that's sort of a hack. I still consider that adding a config option for keypair in case of OpenStack provider, would make things cleaner. | 12:47 |
| lazyPower | heyyyy powershell modules | 12:54 |
| lazyPower | right on, i forgot those were published | 12:54 |
| admcleod | kjackal: im interested in the 'slow sync' messages in the hbase log during the smoke-test - have you seen these? | 12:57 |
| kjackal | admcleod: nope, I suspect what they mean but have never seen them | 13:06 |
| kjackal | let me see in hbase docs/list | 13:06 |
| kjackal | admcleod: something like this: https://issues.apache.org/jira/browse/HBASE-11240 | 13:09 |
| lazyPower | https://github.com/juju-solutions/interface-etcd-proxy/pull/2 - could use a quick CR on this if anyone has the bandwidth | 13:09 |
| lazyPower | i'm down a team-mate for spot reviews | 13:09 |
| admcleod | kjackal: right. >> "abnormal datanode" << | 13:11 |
| kjackal | yes, basicaly, HBase writes everything in a write ahead log and then keeps it in memory. There are phases when everything that is in memory has to be written down to the secondary storage (compaction pahses). I guess this message means that the secondary storage takes toolong | 13:13 |
| kjackal | admcleod: ^ | 13:13 |
| admcleod | kjackal: right, which means... | 13:19 |
| gennadiy | hi lazyProwe, do you have some windows subordinate charms in jujustore or github? | 13:41 |
| lazyPower | gennadiy - I dont believe we do, i think you're pioneering | 13:47 |
| lazyPower | gennadiy - the only windows charms I have interfaced with were principal charms provided by cloudbase | 13:47 |
| gennadiy | seem i was wrong with windows subordinate issue. i have just deployed empty subordinate charm - everything is ok | 13:54 |
| lazyPower | gennadiy - when you say "I have deployed empty subordinate charm" - do you mean on a windows series? | 14:00 |
| gennadiy | yes, i used this one - https://github.com/cloudbase/windows-charms-boilerplate | 14:01 |
| lazyPower | i'm not surprised that would work, if it has no hooks. The agent would skip all hooks. | 14:01 |
| lazyPower | and it would appear to be fine, when it really just no-op'd | 14:01 |
| lazyPower | gennadiy - have you logged a bug with the charm that appears to be broken? I dont have the time right now to dig into it but I'm interested in following the conversation | 14:02 |
| gennadiy | it's my charm. i'm creating 2 charms for windows. one is principal, another is subordinate | 14:03 |
| lazyPower | ah, well that does present certain... hurdles | 14:03 |
| cory_fu | stub: I confirmed it yesterday in 2.0-beta8 | 14:03 |
| cory_fu | admcleod, kjackal: I don't know if you noticed that I moved the card, but the plugin ready issue was, I think, best fixed in charms.reactive, if you want to take a look: https://github.com/juju-solutions/charms.reactive/pull/71 | 14:05 |
| admcleod | cory_fu: ah yeah ok | 14:07 |
| cory_fu | Technically, the issue was a subtlety of Python, where `None and <anything>` returns None and not False like you would expect. That, combined with using None as a deafult value to mean something significant made for unexpected behavior | 14:08 |
| stub | cory_fu: Ta. I'll assume is is a 2.0 feature for now. | 14:13 |
| cory_fu | stub: "Feature" | 14:13 |
| cory_fu | Seems like a bug to me, but at least I was able to work around it | 14:14 |
| cory_fu | Though I suppose it depends on how strictly you take the fact that the hook is -departed and not -departing | 14:14 |
| stub | cory_fu: Oh, I was thinking it might be part of a fix. Before, in a departed hook neither end had an idea about which unit was departing. | 14:14 |
| cory_fu | That seems like a round-about way of communicating it. | 14:15 |
| === fwereade_ is now known as fwereade | ||
| cory_fu | I mean, not wrong, per se, but then you still have to jump through the hoop of comparing JUJU_REMOTE_UNIT to the relation-list to figure out if it's you or the other unit | 14:16 |
| stub | cory_fu: So I guess I shouldn't rely on the behavior and wait for a real fix to https://bugs.launchpad.net/juju-core/+bug/1417874 | 14:16 |
| mup | Bug #1417874: Impossible to cleanly remove a unit from a relation <canonical-is> <charms> <feature> <hooks> <sts> <sts-needs-review> <juju-core:Triaged> <https://launchpad.net/bugs/1417874> | 14:16 |
| lazyPower | cory_fu - the one thing i was curious about that pr is we're catching CalledProcessError | 14:17 |
| lazyPower | does relation_get not ever return > 0 except only in that scenario? | 14:17 |
| lazyPower | seems like we could be hiding other failure and skipping it due to that one little stanza. But it seems nitty and i dont have a solid use case for where thats bad | 14:18 |
| cory_fu | lazyPower: Well, no charm that I've ever seen captures CalledProcessError around the call to relation-get and I've never seen it fail in another circumstance. But you're right that it's perhaps a bit heavy-handed. Ideally, hookenv.relation_get would capture the stderr output on failure and we could inspect that, but that would require changes in charmhelpers. | 14:20 |
| lazyPower | I'm not about that life at the moment | 14:21 |
| lazyPower | carry on as you were sir | 14:21 |
| cory_fu | lazyPower: We could also assume that the units list cleanup is functional and remove the check entirely. I'm not against that; I added the except before I was sure if I could reasonably do the cleanup | 14:21 |
| lazyPower | Thats the one niggly thing, and its really a nit | 14:22 |
| lazyPower | without empirical evidence that "hey this fails under x condition" | 14:22 |
| cory_fu | I did have the same concern, so I'm not against changing it. | 14:24 |
| lazyPower | :O Does this mean you're rubbing off on me cory_fu? | 14:28 |
| cory_fu | :) | 14:28 |
| stub | cory_fu, lazyPower , marcoceppi : So I knocked up https://github.com/stub42/ReactiveCharmingWorkflow a while ago, to codify and improve the process I'd embedded in the PostgreSQL charm Makefile. And per the 'Future' section in that am thinking of making this process simpler with some git plugins. | 14:29 |
| lazyPower | export JUJU_REPOSITORY=$CHARM_ROOT/repo | 14:29 |
| lazyPower | i want that to go away | 14:29 |
| lazyPower | its a legacy concept and we should kill it with fire | 14:30 |
| stub | cory_fu, lazyPower , marcoceppi : Does this seem like I'm going in the right direction, or do people have reasons to prefer multiple repos for source layer and built charm? | 14:30 |
| stub | lazyPower: Yes, but for now I need both Juju 1 and Juju 2. Plugins will be targetted for Juju 2 though. | 14:30 |
| lazyPower | from what im reading so far you're on the same path i've been using | 14:31 |
| lazyPower | --no-local-layers before building for a publish and testing that artifact pre-push, this is all like the workflow i wanted for CI too | 14:31 |
| lazyPower | i like your push/publish hack too | 14:32 |
| marcoceppi | stub: I'm traveling, but will review in a bit and leave comments, thanks for typing this up! | 14:32 |
| stub | I've opened isues on github to hopefully avoid that hack ;) | 14:32 |
| lazyPower | yeah LGTM stub - there's a few things in here i'll comment on later but initial scan was good | 14:33 |
| lazyPower | there are some conventions in here we could probably put into layer-basic as a Makefile and make this useful to more people out of the box | 14:33 |
| stub | I'm also considering if I should generate the branch name to contain the built version of a layer (so the master branch gets built to master-built) | 14:33 |
| lazyPower | but thats up to cory_fu | 14:33 |
| lazyPower | and other maintainers | 14:33 |
| stub | Well, I think the git bits are ugly enough to put into a git plugin, which I could package or snap | 14:34 |
| lazyPower | snap ftw | 14:34 |
| stub | git plugins should at least make things readable and avoid the ugly underlying details. | 14:35 |
| lazyPower | fair, i use a shell hack i got from gary bernhardts dotfiles for git pretty tree. its invaluable | 14:36 |
| stub | (git clones into temp directories etc. to ensure clean publication, committing uncommitted changes to the built branch before building) | 14:36 |
| kwmonroe | cory_fu: teach me some python.. are double underscored vars the convention for defining globals? eg https://github.com/juju-solutions/charms.reactive/pull/71/files | 15:02 |
| stub | It should really be "TOGGLE = object()". You only want magic strings if you need a readable string representation | 15:25 |
| cory_fu | kwmonroe: What stub just said. I went with strings for debugging, but object() would have worked just as well and perhaps been less misleading | 15:26 |
| cory_fu | kwmonroe: Also, leading / trailing underscores are a convention in Python for representing internal things. Double underscores are usually reserved for Python-internal things, so I probably should have used single underscores, but it's just a string value and not an identifier, so it's slightly less of an issue | 15:28 |
| cory_fu | stub, kwmonroe: Feel free to nack the PR and I'll update it | 15:28 |
| stub | I'm not going to be that pedantic | 15:29 |
| kwmonroe | thx stub and cory_fu.. i didn't read that PR right from the get go.. i think i was thinking the *var* was __TOGGLE__ and didn't pick up that was just a string.. anyway, __SORRY__. | 15:32 |
| cory_fu | kwmonroe: Yeah, I think the way I wrote that encourages that confusion. I'm up for changing it to object() to avoid that | 15:34 |
| cory_fu | kwmonroe, stub: Updated. Thanks | 15:48 |
| saudk | hey guys | 17:44 |
| saudk | having an issue deploying openstack using juju charms and maas | 17:44 |
| saudk | i am seeing the same IP assigned to juju-br0 and the interface that is connected to | 17:46 |
| saudk | in /etc/network/interfaces the interface e.g eth1 is set as inet manual | 17:46 |
| saudk | and in the same file /etc/network/interfaces.d/*.cfg is sourced where a file eth1.cfg exists in which eth1 is set as inet dhcp | 17:48 |
| marcoceppi | saudk: what versoin of maas? | 17:48 |
| saudk | 1.9.3+bzr4577-0ubuntu1~trusty1 | 17:49 |
| kwmonroe | hey cory_fu, i'm reviewing https://github.com/juju-solutions/charms.reactive/pull/72, but don't understand why -departed has to be handled in __init__.py, or for that matter why there's no handling of -joined that does rel.conversation().join(). | 18:18 |
| cory_fu | kwmonroe: join happens implicitly in RelationBase.__init__: https://github.com/juju-solutions/charms.reactive/blob/master/charms/reactive/relations.py#L156 | 18:19 |
| cory_fu | The reason we need to call .depart() is that we're now depending on the internal list of units to be accurate, since Juju no longer includes the departing unit in relation-list | 18:20 |
| kwmonroe | yup, got it | 18:20 |
| cory_fu | It's actually better for that list to be accurate, anyway, for charm use | 18:21 |
| cory_fu | kwmonroe: Give me a second to push up a minor edit to that. Going to add logging to that try / except | 18:21 |
| kwmonroe | ack | 18:21 |
| cory_fu | kwmonroe: Updated | 18:26 |
| cory_fu | kwmonroe: You'll notice that it was always my intention to have depart() called implicitly | 18:27 |
| kwmonroe | yes i will notice that cory_fu, but no one else will since the todo is going away. | 18:29 |
| cory_fu | :) | 18:29 |
| kwmonroe | frankly, that change is probably the only thing i'm qualified to review here ;) | 18:29 |
| lazyPower | kwmonroe - i dub you the pr poobah | 18:31 |
| lazyPower | you're now qualified to review everything by virtue of being the poobah | 18:31 |
| kwmonroe | we're doomed | 18:31 |
| kwmonroe | i remember back in the day (like monday), when the curtain looked so pretty. why oh why did i stick my head behind there? | 18:32 |
| lazyPower | :) well your self confidence rating certainly shines through | 18:33 |
| kwmonroe | i can be poobah now lazyPower! i totally get it. i was missing the link between get_remote and relation_get -- it's related_units (and relation-list therein) causing the problem. | 18:48 |
| lazyPower | yep, that niggly little workflow we used to use back in the day | 18:51 |
| lazyPower | cory_fu - correct me if i'm wrong, but there's a key in layer.yaml i can use to control omission of files right? | 19:14 |
| lazyPower | eg: ignores: ['known-weird-module-that-doesnt-play-well-with-other-modules.py'] | 19:14 |
| cory_fu | Yes, ignores, but be aware of this issue: https://github.com/juju/charm-tools/issues/220 | 19:15 |
| cory_fu | lazyPower: The TL;DR of that issue is that ignores is currently not scoped to an individual layer | 19:16 |
| cory_fu | It will prevent a file with that name from being included in the final charm, period. | 19:16 |
| cory_fu | Also, that behavior is likely to change, and the calling convention of ignores might change, too | 19:17 |
| lazyPower | ok | 19:19 |
| lazyPower | i have need to exclude a test in the final product thats fine for the layer (for now) | 19:20 |
| lazyPower | so this is a good enough impl i'm opting fo rit | 19:20 |
| lazyPower | except that it doesn't appear to work with pathed files | 19:20 |
| lazyPower | http://paste.ubuntu.com/17376175/ | 19:23 |
| bdx | hey whats up guys? Is there a way to update a resource without pushing the charm too? | 20:34 |
| lazyPower | bdx - see: charm attach --help | 20:41 |
| bdx | lazyPower: http://paste.ubuntu.com/17379141/ | 20:46 |
| bdx | :-( | 20:46 |
| lazyPower | bdx are you trying to push this to the store or to your controller? | 20:46 |
| lazyPower | the 502 bad gateway is troubling... but first things first :) | 20:47 |
| bdx | lazyPower: to the store | 20:50 |
| lazyPower | bdx ok thats odd. | 20:54 |
| lazyPower | jrwren - Charm store status looks good to you yeah? | 20:54 |
| * lazyPower remembers he needs to finish a reply to the etcd email now | 20:54 | |
| === firl_ is now known as firl | ||
| magicaltrout | i love a prime, thats primest | 21:27 |
| cory_fu | lazyPower: The fix for the -relation-departed issue turned out to be a bit of a lame duck, and I had to go back and take a different approach | 21:40 |
| cory_fu | https://github.com/juju-solutions/charms.reactive/pull/75/files if you want to review | 21:40 |
| cory_fu | kwmonroe spotted my mistake and is also reviewing | 21:41 |
| magicaltrout | you made a mistake cory_fu ?! | 21:43 |
| magicaltrout | sad times | 21:43 |
| cory_fu | As far as making mistakes goes, I'm on fire today | 21:43 |
| * magicaltrout spots smoke on the horizon | 21:43 | |
| cory_fu | https://i.imgur.com/F0NtTsP.gif | 21:44 |
| magicaltrout | its like me on a daily basis | 21:45 |
| magicaltrout | of course as IT professionals, we never openly admit to the weird stuff that happens daily! ;) | 21:45 |
| kwmonroe | cory_fu: the "if unit not in self.units, continue" is to keep us from calling relation_get on globally scoped relation ids? | 21:59 |
| kwmonroe | (referring to https://github.com/juju-solutions/charms.reactive/pull/75/files#diff-3c5467f4229b8dd06bdf1c43813c03d8R623) | 21:59 |
| cory_fu | kwmonroe: Not just GLOBAL. Not every unit on a given relation will be in the state that the conversation is representing. Some might still waiting on the unit to finish setting up and providing its relation data | 22:00 |
| kwmonroe | well, i guess not just global rel id, but more .... yeah, what you said. | 22:00 |
| cory_fu | I'm not sure I trust Travis at this point. :p | 22:03 |
| kwmonroe | lol cory_fu | 22:05 |
| kwmonroe | don't be mad | 22:05 |
| kwmonroe | https://github.com/johnsca/charms.reactive/blob/812a06f657a0b6fb3f1488f91a1a0a0aa13fe761/charms/reactive/relations.py#L19 | 22:05 |
| cory_fu | Oh snap. Linty linty | 22:06 |
| kwmonroe | that's your old frient F401 | 22:06 |
| cory_fu | Stupid Travis | 22:06 |
| kwmonroe | truth | 22:06 |
| cory_fu | May the force-push be with me | 22:06 |
| kwmonroe | looks good | 22:08 |
| kwmonroe | cory_fu: cool for 0.4.4? | 22:10 |
| cory_fu | Ok, we finally ready for a release, then? I need to go on my damned vacation. :) | 22:10 |
| cory_fu | ha | 22:10 |
| cory_fu | kwmonroe: You want me to release it, or you want to try your hand now that you're a maintainer on pypi? | 22:11 |
| kwmonroe | the latter | 22:11 |
| cholcombe | thedac, interesting MR here | 22:11 |
| kwmonroe | ugh, my first objective as maintainer will be to remove the pesky 'make test' prereq of 'make release'. this is taking too long. | 22:12 |
| cholcombe | thedac, there's actually a 3rd option but it's a PITA to setup | 22:12 |
| cory_fu | Only takes 6 seconds (times 2, I guess) for me. How long does it take for you, kwmonroe? | 22:13 |
| kwmonroe | like at least 10 seconds | 22:13 |
| cory_fu | ha | 22:13 |
| thedac | cholcombe: hey, which MR are we talking about? | 22:13 |
| kwmonroe | anyway, she's away cory_fu. go forth and vacation. | 22:13 |
| cholcombe | thedac, the dns HA for rgw | 22:13 |
| thedac | got it | 22:13 |
| cholcombe | thedac, so the other possibility here is we could use bgp | 22:13 |
| thedac | cholcombe: just keep in mind this is one of many https://review.openstack.org/#/q/topic:dnsha | 22:14 |
| cory_fu | kwmonroe: Sweet, thanks. Be sure to let admcleod and kjackl know they can rebuild hbase and test it again | 22:14 |
| cholcombe | i see | 22:14 |
| lazyPower | haha guyzzzz | 22:14 |
| cory_fu | Actually, we'll need to rebuild hadoop-plugin to fix it | 22:14 |
| kwmonroe | what lazyPower? you see something? | 22:14 |
| cory_fu | lazyPower: You talking to us? | 22:14 |
| kwmonroe | if you see something, you have to say something. | 22:14 |
| thedac | yes, one could use BGP, but these are charm handled HA options | 22:14 |
| cholcombe | thedac, interesting. so the charm handles the vip? | 22:14 |
| cory_fu | lazyPower: Don't listen to kwmonroe. You had your chance to review and you blew it. ;) | 22:15 |
| thedac | Yes, you have to add it to the config but yes hacluster/corosync handles that | 22:15 |
| lazyPower | cory_fu kwmonroe -nahhh i just looking over this thread of review comments ;) | 22:15 |
| cory_fu | Ah, lol | 22:15 |
| lazyPower | solid comedic gold considering i know how today has been :P | 22:15 |
| cory_fu | Alright, I'm out. Everyone have a good weekend! | 22:16 |
| lazyPower | cheers cory_fu | 22:16 |
| kwmonroe | adios | 22:16 |
| cholcombe | thedac, i've had a lot of good experience with floating vip's using ctdb. It's very solid | 22:16 |
| lazyPower | (its only Wed.) | 22:16 |
| kwmonroe | lol | 22:16 |
| cholcombe | thedac, corosync i have no experience with so i'll do the best i can reviewing | 22:16 |
| magicaltrout | youth of today | 22:17 |
| magicaltrout | always on holiday | 22:17 |
| cory_fu | lazyPower: I'm out for the rest of the week | 22:17 |
| lazyPower | oo snap | 22:17 |
| kwmonroe | pretty sure it's thanksgiving this week | 22:17 |
| lazyPower | (jackie face) | 22:17 |
| thedac | cholcombe: keep in mind the corosync VIP solution was already there (it is just indented). I added the DNS bit which is a call out to charmhelpers which has already been reviewed. You can also just do a +1 and wait for a second opinion. | 22:18 |
| cholcombe | thedac, cool | 22:18 |
| lazyPower | > You can also just do a +1 and wait for a second opinion. | 22:18 |
| lazyPower | pretty much exactly what i do | 22:18 |
| lazyPower | cholcombe - you're getting solid guidance here. i approve | 22:18 |
| cholcombe | lazyPower, :) | 22:19 |
| thedac | :) | 22:19 |
| cholcombe | thedac, looks reasonable. I just have a question on the hooks.py code | 22:22 |
| thedac | shoot? | 22:22 |
| cholcombe | thedac, i'm just wondering if the iface turns up as None on the vip if we should error or log there. The code currently skips that case | 22:24 |
| cholcombe | thedac, I know it's not your code | 22:24 |
| thedac | looking | 22:24 |
| kwmonroe | lazyPower: the only thing holding kubes-core from passing cwr is a "charm push . cs:~containers/bundle/kubernetes-core" from a recent https://github.com/juju-solutions/bundle-kubernetes-core dir. feeling frisky? (i am, but i'm not in ~containers) | 22:29 |
| thedac | so, good point. What I would like to eventually do is move the VIP code to charmhlpers just like the update_dns_ha_resource_params. Then we could fix it in one place. Right now I am trying to change as little as possible so that only the additional feature is added if it needs to be reverted for any reason. | 22:29 |
| thedac | Was that weasaly enough :) | 22:30 |
| cholcombe | thedac, fair enough :) | 22:34 |
| lazyPower | kwmonroe - i cant fix it like that | 22:46 |
| lazyPower | kwmonroe - not without landing the pile of CR's i linked elsewhere | 22:46 |
| lazyPower | i'd love to publish though :) | 22:46 |
| kwmonroe | ah, ack lazyPower. i thought it was just a case of the bundle not using the latest rev of the kubes charm. | 22:48 |
| lazyPower | that indeed is the case, but its more involved :) | 22:56 |
| magicalt1out | :P | 23:09 |
| lazyPower | primey wimey spacey wacey amirite? | 23:11 |
| === jcsackett_ is now known as jcsackett | ||
| === markthomas_ is now known as markthomas | ||
| === StoneTable is now known as aisrael | ||
| === thomi_ is now known as thomi | ||
| === X-Istence is now known as x58 | ||
| lazyPower | bdx - i circled back and it appears to work now? http://paste.ubuntu.com/17383707/ | 23:18 |
| bdx | lazyPower: did it not work for you earlier either? | 23:29 |
| lazyPower | bdx - i didnt try at that time, i was judging based on the output. can you give it another go? | 23:30 |
| lazyPower | it may have been transient | 23:30 |
| bdx | yea, omp | 23:30 |
| bdx | lazyPower: yeah, its working now | 23:32 |
| bdx | lazyPower: trickery | 23:32 |
| lazyPower | ok cool. sorry that happened :( i got no response when i pinged so i circled back | 23:32 |
| bdx | hey thanks! | 23:32 |
| lazyPower | np mate | 23:32 |
| lazyPower | glad we got it sorted | 23:32 |
| === verterok` is now known as verterok | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
