[00:03] <cherylj> wallyworld: I find it a little confusing that the controllerUUID is effectively passed into environs/bootstrap.Bootstrap two ways.  One is explicit as a Param, and one is through the environ.Config
[00:03] <cherylj> wallyworld: and the Bootstrap function validates the controllerUUID in the environ.Config
[00:03] <cherylj> but doesn't look at the one passed in the BootstrapParams
[00:04] <cherylj> wallyworld: should environs/bootstrap.Bootstrap verify that they're equal and non empty?
[00:04] <wallyworld> cherylj: it's a little messed up as we transition to passing the uuid explicitly rather than in config, i'll see if i can do some more work to extract it
[00:05] <cherylj> wallyworld: ok, then my comment would be to perform the non-empty check in Bootstrap on the BootstrapParam.ControllerUUID
[00:05] <cherylj> rather than what's passed into the environ.Config
[00:05] <cherylj> (or both as it's transitioning)
[00:05] <wallyworld> will do, i'll see if i can now even remove it from config
[00:06] <cherylj> k, sounds good.
[00:07] <cherylj> wallyworld: it also looks like you had a leftover comment in controller/modelmanager/createmodel.go
[00:07] <wallyworld> cherylj: i just looked again, that stuff checking for it in config should have been removed, it was a carry over from the old way
[00:07] <cherylj> ok
[00:11] <wallyworld> cherylj: changes pushed. there's still more todo - we don't want to have controller uuid on config attrs at all, but it's like untangling spaghetti
[00:18] <cherylj> thanks, wallyworld.  I'm verifying it on azure right now
[00:18] <wallyworld> awesome
[00:22] <mup> Bug #1157022 changed: environs/openstack: openstack.Instance should implement Stringer <logging> <openstack-provider> <ui> <juju-core:Fix Released> <https://launchpad.net/bugs/1157022>
[00:22] <mup> Bug #1164220 changed: environs.MongoURL sould check that the fallback option actually exists <tech-debt> <juju-core:Invalid> <https://launchpad.net/bugs/1164220>
[00:52] <mup> Bug #1155276 changed: support ~/.juju/environments.d <improvement> <juju-core:Fix Released> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1155276>
[00:55] <wallyworld> cherylj: thanks! will land now
[04:22] <mup> Bug # changed: 1558223, 1561566, 1569969, 1570175
[14:12] <mup> Bug #1593978 opened: failed to bootstrap <juju-core:New> <https://launchpad.net/bugs/1593978>
[16:51] <mup> Bug #1593996 opened: unit agent tests cannot run uniter <juju-core:Triaged> <https://launchpad.net/bugs/1593996>
[18:42] <mup> Bug #1593996 changed: unit agent tests cannot run uniter <juju-core:Invalid> <https://launchpad.net/bugs/1593996>
[22:25] <mup> Bug #1593978 changed: failed to bootstrap <juju-core:New> <https://launchpad.net/bugs/1593978>