[00:03] wallyworld: I find it a little confusing that the controllerUUID is effectively passed into environs/bootstrap.Bootstrap two ways. One is explicit as a Param, and one is through the environ.Config [00:03] wallyworld: and the Bootstrap function validates the controllerUUID in the environ.Config [00:03] but doesn't look at the one passed in the BootstrapParams [00:04] wallyworld: should environs/bootstrap.Bootstrap verify that they're equal and non empty? [00:04] cherylj: it's a little messed up as we transition to passing the uuid explicitly rather than in config, i'll see if i can do some more work to extract it [00:05] wallyworld: ok, then my comment would be to perform the non-empty check in Bootstrap on the BootstrapParam.ControllerUUID [00:05] rather than what's passed into the environ.Config [00:05] (or both as it's transitioning) [00:05] will do, i'll see if i can now even remove it from config [00:06] k, sounds good. [00:07] wallyworld: it also looks like you had a leftover comment in controller/modelmanager/createmodel.go [00:07] cherylj: i just looked again, that stuff checking for it in config should have been removed, it was a carry over from the old way [00:07] ok [00:11] cherylj: changes pushed. there's still more todo - we don't want to have controller uuid on config attrs at all, but it's like untangling spaghetti [00:18] thanks, wallyworld. I'm verifying it on azure right now [00:18] awesome [00:22] Bug #1157022 changed: environs/openstack: openstack.Instance should implement Stringer

[00:22] Bug #1164220 changed: environs.MongoURL sould check that the fallback option actually exists

[00:52] Bug #1155276 changed: support ~/.juju/environments.d

[00:55] cherylj: thanks! will land now [04:22] Bug # changed: 1558223, 1561566, 1569969, 1570175 [14:12] Bug #1593978 opened: failed to bootstrap === lazyPower is now known as lazypower-travel [16:51] Bug #1593996 opened: unit agent tests cannot run uniter [18:42] Bug #1593996 changed: unit agent tests cannot run uniter === ejat_ is now known as ejat [22:25] Bug #1593978 changed: failed to bootstrap