[21:28] <thumper> what is the godeps flag to look at the current deps?
[21:31] <thumper> nm
[21:31]  * thumper is running all the tests
[21:32] <thumper> exorcise complete in master
[21:32] <thumper> exorcism
[21:36] <thumper> 34 files, +370 −691
[21:36] <thumper> not a bad change
[21:36] <thumper> http://reviews.vapour.ws/r/5103/
[21:45] <thumper> hmm
[21:45] <thumper> I spotted a few things myself in that review
[21:45]  * thumper goes to tweak...
[21:55]  * thumper runs up to physio
[21:55] <thumper> bbs
[22:37] <thumper> wallyworld: ping
[22:44] <thumper> davecheney: review above removes fslock from master
[22:44]  * thumper starts on 1.25 backport
[23:08] <wallyworld> thumper: hey
[23:11] <menn0> thumper: this adds access to the minion reports to the migrationmaster apiserver facade: http://reviews.vapour.ws/r/5105/
[23:15] <thumper> wallyworld: you are reviewer, and I have a review :)
[23:15] <wallyworld> so i see
[23:18]  * thumper sighs...
[23:35] <davecheney> thumper: ta
[23:36] <wallyworld> thumper: in RunTestSuite, why pass in a wall clock instead of a mock? is the thinking that the delay is "only" 250ms? why not use testing.ShortDelay?
[23:36] <thumper> wallyworld: I was trying to reduce the work to get the code in
[23:36] <thumper> really it isn't going to matter because the lock isn't held
[23:37] <thumper> so the delay never occurs
[23:37] <thumper> could change to testing.ShortDelay
[23:37] <thumper> should have zero impact
[23:37] <wallyworld> yes please
[23:37] <wallyworld> for consistency
[23:37] <wallyworld> with out tests around the place
[23:37] <wallyworld> *other
[23:37] <thumper> add comments
[23:37] <thumper> I'll go through them
[23:38] <wallyworld> if lock is never held, isn't that a gap in the tetst?
[23:38] <thumper> there are some places where we test for held locks
[23:39] <thumper> in the important places
[23:39] <thumper> well, most places that actually use the lock
[23:40] <wallyworld> ok
[23:46] <davecheney> thumper: looks pretty close to me
[23:57] <thumper> wallyworld: while you finish looking, I'll head out to lunch and address both davecheney's comments and yours after lunch
[23:57] <wallyworld> ok