| dandrader | tsdgeos, are you reviewing https://code.launchpad.net/~dandrader/unity8/splashRotation/+merge/297318 ? | 10:30 |
|---|---|---|
| tsdgeos | damn i forgot | 10:32 |
| tsdgeos | will do today | 10:32 |
| dandrader | ok, thanks | 10:32 |
| tsdgeos | dandrader: only a nitpick | 12:27 |
| tsdgeos | code looks good and test looks | 12:27 |
| tsdgeos | not sure i feel totally confident with top approving given i don't have a device where this actually happens | 12:27 |
| dandrader | tsdgeos, you can reproduce it with any phone if you hold it on landscape | 12:38 |
| tsdgeos | can you? | 12:39 |
| tsdgeos | i didn't understand it like that on the bug | 12:39 |
| tsdgeos | ok, let me try the | 12:39 |
| tsdgeos | n | 12:39 |
| === dpm_ is now known as dpm | ||
| dandrader | tsdgeos, a phone held on landscape (with unity8-dash in landscape) is exactly like a flo or m10 on landscape | 12:39 |
| tsdgeos | dandrader: there's the "primary orientation" concept that is slightly different, no? | 12:40 |
| dandrader | tsdgeos, yes, but since untiy8-dash no longs sticks to the primary orientation, it boils down to the same | 12:41 |
| tsdgeos | oka | 12:42 |
| tsdgeos | dandrader: can you do this easy one https://code.launchpad.net/~aacid/unity8/components_for_gu/+merge/297924 ? | 12:45 |
| tsdgeos | nice i'm downloading at 7KB/s | 12:45 |
| tsdgeos | let me reboot the router and see if that improves | 12:45 |
| yw | seb128 - re: our chat yesterday re: dash issue, apparently there is a bug https://bugs.launchpad.net/ubuntu/+source/unity/+bug/1493106 | 15:10 |
| ubot5 | Launchpad bug 1493106 in unity (Ubuntu) "Dash randomly becomes transparent to mouse events" [High,Confirmed] | 15:10 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| josharenson | Do you have to manually add the key for the yakkety repo, or am I under some sophisticated attack....? | 17:03 |
| josharenson | mterry: so I have a hack idea for the sessions list | 17:14 |
| mterry | josharenson, go on... | 17:14 |
| mterry | :) | 17:14 |
| josharenson | mterry: let me make a small diff, it will explain better than I can with actual words | 17:14 |
| josharenson | mterry: http://pastebin.ubuntu.com/17652005/ | 17:15 |
| josharenson | mterry: so the code for the view has this wonderful condition where if text==="", it breaks | 17:16 |
| josharenson | mterry: and I can't figure out how to apply a style to the text... | 17:16 |
| josharenson | mterry: and I don't want to re-implement everything just for the ability to change the text color... | 17:16 |
| josharenson | mterry: but let me know if there is a better way that I'm missing | 17:17 |
| josharenson | mterry: (sorry to keep spamming), I'll add an elide to that text area if you think its a decent work around | 17:17 |
| mterry | josharenson, ok... wait, so why is display ever ""? | 17:17 |
| mterry | josharenson, in real world it wouldn't be, right? | 17:17 |
| josharenson | mterry: its never "", just explaining why I have it set to " " | 17:17 |
| josharenson | instead of any other value | 17:18 |
| mterry | josharenson, oh I see you can't adjust text color | 17:18 |
| josharenson | mterry: sadly | 17:18 |
| josharenson | mterry: at least that I can see | 17:18 |
| mterry | josharenson, sure seems fine. Just add a comment maybe for the " " bit | 17:19 |
| josharenson | mterry: ack... | 17:19 |
| mterry | josharenson, and maybe left-align instead of center? | 17:19 |
| mterry | josharenson, works better for lists | 17:19 |
| josharenson | mterry: ah, I agree | 17:19 |
| mterry | josharenson, elide or use a FadingLabel -- we use FadingLabel elsewhere in greeter, might make sense to be consistent here too | 17:19 |
| josharenson | ok | 17:20 |
| mterry | josharenson, (another reason to use custom text object) | 17:20 |
| vitimiti | Oh, FadingLabel is part of the QML modules now? | 17:44 |
| === JanC is now known as Guest79667 | ||
| === JanC_ is now known as JanC | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!