| axw | wallyworld: I was thinking we'd have a separate command and API to revoke credentials | 00:28 |
|---|---|---|
| wallyworld | axw: no worries, wasn't sure as both approaches can be used | 00:29 |
| katco | wallyworld: hey sorry that patch you reviewed is kind of a mess. it's WIP and dependent on 2 other PRs, so some of the stuff you've commented on are covered in other PRs | 00:39 |
| wallyworld | katco: no worries, just wanted to give some initial feedback | 00:39 |
| katco | wallyworld: i'm not sure why review board doesn't do the diff between a branches parent | 00:40 |
| katco | wallyworld: yeah ta | 00:40 |
| axw | wallyworld: can you please see my reply, I'm just live testing one last time | 00:50 |
| wallyworld | ok | 00:50 |
| wallyworld | axw: lgtm | 00:51 |
| axw | wallyworld: ta | 00:51 |
| === thumper-afk is now known as thumper | ||
| marcoceppi | still no shared filesystems in Juju? | 01:26 |
| wallyworld | marcoceppi: that got bumped in lieu of other feature work | 01:29 |
| marcoceppi | it basically makes every web application impossible to charm still without some storage subordinate janky charm | 01:29 |
| marcoceppi | wordpress, mediawiki, django apps, anyhting storing uploads is just garbage | 01:30 |
| wallyworld | marcoceppi: i hear you. people with higher pay grades mae those priority calls | 01:30 |
| marcoceppi | i hear you, wish it was different | 01:30 |
| wallyworld | me too | 01:30 |
| axw | wallyworld: ok for me to land this cloud change right? | 01:31 |
| thumper | marcoceppi: it is our unique funding model :) | 01:31 |
| axw | before beta | 01:32 |
| axw | ... because they'll just pick another rev if I break things | 01:32 |
| wallyworld | axw: let's just check that the previous CI run passes | 01:32 |
| axw | ok | 01:32 |
| wallyworld | axw: a minute late | 01:59 |
| wallyworld | axw: sorry, thumper won't stop talking | 02:07 |
| thumper | :( | 02:07 |
| axw | heh | 02:07 |
| wallyworld | menn0: you arriving sat arvo? anastasia will be there alredy and i arrive sat evening, so let's do something sunday, unless you have other plans | 02:23 |
| axw | wallyworld: reviewed | 02:31 |
| wallyworld | ta | 02:31 |
| menn0 | wallyworld: sounds good. I haven't made any plans for sunday. | 02:31 |
| menn0 | wallyworld: I arrive sat afternoon | 02:32 |
| wallyworld | menn0: ok, i arrive at airport around 20:30 | 02:32 |
| wallyworld | will catch up for breakfast if not before - maybe you'll be at bar drinking :-) | 02:33 |
| menn0 | wallyworld: it has been known to happen :) | 02:33 |
| wallyworld | to the best of us | 02:34 |
| menn0 | wallyworld: although I might hit some of my old haunts instead of the hotel bar | 02:34 |
| menn0 | wallyworld: it's my old hood | 02:34 |
| wallyworld | nice | 02:34 |
| menn0 | wallyworld: i'll have data so ping me on twitter or something | 02:34 |
| * wallyworld doesn't do social mendia | 02:34 | |
| wallyworld | *media | 02:34 |
| menn0 | wallyworld: of course, I forgot :) | 02:35 |
| wallyworld | i'll be at breakfast first thing | 02:35 |
| menn0 | wallyworld: email then | 02:35 |
| wallyworld | or hangout message | 02:35 |
| menn0 | even better | 02:35 |
| menn0 | and failing that I'll be at breakfast in the morning too | 02:35 |
| axw | wallyworld: http://reviews.vapour.ws/r/5156/ | 03:58 |
| wallyworld | looking | 03:58 |
| axw | wallyworld: I think I'll look at splitting model/controller config schemas | 03:59 |
| axw | now | 03:59 |
| wallyworld | sgtm, hopefully won't take much | 03:59 |
| mup | Bug # changed: 1414890, 1460685, 1491578, 1506338 | 04:25 |
| axw | wallyworld: I'm really not fond of that code I took out. I don't think it's needed, because we always generate SSH keys for the client anyway. | 04:35 |
| wallyworld | ok, we can always change if needed | 04:36 |
| === urulama|__ is now known as urulama | ||
| ericsnow | wallyworld: FYI, I have a WIP in for the "final" patch (the one that actually adds the worker) | 05:50 |
| ericsnow | wallyworld: http://reviews.vapour.ws/r/5157/ | 05:50 |
| ericsnow | wallyworld: now I need to be asleep :) | 05:50 |
| mup | Bug #1414890 opened: Network security tests fail, all ports open when using the local provider <charms> <local-provider> <juju-core:New> <https://launchpad.net/bugs/1414890> | 06:55 |
| mup | Bug #1414890 changed: Network security tests fail, all ports open when using the local provider <charms> <local-provider> <juju-core:New> <https://launchpad.net/bugs/1414890> | 07:04 |
| mup | Bug #1414890 opened: Network security tests fail, all ports open when using the local provider <charms> <local-provider> <juju-core:New> <https://launchpad.net/bugs/1414890> | 07:10 |
| === frankban|afk is now known as frankban | ||
| * babbageclunk sighs. | 08:34 | |
| babbageclunk | dimitern: ping? | 08:35 |
| babbageclunk | dimitern: I hacked up the postgres charm last night - it's pretty neat! | 08:43 |
| dimitern | babbageclunk: hey | 08:47 |
| dimitern | babbageclunk: sorry, still reading the headlines... | 08:47 |
| babbageclunk | dimitern: man, tell me about it. | 08:47 |
| dimitern | babbageclunk: so what about the charm? | 08:47 |
| dimitern | babbageclunk: you added bindings? | 08:48 |
| babbageclunk | dimitern: No, just in reference to your email about charming - I was hacking workload version into the postgresql charm. | 08:48 |
| dimitern | babbageclunk: ah :) I see | 08:49 |
| babbageclunk | dimitern: but it was fun, and easier than I'd anticipated | 08:49 |
| babbageclunk | dimitern: hmm - about bindings - are we (or maybe charmers) going to need to come up with standard names for spaces so that bindings match up between different charms? | 08:50 |
| dimitern | babbageclunk: it is neat, getting into charming for sure is - I was surprised, and as they say here 'appetite grows along with eating more of it' :) | 08:50 |
| babbageclunk | dimitern: ha | 08:50 |
| babbageclunk | dimitern: ...or is there a way to say "this binding corresponds to this space" when deploying? | 08:51 |
| dimitern | babbageclunk: yeah - `juju deploy .. --bind '<ep1>=<sp1> <ep2>=<sp2> ..'` | 08:52 |
| babbageclunk | dimitern: Ah, hadn't seen that. Cool. | 08:53 |
| dimitern | babbageclunk: or just --bind '<sp>' to bind all to the same (can also mix those 2) | 08:53 |
| babbageclunk | dimitern: Would you be able to look at this review? It's pretty straightforward. http://reviews.vapour.ws/r/5152/ | 08:53 |
| dimitern | babbageclunk: sure | 08:54 |
| dimitern | babbageclunk: LGTM | 09:01 |
| voidspace | dimitern: babbageclunk: be at standup in 5 | 09:01 |
| dimitern | ok | 09:04 |
| dimitern | frobware: standup? | 09:04 |
| aim__ | dimitern: yep, trying... | 09:14 |
| frobware | dimitern: did you see the latest missing 'search' comments in /etc/resolv.conf. https://bugs.launchpad.net/juju-core/+bug/1575940 | 09:35 |
| mup | Bug #1575940: LXC containers under MAAS get no "search <domain>" entry in resolv.conf when deployed with juju2 <cdo-qa-blocker> <landscape> <juju-core:Triaged> <https://launchpad.net/bugs/1575940> | 09:35 |
| dimitern | frobware: looking | 09:36 |
| dimitern | frobware: that's beta9 though.. | 09:37 |
| frobware | dimitern: right, the changes you landed will only be available in 10 or a daily ppa | 09:37 |
| dimitern | frobware: yeah, but I'll try to repro those last steps with b10 + 1.9.3 and 2.0b8 maas | 09:38 |
| frobware | dimitern: great, thanks | 09:40 |
| * dimitern thinks .. at least brexit didn't happen just before a release.. that would've been bad.. oh wait a minute! :/ | 10:21 | |
| andrey-mp | jamespage: Am I right that next release of OpenStack charms will be 07/16? If it so - when last changes can be made for this release? Is it possible to merge my changes for nova-compute https://review.openstack.org/#/c/331249/ ? | 11:22 |
| jamespage | andrey-mp, hey! | 11:23 |
| jamespage | andrey-mp, https://launchpad.net/charms/+milestone/16.07 due 07/28 | 11:23 |
| andrey-mp | hi! | 11:23 |
| jamespage | we freeze two weeks in advance of that date - so I think that's the 14th | 11:23 |
| jamespage | for features to land; I have your review on my todo list | 11:24 |
| andrey-mp | good, thanks ) | 11:24 |
| jamespage | andrey-mp, do you have an example ephemeral backend charm as well? | 11:24 |
| andrey-mp | will wait for comments | 11:24 |
| andrey-mp | yeah - https://jujucharms.com/u/cloudscaling/scaleio-openstack | 11:24 |
| andrey-mp | this is charm for connecting ScaleIO storage as ephemeral to nova-compute | 11:25 |
| andrey-mp | this charm also connects ScaleIO storage to cinder via storage-backend | 11:25 |
| dimitern | frobware: ping | 11:42 |
| frobware | dimitern: pong | 11:46 |
| dimitern | frobware: re bug 1575940 | 11:46 |
| mup | Bug #1575940: LXC containers under MAAS get no "search <domain>" entry in resolv.conf when deployed with juju2 <cdo-qa-blocker> <landscape> <juju-core:In Progress by dimitern> <juju-core 1.25:Triaged> <https://launchpad.net/bugs/1575940> | 11:46 |
| dimitern | frobware: I've reproduced it, working on a fix | 11:46 |
| frobware | dimitern: what's the issue? | 11:47 |
| dimitern | frobware: good we caught this before beta10 is out, and I strongly suspect it affects 1.25 too | 11:47 |
| frobware | ooh | 11:47 |
| dimitern | frobware: adding a comment to the bug now - basically the issue is with `if !haveDNSConfig { // parse resolv.conf }` (in worker/provisioner/broker.go | 11:48 |
| dimitern | frobware: i.e. it happens if we only have dns servers (which is the only thing we can get from MAAS 1.9 API), but not search | 11:49 |
| dimitern | easy to fix at least - just need to check whether we have both fields set | 11:50 |
| frobware | dimitern: bleh | 11:51 |
| frobware | dimitern: that's horrible | 11:51 |
| dimitern | frobware: yeah :/ | 11:52 |
| mup | Bug #1595937 opened: there is no way to configure the availability zone for neutron's dhcp agents <juju-core:New> <https://launchpad.net/bugs/1595937> | 12:02 |
| frobware | dimitern: do you have some time to talk about the fan? | 12:15 |
| dimitern | frobware: yeah, but can it be a bit later? | 12:16 |
| dimitern | frobware: I need to go to the bank now (again) | 12:16 |
| frobware | dimitern: yep sure - np. Selling sterling? :-D | 12:16 |
| dimitern | :D | 12:16 |
| dimitern | frobware: I wish | 12:16 |
| frobware | dimitern: I'm just going to invent myown | 12:17 |
| dimitern | frobware: there's the fix for dns search missing: http://reviews.vapour.ws/r/5159/ | 12:17 |
| dimitern | voidspace, babbageclunk: ^^ please take a look | 12:17 |
| * dimitern steps out, back in ~30m hopefully | 12:17 | |
| voidspace | dimitern: LGTM | 12:18 |
| dimitern | voidspace, babbageclunk, frobware: thanks guys! | 13:18 |
| dimitern | frobware: hey, you wanted to sync re the fan? | 13:50 |
| === redelmann is now known as rudi|wfh | ||
| mup | Bug #1588575 changed: allwatcher_internal_test has intermittent failure <intermittent-failure> <juju-core:Fix Released by dave-cheney> <https://launchpad.net/bugs/1588575> | 14:08 |
| === alexisb-afk is now known as alexisb | ||
| babbageclunk | dimitern, frobware, voidspace: review please? http://reviews.vapour.ws/r/5161/ | 14:17 |
| dimitern | babbageclunk: looking | 14:18 |
| babbageclunk | Thanks! | 14:18 |
| dimitern | sinzui: hey, did we cut 2.0 beta10 yet? | 14:25 |
| dimitern | sinzui: FWIW there's a fix landing as we speak, which will be good to be in beta10 | 14:25 |
| sinzui | dimitern: yes we have | 14:26 |
| dimitern | sinzui: ok, then the fix will be in beta11 I guess | 14:26 |
| sinzui | dimitern: yep. We will release next week | 14:27 |
| dimitern | ok | 14:27 |
| alexisb | katco, ping | 14:36 |
| katco | alexisb: pong | 14:36 |
| alexisb | perrito666, ping, you still around today?? | 14:37 |
| cherylj | dimitern: what fix? | 14:38 |
| mup | Bug # changed: 1467331, 1486712, 1567951, 1567963, 1568090, 1571792, 1576003, 1593299, 1593566, 1593761, 1593838, 1594232, 1594335, 1594580, 1594855, 1594875, 1595278 | 14:38 |
| dimitern | cherylj: for bug 1575940 | 14:38 |
| mup | Bug #1575940: LXC containers under MAAS get no "search <domain>" entry in resolv.conf when deployed with juju2 <cdo-qa-blocker> <landscape> <juju-core:Fix Committed by dimitern> <https://launchpad.net/bugs/1575940> | 14:38 |
| natefinch | welp.... our meals will be cheaper at the sprint at least. | 14:38 |
| cherylj | dimitern: oh, you figured it out?! awesome! | 14:39 |
| dimitern | cherylj: yeah :) | 14:39 |
| perrito666 | alexisb: I am intermittently | 14:41 |
| cherylj | dimitern: I bet ahasenack is relieved that he wasn't going crazy with that bug. | 14:43 |
| cherylj | dimitern: thanks for tracking it down | 14:43 |
| dimitern | cherylj: :) yeah - if I looked more carefully earlier I would've been able to repro and fix it earlier.. | 14:44 |
| ahasenack | cherylj: :) | 14:45 |
| natefinch | sinzui: has your MAAS come back up? Wondering how the HA CI test fared | 14:46 |
| dimitern | ahasenack: sorry ;) | 14:46 |
| sinzui | natefinch: yes, let me see if I can find you two results. master consistently fails, but model-migrations passed | 14:46 |
| ahasenack | I was the last standing witness, since cgregan wasn't seeing it anymore | 14:46 |
| katco | does anyone know if we can still accept patches from people in the UK? | 14:47 |
| dimitern | I bet he didn't go and set dns servers on subnets directly though, and it can't be repro'd with a default maas installation | 14:47 |
| natefinch | katco: lol | 14:47 |
| dimitern | katco: don't be nasty to the poor guys :D | 14:48 |
| sinzui | natefinch: on master, HA is never reached: http://reports.vapour.ws/releases/4099/job/functional-ha-recovery-maas-1-9/attempt/8 | 14:48 |
| natefinch | sinzui: ok. Does the same test pass on other substrates? | 14:48 |
| sinzui | natefinch: the model-migrations branch passes http://reports.vapour.ws/releases/4097/job/functional-ha-recovery-maas-1-9/attempt/6 | 14:49 |
| katco | dimitern: lol wasn't meant to be a jab. commentary on isolationism, ramifications of that vote | 14:49 |
| sinzui | natefinch: Yes, the test passes on aws, azure, and openstack | 14:49 |
| dimitern | katco: :) jk | 14:49 |
| katco | dimitern: how are you btw | 14:49 |
| natefinch | sinzui: ok, good. That jives with my manual testing. | 14:49 |
| dimitern | katco: tired.. I'm looking forward to getting back from the sprints hehe | 14:50 |
| dimitern | but also for some beers while at them | 14:50 |
| katco | dimitern: :) | 14:50 |
| natefinch | sinzui: interesting that it passes on the model migration branch... thanks for that info, that could be very useful | 14:50 |
| dimitern | somebody didn't use the pre-push hook recently.. | 14:51 |
| dimitern | checking: go vet ... | 14:51 |
| dimitern | provider/openstack/firewaller.go:234: arg c.environ.Config().UUID() for printf verb %s of wrong type: (string, bool) | 14:51 |
| dimitern | provider/openstack/firewaller.go:354: arg c.environ.Config().UUID() for printf verb %s of wrong type: (string, bool) | 14:51 |
| dimitern | provider/openstack/firewaller.go:368: arg c.environ.Config().UUID() for printf verb %s of wrong type: (string, bool) | 14:51 |
| dimitern | 14:51 | |
| natefinch | dimitern: I never use the pre-push hook. If we don't enforce it on the bot, it's not a real rule. But my editor runs go vet on save, so.... | 14:52 |
| dimitern | natefinch: good point, it should be part of what 'make check' does | 14:53 |
| natefinch | dimitern: I also never use the makefile :) | 14:53 |
| dimitern | natefinch: but the merge bot does ;) | 14:53 |
| natefinch | dimitern: indeed. | 14:53 |
| babbageclunk | forgot - I need to go home now while my wife goes to the doctor, but I'll be back online from there. | 14:56 |
| katco | redir: standup time | 15:03 |
| alexisb | all I will be out for a bit this morning, call my cell if somehting is urgent | 15:09 |
| === alexisb is now known as alexisb-afk | ||
| perrito666 | bbl mail me if you need me urgnently ill be on and off all day | 15:11 |
| === frankban is now known as frankban|afk | ||
| === alexisb-afk is now known as alexisb | ||
| perrito666 | is there a way to ask state if a model is controller model? | 16:55 |
| mup | Bug #1594865 changed: 2.0 beta8: deployment with sphere as provider - bootstrap node - no space left on / <oil> <juju-core:Invalid> <https://launchpad.net/bugs/1594865> | 17:05 |
| voidspace | frobware: simple-ish one if you're still around http://reviews.vapour.ws/r/5162/ | 17:09 |
| frobware | voidspace: remind me again... what's the deal with omitempty and time? | 17:11 |
| voidspace | frobware: it just doesn't work... | 17:12 |
| voidspace | frobware: it gets omitted all the time | 17:12 |
| voidspace | frobware: even when it's there - so you have to use a pointer | 17:12 |
| frobware | voidspace: asked for an explanation in the review. | 17:12 |
| frobware | voidspace: as in we add something explainging what doesn't work | 17:13 |
| voidspace | ok | 17:13 |
| frobware | voidspace: I'm rushing this; will look on monday as I need to go out | 17:16 |
| perrito666 | K going to London bbl | 17:16 |
| katco | perrito666: safe travels | 17:16 |
| voidspace | frobware: perrito666: bye o/ | 17:16 |
| perrito666 | Man this referendum really broke my 1us 1eu chain :p | 17:18 |
| mup | Bug #1596038 opened: typo in cloud definition yields "ERROR cloud <foo> does not require credentials" <landscape> <usability> <juju-core:New> <https://launchpad.net/bugs/1596038> | 17:29 |
| mup | Bug #1596039 opened: juju add-cloud should tell you what it did <landscape> <usability> <juju-core:New> <https://launchpad.net/bugs/1596039> | 17:29 |
| mup | Bug #1596045 opened: Juju says windows mongo: invalid version <blocker> <ci> <mongodb> <regression> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1596045> | 17:54 |
| perrito666 | oi, I am partially back, now from the airport | 18:19 |
| alexisb | perrito666, either that was a very short flight to london or something happened wtih your travels | 18:23 |
| perrito666 | alexisb: Cordoba airport | 18:23 |
| perrito666 | I was here incredibly early | 18:23 |
| perrito666 | exiting my lovely country requires bureaucracy so I decided that I wanted room just in case | 18:24 |
| natefinch | yeah, I prefer to be super early, too. Much rather mess around in the airport for an hour or so, than be running and scared I'm going to miss my flight. | 18:25 |
| perrito666 | ouch my screen is starting to show some serious screen burn I hope it will ive until laptop refresh | 18:25 |
| katco | perrito666: what's the period on laptop refreshes? | 18:45 |
| perrito666 | katco: 3ys I believe | 18:47 |
| katco | perrito666: cool | 18:47 |
| natefinch | yeah, 3 years | 18:55 |
| perrito666 | that would be march for me | 18:55 |
| katco | ericsnow: ping | 18:55 |
| natefinch | July for me :) | 18:56 |
| ericsnow | katco: pong | 18:56 |
| katco | ericsnow: hey, trying to use the stub framework, but when i do .CheckCall i get this: "... mismatch at .FuncName: unequal; obtained "github.com/juju/juju/apiserver/observer/fakeobserver.(*Instance).Join"; expected "Join"" | 18:56 |
| katco | ericsnow: is there a way to make it not care about the namespace + type? what am i doing wrong? | 18:57 |
| ericsnow | katco: it uses whatever you passed to Stub.AddCall() | 18:58 |
| katco | ericsnow: ah ok. see if i can clean that up a bit, thanks | 18:58 |
| ericsnow | katco: I'd recommend using a string literal in that call | 18:58 |
| katco | ericsnow: i'm using reflection; seems more robust | 18:59 |
| alexisb | anyone on the channel used dave's pprof command? | 19:09 |
| mup | Bug #1596066 opened: Juju never achieves HA on maas 1.9 with trusty <blocker> <ci> <maas-provider> <regression> <trusty> <juju-core:Triaged> <https://launchpad.net/bugs/1596066> | 19:09 |
| natefinch | alexisb: https://medium.com/@tjholowaychuk/profiling-golang-851db2d9ae24#.vlmpkj2tg | 19:23 |
| mup | Bug #1596066 opened: In some configurations, juju never achieves HA on maas 1.9 with trusty <blocker> <ci> <maas-provider> <regression> <trusty> <juju-core:Triaged> <https://launchpad.net/bugs/1596066> | 19:24 |
| mup | Bug #1596071 opened: api documentation should be written from a user perspective <landscape> <juju-core:New> <https://launchpad.net/bugs/1596071> | 19:24 |
| natefinch | ericsnow: it looks like we don't ever call Priority.decode? | 19:42 |
| ericsnow | natefinch: hmm, I thought there was a test that roundtripped it | 19:43 |
| ericsnow | natefinch: thanks for that review :) | 20:28 |
| marcoceppi | rick_h_ alexisb what's the over under on the api changing agian for beta11? | 20:37 |
| rick_h_ | marcoceppi: I'd not take any odds on that | 20:37 |
| marcoceppi | rick_h_: I really /really/ want to update bundletester/amulet/deployer/python-jujuclient but if beta11 is likely to have more breakage I don't want to have developers constantly patching to keep up | 20:38 |
| rick_h_ | marcoceppi: I'd really hoped to have things frozen but it's not worked out that way and I've learned my lesson that I just don't think I can say anything with a really firm commitment there. | 20:41 |
| rick_h_ | marcoceppi: the big rename branch of Tim's missed some areas of the code that we're debating if it needs to be done or not now | 20:42 |
| rick_h_ | marcoceppi: so I know if several chunks that aren't determined as "go" or "no go" yet that will be breaking api changes | 20:42 |
| marcoceppi | rick_h_: cool, I wasn't looking for a promise, just if there were still murmors | 20:42 |
| rick_h_ | marcoceppi: lots of murmors | 20:42 |
| marcoceppi | rick_h_: cool, we'll evaluate the level of work, and keep an eye out for the next few days next week if there's any announcement of changes | 20:42 |
| marcoceppi | +1 to the mails that have gone out so far announcing changes before they land | 20:42 |
| marcoceppi | it's really helped us from getting soured when betas drop | 20:43 |
| rick_h_ | marcoceppi: yes, we'll be continuing that for sure. It's a case of "the least we can do" :) | 20:43 |
| marcoceppi | \o/ | 20:44 |
| babbageclunk | ericsnow, natefinch: would either of you be able to review a bugfix for me? http://reviews.vapour.ws/r/5163/ | 20:49 |
| ericsnow | babbageclunk: sure | 20:50 |
| babbageclunk | ericsnow: thanks! | 20:51 |
| ericsnow | babbageclunk: LGTM | 20:52 |
| babbageclunk | ericsnow: awesome. | 20:52 |
| babbageclunk | ericsnow: See you on Monday! | 20:53 |
| katco | oh dear god. emacs truly can do anything: https://github.com/Fuco1/clippy.el | 20:54 |
| babbageclunk | katco: ha ha, I should install that. | 21:04 |
| katco | babbageclunk: it looks like you're trying to install clippy.el | 21:04 |
| babbageclunk | ericsnow: mind reviewing the dependency change for that too? http://reviews.vapour.ws/r/5164/ | 21:04 |
| babbageclunk | or katco, would you have a moment to review this? http://reviews.vapour.ws/r/5164/ | 21:14 |
| katco | babbageclunk: ship it | 21:14 |
| babbageclunk | katco: sweet, thanks | 21:15 |
| mup | Bug #1596104 opened: Can't kill a controller if the substrate is gone <v-pil> <juju-core:New> <https://launchpad.net/bugs/1596104> | 22:24 |
| katco | anyone still around? | 22:24 |
| redir | katco: :) | 22:25 |
| katco | redir: yay! i have a small review for you | 22:25 |
| redir | k | 22:25 |
| katco | redir: http://reviews.vapour.ws/r/5165/ | 22:25 |
| katco | redir: it doesn't require any juju knowledge, so if you're comfortable, i think you can +1 it. it's gating some of my other work | 22:25 |
| katco | redir: and i am just now seeing i should have implemented Increment and Decrement in terms of Add(n) | 22:27 |
| redir | should I look later? | 22:28 |
| katco | redir: no, new version up | 22:28 |
| mup | Bug #1596104 changed: Can't kill a controller if the substrate is gone <v-pil> <juju-core:Invalid> <https://launchpad.net/bugs/1596104> | 23:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!