| === lunarlamp is now known as mariusv | ||
| === shardy is now known as shardy_afk | ||
| smoser | harlowja, around ? | 19:58 |
|---|---|---|
| smoser | https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1596690 | 19:58 |
| harlowja | yo yo | 20:00 |
| harlowja | around, in all day meeting about ironic | 20:00 |
| harlowja | so may be on/off | 20:00 |
| harlowja | whats this azure thing | 20:00 |
| harlowja | lo | 20:00 |
| smoser | http://paste.ubuntu.com/17990192/ | 20:00 |
| smoser | is that sane ? | 20:01 |
| smoser | that obj.pkl think is apita | 20:01 |
| smoser | a pita | 20:01 |
| smoser | but when i load it from disk, i can't be guaranteed that it has a dsmode, as the dsmode was getting set in the __init__ | 20:01 |
| smoser | but restoring doesn't call __init__ | 20:01 |
| harlowja | hmmmm, stupid pickle | 20:01 |
| smoser | so that change there *does* stop the stack trace... as it then means the dsmode is gotten from the superclass. | 20:02 |
| harlowja | is there anyway to plugin to __setstate__ and ensure a default is set? | 20:02 |
| harlowja | https://docs.python.org/2/library/pickle.html#object.__setstate__ | 20:03 |
| smoser | maybe.. | 20:04 |
| smoser | so th patch there works, but wasn't sure if it migiht mean getting the super classes value all the time | 20:04 |
| smoser | i wouldnt think so, but need to check. | 20:04 |
| smoser | it seems to be ok.. the __setstate__ seems useful | 20:13 |
| smoser | i think amybe look at that late.r | 20:13 |
| smoser | i want to get to ditching the pkl'd object at some point | 20:13 |
| smoser | and have some better serialized object... less complex that is restored from | 20:14 |
| smoser | harlowja, could you sanity check http://paste.ubuntu.com/17991115/ ? | 20:18 |
| smoser | it seems to be right for me... tested that un-pickled objects that did not have the dsmode attribute now have it, and those that *did* have it keep their old value. | 20:19 |
| harlowja | ya, i think that will be ok | 20:19 |
| smoser | i guess the thing i'm really asking about is the differece between __init__ doing a self.dsmode = | 20:19 |
| smoser | and having dsmode as a class attribute | 20:20 |
| harlowja | ya, one is just setting it a class load time as a default | 20:23 |
| harlowja | which i guess is fine for this, until we get rid of the obj.pkl junk | 20:23 |
| harlowja | and move to something like to_json or something | 20:24 |
| smoser | right. ok thank you. | 20:25 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!