=== alexlist` is now known as alexlist
mupBug #1576366 changed: juju 2 beta6: show-controller --format=json is broken <landscape> <juju-core:Expired> <https://launchpad.net/bugs/1576366>04:25
=== frankban|afk is now known as frankban
=== gnuoy` is now known as gnuoy
perrito666I believe reviewboard is not having a good day08:00
perrito666this never got a rb link https://github.com/juju/juju/pull/574708:00
mupBug #1597354 changed: Juju 2.0 Resource Error - cannot add resource failed to write data: read tcp : i/o timeout <juju-core:Incomplete> <https://launchpad.net/bugs/1597354>08:28
mupBug #1598049 opened: TestLogRecordForwarded fails on non-ubuntu <blocker> <centos> <ci> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1598049>08:28
mgzcherylj, ericsnow: ^ bug A08:29
mgzericsnow, katco: also bug 1598063 (I have not assigned this one to milestone, we may be able to punt)08:56
mupBug #1598063: Data race in apiserver/observer package <race-condition> <juju-core:Triaged> <https://launchpad.net/bugs/1598063>08:56
mgzwait, I did, but maybe we punt08:57
mupBug #1598063 opened: Data race in apiserver/observer package <race-condition> <juju-core:Triaged> <https://launchpad.net/bugs/1598063>09:01
jammgz: https://github.com/juju/juju/pull/575009:39
mgzsinzui: this looks good to me ^09:41
mgzok  github.com/juju/juju/featuretests138.465s09:42
mgzericsnow: that's 54617e0a from wed09:43
mgzso, it passed (possibly with that junk in the logs, not shown), before your changes09:44
sinzuimgz: jam: yes this looks good. but consider that run-unit-tests always calls "go test -i ./..." now09:47
jamsinzui: I missed that, but I see it now.09:48
sinzuijam: so gig mgz...who add it to the script :)09:49
sinzuijam: mgz: In the past, we varied the command line for testing. 2 or 3 of the variations are no longer used. I think the only case where we don't use the makefile is running with race09:51
mgzsinzui: yeah, we were looking at the gating job specifically09:52
sinzuimgz: yeah that is one we flip-flop from makefile's test to --race09:53
sinzuimgz: and the goal for xenial-amd64 is to use race next week09:53
sinzuior today even09:53
perrito666would anyone kindly review https://github.com/juju/juju/pull/5747 that lacks a reviewboard link for reasons escape my control?10:14
perrito666axw: I addressed your comments for register, please re-check10:15
axwperrito666: reviewed10:22
perrito666axw: tx10:22
perrito666did you really go through the checklist?10:22
anastasiamacperrito666: did u keep checklist in mind while coding? :D10:27
* axw looks shamefaced10:27
axwwe're not starting till next week :)10:27
perrito666anastasiamac: evidently, I always do, even before it existed :p10:27
perrito666thumper: as if it had head you https://twitter.com/4BringingFire/status/74826585539857612810:30
mupBug #1598113 opened: resource-get should not download if not necessary <resources> <juju-core:New> <https://launchpad.net/bugs/1598113>11:11
perrito666cherylj: got a fail from featuretest, which I little suspected where testing this11:24
mgzperrito666: bug 1598049?11:28
mupBug #1598049: TestLogRecordForwarded fails on non-ubuntu <blocker> <centos> <ci> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1598049>11:28
mgzor a new one?11:28
perrito666mgz: a new one, I made a change in juju register and it would seem that the same functionality is being tested in the cmd tests and in feature tests11:30
=== bradm_ is now known as bradm
mupBug #1316223 changed: specifying juju deploy --networks=vlan:42 causes a panic <deploy> <juju-core:Invalid> <https://launchpad.net/bugs/1316223>11:53
mupBug #1584805 changed: Timeout in github.com/juju/juju/apiserver/service on windows <bitesize> <ci> <regression> <test-failure> <timeout> <unit-tests> <windows> <juju-core:Fix Released> <juju-core 1.25:New> <https://launchpad.net/bugs/1584805>11:53
mupBug #1595276 changed: TestDestroyControllerErrors failure with out of order errors <azure-provider> <ci> <intermittent-failure> <test-failure> <juju-core:Fix Released by fwereade> <https://launchpad.net/bugs/1595276>11:53
mupBug #1598118 opened: log-forwarder worker bounces endlessly when forwarding is not configured <2.0> <debug-log> <log-forwarding> <logging> <juju-core:Triaged> <https://launchpad.net/bugs/1598118>11:53
mupBug #1598127 opened: lxdbr0 spam in log file <logging> <juju-core:Triaged> <https://launchpad.net/bugs/1598127>12:02
perrito666mgz: this is a flaky run  right? http://juju-ci.vapour.ws:8080/job/github-merge-juju/8340/console12:10
mupBug #1598127 changed: lxdbr0 spam in log file <logging> <juju-core:Triaged> <https://launchpad.net/bugs/1598127>12:14
mupBug #1598127 opened: lxdbr0 spam in log file <logging> <juju-core:Triaged> <https://launchpad.net/bugs/1598127>12:23
dimiterncherylj: here it is - bug 159816413:32
mupBug #1598164: [aws] adding a machine post-bootstrap on the controller model closes of api port in controller security group <add-machine> <addressability> <ec2-provider> <tech-debt> <juju-core:New> <https://launchpad.net/bugs/1598164>13:32
mupBug #1598164 opened: [aws] adding a machine post-bootstrap on the controller model closes of api port in controller security group <add-machine> <addressability> <ec2-provider> <tech-debt> <juju-core:New> <https://launchpad.net/bugs/1598164>13:32
cheryljthanks, dimitern!13:34
katcomgz: thanks, i'll pick up bug 1598063 shouldn't be a hard dx/fix13:44
mupBug #1598063: Data race in apiserver/observer package <race-condition> <juju-core:Triaged by cox-katherine-e> <https://launchpad.net/bugs/1598063>13:44
mgzkatco: thank you!13:47
mgzperrito666: bug 159804915:03
mupBug #1598049: TestLogRecordForwarded fails on non-ubuntu <blocker> <centos> <ci> <test-failure> <windows> <juju-core:Triaged> <https://launchpad.net/bugs/1598049>15:03
perrito666mgz: tx15:05
katcovery simple review for someone: http://reviews.vapour.ws/r/5201/15:19
katcomgz: perhaps you are interested15:20
mupBug #1598206 opened: lxc/lxd/shared/util_linux.go sys/types.h: No such file or directory <blocker> <ci> <ppc64el> <regression> <test-failure> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1598206>15:26
mgzkatco: ta15:28
katcowallyworld: ping16:22
wallyworldkatco: hey, how'd the house go?16:23
katcowallyworld: fine, boring16:23
wallyworldboring is good16:23
katcowallyworld: yep :)16:23
katcowallyworld: re. your comment on my review. are you referring to the observer multiplexer?16:23
katcowallyworld: e.g. this? https://github.com/juju/juju/blob/master/apiserver/observer/observer.go#L102-L11516:24
katcoi.e. rather16:24
wallyworldkatco: https://github.com/juju/juju/blob/master/apiserver/observer/observer.go#L10916:24
wallyworldthe use of a go routine inside the loop16:25
katcowallyworld: i don't think that's what's causing the issue16:25
katcowallyworld: the race is between a call to ServerRequest and ServerReply16:25
wallyworldthe race output seemd to implicate that aspect; i was going by advice from williamn16:25
wallyworldie the race output specically talks about calls from inside those go eoutines16:26
katcowallyworld: that loop will just call a single observer method on multiple observers concurrently.16:26
katcowallyworld: yeah, but not at the top of the call-stack...16:26
katcowallyworld: Previous write by goroutine 56:16:27
katco  github.com/juju/juju/apiserver/observer.(*RequestNotifier).ServerRequest()16:27
katcowallyworld: Read by goroutine 245:16:27
katco  github.com/juju/juju/apiserver/observer.(*RequestNotifier).ServerReply()16:27
katcowallyworld: the issue is that there are two calls coming into the same observer concurrently... i could remove the multiplexer entirely and this race would still occur16:27
wallyworldok, my brain hasn't yet delved into the full detail, so i can't confirm mentally one way or the other16:28
wallyworldbut we didn;t see this race before right16:29
katcowallyworld: this observer had mutexes before16:29
wallyworldthe observer stuff seems to have introduced it16:29
wallyworldwhere were the mutexes? why were they removed?16:30
wallyworlddid their removal intorduce the race?16:30
katcowallyworld: https://github.com/juju/juju/blob/bbc4a902fe44ee6effdd5e0216b3e0b8216643ef/apiserver/apiserver.go#L24816:30
katcowallyworld: because of what i said in the PR... i incorrectly assumed that requests/replies would happen synchronously16:30
katcowallyworld: the rpc server does not guarantee that. it has nothing to do with the multiplexer16:31
katcowallyworld: here's where ServerReply is kicked off on a new goroutine: https://github.com/juju/juju/blob/master/rpc/server.go#L46516:32
wallyworldkatco: i'm slow today (or always) - so the above mutex on line 248 avoided races before this new work?16:32
katcowallyworld: apparently so16:32
wallyworldso why does this new work introduce the recaes then? is that mutex removed?16:32
wallyworldthe observer stuff should not need extra locking?16:33
katcowallyworld: yes, because the rpc server will call ServerRequest, and then spawn another goroutine and call ServerReply16:33
katcowallyworld: if it's not in the observer, we need to touch rpc.Conn to lock there16:34
katcowallyworld: i.e. synchronize the reply to the request so it's synchronous16:34
katcowallyworld: i can tell you don't believe me; i'll just inject the RequestNotifier and show that the problem doesn't reside in the multiplexer16:36
thumperwallyworld: yarp16:40
perrito666sinzui: 2 things, 1) how will I know when I have my new mongo 2) how did you find a mongo for windows with ssl?16:44
sinzuiperrito666: we rarely update the db. the choice to switch to 2.6 was driven by the case it is supported.16:45
sinzuiperrito666: When we want to test only with 3.2, we will put 3.2 on the host16:45
katcowallyworld: ok, justification posted to the review17:18
=== frankban is now known as frankban|afk
perrito666mgz: https://github.com/juju/juju/pull/575917:32
mupBug # changed: 1575940, 1588403, 1594415, 1596967, 1597372, 1597516, 159751918:18
wallyworldkatco: hey, sorry, have been smashed trying to get log forwarding working using the actual code for the build18:42
katcowallyworld: no worries at all18:43
wallyworldkatco: one comment given to me in additon was the use of a RWMutex instead of just a sync.Mutex - the added complexity is not justified18:45
katcowallyworld: i'm sorry, i don't understand how that's more complex?18:46
mupBug #1598272 opened: LogStreamIntSuite.TestFullRequest sometimes fails <ci> <intermittent-failure> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1598272>18:48
wallyworldkatco: it's cognitive overhead - when do i use read vs write lock, as opposed to just lock18:56
mupBug #1585825 changed: Takes too long to download a resource from a controller to unit <ci> <resources> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1585825>18:57
katcowallyworld: shouldn't we be thinking about that?18:57
wallyworldkatco: not prematurely18:58
wallyworldnot unless it has been shown to be an issue18:58
katcowallyworld: it's our RPC mechanism, we want to limit our critical section as much as possible18:58
mupBug #1585825 opened: Takes too long to download a resource from a controller to unit <ci> <resources> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1585825>19:09
mupBug #1585825 changed: Takes too long to download a resource from a controller to unit <ci> <resources> <test-failure> <juju-core:Triaged> <https://launchpad.net/bugs/1585825>19:18
mupBug # opened: 1598286, 1598289, 1598290, 159829120:03
=== mup_ is now known as mup
mupBug # opened: 1598286, 1598289, 1598290, 1598291, 1598292, 159829320:24
mupBug #1598292 changed: log forwarding subject to clock skew <juju-core:Triaged> <https://launchpad.net/bugs/1598292>20:30
mupBug #1598293 changed: log forwarding feature does not use updated config <juju-core:Triaged> <https://launchpad.net/bugs/1598293>20:30
mupBug #1598292 opened: log forwarding subject to clock skew <juju-core:Triaged> <https://launchpad.net/bugs/1598292>20:36
mupBug #1598293 opened: log forwarding feature does not use updated config <juju-core:Triaged> <https://launchpad.net/bugs/1598293>20:36
=== urulama|___ is now known as urulama|____
mupBug #1598319 opened: Openstack Provider - No way to use multiple images <juju-core:New> <https://launchpad.net/bugs/1598319>23:46

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!