mupBug #1600061 opened: Expect multi-region MAAS clouds <juju-core:New> <https://launchpad.net/bugs/1600061>00:40
mupBug #1600063 opened: Remove the local: from cloud listing <juju-core:New> <https://launchpad.net/bugs/1600063>00:40
mupBug #1587739 changed: rackspace,vsphere: firewalling in HA setup is broken <juju-core:Fix Released by wallyworld> <https://launchpad.net/bugs/1587739>07:41
mupBug #1587739 opened: rackspace,vsphere: firewalling in HA setup is broken <juju-core:Fix Released by wallyworld> <https://launchpad.net/bugs/1587739>07:44
mupBug #1587739 changed: rackspace,vsphere: firewalling in HA setup is broken <juju-core:Fix Released by wallyworld> <https://launchpad.net/bugs/1587739>07:50
=== urulama|__ is now known as urulama
babbageclunkhey dimitern, could you take another look at http://reviews.vapour.ws/r/5161/ please?08:44
dimiternbabbageclunk, dooferlad: a tiny review fixing bug 1598164 - http://reviews.vapour.ws/r/5215/) please, take a look08:44
mupBug #1598164: [aws] adding a machine post-bootstrap on the controller model closes of api port in controller security group <add-machine> <addressability> <ec2-provider> <tech-debt> <juju-core:In Progress by dimitern> <https://launchpad.net/bugs/1598164>08:44
dimiternbabbageclunk: *click*08:45
babbageclunkdimitern: ha ha, swap you - looking now08:45
dimiternbabbageclunk: have you seen such an elaborate explanation for a 2 line fix? :D08:45
dimiternbabbageclunk: ha, that looks familiar ;) I'll give it a manual test now08:48
babbageclunkdimitern: quite a twisty tale!08:48
dimiternbabbageclunk: yeah, one of those you tell over campfire at night LOL08:49
* babbageclunk waves. :(08:52
dimiternbabbageclunk: I meant mine :)08:52
babbageclunkdimitern: Yeah, that's what I was talking about too!08:52
dimiternbabbageclunk: however reading fwereade's comments it seems we don't need the hook tool at all?08:52
babbageclunkdimitern: yours LGTM08:53
dimiternbabbageclunk: ta!08:53
babbageclunkdimitern: Only the get one - we still need the set.08:53
dimiternbabbageclunk: ah, now it makes more sense, yeah08:53
dimiternbabbageclunk: got a link to that modified postgresql charm?08:54
babbageclunkdimitern: Hmm, no - I could push it somewhere.08:55
babbageclunkdimitern: But would you be happy enough with `juju run --unit blah/0 "application-version-set yay"`?08:56
dooferladdimitern, babbageclunk: http://reviews.vapour.ws/r/5213/ and http://reviews.vapour.ws/r/5214/ are both small and high impact if you could take a look08:57
dimiterndooferlad: certainly, adding them to my list08:57
babbageclunkdooferlad: Think I can do them both in 2 mins?08:58
dimiternbabbageclunk: ok, so should work with an unmodified ubuntu charm then?08:58
dooferladbabbageclunk: probably08:58
babbageclunkdimitern: yup08:58
dimiterndooferlad: oh alright :)08:58
dimiterndooferlad: I'll swap those 2 for my tiny one08:59
dooferladdimitern: you are on08:59
babbageclunkdimitern: I can quickly fork and push the charm anyway - it's nicer to see it working properly.08:59
dimiterndooferlad: http://reviews.vapour.ws/r/5215/08:59
babbageclunkdimitern's one is small but perfectly formed08:59
dimiternbabbageclunk: that's better - it makes it reusable for CI as well08:59
babbageclunkdimitern: ok09:00
babbageclunkanyway, lets talk about this in video!09:00
dimiternbabbageclunk: beware though, if you haven't used the charm tools before to publish a charm, you'll need to both push it on LP and then grant everyone read access, otherwise only you'll see it on jujucharms.com/u/babbageclunk09:01
dimiternbabbageclunk: ping10:41
babbageclunkdimitern: hi10:42
babbageclunkdimitern: ?10:46
dimiternbabbageclunk: I'm trying to live test your branch10:49
dimiternbabbageclunk: on lxd I deployed 3 ubuntu units and tried juju run --unit ubuntu/X -- 'application-version-set Y'10:50
babbageclunkdimitern: ok10:50
dimiternbabbageclunk: should I be seeing what I set somewhere? I can't..10:50
babbageclunkdimitern: There's another change to add version to the tabular status, but it's not landed. Can you see it on juju status --format yaml?10:51
dimiternbabbageclunk: ah, yeah - I can see it now, sorry10:51
babbageclunkdimitern: awesome10:52
babbageclunkdimitern: Just working out how to create (the equivalent of) a pull request on bzr+launchpad.10:53
dimiternbabbageclunk: you can just push a local bzr branch to lp:~user/+junk/name IIRC10:55
babbageclunkdimitern: thanks11:09
mupBug #1600221 opened: "juju ssh" et al. should recommend add-ssh-key on auth failure <juju-core:Triaged> <https://launchpad.net/bugs/1600221>12:50
mupBug #1598358 opened: [juju beta10] With MAAS, node allocated but never told to deploy. <oil> <juju-core:New> <MAAS:Invalid> <https://launchpad.net/bugs/1598358>13:48
mupBug #1600237 opened: ErroredUnit: 0 is in state cannot complete machine configuration: model configuration has no authorized-keys <juju-ci-tools:New> <juju-core:New> <https://launchpad.net/bugs/1600237>14:18
mupBug #1600237 changed: ErroredUnit: 0 is in state cannot complete machine configuration: model configuration has no authorized-keys <juju-ci-tools:New> <juju-core:New> <https://launchpad.net/bugs/1600237>14:24
mupBug #1600237 opened: ErroredUnit: 0 is in state cannot complete machine configuration: model configuration has no authorized-keys <juju-ci-tools:New> <juju-core:New> <https://launchpad.net/bugs/1600237>14:27
mupBug #1600257 opened: The tab completion on juju yeilds KeyError: 'services' <juju-core:New> <https://launchpad.net/bugs/1600257>14:57
mbruzekHello balloons can I bother you for a minute?16:20
mbruzekballoons: Do you know where the tab completion code is for Juju? Regarding: https://bugs.launchpad.net/juju-core/+bug/160025716:20
mupBug #1600257: The tab completion on juju yeilds KeyError: 'services' <juju-core:New> <https://launchpad.net/bugs/1600257>16:20
balloonsmbruzek, yes I know where the code is16:34
mbruzekballoons: I found it in etc/bash_completion.d/16:35
balloonsmbruzek, that's an interesting bug. Right, that's the installed location16:35
balloonsmbruzek, it stems from https://github.com/juju/juju/tree/41eb73708fa1f86c337cf60d10c2c9f3b2b004f7/etc/bash_completion.d16:36
balloonsyou should be able to propose any fixes against one of those files16:37
mbruzekballoons: This is strange. I see the bash_completion file in juju-core (master) does not contain the word "services" but the one on my system does.16:37
mbruzekballoons: Perhaps it is resolved and just not released in beta11 yet?16:38
babbageclunkmbruzek: I think I was talking to you in the wrong channel :)16:38
babbageclunkmbruzek: or is your problem that installing the newer beta doesn't update the completions?16:39
mbruzekbabbageclunk: I just wanted to help fix this problem, but it looks OK in master16:40
babbageclunkmbruzek: Yeah, I tried the same thing a little while ago and realised it was already fixed. :)16:41
mbruzekI will stand down.16:41
balloonsI'm curious why you aren't seeing the fix in beta1116:42
mbruzekbabbageclunk: I see 3 files in /etc/bash_completion.d/ juju2, juju-core, and juju-core2. I don't see the corresponding files in the code tree in github. There must be some rule to copy those?16:42
balloonsmy expectation was it would be there16:43
balloonsmbruzek, yes the packaging code lives in a bzr brnach16:43
babbageclunkmbruzek: Hmm - maybe the wrong one is being found? Possibly one of them was renamed at some point, and so the old file has been orphaned in bash_completion.d?16:45
mbruzekbabbageclunk: I just compared the three files, the only difference is juju-core2 has #!/bin/bash on line 116:46
babbageclunkmbruzek: but they all still refer to services?16:47
babbageclunkmbruzek: This is in /etc/bash_completion.d?16:48
mbruzekbabbageclunk: Yes, and I see the file in master does not have any references to "services"16:48
mbruzekbabbageclunk: Correct on my system, xenial 16.0416:48
babbageclunkmbruzek: Do you install juju from ppa, or are you building it yourself?16:48
babbageclunkOk, in that case it sounds like there is still a bug with how the installer sets up completions.16:50
babbageclunkWhen you got beta11 it should have included updating the bash_completion.d files.16:52
jcastroI still don't have working completion16:52
balloonsI touched those rules last :-)16:53
mbruzekbabbageclunk:  ballooons:  Could you point me to the packaging branch on bzr so I could have a look?16:53
mupBug # opened: 1600296, 1600300, 1600301, 160030216:54
mbruzekahh I see the link above16:54
jcastrofyi I just reinstalled juju-2.0 from the ppa in xenial and I don't have anything juju related in /etc/bash_completion.d16:55
mbruzekLine 52 installs the file to /usr/share/bash-completion/completions/ but I was checking /etc/bash_completion.d/ directory.16:56
mbruzekI checked my system, I have juju-2.0 and juju-version in /usr/share/bash-completion/completions/16:57
babbageclunkWeird. I've got working completion, but mine's built from source and is installed from the makefile target (install-etc) whicn puts the files in /etc/bash_completion.d17:01
balloonsmbruzek, if you have the files in the right place, sourcing the directory should make tab completion work17:09
mbruzekballoons: is it possible this file used to install in /etc/bash_completion.d/ directory ? I may have old ones left over, but it seems to be favoring the /etc/bash_completion.d/ directory rather than the one in /usr/share/bash-completion/completions/17:27
balloonsmbruzek, it has changed a bit -- both the location and file name -- and the fact there are 2 files now17:31
mbruzekballoons: What should be done about the old files? I have juju2 and juju-core and juju-core2 which all appear to be the same file. Should the packaging clean up the old ones? Or is that an exercise left to the user?17:33
mupBug #1600311 opened: Juju 2.0 Bootstrap Fails on Ubuntu Trusty Power machine. <juju-core:New> <https://launchpad.net/bugs/1600311>17:54
balloonsmgz, opinions on old files ^^?17:57
mgz...dpkg should handle it17:57
balloonsmbruzek, for the ppa stuff, I would generally say it's just life. However for the archive, we shouldn't be leaving a mess. And since we depend on the ppa so heavily an argument could be made there as well to hold oneself to a higher standard.17:57
mgzmbruzek: which packages own which files?17:58
mbruzekmgz how can I tell that?17:58
mbruzekI just updated the bug: https://bugs.launchpad.net/juju-core/+bug/160025717:58
mupBug #1600257: The tab completion on juju yeilds KeyError: 'services' <juju-core:New> <https://launchpad.net/bugs/1600257>17:58
mbruzekIt seems like my system favors the files in /etc/bash_completion.d/17:59
balloonsmbruzek, you can use apt-file to check17:59
mgzmbruzek: `dpkg -S completions/juju` or similar18:00
mgzwhatver the new dir we put it in is called18:00
mgzmbruzek: `dpkg -S bash_completion.d/juju` for the old location as you seem to have those18:01
mbruzekmgz: http://pastebin.ubuntu.com/18804873/18:01
mgzballoons: did we not make a conflicts/replaces on juju-core2?18:02
mgzwe want juju2 and juju-core2 deaded if any new packages are installed18:03
balloonsmgz, my concern above came from the fact we have the ppa packaging and the archive packaging18:03
mgzjuju-core2 is superdead though right?18:03
mbruzekThat now includes the new files.18:03
mgzmbruzek: yeah, so it's a bad mix of ppa and archive18:03
mgzmbruzek: we should do a better job of sanity18:04
mgzmbruzek: I'd appreciate a bug against juju ini ubuntu for this18:04
mbruzekmgz: OK. I am happy to help, is my juju-core bug not sufficient? You want me to open this on ubuntu?18:04
mgzmbruzek: oh, you had one?18:05
mupBug #1600257: The tab completion on juju yeilds KeyError: 'services' <juju-core:New> <https://launchpad.net/bugs/1600257>18:05
mgzthat's fine, I shall just also affects distro/package to it18:05
mgzand you misspelt yields :P18:06
balloonsand yea juju-core2 is super dead18:06
balloonsbut clearly still lives!18:06
mbruzekballoons: I think all three files in /etc/bash_completion.d/ are "dead" from what I read in the current packaging18:08
mgzmbruzek: that should be correct18:09
mgzmbruzek: if you purge juju2 and juju-core2 do you still see the symptom?18:09
mgzmbruzek: thanks for poking this18:11
mbruzekGlad to help and if there is some code that needs to change I can sling some bash18:11
mbruzekmgz: I will delete the files after my standup.18:11
mbruzeketa 10 mins18:11
mgzmbruzek: aha, now that's an offer18:11
mbruzekmgz: I was digging into this because I thought it was something I could fix18:12
mbruzekmgz: It *is* but I don't know if you or balloons will let me fix it18:12
mbruzektrust is earned, not sure if I have achieved it yet.18:13
balloonsI would happily let someone unleash magic on bash completion. I've got it working on my box, but it hasn't translated to others.18:13
mbruzekmgz: balloons: I am done with meeting. I can purge the files in /etc/bash_completion.d/ now. Any objections? Is there anything else you want to see before I do that?18:25
mgzmbruzek: nope, go for it18:28
mbruzekDone. mgz: I have new information. My old terminals still get the Traceback, and a new terminal does not tab complete.18:28
mbruzekI understand why on the old terminals, but thew new on does not seem to be getting the new /usr/share/bash_completion/completions directory18:29
mgzokay, so we're back to the mystery of why some systems don't do anything with the file we add to the completions dir18:29
mgzmbruzek: hack-copy it to the old /etc location and see if that then completes in a new term? my guess is it will18:30
mbruzekmgz: Correct that works in my system.18:31
mgzokay, well I wish this stuff was documented like... anywhere18:32
mbruzekmgz: My system was 15.04 and was upgraded to xenial 16.04 . Would that have anything to do with this?18:32
mbruzekI tried to trace this from .bashrc to /usr/share/bash-completion/bash_completion let me inspect bash_completion more closely18:33
mgzmbruzek: it may, but really the upgrade should be transparent18:34
mbruzekmgz: I only mentioned that because the configuration files may have been from the old system, I think 15.04 was systemd also18:35
mgzyeah, and the defaulting to the old location makes more sense for a post-upgrade system18:36
mbruzekmgz: /usr/share/bash-completion/bash_completion18:36
mbruzekmgz: http://paste.ubuntu.com/18808058/18:36
mbruzekCan you compare that against your file? I see on line 43 it sets the backwards compat completion dir.18:37
mgzmbruzek: yeah, same on a fresh xenial system (and in fact on trusty), all claim RELEASE: 2.118:40
mgzjust having the concept of a compat dir is no problem provided it does actually look in the new place18:41
mbruzekmgz: I was not able to get tab completion when only juju-2.0 was in the new location...18:44
mgzmbruzek: on either juju<TAB> or juju-2.0<TAB> right? that's what's we've had reported before18:45
mbruzekmgz: Actually it was "juju ssh kuber<TAB>"18:46
mgzI'm not sure how we're meant to register completions under the new scheme, what we're doing (sticking in dir) doesn't seem enough18:46
mbruzekso it is using the ssh completion,18:46
mbruzekI can try juju-2.0 ssh kuber<TAB> if you like18:46
mgzyeah, I expect it's the same as would be juju s<TAB> but...18:47
mbruzekmgz: I am seeing a very strange behavior. I can do "juju-2.0 ssh kuber<TAB>" and THEN "juju ssh kuber<TAB>".  HOWEVER, if I start a new terminal "juju ssh kuber<TAB>" that does not work until I try juju-2.018:56
mgzokay, well that seems like fun18:57
mbruzekmgz: My current theory is "juju" does not alias to "juju-2.0" (which is the name of the completions file) until I use juju-2.0 first.18:57
mgzthat does seem likely18:57
mbruzeklet me symlink juju -> juju-2.0 and see if that helps18:58
mgzmbruzek: new thing to try, move the file in completions/ dir to 'juju' and see if new terminal then lets you juju s<TAB> immediately18:58
mbruzekmgz: The symbolic link worked?19:01
mgzokay, so the fancy mechanism does only load files based on the root path, then once it's loaded everything works19:02
mgzso... humph19:02
mbruzek! I meant the punctuation !19:02
mbruzekmgz: Do you agree with the symbolic link fix? Or would the name "juju" collide with the 1.25 version in packaging?19:29
mbruzekmgz: and or balloons: Here is my solution for your consideration:  https://code.launchpad.net/~mbruzek/juju-release-tools/packaging-juju2-default/+merge/29960019:45
mgzmbruzek: well, I guess the issue is are we okay with the script being executed twice19:51
mgzunder different names19:51
balloonsmbruzek, whoa that MP is insane.. target is off :-)20:00
balloonsso mbruzek, the file needs to be named juju right? And it works with 1.x and 2.x?20:00
balloonsif yes, we should change the upstream sourcew20:01
mbruzekballoons: I didn't test this with juju 1.x20:06
mbruzekballoons: what should the target be?20:07
balloonsit needs to work with both20:07
balloonsor perhaps better said; we need tab completion for both, and any change cannot break either20:07
mbruzekballoons: agreed...20:07
mbruzekballoons: perhaps we need to do further investigation into why juju-2.0 is not loading for "juju ssh kuber<TAB>"20:08

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!