dmj_s76 | xnox: Anything else you need for https://code.launchpad.net/~dmj726/ubiquity/nvme-fix/+merge/299596 ? | 16:40 |
---|---|---|
xnox | dmj_s76, it's all good. thanks for confirming the legacy boot code path. | 17:37 |
xnox | when i coded nvme support it was only available via UEFI boot and not via legacy boot at all. | 17:38 |
xnox | hence legacy boot was never tested / never worked correctly. | 17:38 |
xnox | i'm not quite sure about the regexp pattern. | 17:39 |
xnox | cyphermox, above merge proposal looks ok to me, what do you think? | 17:39 |
dmj_s76 | xnox: Legacy boot is still a bit messed up for multiple drive scenarios, so more than open to help on that. | 17:40 |
dmj_s76 | this patch should make single drive nvme legacy installs work without breaking anything, and I'm working on figuring out why multiple drives behaves weird, but it's a separate issue | 17:42 |
dmj_s76 | xnox: What did you have to change for nvme UEFI support? | 17:42 |
dmj_s76 | I've noticed that UEFI survives even with dumb/wrong targeting in grub_default() | 17:43 |
dmj_s76 | xnox: looking to get this change into 16.04.1 | 17:50 |
=== sakrecoer_ is now known as sakrecoer | ||
dmj_s76 | xnox: cyphermox is on vacation I believe | 22:17 |
xnox | didims | 23:19 |
xnox | i guess it's on me to test and land this then. | 23:20 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!