| dmj_s76 | xnox: Could you review and merge the nvme fix? | 17:38 |
|---|---|---|
| cyphermox | davmor2: in that case, situation seems exactly as it was for 16.04. I suppose the enter issue is jsut about VBox though | 19:50 |
| dmj_s76 | cyphermox: So, for multiple device scenarios... | 19:59 |
| dmj_s76 | Do we want to put grub always on the first drive listed by grub-mkdevicemap or favor the drive we're choosing to install to? | 20:00 |
| dmj_s76 | Right now the regex specifically operates on the targetted drive, which is the first item returned by grub-mkdevicemap that isn't the install media. | 20:02 |
| cyphermox | I think you always want to favor the drive you're installing to; you can't depend on grub-mkdevicemap returning what you want in all cases | 20:14 |
| cyphermox | now; that's my opinion we can deal with it however xnox wants since he's going to be the person doing the merging | 20:17 |
| cyphermox | I need to get back offline; I want just logged on to do some extra printing that we'd gotten wrong | 20:17 |
| cyphermox | I'm getting married this weekend so I have a gazillion small things to finish up | 20:17 |
| dmj_s76 | cyphermox: Congratulations and sorry to take you away from friends, family, and fiancee! | 20:23 |
| cyphermox | no worries | 20:24 |
| cyphermox | sending the email was the right thing to do | 20:24 |
| dmj_s76 | I'm testing the behavior with 2 nvme drives now just to make sure that works correctly. | 20:58 |
| xnox | dmj_s76, cyphermox: my plan was to bring up VM with two nvme machines. | 22:03 |
| xnox | the regexps look okish, but don't look right, because exacatly as cyphermox points out the whole "drive" is "nvmenX" | 22:04 |
| xnox | i'm also not sure if qemu can boot of nvme in BIOS mode, I only ever tried it / made it work in UEFI mode | 22:05 |
| xnox | my laptop has just one nvme drive, and i'm not able to burn this laptop =( | 22:05 |
| dmj_s76 | xnox: I've been trying with 2 nvme drives in the same machine | 22:08 |
| dmj_s76 | xnox: So the modified regex makes grub_default() target the right thing with 2 nvme drives, and the installer thinks it succeeded, but doesn't actually result in a bootable system in bios mode. | 22:14 |
| dmj_s76 | ...that's not a regression, since grub-installer simply fails without the change | 22:15 |
| dmj_s76 | in this test there was both an nvme0n1 and nvme1n1 | 22:16 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!