| === pavlushka is now known as Guest80024 | ||
| === pavlushka_ is now known as Guest65138 | ||
| === Guest65138 is now known as pavlushka | ||
| sparkiegeek | hi, I have a MP which has generated a rather long diff, enough that LP is truncating it. Is there a way of persuading LP to show me the full diff? (via URL hackery or similar) | 09:51 |
|---|---|---|
| cjwatson | sparkiegeek: I'm afraid the only option is to check out the branches and generate it locally | 09:59 |
| cjwatson | I think ... | 09:59 |
| cjwatson | sparkiegeek: URL to the MP? | 09:59 |
| sparkiegeek | cjwatson: fair enough, I discussed with reviewers and agreed a different approach | 09:59 |
| sparkiegeek | cjwatson: I actually have a follow-up question - can I tell bzr/LP that a file is "binary" even if technically it isn't? the large file in question is generated code, which shouldn't be reviewed, it's just an artifact that's version controlled for REASONS™ | 10:01 |
| cjwatson | sparkiegeek: so you should be able to use the "Download diff" link to get the whole thing, albeit not syntax-highlighted | 10:04 |
| sparkiegeek | cjwatson: right, we really were hoping for inline comments on chunks past the first "page" | 10:04 |
| sparkiegeek | don't worry, problem has been worked around (for now) | 10:05 |
| cjwatson | Yeah, this is basically "if we do that then we time out due to spending too much time rendering" | 10:05 |
| sparkiegeek | ack | 10:06 |
| cjwatson | bzr's logic for detecting a binary file is just "is there a NUL byte in the first 1024 bytes" | 10:06 |
| cjwatson | which is crude but apparently mostly pretty effective | 10:06 |
| cjwatson | and indeed that's pretty much diff's logic too | 10:07 |
| cjwatson | don't see a way to override that | 10:07 |
| sparkiegeek | right, was hoping for a way to hint to LP that it should treat /this/ file as a blob | 10:07 |
| cjwatson | in subversion I'd suggest setting the content-type or something but bzr doesn't have that degree of per-file properties | 10:08 |
| * sparkiegeek nods | 10:08 | |
| cjwatson | it would have to be a facility in the underlying VCS rather than in LP, really | 10:08 |
| cjwatson | now, git *does* have this facility | 10:09 |
| cjwatson | https://git-scm.com/docs/gitattributes | 10:09 |
| cjwatson | so you can have this if you switch to git :) | 10:09 |
| sparkiegeek | haha | 10:10 |
| cjwatson | (in LP, obviously ...) | 10:10 |
| sparkiegeek | and a series of headaches to go along with it :D | 10:10 |
| sparkiegeek | thanks though | 10:10 |
| cjwatson | best I can do, sorry | 10:10 |
| sparkiegeek | np, it's good to have confirmation either way! | 10:11 |
| === maxb_ is now known as maxb | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!