menn0wallyworld, thumper, axw : I think I've figured out that bootstrap problem00:20
menn0the bootstrap command embeds a ModelCommandBase and that's never told what the name of the controller that's being bootstrapped00:20
menn0so it defaults to the current controller00:21
menn0so the correct API details are being written out to controllers.yaml00:21
menn0but the details for the other controller are being read out00:21
menn0and the other controller doesn't have any details yet00:21
menn0trialing a fix now00:21
menn0wallyworld, thumper, axw: yep, that was it00:24
* menn0 cleans up and adds tests00:24
menn0wallyworld: can I pls have permission to modify the A team board?00:27
wallyworldmenn0: sorry was otp, done00:44
menn0wallyworld: cheers00:44
axwmenn0: cool, thanks for fixing01:06
axwwallyworld: is this a bit clearer? http://reviews.vapour.ws/r/5205/diff/4-5/01:18
wallyworldaxw: awesome, thanks01:18
axwwallyworld: are we still JFDIing things, or should I fix https://bugs.launchpad.net/juju-core/+bug/1603596 first?01:19
mupBug #1603596: HA often fails on azure creating virtual machine <azure-provider> <blocker> <ci> <ha> <regression> <juju-core:Triaged by axwalk> <https://launchpad.net/bugs/1603596>01:19
wallyworldaxw: i thinks there's more than one critical blocker? if that bug is the last one, would be good to fix that first; if not what's one more jfdi rught?01:21
axwwallyworld: just that one and the one you fixed yesterday. I'll take a look at the azure one now01:21
mgzaxw: if you have a bug that is also causing a CI failure and is marked crtical and tagged blocker, edit the bug to have that and use fixes-nnnn01:21
mgz*is not marked01:22
axwmgz: okey dokey01:22
axwmgz: it's not a bug related thing, we were just JFDIing things for a while because of time pressure.01:22
axwbut no more01:22
thumpermenn0: oh FFS, master and model-migration conflict again01:23
thumpermenn0: do you wanna take this one?01:23
thumperwallyworld: the CI run for model-migration is mostly good01:26
thumperthere are a few failures, but I don't think they are new, and certainly not related to migration01:26
wallyworldyou want to land it01:26
thumperso I'm thinking lets just fix the merge conflicts and merge into master01:26
thumperwallyworld: thoughts?01:26
wallyworldlet me cast a second set of eyes on it so we can say we've done due diligence01:27
thumperwallyworld: http://reports.vapour.ws/releases/414801:27
thumperwallyworld: compare with the lastest curse email on master01:29
wallyworldthumper: won't the race test failures be an issue?01:29
wallyworldi thought we were gating on those now for master01:29
thumperraces aren't01:30
thumperbut joyent races are long known01:30
thumperand I should double check that the joyent deps are right01:30
thumperbecause dave fixed some of those01:30
wallyworldhmmm, i could have sworn race tests were gating01:30
wallyworldother than that, looks ok to merge01:31
wallyworldor merge regardless and if i'm wrong it will land01:31
* thumper sets up a branch01:31
* thumper runs the tests01:34
natefinchanastasiamac: did we have a meeting set up for tonight?01:35
anastasiamacnatefinch: we did not. we said whenever u and i r available :D01:36
natefinchanastasiamac: are you available? :)01:36
anastasiamacnatefinch: for u, i could be :D01:36
anastasiamacnatefinch: in 15mins k?01:37
natefinchanastasiamac: sure, whenever is good for you.01:37
anastasiamacnatefinch: \o/01:37
redirnatefinch: another issue01:54
* redir puts it in doc01:54
natefinchredir: good... better to find them now01:54
menn0thumper: yep, I'll take a lok02:05
thumpermenn0: too late02:05
thumperdone it02:05
thumperand it is being merged02:05
menn0thumper/wallyworld/axw: fix for that concurrent bootstrap issue: http://reviews.vapour.ws/r/5262/03:31
menn0easy fix, horrible test03:31
menn0it took me 3 attempts at different approaches to arrive at this03:31
* thumper leaves for wallyworld03:31
wallyworldmenn0: jesus, you were not wrong about the test03:36
menn0wallyworld: yeah, pretty terrible. I almost thought about not testing the change.03:38
wallyworldyou are a better man than me :-)03:39
menn0ha :)03:40
menn0thumper: is model-migration merged into master?03:42
menn0looks like it03:42
thumpermenn0: yep03:42
menn0thumper: awesome \o/03:42
mupBug #1604223 opened: Concurrent bootstrap fails with "no API addresses" <bootstrap> <juju-core:In Progress by menno.smits> <https://launchpad.net/bugs/1604223>03:44
menn0axw: only just saw your review and it's already merging. I'll land a separate micro-PR afterwards.03:46
axwmenn0: it's no big deal03:50
axwmenn0: feel free to leave it03:51
menn0axw: it's ok. your suggestion is good and it's really not much effort.03:52
menn0wallyworld, thumper: that bootstrap fix was rejected because it's not one of the blockers. jfdi or wait?04:13
thumperJFDI IMO04:14
wallyworldmenn0: update with new comment too :-)04:14
menn0wallyworld: of course :)04:14
wallyworldthe change is only one line, what could possibly go wrong :-D04:14
thumperwallyworld, axw: in the new world of commands, I want to get the modelTag for a modelCmd04:17
thumperit isn't yet obvious to me04:17
wallyworldthere's a CurrentModelUUID somewhere on the base command, i'd need to look it up04:17
axwthumper: 1. get the client store (c.ClientStore()); 2. call store.ModelByName(c.ControllerName(), c.ModelName()) to get model details; 3. names.NewModelTag(details.ModelUUID)04:18
axwthumper: see cmd/juju/model/show.go04:19
thumperaxw: ta04:19
thumperha poop04:30
thumperah poop even04:30
thumperI have an old controller lying around04:30
thumperwhich I now can't talk do because missing creds04:30
thumperaxw: recoverable? or just kill the machines and blow away the cache dir?04:31
axwthumper: umm. I think you can get the admin password from the machine? in the agent.conf?04:32
axwold password or something?04:32
thumpertoo hard04:32
axwthumper: not sure. there should be a command to fix it, but we don't have one04:32
axwprobably easiest to restart04:32
thumperwhere is our config?04:33
thumper~/.config? or .cache?04:33
axwthumper: ~/.local/share/juju04:34
thumperjust wondering...04:35
thumperbut why did we choose there?04:36
axwthumper: IIRC, things that you need for operation to continue should go in the data dir04:37
axwoptional config goes in config04:37
* thumper starts afresh04:39
anastasiamacskipping windows tests review, plz :D http://reviews.vapour.ws/r/5263/04:39
menn0wallyworld: what's the name you're using for the config inheritance work?05:12
wallyworldjuju model tree05:13
wallyworldor juju model config tree05:13
menn0ok, that'll do (it's for a document i'm writing on current model migration status)05:14
wallyworldaxw: no rush, when you are free, would love a review on http://reviews.vapour.ws/r/5264/05:19
axwwallyworld: ok, in a little while05:20
thumperyes... new command in under 350 lines http://reviews.vapour.ws/r/5265/diff/#05:37
thumperjuju dump-model05:37
thumper(behind developer-mode feature flag)05:37
* thumper out now to go make dinner05:39
axwwallyworld: where abouts do we generate the certs in the lxd provider?05:55
axwI got lost in a twisty maze05:55
wallyworldaxw: there's a juju/tools/lxdclient package05:56
wallyworldthere's a UseRemoteTCP() method or something like that. it's called when config is finalised05:56
wallyworldthat method generates client certs, connects to server, and gets back the server cert05:56
wallyworldthe client certs are based on network interfaces and host name at the time05:57
wallyworldso it's implausible to generate ahead of time05:57
axwwallyworld: I was thinking we'd only generate them at bootstrap time06:01
axwwallyworld: I guess having it in DetectCredentials opens users up to accidentally storing them in credentials.yaml. would be good to auto-generate still though...06:02
wallyworldbut at bootstrap time seems ok i think06:02
wallyworldi'd like to do that after the work to properly store credentials06:03
wallyworldout of the model06:03
axwwallyworld: ok06:03
wallyworldfor now, the PR as it exists I think adds value06:03
wallyworldmodel-config looks sweet now06:03
axwwallyworld: model-config looks good, I'm not sure there's any point in adding the tls auth-type without the implementation though?06:04
wallyworldaxw: it exists merely to define the attributes to filter out06:04
axwah, right06:04
axwwallyworld: reviewed, just a few little things06:06
wallyworldaxw: ta, will look after I get back from school pickup, heading out now to do that06:06
wallyworldaxw: i explained the \n thing in the CLI - i could just drop the code since we don't displau authorised keys now, but figured it can't hurt to keep it?06:35
axwwallyworld: I'm not strongly opposed to it, I just wondered what the reason was - wasn't mentioned in the review description. why drop the leading character?06:37
* axw looks at comment06:38
wallyworldaxw: cause i'm an idiot06:38
axwwallyworld: maybe just use strings.TrimSuffix(valString, "\n") then ?06:38
wallyworldyeah, that's much better06:39
anastasiamacaxw: wallyworld: fix of the fix :D http://reviews.vapour.ws/r/5267/06:46
anastasiamacfor those of u with eagle eyes :D06:46
anastasiamacaxw: fast \o/ tyvm!!06:49
=== frankban|afk is now known as frankban
mupBug #1567708 changed: unit tests fail with mongodb 3.2 <juju-core:Fix Released by 2-xtian> <https://launchpad.net/bugs/1567708>08:47
frobwarebabbageclunk: my kvm-maas scripts now work on 2.0 - please let me know otherwise10:18
babbageclunkfrobware: wilco, thanks. In other news it looks like the dhcp was the problem.10:21
frobwarebabbageclunk: as in lack of?10:21
babbageclunkfrobware: yup10:22
babbageclunkfrobware: just working out what I should be putting into the network info instead now.10:22
frobwarebabbageclunk: want to HO?10:40
babbageclunkfrobware: yeah, why not?10:40
babbageclunkfrobware: I'm in juju-sapphire10:43
perrito666wallyworld: tx for the overnight merge on controller tag11:00
wallyworldperrito666: no worries11:01
* perrito666 fears the merge with master11:01
frobwarebabbageclunk: http://pastebin.ubuntu.com/20024195/11:03
frobwarebabbageclunk: https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/159010411:21
mupBug #1590104: network config from datasource overrides network config from system <amd64> <apport-bug> <uec-images> <xenial> <cloud-init:Confirmed> <cloud-init11:21
mup(Ubuntu):Fix Released> <cloud-init (Ubuntu Xenial):Confirmed> <cloud-init (Ubuntu Yakkety):Fix Released> <https://launchpad.net/bugs/1590104>11:21
frobwarebabbageclunk: https://bugs.launchpad.net/maas/+bug/160416911:26
mupBug #1604169: maas login yields "ImportError: No module named 'maasserver'" <MAAS:Confirmed> <https://launchpad.net/bugs/1604169>11:26
frobwarejam: ^ the maas bug I talked about this morning11:27
=== rogpeppe1 is now known as rogpeppe
jamfrobware: I'll brt, just need to grab a snack12:05
rogpeppeanyone know how to recompile a Go stdlib package without rebuilding the whole go install?12:30
rogpeppeit used to work but no longer seems to12:30
perrito666I believe that at some point we should accept that there is no way to be descriptive enough in a test name (in some cases) and start adding a couple of doc lines in the tests13:10
fwereadeperrito666, I heartily endorse explanatory comments all over the place13:26
perrito666heh, my issue is with tests that usually are called something like TestThisHappensWhenX which is explanatory of what the test does, but not why, which is the important bit13:27
perrito666bbl heating people is finally here13:30
mupBug #1604408 opened: LogForwarderSuite.TestConfigChange obtained Next, expected close <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1604408>13:33
mupBug #1604408 changed: LogForwarderSuite.TestConfigChange obtained Next, expected close <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1604408>13:36
mupBug #1604408 opened: LogForwarderSuite.TestConfigChange obtained Next, expected close <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1604408>13:39
babbageclunkfrobware: Those scripts work an absolute treat!14:12
frobwarebabbageclunk: \o/14:14
babbageclunkfrobware: I guess I shouldn't be surprised, but it's nice! :)14:14
frobwarebabbageclunk: what we need next is a means of describing what NICS you want connected to which subnets and/or dhcp/manual, et al14:16
babbageclunkfrobware: The only thing I'm having trouble with is that I don't want to allocate 16GB of disk to each node.14:38
babbageclunkfrobware: Even if I set VIRT_DISK_SIZE and KVM_DISK_SIZE to 10, I still get 16GB disks.14:39
babbageclunkfrobware: Ah, worked it out - removing the node doesn't remove the pool, so even though I'm specifying the size for add-node it's reusing the already-created image.14:48
babbageclunkfrobware: gah, nope - still can't see why the images are always coming up with 16G disks.14:53
babbageclunkfrobware: ignore, everything's fine now! PICNIC14:56
=== natefinch is now known as nfinch-baby-chic
=== nfinch-baby-chic is now known as nfinch-babychick
=== nfinch-babychick is now known as nfinchbabychicks
frobwarecherylj: fyi, marking this as critical  - https://bugs.launchpad.net/juju-core/+bug/160448216:30
mupBug #1604482: MAAS bridge script should drop all 'source' stanzas from original file <network> <juju-core:New> <https://launchpad.net/bugs/1604482>16:30
mupBug #1604474 opened: Juju 2.0-beta12  userdata execution fails on Windows if azure-provider is used <azure-provider> <juju2.0> <windows> <juju-core:New> <https://launchpad.net/bugs/1604474>16:31
mupBug #1604482 opened: MAAS bridge script should drop all 'source' stanzas from original file <network> <juju-core:New> <https://launchpad.net/bugs/1604482>16:31
=== frankban is now known as frankban|afk
=== nfinchbabychicks is now known as natefinch
mupBug #1604514 opened: Race in github.com/joyent/gosdc/localservices/cloudapi <blocker> <ci> <joyent-provider> <race-condition> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1604514>18:16
balloonscan someone approve this? It's just a markdown change -- perhaps I did it wrong. https://github.com/juju/juju/pull/582019:20
natefinchballoons: LGTM19:21
katcoperrito666: i believe you are OCR. tal at a small change? http://reviews.vapour.ws/r/5270/19:22
perrito666I am, and now with heating19:22
katcoyay :)19:23
perrito666sadly my office is the last portion of the wather circuit :p19:23
mgzballoons: you need to get the keys to reviews.vapour.ws off ericsnow then you could add yourself and your pr would be more visible :)19:23
balloonsnatefinch, do I need to tell the bot to merge then? Not sure of the formal process as I do generally hit it with the comment19:41
perrito666balloons: I can merge it for you19:42
perrito666balloons: done19:42
natefinchwell, except it'll fail because master is blocked19:42
perrito666not really, just added the $$merge$$ but you will have to watch if that goes trough19:42
* perrito666 curses in spanish19:42
* natefinch adds a JFDI19:43
balloonsindeed.. I just wasn't sure if the person proposing should tell it to merge, or if the reviewer(s) do19:43
mgzballoons: also with that mp^ - you shouldn't be using the juju namespace for merge proposals19:43
mgzballoons: we had a spurious CI run because of it19:43
balloonsmgz, right, I noticed it did a CI run19:43
mgzyou need your git config to have different upstream and origin19:43
balloonsI did it on github as I saw the error and thought nothing more of it19:43
balloonsso I was led astray by gh :-)19:43
katcoare we still jfding changes?19:44
mgzyou have to treat owner privs with care or I shall remove them :)19:44
natefinchyeah, that's not really his fault.  I'm kind of surprised it let him make a branch there19:44
mgzit is surprising the web ui would do that19:45
natefinchwell, it's made to make it easy to make minor edits to docs.19:45
natefinchit's our fault that we automatically run CI on any branch created there19:45
natefinch...and that CI takes so damn long :)19:45
balloonsworking on that last part!19:47
marcoceppiproduction deployment, beta11, AWS: 'listing instances: An internal error has occurred (InternalError)'19:48
marcoceppiwhen trying ot provision a machine19:48
stokachumarcoceppi: aws seems down19:48
balloonsstokachu, us east 1 is19:49
balloonsor was at least19:49
marcoceppistokachu balloons not according to the status anymore19:49
mupBug # opened: 1604542, 1604551, 1604559, 160456119:49
stokachuballoons: yea still is, error retrieving resource count19:49
stokachumarcoceppi: aws.amazon.com shows failure retrieving instances19:49
marcoceppistokachu: http://status.aws.amazon.com/19:50
stokachumarcoceppi: i see that, but im just telling you what i see19:50
stokachumarcoceppi https://usercontent.irccloud-cdn.com/file/nH5BLoCy/19:50
stokachuthe status is reporting it working19:50
stokachubut the console says otherwise19:51
marcoceppistokachu: works for me http://i.imgur.com/fnlaUkl.png19:55
marcoceppiso, lets pretend they fixed this, can someone help me troubleshoot that error?19:55
marcoceppi 'cannot run instances: Request limit exceeded. (RequestLimitExceeded)'19:55
stokachuaren't you limited to 20 instances19:56
stokachuor smaller?19:56
marcoceppinot on this account19:56
marcoceppithis is API requests19:56
stokachui see19:56
mgzmarcoceppi: what region?19:59
marcoceppiseems to be catching the tail end of the api outage19:59
marcoceppiI got a series of other errors about root-tagging19:59
marcoceppiand now it's pending again19:59
mgzsinzui says that's borked20:00
mgztry a different region20:00
mgzyou can also see some red on our test-cloud-aws-us-east-1 health job20:01
perrito666fcs is it really so hard to add docs to public structs?20:05
natefinchThat's why I love having golint running on save... the little squiggles drive me crazy, so I fix them ASAP.20:06
perrito666some people might need for golint to kick them in the face to actually do something about20:11
perrito666I would totally love a golint with that feature20:11
natefinchperrito666 is taking over Dave's role as grumpy cat, it seems.20:13
perrito666oh, you sure are one to talk20:13
natefinchwell, to be fair, maybe if we both worked at it together, we might be able to almost match dave's grumpiness.20:14
perrito666mm, ok, it would seem that I need thumper to make sure I dont break anything in this20:15
perrito666oh, that actually works, sweet20:16
perrito666mm, ok, it would seem that I need one million dolars so I dont break anything in this20:16
perrito666meh, nothing happend20:16
perrito666thumper: I am adding ControllerUser to migrations, but it would seem that migrations are per model?20:17
thumperperrito666: yes, migrations are only per model20:17
thumpercontroller user probably doesn't need to be migrated20:17
perrito666thumper: ok then controller permissions are not something we will be migrating, that makes sense, since we migrate models20:18
* perrito666 facepalms20:18
* perrito666 adds a bit of info to that pesky test that tells you that you need to migrate stuff20:19
perrito666natefinch: your jfdi did not like windows20:25
natefinchperrito666: juju doesn't like windows :/20:30
perrito666well bad luck, since we are gating landings on it20:31
redirwithout gates there'd be no windows20:48
redirso if I juju set-model-config default-series=xenial && juju deploy wordpress I should expect wordpress to be deployed on xenial, yes?21:13
mupBug #1604586 opened: devel Charm Docs are out of date and examples do not work <juju-core:New> <https://launchpad.net/bugs/1604586>21:16
thumpermenn0: http://reviews.vapour.ws/r/5271/diff/#21:23
menn0thumper: looking21:24
thumpermenn0: ta21:25
perrito666redir: ir fail iirc21:27
redirtx perrito666 looks like it falls back if the charms doesn't support the series21:28
redirbut I have another error: ERROR storing charm for URL "cs:trusty/wordpress-4": delegatable macaroon cannot be obtained for public entities21:29
redirthink I must have something twisted.21:29
redirlike my understanding21:29
menn0thumper: done21:32
thumpermenn0: as reviewer, here's another http://reviews.vapour.ws/r/5265/diff/#21:52
menn0thumper: looking21:57
thumpermenn0: ta21:57
rick_h_katco: can you add the link to your pr to the card on the board please?22:05
rick_h_natefinch: you around to be able to give that a look over?22:05
katcorick_h_: oh sorry, sure22:06
rick_h_katco: np, ty much22:06
rick_h_katco: there's a new bug added there but post the provider doc work just as a heads up, will cover in standup tomorrow22:06
katcorick_h_: k22:06
katcowallyworld: hey i see your comment in my PR for the config change... this change isn't in environs/config.go. should i still be writing unit tests there?22:09
wallyworldkatco: it's a bit messed up. the controller config was being parsed by environs/config.go since at bootstrap we handle a single bucket of config items which are then split up. i think that's still the case22:11
perrito666does anyone know what goes on the depends on field on rb to actually have a dependency?22:11
wallyworldkatco: so as with log forward on/off, i think we can just extend the environs/config tests22:12
redirperrito666: interface{}22:12
perrito666redir: of reviewboard, sorry22:12
perrito666missed that22:12
redirperrito666: i got that, just a bad joke22:12
thumpermenn0: and another http://reviews.vapour.ws/r/5273/22:14
rick_h_axw: wallyworld folks arriving on the call22:16
menn0thumper: done and done. reboot worker one to go.22:25
mupBug #1603577 changed: backup-restore: panic: empty value for "api-port" found in configuration <backup-restore> <blocker> <ci> <regression> <juju-core:Fix Released by wallyworld> <https://launchpad.net/bugs/1603577>22:25
menn0coffee first22:25
thumpermenn0: the reboot one is just a backport22:32
thumperdoesn't need its own review IMO22:32
* perrito666 would be a bit happier if we stoped passing State around as if it where a hot potato and started passing a reduced interface of state22:35
menn0thumper: ok cool. I thought it sounded familiar :)22:46
thumpermerge bot is rejecting a 1.25 merge, but juju.fail doesn't show any blockers22:46
thumperah... a private bug22:47
thumperhence juju.fail doesn't see it22:47
menn0wallyworld: any idea on the status of this: http://reviews.vapour.ws/r/5173/22:51
thumperugh... none of the core description stuff has any json serialization tags22:51
thumperperhaps we should add some22:51
wallyworldmenn0: it can be discarded for now, i'll do that22:53
menn0wallyworld: cheers22:54
alexisbwallyworld, thumper do you guys have time to meet before the standup?22:58
alexisbI will jump on teh hangout22:58
wallyworldalexisb: can do, i have a 1:1 with redir, hopefully he will be ok if we do that later22:58
alexisbwallyworld, it is not super urgent22:59
menn0thumper: I just went through the review checklists with http://reviews.vapour.ws/r/5265/. It wasn't too painful and I found a bunch more stuff.23:08
anastasiamacmenn0: how r we maintaing review checklist? is it part of our wiki? or juju/juju/docs?23:09
menn0anastasiamac: it's on the wiki. there will be an official announcement this week about us using it soon from alexisb and rick_h_.23:10
menn0anastasiamac: https://github.com/juju/juju/wiki/Code-Review-Checklists23:10
menn0anastasiamac: I just thought I'd get some actual experience with using it23:10
alexisbmenn0, yeah we will try to get that out tomorrow23:11
anastasiamacmenn0: so for item "Are there unit tests with reasonable coverage?"23:11
anastasiamaci think it should be coverage specific to what PR addresses23:11
anastasiamacnot general23:11
anastasiamacit's not responsibility of an individual PR to ensure correct test coverage23:12
anastasiamacPRs should b focused23:12
menn0anastasiamac: sure. all the items related to the work being reviewed, not the code around it23:12
anastasiamacmenno my hero :D23:12
menn0anastasiamac: we can make that clearer in the guidance at the top23:12
anastasiamacmenn0: \o/23:13
axwwallyworld: seen https://bugs.launchpad.net/juju-core/+bug/1604561 ?23:14
mupBug #1604561: restoreSuite.TestRestoreReboostrapBuiltInProvider map ordering wrong <blocker> <ci> <regression> <unit-tests> <juju-core:Triaged by wallyworld> <https://launchpad.net/bugs/1604561>23:14
axwoh it's assigned, I guess so23:14
wallyworldyep :-)23:15
alexisbmenn0, https://hangouts.google.com/hangouts/_/canonical.com/menno-alexis23:46
perrito666wallyworld: ill go have dinner then ping you re syncing about acls\23:46
wallyworldperrito666: ok23:46
wallyworldredir: there now23:57
redirwallyworld: omw23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!