[00:20] <menn0> wallyworld, thumper, axw : I think I've figured out that bootstrap problem
[00:20] <menn0> the bootstrap command embeds a ModelCommandBase and that's never told what the name of the controller that's being bootstrapped
[00:21] <menn0> so it defaults to the current controller
[00:21] <menn0> so the correct API details are being written out to controllers.yaml
[00:21] <menn0> but the details for the other controller are being read out
[00:21] <menn0> and the other controller doesn't have any details yet
[00:21] <menn0> trialing a fix now
[00:24] <menn0> wallyworld, thumper, axw: yep, that was it
[00:24]  * menn0 cleans up and adds tests
[00:27] <menn0> wallyworld: can I pls have permission to modify the A team board?
[00:44] <wallyworld> menn0: sorry was otp, done
[00:44] <menn0> wallyworld: cheers
[01:06] <axw> menn0: cool, thanks for fixing
[01:18] <axw> wallyworld: is this a bit clearer? http://reviews.vapour.ws/r/5205/diff/4-5/
[01:18] <wallyworld> looking
[01:18] <wallyworld> axw: awesome, thanks
[01:19] <axw> wallyworld: are we still JFDIing things, or should I fix https://bugs.launchpad.net/juju-core/+bug/1603596 first?
[01:19] <mup> Bug #1603596: HA often fails on azure creating virtual machine <azure-provider> <blocker> <ci> <ha> <regression> <juju-core:Triaged by axwalk> <https://launchpad.net/bugs/1603596>
[01:21] <wallyworld> axw: i thinks there's more than one critical blocker? if that bug is the last one, would be good to fix that first; if not what's one more jfdi rught?
[01:21] <axw> wallyworld: just that one and the one you fixed yesterday. I'll take a look at the azure one now
[01:21] <wallyworld> ok
[01:21] <wallyworld> ta
[01:21] <mgz> axw: if you have a bug that is also causing a CI failure and is marked crtical and tagged blocker, edit the bug to have that and use fixes-nnnn
[01:22] <mgz> *is not marked
[01:22] <axw> mgz: okey dokey
[01:22] <axw> mgz: it's not a bug related thing, we were just JFDIing things for a while because of time pressure.
[01:22] <axw> but no more
[01:23] <thumper> menn0: oh FFS, master and model-migration conflict again
[01:23] <thumper> menn0: do you wanna take this one?
[01:26] <thumper> wallyworld: the CI run for model-migration is mostly good
[01:26] <thumper> there are a few failures, but I don't think they are new, and certainly not related to migration
[01:26] <wallyworld> you want to land it
[01:26] <thumper> so I'm thinking lets just fix the merge conflicts and merge into master
[01:26] <thumper> wallyworld: thoughts?
[01:27] <wallyworld> let me cast a second set of eyes on it so we can say we've done due diligence
[01:27] <thumper> wallyworld: http://reports.vapour.ws/releases/4148
[01:29] <thumper> wallyworld: compare with the lastest curse email on master
[01:29] <wallyworld> thumper: won't the race test failures be an issue?
[01:29] <wallyworld> i thought we were gating on those now for master
[01:30] <thumper> races aren't
[01:30] <thumper> but joyent races are long known
[01:30] <thumper> and I should double check that the joyent deps are right
[01:30] <thumper> because dave fixed some of those
[01:30] <wallyworld> hmmm, i could have sworn race tests were gating
[01:31] <wallyworld> other than that, looks ok to merge
[01:31] <wallyworld> or merge regardless and if i'm wrong it will land
[01:31]  * thumper sets up a branch
[01:34]  * thumper runs the tests
[01:35] <natefinch> anastasiamac: did we have a meeting set up for tonight?
[01:36] <anastasiamac> natefinch: we did not. we said whenever u and i r available :D
[01:36] <natefinch> anastasiamac: are you available? :)
[01:36] <anastasiamac> natefinch: for u, i could be :D
[01:37] <anastasiamac> natefinch: in 15mins k?
[01:37] <natefinch> anastasiamac: sure, whenever is good for you.
[01:37] <anastasiamac> natefinch: \o/
[01:54] <redir> natefinch: another issue
[01:54]  * redir puts it in doc
[01:54] <natefinch> redir: good... better to find them now
[02:05] <menn0> thumper: yep, I'll take a lok
[02:05] <thumper> menn0: too late
[02:05] <thumper> done it
[02:05] <menn0> ok
[02:05] <thumper> and it is being merged
[03:31] <menn0> thumper/wallyworld/axw: fix for that concurrent bootstrap issue: http://reviews.vapour.ws/r/5262/
[03:31] <menn0> easy fix, horrible test
[03:31] <wallyworld> looking
[03:31] <menn0> it took me 3 attempts at different approaches to arrive at this
[03:31] <thumper> ugh
[03:31]  * thumper leaves for wallyworld
[03:36] <wallyworld> menn0: jesus, you were not wrong about the test
[03:38] <menn0> wallyworld: yeah, pretty terrible. I almost thought about not testing the change.
[03:39] <wallyworld> you are a better man than me :-)
[03:40] <menn0> ha :)
[03:42] <menn0> thumper: is model-migration merged into master?
[03:42] <menn0> looks like it
[03:42] <thumper> menn0: yep
[03:42] <menn0> thumper: awesome \o/
[03:44] <mup> Bug #1604223 opened: Concurrent bootstrap fails with "no API addresses" <bootstrap> <juju-core:In Progress by menno.smits> <https://launchpad.net/bugs/1604223>
[03:46] <menn0> axw: only just saw your review and it's already merging. I'll land a separate micro-PR afterwards.
[03:50] <axw> menn0: it's no big deal
[03:51] <axw> menn0: feel free to leave it
[03:52] <menn0> axw: it's ok. your suggestion is good and it's really not much effort.
[04:13] <menn0> wallyworld, thumper: that bootstrap fix was rejected because it's not one of the blockers. jfdi or wait?
[04:14] <thumper> JFDI IMO
[04:14] <wallyworld> menn0: update with new comment too :-)
[04:14] <menn0> wallyworld: of course :)
[04:14] <wallyworld> the change is only one line, what could possibly go wrong :-D
[04:17] <thumper> wallyworld, axw: in the new world of commands, I want to get the modelTag for a modelCmd
[04:17] <thumper> it isn't yet obvious to me
[04:17] <wallyworld> there's a CurrentModelUUID somewhere on the base command, i'd need to look it up
[04:18] <axw> thumper: 1. get the client store (c.ClientStore()); 2. call store.ModelByName(c.ControllerName(), c.ModelName()) to get model details; 3. names.NewModelTag(details.ModelUUID)
[04:19] <axw> thumper: see cmd/juju/model/show.go
[04:19] <thumper> axw: ta
[04:30] <thumper> ha poop
[04:30] <thumper> ah poop even
[04:30] <thumper> I have an old controller lying around
[04:30] <thumper> which I now can't talk do because missing creds
[04:31] <thumper> axw: recoverable? or just kill the machines and blow away the cache dir?
[04:32] <axw> thumper: umm. I think you can get the admin password from the machine? in the agent.conf?
[04:32] <axw> old password or something?
[04:32] <thumper> ugh
[04:32] <thumper> too hard
[04:32] <thumper> :)
[04:32] <axw> thumper: not sure. there should be a command to fix it, but we don't have one
[04:32] <axw> probably easiest to restart
[04:33] <thumper> um...
[04:33] <thumper> where is our config?
[04:33] <thumper> ~/.config? or .cache?
[04:34] <axw> thumper: ~/.local/share/juju
[04:35] <thumper> just wondering...
[04:36] <thumper> but why did we choose there?
[04:37] <thumper> hmm
[04:37] <thumper> nm
[04:37] <axw> thumper: IIRC, things that you need for operation to continue should go in the data dir
[04:37] <axw> optional config goes in config
[04:39]  * thumper starts afresh
[04:39] <anastasiamac> skipping windows tests review, plz :D http://reviews.vapour.ws/r/5263/
[05:12] <menn0> wallyworld: what's the name you're using for the config inheritance work?
[05:13] <wallyworld> juju model tree
[05:13] <wallyworld> or juju model config tree
[05:14] <menn0> ok, that'll do (it's for a document i'm writing on current model migration status)
[05:19] <wallyworld> axw: no rush, when you are free, would love a review on http://reviews.vapour.ws/r/5264/
[05:20] <axw> wallyworld: ok, in a little while
[05:37] <thumper> yes... new command in under 350 lines http://reviews.vapour.ws/r/5265/diff/#
[05:37] <thumper> juju dump-model
[05:37] <thumper> (behind developer-mode feature flag)
[05:39]  * thumper out now to go make dinner
[05:39] <thumper> laters
[05:55] <axw> wallyworld: where abouts do we generate the certs in the lxd provider?
[05:55] <axw> I got lost in a twisty maze
[05:56] <wallyworld> axw: there's a juju/tools/lxdclient package
[05:56] <wallyworld> there's a UseRemoteTCP() method or something like that. it's called when config is finalised
[05:56] <wallyworld> that method generates client certs, connects to server, and gets back the server cert
[05:57] <wallyworld> the client certs are based on network interfaces and host name at the time
[05:57] <wallyworld> so it's implausible to generate ahead of time
[06:01] <axw> wallyworld: I was thinking we'd only generate them at bootstrap time
[06:02] <axw> wallyworld: I guess having it in DetectCredentials opens users up to accidentally storing them in credentials.yaml. would be good to auto-generate still though...
[06:02] <wallyworld> exactly
[06:02] <wallyworld> but at bootstrap time seems ok i think
[06:03] <wallyworld> i'd like to do that after the work to properly store credentials
[06:03] <wallyworld> out of the model
[06:03] <axw> wallyworld: ok
[06:03] <wallyworld> for now, the PR as it exists I think adds value
[06:03] <wallyworld> model-config looks sweet now
[06:04] <axw> wallyworld: model-config looks good, I'm not sure there's any point in adding the tls auth-type without the implementation though?
[06:04] <wallyworld> axw: it exists merely to define the attributes to filter out
[06:04] <axw> ah, right
[06:06] <axw> wallyworld: reviewed, just a few little things
[06:06] <wallyworld> axw: ta, will look after I get back from school pickup, heading out now to do that
[06:35] <wallyworld> axw: i explained the \n thing in the CLI - i could just drop the code since we don't displau authorised keys now, but figured it can't hurt to keep it?
[06:37] <axw> wallyworld: I'm not strongly opposed to it, I just wondered what the reason was - wasn't mentioned in the review description. why drop the leading character?
[06:38]  * axw looks at comment
[06:38] <wallyworld> axw: cause i'm an idiot
[06:38] <wallyworld> typo
[06:38] <axw> wallyworld: maybe just use strings.TrimSuffix(valString, "\n") then ?
[06:39] <wallyworld> yeah, that's much better
[06:46] <anastasiamac> axw: wallyworld: fix of the fix :D http://reviews.vapour.ws/r/5267/
[06:46] <anastasiamac> for those of u with eagle eyes :D
[06:49] <anastasiamac> axw: fast \o/ tyvm!!
[08:47] <mup> Bug #1567708 changed: unit tests fail with mongodb 3.2 <juju-core:Fix Released by 2-xtian> <https://launchpad.net/bugs/1567708>
[10:18] <frobware> babbageclunk: my kvm-maas scripts now work on 2.0 - please let me know otherwise
[10:21] <babbageclunk> frobware: wilco, thanks. In other news it looks like the dhcp was the problem.
[10:21] <frobware> babbageclunk: as in lack of?
[10:22] <babbageclunk> frobware: yup
[10:22] <babbageclunk> frobware: just working out what I should be putting into the network info instead now.
[10:40] <frobware> babbageclunk: want to HO?
[10:40] <babbageclunk> frobware: yeah, why not?
[10:43] <babbageclunk> frobware: I'm in juju-sapphire
[11:00] <perrito666> wallyworld: tx for the overnight merge on controller tag
[11:01] <wallyworld> perrito666: no worries
[11:01]  * perrito666 fears the merge with master
[11:03] <frobware> babbageclunk: http://pastebin.ubuntu.com/20024195/
[11:21] <frobware> babbageclunk: https://bugs.launchpad.net/ubuntu/+source/cloud-init/+bug/1590104
[11:21] <mup> Bug #1590104: network config from datasource overrides network config from system <amd64> <apport-bug> <uec-images> <xenial> <cloud-init:Confirmed> <cloud-init
[11:21] <mup> (Ubuntu):Fix Released> <cloud-init (Ubuntu Xenial):Confirmed> <cloud-init (Ubuntu Yakkety):Fix Released> <https://launchpad.net/bugs/1590104>
[11:26] <frobware> babbageclunk: https://bugs.launchpad.net/maas/+bug/1604169
[11:26] <mup> Bug #1604169: maas login yields "ImportError: No module named 'maasserver'" <MAAS:Confirmed> <https://launchpad.net/bugs/1604169>
[11:27] <frobware> jam: ^ the maas bug I talked about this morning
[12:05] <jam> frobware: I'll brt, just need to grab a snack
[12:05] <frobware> ack
[12:30] <rogpeppe> anyone know how to recompile a Go stdlib package without rebuilding the whole go install?
[12:30] <rogpeppe> it used to work but no longer seems to
[13:10] <perrito666> I believe that at some point we should accept that there is no way to be descriptive enough in a test name (in some cases) and start adding a couple of doc lines in the tests
[13:26] <fwereade> perrito666, I heartily endorse explanatory comments all over the place
[13:27] <perrito666> heh, my issue is with tests that usually are called something like TestThisHappensWhenX which is explanatory of what the test does, but not why, which is the important bit
[13:30] <perrito666> bbl heating people is finally here
[13:33] <mup> Bug #1604408 opened: LogForwarderSuite.TestConfigChange obtained Next, expected close <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1604408>
[13:36] <mup> Bug #1604408 changed: LogForwarderSuite.TestConfigChange obtained Next, expected close <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1604408>
[13:39] <mup> Bug #1604408 opened: LogForwarderSuite.TestConfigChange obtained Next, expected close <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1604408>
[14:12] <babbageclunk> frobware: Those scripts work an absolute treat!
[14:14] <frobware> babbageclunk: \o/
[14:14] <babbageclunk> frobware: I guess I shouldn't be surprised, but it's nice! :)
[14:16] <frobware> babbageclunk: what we need next is a means of describing what NICS you want connected to which subnets and/or dhcp/manual, et al
[14:38] <babbageclunk> frobware: The only thing I'm having trouble with is that I don't want to allocate 16GB of disk to each node.
[14:39] <babbageclunk> frobware: Even if I set VIRT_DISK_SIZE and KVM_DISK_SIZE to 10, I still get 16GB disks.
[14:48] <babbageclunk> frobware: Ah, worked it out - removing the node doesn't remove the pool, so even though I'm specifying the size for add-node it's reusing the already-created image.
[14:53] <babbageclunk> frobware: gah, nope - still can't see why the images are always coming up with 16G disks.
[14:56] <babbageclunk> frobware: ignore, everything's fine now! PICNIC
[16:30] <frobware> cherylj: fyi, marking this as critical  - https://bugs.launchpad.net/juju-core/+bug/1604482
[16:30] <mup> Bug #1604482: MAAS bridge script should drop all 'source' stanzas from original file <network> <juju-core:New> <https://launchpad.net/bugs/1604482>
[16:31] <mup> Bug #1604474 opened: Juju 2.0-beta12  userdata execution fails on Windows if azure-provider is used <azure-provider> <juju2.0> <windows> <juju-core:New> <https://launchpad.net/bugs/1604474>
[16:31] <mup> Bug #1604482 opened: MAAS bridge script should drop all 'source' stanzas from original file <network> <juju-core:New> <https://launchpad.net/bugs/1604482>
[18:16] <mup> Bug #1604514 opened: Race in github.com/joyent/gosdc/localservices/cloudapi <blocker> <ci> <joyent-provider> <race-condition> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1604514>
[19:20] <balloons> can someone approve this? It's just a markdown change -- perhaps I did it wrong. https://github.com/juju/juju/pull/5820
[19:21] <natefinch> balloons: LGTM
[19:22] <katco> perrito666: i believe you are OCR. tal at a small change? http://reviews.vapour.ws/r/5270/
[19:22] <perrito666> I am, and now with heating
[19:23] <katco> yay :)
[19:23] <perrito666> sadly my office is the last portion of the wather circuit :p
[19:23] <mgz> balloons: you need to get the keys to reviews.vapour.ws off ericsnow then you could add yourself and your pr would be more visible :)
[19:41] <balloons> natefinch, do I need to tell the bot to merge then? Not sure of the formal process as I do generally hit it with the comment
[19:42] <perrito666> balloons: I can merge it for you
[19:42] <perrito666> balloons: done
[19:42] <natefinch> well, except it'll fail because master is blocked
[19:42] <perrito666> not really, just added the $$merge$$ but you will have to watch if that goes trough
[19:42] <perrito666> ahaa
[19:42]  * perrito666 curses in spanish
[19:43]  * natefinch adds a JFDI
[19:43] <balloons> indeed.. I just wasn't sure if the person proposing should tell it to merge, or if the reviewer(s) do
[19:43] <mgz> balloons: also with that mp^ - you shouldn't be using the juju namespace for merge proposals
[19:43] <mgz> balloons: we had a spurious CI run because of it
[19:43] <balloons> mgz, right, I noticed it did a CI run
[19:43] <mgz> you need your git config to have different upstream and origin
[19:43] <balloons> I did it on github as I saw the error and thought nothing more of it
[19:43] <balloons> so I was led astray by gh :-)
[19:44] <katco> are we still jfding changes?
[19:44] <mgz> you have to treat owner privs with care or I shall remove them :)
[19:44] <natefinch> yeah, that's not really his fault.  I'm kind of surprised it let him make a branch there
[19:45] <mgz> it is surprising the web ui would do that
[19:45] <natefinch> well, it's made to make it easy to make minor edits to docs.
[19:45] <natefinch> it's our fault that we automatically run CI on any branch created there
[19:45] <natefinch> ...and that CI takes so damn long :)
[19:47] <balloons> working on that last part!
[19:48] <marcoceppi> production deployment, beta11, AWS: 'listing instances: An internal error has occurred (InternalError)'
[19:48] <marcoceppi> when trying ot provision a machine
[19:48] <stokachu> marcoceppi: aws seems down
[19:49] <balloons> stokachu, us east 1 is
[19:49] <balloons> or was at least
[19:49] <marcoceppi> stokachu balloons not according to the status anymore
[19:49] <mup> Bug # opened: 1604542, 1604551, 1604559, 1604561
[19:49] <stokachu> balloons: yea still is, error retrieving resource count
[19:49] <stokachu> marcoceppi: aws.amazon.com shows failure retrieving instances
[19:50] <marcoceppi> stokachu: http://status.aws.amazon.com/
[19:50] <stokachu> marcoceppi: i see that, but im just telling you what i see
[19:50] <stokachu> marcoceppi https://usercontent.irccloud-cdn.com/file/nH5BLoCy/
[19:50] <stokachu> the status is reporting it working
[19:51] <stokachu> but the console says otherwise
[19:55] <marcoceppi> stokachu: works for me http://i.imgur.com/fnlaUkl.png
[19:55] <marcoceppi> so, lets pretend they fixed this, can someone help me troubleshoot that error?
[19:55] <marcoceppi> rather
[19:55] <marcoceppi>  'cannot run instances: Request limit exceeded. (RequestLimitExceeded)'
[19:56] <stokachu> aren't you limited to 20 instances
[19:56] <stokachu> or smaller?
[19:56] <marcoceppi> not on this account
[19:56] <marcoceppi> this is API requests
[19:56] <stokachu> i see
[19:56] <marcoceppi> http://docs.aws.amazon.com/AWSEC2/latest/APIReference/query-api-troubleshooting.html#api-request-rate
[19:59] <mgz> marcoceppi: what region?
[19:59] <marcoceppi> us-east-1
[19:59] <marcoceppi> seems to be catching the tail end of the api outage
[19:59] <marcoceppi> I got a series of other errors about root-tagging
[19:59] <marcoceppi> and now it's pending again
[20:00] <mgz> sinzui says that's borked
[20:00] <mgz> try a different region
[20:01] <mgz> you can also see some red on our test-cloud-aws-us-east-1 health job
[20:05] <perrito666> fcs is it really so hard to add docs to public structs?
[20:06] <natefinch> That's why I love having golint running on save... the little squiggles drive me crazy, so I fix them ASAP.
[20:11] <perrito666> some people might need for golint to kick them in the face to actually do something about
[20:11] <perrito666> I would totally love a golint with that feature
[20:12] <natefinch> haha
[20:13] <natefinch> perrito666 is taking over Dave's role as grumpy cat, it seems.
[20:13] <perrito666> oh, you sure are one to talk
[20:13] <natefinch> lol
[20:14] <natefinch> well, to be fair, maybe if we both worked at it together, we might be able to almost match dave's grumpiness.
[20:15] <perrito666> mm, ok, it would seem that I need thumper to make sure I dont break anything in this
[20:16] <thumper> wat?
[20:16] <perrito666> oh, that actually works, sweet
[20:16] <perrito666> mm, ok, it would seem that I need one million dolars so I dont break anything in this
[20:16] <perrito666> meh, nothing happend
[20:17] <natefinch> heh
[20:17] <perrito666> thumper: I am adding ControllerUser to migrations, but it would seem that migrations are per model?
[20:17] <thumper> perrito666: yes, migrations are only per model
[20:17] <thumper> controller user probably doesn't need to be migrated
[20:18] <perrito666> thumper: ok then controller permissions are not something we will be migrating, that makes sense, since we migrate models
[20:18]  * perrito666 facepalms
[20:18] <thumper> aye
[20:19]  * perrito666 adds a bit of info to that pesky test that tells you that you need to migrate stuff
[20:25] <perrito666> natefinch: your jfdi did not like windows
[20:30] <natefinch> perrito666: juju doesn't like windows :/
[20:31] <perrito666> well bad luck, since we are gating landings on it
[20:48] <redir> without gates there'd be no windows
[20:49] <natefinch> *rimshot*
[21:13] <redir> so if I juju set-model-config default-series=xenial && juju deploy wordpress I should expect wordpress to be deployed on xenial, yes?
[21:16] <mup> Bug #1604586 opened: devel Charm Docs are out of date and examples do not work <juju-core:New> <https://launchpad.net/bugs/1604586>
[21:23] <thumper> menn0: http://reviews.vapour.ws/r/5271/diff/#
[21:24] <menn0> thumper: looking
[21:25] <thumper> menn0: ta
[21:27] <perrito666> redir: ir fail iirc
[21:28] <redir> tx perrito666 looks like it falls back if the charms doesn't support the series
[21:29] <redir> but I have another error: ERROR storing charm for URL "cs:trusty/wordpress-4": delegatable macaroon cannot be obtained for public entities
[21:29] <redir> think I must have something twisted.
[21:29] <redir> like my understanding
[21:32] <menn0> thumper: done
[21:52] <thumper> menn0: as reviewer, here's another http://reviews.vapour.ws/r/5265/diff/#
[21:57] <menn0> thumper: looking
[21:57] <thumper> menn0: ta
[22:05] <rick_h_> katco: can you add the link to your pr to the card on the board please?
[22:05] <rick_h_> natefinch: you around to be able to give that a look over?
[22:06] <katco> rick_h_: oh sorry, sure
[22:06] <rick_h_> katco: np, ty much
[22:06] <rick_h_> katco: there's a new bug added there but post the provider doc work just as a heads up, will cover in standup tomorrow
[22:06] <katco> rick_h_: k
[22:09] <katco> wallyworld: hey i see your comment in my PR for the config change... this change isn't in environs/config.go. should i still be writing unit tests there?
[22:11] <wallyworld> katco: it's a bit messed up. the controller config was being parsed by environs/config.go since at bootstrap we handle a single bucket of config items which are then split up. i think that's still the case
[22:11] <perrito666> does anyone know what goes on the depends on field on rb to actually have a dependency?
[22:12] <wallyworld> katco: so as with log forward on/off, i think we can just extend the environs/config tests
[22:12] <redir> perrito666: interface{}
[22:12] <perrito666> redir: of reviewboard, sorry
[22:12] <perrito666> missed that
[22:12] <redir> perrito666: i got that, just a bad joke
[22:14] <thumper> menn0: and another http://reviews.vapour.ws/r/5273/
[22:16] <rick_h_> axw: wallyworld folks arriving on the call
[22:25] <menn0> thumper: done and done. reboot worker one to go.
[22:25] <mup> Bug #1603577 changed: backup-restore: panic: empty value for "api-port" found in configuration <backup-restore> <blocker> <ci> <regression> <juju-core:Fix Released by wallyworld> <https://launchpad.net/bugs/1603577>
[22:25] <menn0> coffee first
[22:32] <thumper> menn0: the reboot one is just a backport
[22:32] <thumper> doesn't need its own review IMO
[22:35]  * perrito666 would be a bit happier if we stoped passing State around as if it where a hot potato and started passing a reduced interface of state
[22:46] <menn0> thumper: ok cool. I thought it sounded familiar :)
[22:46] <thumper> hmm...
[22:46] <thumper> merge bot is rejecting a 1.25 merge, but juju.fail doesn't show any blockers
[22:47] <thumper> ah... a private bug
[22:47] <thumper> hence juju.fail doesn't see it
[22:51] <menn0> wallyworld: any idea on the status of this: http://reviews.vapour.ws/r/5173/
[22:51] <thumper> ugh... none of the core description stuff has any json serialization tags
[22:51] <thumper> perhaps we should add some
[22:53] <wallyworld> looking
[22:53] <wallyworld> menn0: it can be discarded for now, i'll do that
[22:54] <menn0> wallyworld: cheers
[22:58] <alexisb> wallyworld, thumper do you guys have time to meet before the standup?
[22:58] <thumper> yeah
[22:58] <alexisb> I will jump on teh hangout
[22:58] <wallyworld> alexisb: can do, i have a 1:1 with redir, hopefully he will be ok if we do that later
[22:59] <alexisb> wallyworld, it is not super urgent
[23:00] <redir> wfm
[23:08] <menn0> thumper: I just went through the review checklists with http://reviews.vapour.ws/r/5265/. It wasn't too painful and I found a bunch more stuff.
[23:09] <anastasiamac> menn0: how r we maintaing review checklist? is it part of our wiki? or juju/juju/docs?
[23:09] <anastasiamac> maintaining*?
[23:10] <menn0> anastasiamac: it's on the wiki. there will be an official announcement this week about us using it soon from alexisb and rick_h_.
[23:10] <menn0> anastasiamac: https://github.com/juju/juju/wiki/Code-Review-Checklists
[23:10] <menn0> anastasiamac: I just thought I'd get some actual experience with using it
[23:11] <alexisb> menn0, yeah we will try to get that out tomorrow
[23:11] <anastasiamac> menn0: so for item "Are there unit tests with reasonable coverage?"
[23:11] <anastasiamac> i think it should be coverage specific to what PR addresses
[23:11] <anastasiamac> not general
[23:12] <anastasiamac> it's not responsibility of an individual PR to ensure correct test coverage
[23:12] <anastasiamac> PRs should b focused
[23:12] <menn0> anastasiamac: sure. all the items related to the work being reviewed, not the code around it
[23:12] <anastasiamac> menno my hero :D
[23:12] <menn0> anastasiamac: we can make that clearer in the guidance at the top
[23:13] <anastasiamac> menn0: \o/
[23:14] <axw> wallyworld: seen https://bugs.launchpad.net/juju-core/+bug/1604561 ?
[23:14] <mup> Bug #1604561: restoreSuite.TestRestoreReboostrapBuiltInProvider map ordering wrong <blocker> <ci> <regression> <unit-tests> <juju-core:Triaged by wallyworld> <https://launchpad.net/bugs/1604561>
[23:14] <axw> oh it's assigned, I guess so
[23:15] <wallyworld> yep :-)
[23:46] <alexisb> menn0, https://hangouts.google.com/hangouts/_/canonical.com/menno-alexis
[23:46] <perrito666> wallyworld: ill go have dinner then ping you re syncing about acls\
[23:46] <wallyworld> perrito666: ok
[23:57] <wallyworld> redir: there now
[23:57] <redir> wallyworld: omw