| duflu | robert_ancell: Good news... I have no Xmir changes ;) | 02:35 |
|---|---|---|
| robert_ancell | duflu, \o/ | 02:35 |
| === chihchun_afk is now known as chihchun | ||
| === hikiko is now known as hikiko|afk | ||
| alan_g | alf_: I have a design question: I'm trying to restrict the symbols published by libmiral to the public API by generating a symbols.map. And ran across the tests using miral::MRUWindowList (which isn't public). The question: is it best to 1. publish this class? 2. export it in a "private" stanza from the lib? Or, play linker games to make it accessible to tests? | 08:52 |
| alan_g | 4. Stop testing an implementation detail and write tests of the functionality it supports | 08:53 |
| alan_g | alf_: nevermind: Now I've tried it the "linker games" approach feels right. | 09:04 |
| alf_ | alan_g: Sorry, was AFK. Yes, (3) seems best if you can pull it off. As a side note, I don't think (4) is a good choice as the default rule, since it would essentially mean no unit testing. | 09:13 |
| === JanC is now known as Guest77763 | ||
| === JanC_ is now known as JanC | ||
| alan_g | alf_: FWIW https://code.launchpad.net/~alan-griffiths/miral/add-symbols-map/+merge/301754 | 09:15 |
| === hikiko|afk is now known as hikiko | ||
| === mhall119_ is now known as mhall119 | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === Celtor is now known as vitimiti | ||
| === dandrader is now known as dandrader|afk | ||
| === chihchun is now known as chihchun_afk | ||
| === chihchun_afk is now known as chihchun | ||
| === alan_g is now known as alan_g|EOD | ||
| === dandrader|afk is now known as dandrader | ||
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === chihchun is now known as chihchun_afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!