| harlowja | if u want | 00:02 |
|---|---|---|
| === shardy is now known as shardy_mtg | ||
| === shardy_mtg is now known as shardy | ||
| === rangerpbzzzz is now known as rangerpb | ||
| mgagne | harlowja: how can I fork or work on cloud-init in LP git? | 16:38 |
| mgagne | ok so I create a new repo in my own account and push a clone of cloud-init in their? there is no fork button? | 16:39 |
| harlowja | mgagne it seems so | 17:18 |
| harlowja | larks documented this in https://code.launchpad.net/~larsks/cloud-init/+git/cloud-init/+merge/301310 | 17:18 |
| harlowja | its a little different than github | 17:18 |
| larsks | harlowja: yes. | 17:18 |
| larsks | harlowja: but do you have a specific change you'd like to see? | 17:18 |
| mgagne | will read | 17:18 |
| harlowja | not me, mgagne was wondering where is the fork button :-P | 17:19 |
| larsks | Oh sorry. | 17:19 |
| larsks | Ha! | 17:19 |
| * larsks wishes we would all just use gerrit. | 17:19 | |
| mgagne | looks to not be that bad (LP) | 17:20 |
| mgagne | time will tell =) | 17:20 |
| harlowja | its better than bzr | 17:21 |
| harlowja | imho :-P | 17:21 |
| harlowja | cause i only ever understood the basics of bzr, lol | 17:22 |
| smoser | harlowja, going to get over to get completely here shortly. | 17:22 |
| larsks | no argument here :) | 17:22 |
| smoser | with the changge s that larsks had and mine there. | 17:22 |
| harlowja | cool | 17:22 |
| smoser | and then its not ata ll impossible for us to have a c-i that mirrors launchpad to github | 17:22 |
| harlowja | then my jenkins pipeline will work! | 17:22 |
| harlowja | lol | 17:22 |
| smoser | dont know how i feel about that thoguh | 17:22 |
| smoser | ie, i coudl put github/cloud-init-dev/cloud-init to jsut be pushed to from lp:cloud-init by a bot | 17:23 |
| harlowja | meh, i'm ok with this launchpad bzr | 17:23 |
| harlowja | not perfect imho, but good enough | 17:23 |
| harlowja | github not perfect imho either | 17:23 |
| smoser | the big thing is that if i do it there, then it implies we'd take reviews from there. | 17:24 |
| harlowja | ya, meh, don't do it then :-P | 17:24 |
| harlowja | or u can do what openstack-infra does, and they shutdown all PR(s) that come through that | 17:24 |
| harlowja | auto-shutdown | 17:24 |
| smoser | oh. | 17:24 |
| smoser | hm. | 17:24 |
| harlowja | https://github.com/openstack/taskflow/pull/3 | 17:25 |
| harlowja | for example | 17:25 |
| harlowja | i'm pretty sure that person though never followed through with the PR | 17:25 |
| harlowja | (for worse imho) | 17:25 |
| harlowja | so just a warning :-P | 17:25 |
| harlowja | and i don't think people in projects know about how many/if PR(s) have been auto-closed | 17:26 |
| harlowja | for example | 17:26 |
| harlowja | https://github.com/openstack/nova/pulls?q=is%3Apr+is%3Aclosed | 17:26 |
| harlowja | there are 65 lost reviews there? | 17:26 |
| * harlowja i think i complained about that once | 17:26 | |
| harlowja | (ie at least send an email to the PTL when a PR gets auto-closed) | 17:26 |
| harlowja | so PTL can at least follow up with person (if they want) | 17:27 |
| JayF | harlowja: I think monty emailed the list about improving their generic message pushed up to github, to make it more clear how toa ctually contribute | 17:35 |
| harlowja | JayF possibly | 17:38 |
| harlowja | i'd like a 'cc' to the PTL that it got closed on also | 17:38 |
| harlowja | i'm pretty sure that not many people (PTL or other) know to go look and see whats been closed | 17:39 |
| JayF | I mean | 17:40 |
| JayF | PTLs haev no time as is | 17:40 |
| harlowja | meh | 17:40 |
| harlowja | life is hard | 17:40 |
| JayF | that would get filed into a folder and never read ever | 17:40 |
| JayF | at least for the major projects | 17:40 |
| harlowja | i don't accept the life is hard part | 17:40 |
| harlowja | life is hard, therefore /dev/null | 17:40 |
| harlowja | sounds like a cop-out to me ;) | 17:40 |
| harlowja | back to sucking my thumb in the corner | 17:41 |
| harlowja | ha | 17:41 |
| JayF | it's all a matter of priorities right? | 17:41 |
| harlowja | sure | 17:41 |
| harlowja | but if right now it goes to /dev/null u can't even assign someone from the PTL(s) team to even look at that stuff | 17:41 |
| JayF | like folks would rather 1) work a reasonable number of hours and 2) spend those hours working on project priorities, instead of holding the hand of someone who can't read a $#@%$!@#ing doc about how to contribue :P | 17:41 |
| harlowja | thats what interns are for? | 17:42 |
| harlowja | 3) assign task to followup with the folks that got PR closed on them (that may or may not have submitted code to the gerrit system) and be nice and kind to them, and see if they need help | 17:42 |
| harlowja | treat others like u would want to be treated, blah blah | 17:42 |
| mgagne | are unit tests really trying to read files in /proc ? | 19:03 |
| mgagne | harlowja: how do you link your personal repo to the upstream one? I'm following steps found in README, reading LP help page and not much details here, there is no Propose for merge in my repo | 19:16 |
| harlowja | hmmm | 19:18 |
| harlowja | on for example | 19:18 |
| harlowja | https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+ref/fix-distro-tags | 19:18 |
| mgagne | yep, link is showing here | 19:18 |
| harlowja | there was a 'propose for merging' that i clikced thed | 19:18 |
| harlowja | u don't got one? | 19:18 |
| mgagne | there is none for me: https://code.launchpad.net/~mgagne/+git/cloud-init/+ref/bond_name | 19:18 |
| harlowja | *clicked there | 19:18 |
| harlowja | hmmm | 19:19 |
| mgagne | so I think the repo isn't linked with "upstream" | 19:19 |
| mgagne | and I'm not sure how to fix that | 19:19 |
| harlowja | maybe it also needs some commits? | 19:19 |
| mgagne | there is a commit | 19:19 |
| mgagne | which I'm trying to propose for merge | 19:19 |
| harlowja | ah, kk, it shows i think the author as scott | 19:19 |
| harlowja | unsure here | 19:20 |
| mgagne | yes, I didn't code that feature | 19:20 |
| harlowja | i call in smoser who might know, ha | 19:20 |
| mgagne | so I'm not putting my name in there | 19:20 |
| harlowja | k | 19:20 |
| mgagne | harlowja: found it | 19:26 |
| mgagne | Change repository details -> Target: Project: cloud-init | 19:26 |
| mgagne | this detail isn't part of any documentation if found (cloud-init or LP) | 19:27 |
| mgagne | harlowja: ok merge proposal done =) | 19:28 |
| smoser | mgagne, whats up? | 19:29 |
| mgagne | smoser: a review request? =) | 19:29 |
| mgagne | smoser: was struggling to find how to link my personal repo to the upstream one | 19:30 |
| mgagne | now it's done with above steps | 19:30 |
| === rangerpb is now known as rangerpbzzzz | ||
| mgagne | smoser: I think the test you are referring to was to test bond_slaves, not bond name. Maybe i'm wrong: http://paste.ubuntu.com/20492837/ | 20:56 |
| mgagne | let me know if I misunderstood the purpose of the test | 20:57 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!