wallyworldredir: did you want to talk?00:00
wallyworldredir: standup ho is fine with me00:04
mupBug #1333162 changed: cannot bootstrap on openstack provider:  Multiple security_group matches found for name 'XYZ', use an ID to be more specific. <bug-squad>00:06
mup<charmers> <openstack-provider> <repeatability> <security> <uosci> <juju-core:Invalid> <juju-core 1.25:Won't Fix> <https://launchpad.net/bugs/1333162>00:06
=== stokachu_ is now known as stokachu
menn0wallyworld, axw: can we schedule some time next week to talk about the impact of model config tree on migrations?01:41
axwmenn0: sure. any day after 9am is fine for me. some days I can do earlier, some I can't01:42
menn0axw: 9am your time right?01:44
axwmenn0: yup01:44
axwmenn0: gotta do school dropoff01:44
menn0axw: let's wait until wallyworld responds and we'll make a time01:44
wallyworldanytime suits me01:45
wallyworld11am works01:45
* menn0 opens time zone planner01:46
menn0ok, that works for me01:47
menn0i'll put it in the calendar01:47
menn0wallyworld, axw: done01:49
wallyworldmenn0: not shown up for me yet - you made it next monday?01:51
wallyworldyou made it last monday01:52
menn0wallyworld: I'm a moran01:52
wallyworldwe've all been there :-D01:52
wallyworldso it i01:52
mupBug #1428439 changed: retry-provisioning launches instances for containers; cannot retry containers at all <juju-core:Invalid> <juju-core 1.24:Fix Released by hduran-8> <https://launchpad.net/bugs/1428439>02:09
mupBug #1612478 opened: remove retry-provisiosing command <usability> <juju-core:Triaged> <https://launchpad.net/bugs/1612478>02:09
natefincham I doing something wrong?  When I marshal from json to a generic structure in Go, I get map[string]interface{}, when I do it with gopkg.in/yaml.v2, I get map[interface{}]interface{} ... what's up with that, anyone know?02:31
perrito666I would guess that yaml is wrong (but no, yaml does that iirc)02:48
perrito666Menn0 I would be grateful if you publish the instructions (even if crude) for the proxy in juju, the creation of a new lxd instance takes forever02:49
menn0perrito666: ok, I'll try and do that today02:50
perrito666Just a hint would be enough02:50
perrito666I am at near 25 per bootstrap02:50
perrito666Or more02:51
natefinchwallyworld: can you make a new repo in github.com/juju called cloudschema?02:55
wallyworldcloudschema? did we want ot more general?02:56
natefinchnot sure02:56
wallyworldis this for the jsonschema stuff?02:57
natefinchright now it's not cloud config specific, but it is "juju config that we'll want to use for interactive prompts" specific02:57
natefinchwallyworld: current API: https://godoc.org/github.com/natefinch/cloudschema02:58
wallyworldright, so i can't ser why "cloud" is relevant, it's just a schema lib02:58
natefinchwallyworld: because there's metadata that isn't validation schema, like "secret" and metadata for generating CLI prompts02:59
wallyworldthat's not cloud either02:59
wallyworldpasswords are a generic concept02:59
natefinchyes, true02:59
wallyworldgojsonschema is taken it looks like03:00
wallyworldis it reall just CLI; the same thing could be used got GUI03:00
wallyworldwhat's in gojsonschema?03:00
natefinchthat's the old jsonschema we forked from someone else03:00
natefinchit's what this will replace03:01
natefinchthat and environschema03:01
wallyworldhmmm, so we really want this new one call gojsonschema. why not gojsonschema.v203:01
natefinchno I really don't want to call it gojsonschema03:01
wallyworldthat's what it is03:01
wallyworldisn't it?03:02
natefinchit's jsonschema... you don't need "go"03:02
natefinchif you want, we can call it jsonschema03:02
wallyworldthe convention with go projects is goblah right?03:02
wallyworldbut jsonschema works03:02
natefinchthe problem is that it's not really just jsonschema.  it's jsonschema with extra junk03:03
wallyworldi hate naming stuff03:05
wallyworldnatefinch: because it's off juju, maybe jsonschema is ok, since it's a jsonschema lib for use in juju? if it does jsonschema plus extras, i think that's ok?03:07
wallyworldit's not not jsonschema03:08
natefinchthat's fine03:08
wallyworldnatefinch: done03:11
natefinchwallyworld: sweet, thank you03:12
natefinchwallyworld: and thanks for the input on the name03:12
wallyworldsure :-)03:12
wallyworldbikeshed :-)03:12
natefinchnames matter more than we think :)03:12
natefinch$ ls03:14
natefinchLICENCE  LICENSE  README.md  schema.go  schema_test.go03:14
natefinchcrazy brits03:14
wallyworldnatefinch: it's only you guys in the US that spell differently to the rest of the whole world03:17
wallyworldwe know the difference between nouns and verbs03:17
wallyworldlicence is a noun. license is a verb03:17
wallyworldadvice is a noun. advise is a verb03:18
natefinchhmm, good example.03:18
wallyworldwe also understand the difference between least to most significant. YYYY-MM-DD or DD-MMM-YYYY03:18
wallyworldnot YYYY-DD-MM03:18
natefinchno no, we do MM-DD-YYYY03:19
wallyworldsame diff :-)03:19
wallyworldstill out of order03:19
natefinchbut yes, still dumb03:19
natefinchcode review anyone?03:52
mupBug #1612500 opened: Can't migrate back to a controller due to user permissions <juju-core:In Progress by menno.smits> <https://launchpad.net/bugs/1612500>05:43
axwwallyworld: would you please take a look: http://reviews.vapour.ws/r/5423/06:01
wallyworldaxw: sure, just got to go to school pickup, will lookin a bit06:01
axwwallyworld: np, thanks06:01
wallyworldaxw: so did you discover why rate limiting wasn't kicking in? or was that a red herring?06:27
axwwallyworld: red herring. it is, I verified it works - I think their subscription is just so busy it never stopped getting rate limited06:27
wallyworldwondered as much06:28
wallyworldi think storage accouny key used to be a pointer rather than a slice before the sdk change right?06:28
axwwallyworld: it was a pointer to a struct that had multiple keys in it06:29
axwwallyworld: also it never used to have this permission thing06:29
wallyworldah, right ok. lgtm. code looks ok, i'll take your word thst it works06:30
axwwallyworld: thanks06:33
=== akhavr1 is now known as akhavr
mupBug #1603910 changed: model-level log forwarding not supported <oil> <oil-2.0> <juju-core:Fix Released> <https://launchpad.net/bugs/1603910>09:34
=== akhavr1 is now known as akhavr
=== akhavr1 is now known as akhavr
rogpeppeanyone up for a review of this please? it just adds a (failing) test for some currently broken functionality. fix in subsequent PR. https://github.com/juju/juju/pull/598410:47
dimiternrogpeppe: LGTM10:54
rogpeppedimitern: thanks!10:54
rogpeppedimitern: i just realised that to save CI test time, it's better if I submit the fix as well in the same PR, so I've proposed this: https://github.com/juju/juju/pull/5985/files11:05
rogpeppedimitern: that has the PR you just reviewed as the first commit11:05
rogpeppedimitern: and the fix as the second11:05
dimiternrogpeppe: on it11:06
rogpeppedimitern: feel free to comment directly on the second commit: https://github.com/juju/juju/pull/5985/commits/9d3478263f1d5fd4be0adb038e0811c25c9641a011:06
dimiternrogpeppe: ok, but where are your QA steps? :)11:07
rogpeppedimitern: check that juju still works, i guess :)11:07
dimiternrogpeppe: that's preferable, but it should be possible to trigger the issue you're fixing?11:08
rogpeppedimitern: no, the issue only occurs in tests that I've seen11:08
dimiternrogpeppe: or it's one of those races that's hard to trigger?11:08
rogpeppedimitern: because generally apiserver instances aren't torn down11:08
dimiternrogpeppe: ah, so it's not observable otherwise?11:09
rogpeppedimitern: yes11:09
dimiternrogpeppe: ok, housekeeping then ;)11:09
rogpeppedimitern: you could look at it like that, i guess11:09
rogpeppedimitern: but it would impact in any real situation where we try to tear down workers synchronously when there are outstanding blocked API calls11:10
dimiternrogpeppe: right11:11
* dimitern adds rogpeppe's fork as remote to run the tests11:11
dimiternrogpeppe: wow, you're like voidspace - hardly ever deleting merged branches11:12
rogpeppedimitern: i never delete merged branches11:13
rogpeppedimitern: why bother? :)11:13
dimiternrogpeppe: for the sake of anybody pulling regularly from your fork I guess ;)11:13
rogpeppedimitern: it'll only make a difference the first time they pull...11:13
dimiternrogpeppe: and seeing a couple of screenfuls each time heh11:13
mupBug #1612624 opened: Bootstrap fail on MAAS if ipv6 is disabled <juju-core:New> <https://launchpad.net/bugs/1612624>11:16
dimiternrogpeppe: LGTM11:34
rogpeppedimitern: ta!11:34
rogpeppemhilton: i just realised i pushed $$merge$$ having assumed you'd LGTM'd the branch11:41
rogpeppemhilton: and you haven't, sorry!11:41
rogpeppemhilton: any chance of a retrospective... ?11:41
mgzrogpeppe: eheh11:43
rogpeppemgz: :)11:43
rick_h_morning, happy friday11:54
babbageclunkdimitern, katco: could you take another look at http://reviews.vapour.ws/r/5366/diff please?12:06
dimiternbabbageclunk: sure, in a moment12:07
babbageclunkdimitern: Thanks!12:07
rogpeppehere's the branch that exposed the bug fixed by my earlier PR. it splits the controller and model APIs. reviews much appreciated! http://reviews.vapour.ws/r/5426/)12:46
rogpeppedimitern: ?^12:47
dimiternrogpeppe: will do after I finish babbageclunk's review12:50
mupBug #1612645 opened: New EC2 region in India (ap-south-1 - Mumbai) <canonical-is> <juju-core:New> <https://launchpad.net/bugs/1612645>12:53
babbageclunkrogpeppe: I'll take a look at yours while he's doing mine! :)12:59
rogpeppebabbageclunk, dimitern: ta!13:15
babbageclunkrogpeppe: Would it be hard to split the Api -> API change into a separate diff? It'd be a lot easier to follow the controller API / model API change.13:16
rogpeppebabbageclunk: i hoped you wouldn't say that :)13:16
rogpeppebabbageclunk: it would be quite hard now, unfortunately13:17
babbageclunkrogpeppe: oh no - squished commits?13:17
rogpeppebabbageclunk: yeah13:17
babbageclunkoh well13:18
rogpeppebabbageclunk: perhaps you can just slide your eyes over the spelling changes :)13:18
babbageclunkrogpeppe: I guess I'll have to! :)13:19
rogpeppebabbageclunk: thanks13:20
rogpeppebabbageclunk: i should've thought at the time13:20
mupBug #1612653 opened: bootstrap fails in beta15 when installing via snap <juju-core:New> <https://launchpad.net/bugs/1612653>13:23
babbageclunkrogpeppe: reviewed - looks good, just one bit of confusion on my part.13:52
rogpeppebabbageclunk: tyvm13:52
mupBug #1612658 opened: LXD no activate interface is bonding is used in MAAS2rc4 <juju-core:New> <https://launchpad.net/bugs/1612658>13:53
rogpeppebabbageclunk: OpenControllerAPI landed in a PR just recently13:53
babbageclunkrogpeppe: Ah, right - thought it could be something like that.13:54
natefinchrick_h_: I'm going to miss standup.  My wife is sick in bed, so I'm with the kids.  Might get some work done this afternoon, but not sure.  I'll send a summary email of where I am.13:58
natefinchand if anyone wants to do a review: https://github.com/juju/jsonschema/pull/113:59
rick_h_natefinch: k13:59
rick_h_natefinch: please make sure the kanban board is up to date with links/etc13:59
rick_h_natefinch: of particular interest is where the windows bu g is14:00
rick_h_katco: dimitern standup time14:00
natefinchrick_h_: I didn't do much with the windows bug, unfortunately... maybe that was a prioritization failure on my part, if so, I am sorry.  I was finally getting somewhere with the jsonschema stuff, so I was trying to push through with it.14:01
rick_h_natefinch: I've promised that bug by next beta. We need to get it in. it's carried over and block OIL for multiple weeks atm14:02
rick_h_natefinch: so that bug is priority #1 please14:02
natefinchrick_h_: right.  My apologies.  I'll do my best to get it done today.14:02
dimiternbabbageclunk: sorry it took me so long, but you have an initial review14:03
dimiternbabbageclunk: I'm happy to chat / clarify anything after standup14:03
dimiternrogpeppe: reviewed yours as well, finally14:18
rogpeppedimitern: thanks!14:18
=== natefinch is now known as natefinch-afk
macgreagoirkatco: If you have five minutes now, stand-up HO?14:28
katcomacgreagoir: still there :)14:28
macgreagoirCool, cheers :-)14:28
katcomacgreagoir: well for 1, it looks like there's more recent precedent for utilizing testing.RunCommand without the goroutine14:44
katcomacgreagoir: so i would say at the very least, the way you started to do things is more correct14:44
katcomacgreagoir: e.g. take a look at cmd/juju/controller/listmodels_test.go14:45
katcoaxw: has some very nice tests14:45
katcomacgreagoir: and it is done by mocking the api client, which is what i remembered doing, so i would definitely hold this up as the way to properly write tests against commands14:47
katcomacgreagoir: does that sound ok?14:47
babbageclunkdimitern: cool, thanks14:53
babbageclunkdimitern: The connected model checking was something Will asked for. Is he around today? Can't see any holiday on the calendar.14:59
macgreagoirkatco: Cheers15:00
katcomacgreagoir: hope that helps :)15:01
macgreagoir(my irssi bell seems quite, sorry)15:01
katcomacgreagoir: lol no worries15:01
macgreagoirkatco: That might be where unregister tests ideas were scraped from :-)15:04
katcomacgreagoir: :) the cargo culting is real. just gotta make sure you're copying the right stuff! ;p15:04
rick_h_babbageclunk: sorry, not around today15:14
babbageclunkrick_h_: Stink - thanks!15:14
dimiternbabbageclunk: he may have forgotten about GetAuthTag15:27
dimiternbabbageclunk: sorry, I guess you got conflicting suggestions :/15:28
dimiternbabbageclunk: let's have a chat with Will next week I guess..15:28
babbageclunkdimitern: I don't think GetAuthTag does what he wanted, but I can't really explain why he wanted the model check - I do feel like it's a bit redundant given the check in the ctor.15:30
dimiternbabbageclunk: ok15:30
dimiternbabbageclunk: I'll have a look at his earlier comments15:30
dimiternbabbageclunk: and possibly update mine, but a bit later (need to go out ~1h)15:31
ejatanyone here use juju at azure?16:07
mupBug #1612717 opened: Pinger facade not implemented on controller websocket connection <juju-core:New> <https://launchpad.net/bugs/1612717>16:11
mupBug #1612717 changed: Pinger facade not implemented on controller websocket connection <juju-core:New> <https://launchpad.net/bugs/1612717>16:14
mupBug #1612717 opened: Pinger facade not implemented on controller websocket connection <juju-core:New> <https://launchpad.net/bugs/1612717>16:29
mupBug #1612722 opened: Juju cannot destroy models/machine, all testing substrates are exhausted <blocker> <ci> <destroy-controller> <kill-controller> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1612722>16:29
mupBug #1612687 opened: Juju not showing real states of deployed nodes via MAAS. <juju-core:New> <https://launchpad.net/bugs/1612687>16:44
rick_h_katco: can you please review https://github.com/juju/juju/pull/598716:58
rogpeppehere's some apiserver cleanup; reviews appreciated: https://github.com/juju/juju/pull/5988/files17:10
katcorick_h_: sorry, was eating lunch. tal17:25
rick_h_katco: all good, decided it was a clean revert so let it rip17:27
katcorick_h_: ok. redir's +1 is probably sufficient as well. verifying a revert requires no knowledge of juju :)17:27
rick_h_katco: :)17:27
perrito666man, we really need to stop writing doc lines that are tautological17:29
rick_h_katco: can you peek at https://github.com/juju/juju/pull/5988/files then which is more interesting?17:33
katcorick_h_: ok17:35
rick_h_katco: ty17:35
mupBug #1612744 opened: MachinerSuite.TestMachinerMachineAssignedUnits agent should be terminated <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1612744>17:38
mupBug #1612745 opened: rackerSuite.TestGainLeadership number of ClaimLeadership is wrong <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1612745>17:38
mupBug #1612747 opened: DebugHooksServerSuite.TestRunHook signal: killed <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1612747>17:38
* rick_h_ gets some lunch with that done17:46
kwmonroeejat: i use juju/azure18:09
ejatkwmonroe: okie .. its working now .. thanks18:10
* rick_h_ runs to get my truck and the boy from summer camp. have a good weekend folks19:19
mupBug #1612775 opened: resource get fails, resource already staged <juju-core:New> <https://launchpad.net/bugs/1612775>19:30
perrito666it would be extremely nice of us to name the same thing in the same way across facades20:02
redirperrito666: novel idea20:02
perrito666authorizer and state are called something different across all facades20:03
perrito666and just found one without authorizer20:04
natefinchsinzui: are you still having problems with that windows deploy CI test?  I seem to be able to deploy a windows charm just fine on azure20:13
sinzuinatefinch: I think not. I am still wating for one to complete to say all is well20:13
sinzuinatefinch: once juju broke the reate limit. azure locked our for many hours20:13
natefinchsinzui: great :)20:13
sinzuinatefinch: I see some azure successes. most failed though.I suspect the failure were at the tail end of the lockout. I will retest.20:19
katcosinzui: hey does qa have any plans to release the qa tools as a snap?20:27
sinzuikatco: we expect to do dailies20:27
katcosinzui: daily releases of the qa tools?20:27
sinzuikatco: oh, no. no plans to snape jujuc-ci-tools or juju-release-tools20:28
katcosinzui: sorry, jujuc-ci-tools20:28
katcosinzui: having just gone through the setup process, it would be awesome to just download a snap20:28
sinzuimaybe balloons will want try it. Since snap doesn't work with windows, centos, or osx, we are dedicated to working with a common solution.20:29
katcosinzui: ah good point20:30
mupBug #1612793 opened: bootstrap azure/southcentralus is failing in 2.0-betaX <juju-core:New> <https://launchpad.net/bugs/1612793>20:30
perrito666... obtained int = 220:39
perrito666... expected int = 220:39
katcoyay my recator compiles for the 1st time20:44
mupBug #1612335 changed: Azure rate limit leads to catastrophic failure for subscription <azure-provider> <bootstrap> <ci> <destroy-controller> <kill-controller> <regression> <juju-core:Fix Released by axwalk> <https://launchpad.net/bugs/1612335>21:39
mupBug #1612722 changed: Juju cannot destroy models/machine, all testing substrates are exhausted <blocker> <ci> <destroy-controller> <kill-controller> <regression> <juju-core:Fix Released by rharding> <https://launchpad.net/bugs/1612722>21:39
mupBug #1612836 opened: Cannot bring up hosted  model machines in azure <azure-provider> <ci> <deploy> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1612836>21:48
katcorick_h_: ping, don't suppose you're on22:14
perrito666mmm, ppas dont work nicely with my deb proxy22:34

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!