wallyworld | redir: did you want to talk? | 00:00 |
---|---|---|
redir | sure | 00:01 |
redir | where? | 00:01 |
wallyworld | redir: standup ho is fine with me | 00:04 |
redir | OK | 00:04 |
redir | brt | 00:04 |
mup | Bug #1333162 changed: cannot bootstrap on openstack provider: Multiple security_group matches found for name 'XYZ', use an ID to be more specific. <bug-squad> | 00:06 |
mup | <charmers> <openstack-provider> <repeatability> <security> <uosci> <juju-core:Invalid> <juju-core 1.25:Won't Fix> <https://launchpad.net/bugs/1333162> | 00:06 |
=== stokachu_ is now known as stokachu | ||
menn0 | wallyworld, axw: can we schedule some time next week to talk about the impact of model config tree on migrations? | 01:41 |
axw | menn0: sure. any day after 9am is fine for me. some days I can do earlier, some I can't | 01:42 |
menn0 | axw: 9am your time right? | 01:44 |
axw | menn0: yup | 01:44 |
menn0 | cool | 01:44 |
axw | menn0: gotta do school dropoff | 01:44 |
menn0 | axw: let's wait until wallyworld responds and we'll make a time | 01:44 |
wallyworld | anytime suits me | 01:45 |
wallyworld | 11am works | 01:45 |
* menn0 opens time zone planner | 01:46 | |
menn0 | ok, that works for me | 01:47 |
menn0 | i'll put it in the calendar | 01:47 |
menn0 | wallyworld, axw: done | 01:49 |
wallyworld | menn0: not shown up for me yet - you made it next monday? | 01:51 |
menn0 | checking | 01:51 |
wallyworld | you made it last monday | 01:52 |
wallyworld | :-) | 01:52 |
menn0 | wallyworld: I'm a moran | 01:52 |
menn0 | fixed | 01:52 |
wallyworld | we've all been there :-D | 01:52 |
wallyworld | so it i | 01:52 |
wallyworld | s | 01:52 |
menn0 | https://cdn1.vox-cdn.com/thumbor/cdRv1O8Rg-_aVC7N81Z6ROrV6_A=/0x0:524x349/1310x873/cdn0.vox-cdn.com/uploads/chorus_image/image/25006307/moran.0.jpg | 01:53 |
wallyworld | lol | 01:53 |
wallyworld | classic | 01:54 |
mup | Bug #1428439 changed: retry-provisioning launches instances for containers; cannot retry containers at all <juju-core:Invalid> <juju-core 1.24:Fix Released by hduran-8> <https://launchpad.net/bugs/1428439> | 02:09 |
mup | Bug #1612478 opened: remove retry-provisiosing command <usability> <juju-core:Triaged> <https://launchpad.net/bugs/1612478> | 02:09 |
natefinch | am I doing something wrong? When I marshal from json to a generic structure in Go, I get map[string]interface{}, when I do it with gopkg.in/yaml.v2, I get map[interface{}]interface{} ... what's up with that, anyone know? | 02:31 |
perrito666 | I would guess that yaml is wrong (but no, yaml does that iirc) | 02:48 |
perrito666 | Menn0 I would be grateful if you publish the instructions (even if crude) for the proxy in juju, the creation of a new lxd instance takes forever | 02:49 |
menn0 | perrito666: ok, I'll try and do that today | 02:50 |
perrito666 | Just a hint would be enough | 02:50 |
perrito666 | I am at near 25 per bootstrap | 02:50 |
perrito666 | Or more | 02:51 |
natefinch | wallyworld: can you make a new repo in github.com/juju called cloudschema? | 02:55 |
wallyworld | sure | 02:55 |
wallyworld | cloudschema? did we want ot more general? | 02:56 |
wallyworld | it | 02:56 |
natefinch | not sure | 02:56 |
wallyworld | is this for the jsonschema stuff? | 02:57 |
natefinch | right now it's not cloud config specific, but it is "juju config that we'll want to use for interactive prompts" specific | 02:57 |
natefinch | wallyworld: current API: https://godoc.org/github.com/natefinch/cloudschema | 02:58 |
wallyworld | right, so i can't ser why "cloud" is relevant, it's just a schema lib | 02:58 |
natefinch | wallyworld: because there's metadata that isn't validation schema, like "secret" and metadata for generating CLI prompts | 02:59 |
wallyworld | that's not cloud either | 02:59 |
wallyworld | passwords are a generic concept | 02:59 |
natefinch | yes, true | 02:59 |
natefinch | clischema? | 03:00 |
wallyworld | gojsonschema is taken it looks like | 03:00 |
wallyworld | is it reall just CLI; the same thing could be used got GUI | 03:00 |
natefinch | true | 03:00 |
natefinch | uxschema? | 03:00 |
wallyworld | what's in gojsonschema? | 03:00 |
natefinch | that's the old jsonschema we forked from someone else | 03:00 |
natefinch | it's what this will replace | 03:01 |
natefinch | that and environschema | 03:01 |
wallyworld | hmmm, so we really want this new one call gojsonschema. why not gojsonschema.v2 | 03:01 |
natefinch | no I really don't want to call it gojsonschema | 03:01 |
wallyworld | that's what it is | 03:01 |
wallyworld | isn't it? | 03:02 |
natefinch | it's jsonschema... you don't need "go" | 03:02 |
natefinch | if you want, we can call it jsonschema | 03:02 |
wallyworld | the convention with go projects is goblah right? | 03:02 |
wallyworld | but jsonschema works | 03:02 |
natefinch | the problem is that it's not really just jsonschema. it's jsonschema with extra junk | 03:03 |
wallyworld | hmmm | 03:05 |
wallyworld | i hate naming stuff | 03:05 |
wallyworld | natefinch: because it's off juju, maybe jsonschema is ok, since it's a jsonschema lib for use in juju? if it does jsonschema plus extras, i think that's ok? | 03:07 |
wallyworld | it's not not jsonschema | 03:08 |
natefinch | that's fine | 03:08 |
wallyworld | natefinch: done | 03:11 |
natefinch | wallyworld: sweet, thank you | 03:12 |
natefinch | wallyworld: and thanks for the input on the name | 03:12 |
wallyworld | sure :-) | 03:12 |
wallyworld | bikeshed :-) | 03:12 |
natefinch | names matter more than we think :) | 03:12 |
natefinch | lol | 03:14 |
natefinch | $ ls | 03:14 |
natefinch | LICENCE LICENSE README.md schema.go schema_test.go | 03:14 |
natefinch | crazy brits | 03:14 |
wallyworld | natefinch: it's only you guys in the US that spell differently to the rest of the whole world | 03:17 |
wallyworld | we know the difference between nouns and verbs | 03:17 |
wallyworld | licence is a noun. license is a verb | 03:17 |
wallyworld | advice is a noun. advise is a verb | 03:18 |
wallyworld | etc | 03:18 |
natefinch | hmm, good example. | 03:18 |
wallyworld | we also understand the difference between least to most significant. YYYY-MM-DD or DD-MMM-YYYY | 03:18 |
wallyworld | not YYYY-DD-MM | 03:18 |
natefinch | no no, we do MM-DD-YYYY | 03:19 |
wallyworld | same diff :-) | 03:19 |
wallyworld | still out of order | 03:19 |
natefinch | but yes, still dumb | 03:19 |
natefinch | code review anyone? | 03:52 |
natefinch | https://github.com/juju/jsonschema/pull/1 | 03:52 |
mup | Bug #1612500 opened: Can't migrate back to a controller due to user permissions <juju-core:In Progress by menno.smits> <https://launchpad.net/bugs/1612500> | 05:43 |
axw | wallyworld: would you please take a look: http://reviews.vapour.ws/r/5423/ | 06:01 |
wallyworld | axw: sure, just got to go to school pickup, will lookin a bit | 06:01 |
axw | wallyworld: np, thanks | 06:01 |
wallyworld | axw: so did you discover why rate limiting wasn't kicking in? or was that a red herring? | 06:27 |
axw | wallyworld: red herring. it is, I verified it works - I think their subscription is just so busy it never stopped getting rate limited | 06:27 |
wallyworld | wondered as much | 06:28 |
wallyworld | i think storage accouny key used to be a pointer rather than a slice before the sdk change right? | 06:28 |
axw | wallyworld: it was a pointer to a struct that had multiple keys in it | 06:29 |
axw | wallyworld: also it never used to have this permission thing | 06:29 |
wallyworld | ah, right ok. lgtm. code looks ok, i'll take your word thst it works | 06:30 |
axw | wallyworld: thanks | 06:33 |
wallyworld | np | 06:33 |
=== akhavr1 is now known as akhavr | ||
mup | Bug #1603910 changed: model-level log forwarding not supported <oil> <oil-2.0> <juju-core:Fix Released> <https://launchpad.net/bugs/1603910> | 09:34 |
=== akhavr1 is now known as akhavr | ||
=== akhavr1 is now known as akhavr | ||
rogpeppe | anyone up for a review of this please? it just adds a (failing) test for some currently broken functionality. fix in subsequent PR. https://github.com/juju/juju/pull/5984 | 10:47 |
dimitern | rogpeppe: LGTM | 10:54 |
rogpeppe | dimitern: thanks! | 10:54 |
rogpeppe | dimitern: i just realised that to save CI test time, it's better if I submit the fix as well in the same PR, so I've proposed this: https://github.com/juju/juju/pull/5985/files | 11:05 |
rogpeppe | dimitern: that has the PR you just reviewed as the first commit | 11:05 |
rogpeppe | dimitern: and the fix as the second | 11:05 |
dimitern | rogpeppe: on it | 11:06 |
rogpeppe | dimitern: feel free to comment directly on the second commit: https://github.com/juju/juju/pull/5985/commits/9d3478263f1d5fd4be0adb038e0811c25c9641a0 | 11:06 |
dimitern | rogpeppe: ok, but where are your QA steps? :) | 11:07 |
rogpeppe | dimitern: check that juju still works, i guess :) | 11:07 |
dimitern | rogpeppe: that's preferable, but it should be possible to trigger the issue you're fixing? | 11:08 |
rogpeppe | dimitern: no, the issue only occurs in tests that I've seen | 11:08 |
dimitern | rogpeppe: or it's one of those races that's hard to trigger? | 11:08 |
rogpeppe | dimitern: because generally apiserver instances aren't torn down | 11:08 |
dimitern | rogpeppe: ah, so it's not observable otherwise? | 11:09 |
rogpeppe | dimitern: yes | 11:09 |
dimitern | rogpeppe: ok, housekeeping then ;) | 11:09 |
rogpeppe | dimitern: you could look at it like that, i guess | 11:09 |
rogpeppe | dimitern: but it would impact in any real situation where we try to tear down workers synchronously when there are outstanding blocked API calls | 11:10 |
dimitern | rogpeppe: right | 11:11 |
* dimitern adds rogpeppe's fork as remote to run the tests | 11:11 | |
dimitern | rogpeppe: wow, you're like voidspace - hardly ever deleting merged branches | 11:12 |
rogpeppe | dimitern: i never delete merged branches | 11:13 |
rogpeppe | dimitern: why bother? :) | 11:13 |
dimitern | rogpeppe: for the sake of anybody pulling regularly from your fork I guess ;) | 11:13 |
rogpeppe | dimitern: it'll only make a difference the first time they pull... | 11:13 |
dimitern | rogpeppe: and seeing a couple of screenfuls each time heh | 11:13 |
mup | Bug #1612624 opened: Bootstrap fail on MAAS if ipv6 is disabled <juju-core:New> <https://launchpad.net/bugs/1612624> | 11:16 |
dimitern | rogpeppe: LGTM | 11:34 |
rogpeppe | dimitern: ta! | 11:34 |
rogpeppe | mhilton: i just realised i pushed $$merge$$ having assumed you'd LGTM'd the branch | 11:41 |
rogpeppe | mhilton: and you haven't, sorry! | 11:41 |
rogpeppe | mhilton: any chance of a retrospective... ? | 11:41 |
mgz | rogpeppe: eheh | 11:43 |
rogpeppe | mgz: :) | 11:43 |
rick_h_ | morning, happy friday | 11:54 |
babbageclunk | dimitern, katco: could you take another look at http://reviews.vapour.ws/r/5366/diff please? | 12:06 |
dimitern | babbageclunk: sure, in a moment | 12:07 |
babbageclunk | dimitern: Thanks! | 12:07 |
rogpeppe | here's the branch that exposed the bug fixed by my earlier PR. it splits the controller and model APIs. reviews much appreciated! http://reviews.vapour.ws/r/5426/) | 12:46 |
rogpeppe | dimitern: ?^ | 12:47 |
dimitern | rogpeppe: will do after I finish babbageclunk's review | 12:50 |
mup | Bug #1612645 opened: New EC2 region in India (ap-south-1 - Mumbai) <canonical-is> <juju-core:New> <https://launchpad.net/bugs/1612645> | 12:53 |
babbageclunk | rogpeppe: I'll take a look at yours while he's doing mine! :) | 12:59 |
rogpeppe | babbageclunk, dimitern: ta! | 13:15 |
babbageclunk | rogpeppe: Would it be hard to split the Api -> API change into a separate diff? It'd be a lot easier to follow the controller API / model API change. | 13:16 |
rogpeppe | babbageclunk: i hoped you wouldn't say that :) | 13:16 |
rogpeppe | babbageclunk: it would be quite hard now, unfortunately | 13:17 |
babbageclunk | rogpeppe: oh no - squished commits? | 13:17 |
rogpeppe | babbageclunk: yeah | 13:17 |
babbageclunk | oh well | 13:18 |
rogpeppe | babbageclunk: perhaps you can just slide your eyes over the spelling changes :) | 13:18 |
babbageclunk | rogpeppe: I guess I'll have to! :) | 13:19 |
rogpeppe | babbageclunk: thanks | 13:20 |
rogpeppe | babbageclunk: i should've thought at the time | 13:20 |
mup | Bug #1612653 opened: bootstrap fails in beta15 when installing via snap <juju-core:New> <https://launchpad.net/bugs/1612653> | 13:23 |
babbageclunk | rogpeppe: reviewed - looks good, just one bit of confusion on my part. | 13:52 |
rogpeppe | babbageclunk: tyvm | 13:52 |
mup | Bug #1612658 opened: LXD no activate interface is bonding is used in MAAS2rc4 <juju-core:New> <https://launchpad.net/bugs/1612658> | 13:53 |
rogpeppe | babbageclunk: OpenControllerAPI landed in a PR just recently | 13:53 |
babbageclunk | rogpeppe: Ah, right - thought it could be something like that. | 13:54 |
natefinch | rick_h_: I'm going to miss standup. My wife is sick in bed, so I'm with the kids. Might get some work done this afternoon, but not sure. I'll send a summary email of where I am. | 13:58 |
natefinch | and if anyone wants to do a review: https://github.com/juju/jsonschema/pull/1 | 13:59 |
rick_h_ | natefinch: k | 13:59 |
rick_h_ | natefinch: please make sure the kanban board is up to date with links/etc | 13:59 |
rick_h_ | natefinch: of particular interest is where the windows bu g is | 14:00 |
rick_h_ | katco: dimitern standup time | 14:00 |
dimitern | owm | 14:00 |
natefinch | rick_h_: I didn't do much with the windows bug, unfortunately... maybe that was a prioritization failure on my part, if so, I am sorry. I was finally getting somewhere with the jsonschema stuff, so I was trying to push through with it. | 14:01 |
rick_h_ | natefinch: I've promised that bug by next beta. We need to get it in. it's carried over and block OIL for multiple weeks atm | 14:02 |
rick_h_ | natefinch: so that bug is priority #1 please | 14:02 |
natefinch | rick_h_: right. My apologies. I'll do my best to get it done today. | 14:02 |
dimitern | babbageclunk: sorry it took me so long, but you have an initial review | 14:03 |
dimitern | babbageclunk: I'm happy to chat / clarify anything after standup | 14:03 |
dimitern | rogpeppe: reviewed yours as well, finally | 14:18 |
rogpeppe | dimitern: thanks! | 14:18 |
=== natefinch is now known as natefinch-afk | ||
macgreagoir | katco: If you have five minutes now, stand-up HO? | 14:28 |
katco | macgreagoir: still there :) | 14:28 |
macgreagoir | Cool, cheers :-) | 14:28 |
katco | macgreagoir: well for 1, it looks like there's more recent precedent for utilizing testing.RunCommand without the goroutine | 14:44 |
katco | macgreagoir: so i would say at the very least, the way you started to do things is more correct | 14:44 |
katco | macgreagoir: e.g. take a look at cmd/juju/controller/listmodels_test.go | 14:45 |
katco | axw: has some very nice tests | 14:45 |
katco | macgreagoir: and it is done by mocking the api client, which is what i remembered doing, so i would definitely hold this up as the way to properly write tests against commands | 14:47 |
katco | macgreagoir: does that sound ok? | 14:47 |
babbageclunk | dimitern: cool, thanks | 14:53 |
babbageclunk | dimitern: The connected model checking was something Will asked for. Is he around today? Can't see any holiday on the calendar. | 14:59 |
macgreagoir | katco: Cheers | 15:00 |
katco | macgreagoir: hope that helps :) | 15:01 |
macgreagoir | (my irssi bell seems quite, sorry) | 15:01 |
katco | macgreagoir: lol no worries | 15:01 |
macgreagoir | *quiet | 15:01 |
macgreagoir | katco: That might be where unregister tests ideas were scraped from :-) | 15:04 |
katco | macgreagoir: :) the cargo culting is real. just gotta make sure you're copying the right stuff! ;p | 15:04 |
rick_h_ | babbageclunk: sorry, not around today | 15:14 |
babbageclunk | rick_h_: Stink - thanks! | 15:14 |
dimitern | babbageclunk: he may have forgotten about GetAuthTag | 15:27 |
dimitern | babbageclunk: sorry, I guess you got conflicting suggestions :/ | 15:28 |
dimitern | babbageclunk: let's have a chat with Will next week I guess.. | 15:28 |
babbageclunk | dimitern: I don't think GetAuthTag does what he wanted, but I can't really explain why he wanted the model check - I do feel like it's a bit redundant given the check in the ctor. | 15:30 |
dimitern | babbageclunk: ok | 15:30 |
dimitern | babbageclunk: I'll have a look at his earlier comments | 15:30 |
dimitern | babbageclunk: and possibly update mine, but a bit later (need to go out ~1h) | 15:31 |
ejat | anyone here use juju at azure? | 16:07 |
mup | Bug #1612717 opened: Pinger facade not implemented on controller websocket connection <juju-core:New> <https://launchpad.net/bugs/1612717> | 16:11 |
mup | Bug #1612717 changed: Pinger facade not implemented on controller websocket connection <juju-core:New> <https://launchpad.net/bugs/1612717> | 16:14 |
mup | Bug #1612717 opened: Pinger facade not implemented on controller websocket connection <juju-core:New> <https://launchpad.net/bugs/1612717> | 16:29 |
mup | Bug #1612722 opened: Juju cannot destroy models/machine, all testing substrates are exhausted <blocker> <ci> <destroy-controller> <kill-controller> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1612722> | 16:29 |
mup | Bug #1612687 opened: Juju not showing real states of deployed nodes via MAAS. <juju-core:New> <https://launchpad.net/bugs/1612687> | 16:44 |
rick_h_ | katco: can you please review https://github.com/juju/juju/pull/5987 | 16:58 |
rogpeppe | here's some apiserver cleanup; reviews appreciated: https://github.com/juju/juju/pull/5988/files | 17:10 |
katco | rick_h_: sorry, was eating lunch. tal | 17:25 |
rick_h_ | katco: all good, decided it was a clean revert so let it rip | 17:27 |
katco | rick_h_: ok. redir's +1 is probably sufficient as well. verifying a revert requires no knowledge of juju :) | 17:27 |
rick_h_ | katco: :) | 17:27 |
perrito666 | man, we really need to stop writing doc lines that are tautological | 17:29 |
rick_h_ | katco: can you peek at https://github.com/juju/juju/pull/5988/files then which is more interesting? | 17:33 |
katco | rick_h_: ok | 17:35 |
rick_h_ | katco: ty | 17:35 |
mup | Bug #1612744 opened: MachinerSuite.TestMachinerMachineAssignedUnits agent should be terminated <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1612744> | 17:38 |
mup | Bug #1612745 opened: rackerSuite.TestGainLeadership number of ClaimLeadership is wrong <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1612745> | 17:38 |
mup | Bug #1612747 opened: DebugHooksServerSuite.TestRunHook signal: killed <ci> <intermittent-failure> <regression> <unit-tests> <juju-core:Triaged> <https://launchpad.net/bugs/1612747> | 17:38 |
* rick_h_ gets some lunch with that done | 17:46 | |
kwmonroe | ejat: i use juju/azure | 18:09 |
ejat | kwmonroe: okie .. its working now .. thanks | 18:10 |
redir | bbiab | 19:11 |
* rick_h_ runs to get my truck and the boy from summer camp. have a good weekend folks | 19:19 | |
mup | Bug #1612775 opened: resource get fails, resource already staged <juju-core:New> <https://launchpad.net/bugs/1612775> | 19:30 |
perrito666 | it would be extremely nice of us to name the same thing in the same way across facades | 20:02 |
redir | perrito666: novel idea | 20:02 |
perrito666 | authorizer and state are called something different across all facades | 20:03 |
perrito666 | and just found one without authorizer | 20:04 |
natefinch | sinzui: are you still having problems with that windows deploy CI test? I seem to be able to deploy a windows charm just fine on azure | 20:13 |
sinzui | natefinch: I think not. I am still wating for one to complete to say all is well | 20:13 |
sinzui | natefinch: once juju broke the reate limit. azure locked our for many hours | 20:13 |
natefinch | sinzui: great :) | 20:13 |
natefinch | oops | 20:14 |
sinzui | natefinch: I see some azure successes. most failed though.I suspect the failure were at the tail end of the lockout. I will retest. | 20:19 |
katco | sinzui: hey does qa have any plans to release the qa tools as a snap? | 20:27 |
sinzui | katco: we expect to do dailies | 20:27 |
katco | sinzui: daily releases of the qa tools? | 20:27 |
sinzui | katco: oh, no. no plans to snape jujuc-ci-tools or juju-release-tools | 20:28 |
katco | sinzui: sorry, jujuc-ci-tools | 20:28 |
katco | sinzui: having just gone through the setup process, it would be awesome to just download a snap | 20:28 |
sinzui | maybe balloons will want try it. Since snap doesn't work with windows, centos, or osx, we are dedicated to working with a common solution. | 20:29 |
katco | sinzui: ah good point | 20:30 |
mup | Bug #1612793 opened: bootstrap azure/southcentralus is failing in 2.0-betaX <juju-core:New> <https://launchpad.net/bugs/1612793> | 20:30 |
perrito666 | ... obtained int = 2 | 20:39 |
perrito666 | ... expected int = 2 | 20:39 |
perrito666 | evidently | 20:39 |
katco | yay my recator compiles for the 1st time | 20:44 |
katco | refactor | 20:44 |
mup | Bug #1612335 changed: Azure rate limit leads to catastrophic failure for subscription <azure-provider> <bootstrap> <ci> <destroy-controller> <kill-controller> <regression> <juju-core:Fix Released by axwalk> <https://launchpad.net/bugs/1612335> | 21:39 |
mup | Bug #1612722 changed: Juju cannot destroy models/machine, all testing substrates are exhausted <blocker> <ci> <destroy-controller> <kill-controller> <regression> <juju-core:Fix Released by rharding> <https://launchpad.net/bugs/1612722> | 21:39 |
mup | Bug #1612836 opened: Cannot bring up hosted model machines in azure <azure-provider> <ci> <deploy> <regression> <juju-core:Triaged> <https://launchpad.net/bugs/1612836> | 21:48 |
katco | rick_h_: ping, don't suppose you're on | 22:14 |
perrito666 | mmm, ppas dont work nicely with my deb proxy | 22:34 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!