| === rangerpbzzzz is now known as rangerpb | ||
| smoser | harlowja, 'rejected' seems so mean. | 15:22 |
|---|---|---|
| smoser | wrt https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/302609 | 15:22 |
| brian_price_ | Hello, random question. Is cloud-init 2.0 currently on hold or is there work or plans being discussed somewhere? | 15:51 |
| smoser | on holser_ | 16:29 |
| smoser | hold even :) | 16:29 |
| smoser | sorry holser_ | 16:29 |
| smoser | rangerpb, https://code.launchpad.net/~smoser/cloud-init/+git/cloud-init/+merge/303303 | 16:29 |
| brian_price_ | ohh heh, okay thanks. | 16:30 |
| wznoinsk | hi all | 16:38 |
| rangerpb | smoser, lgtm | 17:43 |
| rangerpb | larsks, u might want to peek at it too | 17:44 |
| larsks | smoser: seems like a reasonable idea. I left a comment re: simplifying is_azure, but functionally everything seems fine. | 17:54 |
| smoser | larsks, i know that you'll tell me that i'm over-concerned, but the is_azure that i have there is probably 100x faster than grep | 17:57 |
| larsks | I think you are placing too much value on execution efficiency and not enough on code legibility, but the end result is that both options deliver the same answer and the difference in execution time is probably not noticable. So go with what you have :) | 17:58 |
| smoser | alri largely agree, but i dont think the code is non-radable and avoiding another program execution and one more fork in boot i think is useful. | 18:05 |
| smoser | http://paste.ubuntu.com/23068101/ | 18:05 |
| smoser | ^ that shows the relative performance | 18:05 |
| smoser | it is minimal i agree. and its also liekly that 'grep' is already in the vfs layer during boot because some other script used it (probably for something very similar) | 18:07 |
| smoser | harlowja, https://code.launchpad.net/~ajorgens/cloud-init/python26/+merge/296575 | 18:11 |
| smoser | that doesnt work. simply doesnt work | 18:11 |
| smoser | right ? | 18:11 |
| smoser | os.uname is always a method, not a property | 18:11 |
| harlowja | oh man, i got rejected | 18:20 |
| harlowja | lol | 18:20 |
| harlowja | smoser will u still be my friend | 18:20 |
| harlowja | lol | 18:20 |
| smoser | harlowja, ^ | 18:23 |
| smoser | how did / does that work ? | 18:23 |
| harlowja | not sure u are my friend anymore | 18:23 |
| harlowja | i'm a reject | 18:23 |
| harlowja | lol | 18:23 |
| harlowja | smoser maybe it never worked? | 18:24 |
| harlowja | though why it neverr blew up | 18:24 |
| harlowja | thats another question... | 18:24 |
| prometheanfire | smoser: 0.7.7 has py3 support (from reading the notes) | 20:37 |
| prometheanfire | if so, which py3? | 20:37 |
| smoser | prometheanfire, probably 3.4+ | 20:38 |
| prometheanfire | k, that's what I was thinking | 20:38 |
| prometheanfire | can we get https://github.com/gentoo/gentoo/blob/master/app-emulation/cloud-init/files/cloud-init-0.7.6_p1212-gentoo.patch in :P | 21:00 |
| prometheanfire | the init files are already there | 21:00 |
| harlowja | propose a branch ? | 21:04 |
| prometheanfire | ya | 21:05 |
| prometheanfire | does cloud-init follow the openstack review process? | 21:13 |
| smoser | prometheanfire, not openstack. launchpad . see HACKING.rst | 21:18 |
| prometheanfire | clone so slow | 21:22 |
| smoser | prometheanfire, http://paste.ubuntu.com/23068496/ | 21:27 |
| smoser | 7 seconds here. | 21:27 |
| prometheanfire | ya, second try was fine | 21:29 |
| prometheanfire | also, lolmake :P | 21:29 |
| prometheanfire | installing requirements and tests requirements in a virtualenv doesn't install the nosetests3 | 21:32 |
| prometheanfire | binary which it expects | 21:32 |
| smoser | ? | 21:33 |
| smoser | run tox | 21:33 |
| prometheanfire | that's not what hacking says to do | 21:33 |
| smoser | does it really. | 21:33 |
| smoser | man | 21:33 |
| smoser | i should read that | 21:33 |
| smoser | run tox | 21:33 |
| prometheanfire | :P | 21:33 |
| prometheanfire | make test pep8 | 21:34 |
| smoser | yeah. | 21:34 |
| smoser | tox does the right thing. | 21:34 |
| smoser | and will then run python 2 and python3 too | 21:34 |
| prometheanfire | ya | 21:34 |
| prometheanfire | I forgot about our /sbin/ip vs /bin/ip thing... | 21:34 |
| smoser | oh? do we have that hard coded somewhere? | 21:34 |
| smoser | that just needs fixing | 21:35 |
| prometheanfire | ya | 21:35 |
| prometheanfire | cloud-init-0.7.6/cloudinit/sources/DataSourceOpenNebula.py | 21:35 |
| prometheanfire | well, in the patch | 21:35 |
| smoser | yeah. i got to run, but we should not run by full path. | 21:35 |
| smoser | so patches welcome on that. | 21:36 |
| smoser | i have to run | 21:36 |
| prometheanfire | want me to include that as an addtional commit on the same topic? | 21:36 |
| prometheanfire | it'd be easier for me at least | 21:36 |
| smoser | sure. | 21:36 |
| prometheanfire | thankss | 21:37 |
| prometheanfire | done, https://code.launchpad.net/~prometheanfire/cloud-init/+git/cloud-init/+merge/303339 | 21:43 |
| === rangerpb is now known as rangerpbzzzz | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!