| === chihchun_afk is now known as chihchun | ||
| === hikiko is now known as hikiko|ln | ||
| alan_g | greyback: have you looked at this? (I'm tempted to update, but won't if a review is already in progress) https://code.launchpad.net/~alan-griffiths/miral/spike-miral-qt-integration/+merge/303165 | 10:51 |
|---|---|---|
| greyback | alan_g: I had a brief look this morning over coffee, was going to review proper after lunch. | 10:52 |
| greyback | welcome to update it | 10:52 |
| greyback | I mostly was thinking of plan for action to test it out | 10:52 |
| alan_g | greyback: updated, now you plan can test the combined changes | 10:55 |
| greyback | ack | 10:56 |
| === chihchun is now known as chihchun_afk | ||
| alan_g | greyback: did you ever look into the crash I see when apps close? | 11:42 |
| greyback | alan_g: not yet, but the current work I'm doing touches that code so I hope to fix it that way | 11:43 |
| alan_g | OK, I was thinking of poking around, but it clearly isn't the right time just now. | 11:44 |
| === hikiko|ln is now known as hikiko | ||
| greyback | alan_g: could you do me a favour and check if this compiles ok for you (with MIRAL_ENABLE_TESTS=1): lp:~gerboland/miral/use-cmake-extras | 13:36 |
| alan_g | GRE | 13:37 |
| alan_g | greyback: sure. 2 min | 13:37 |
| greyback | ta | 13:38 |
| greyback | I'm getting http://pastebin.ubuntu.com/23067425/ which I'm presuming is due to my custom mir build (with test LTO disabled) | 13:39 |
| alan_g | greyback: that's bug 1603080 | 13:40 |
| ubot5 | bug 1603080 in mir (Ubuntu) "mirtest-dev provides an incorrect .pc file" [Undecided,New] https://launchpad.net/bugs/1603080 | 13:40 |
| greyback | aha | 13:40 |
| alan_g | It's your own fault for not reporting mirtest-dev bugs when you got it. | 13:41 |
| greyback | I only got that now! | 13:41 |
| greyback | instead I was getting fail on gtest.a not existing | 13:41 |
| alan_g | Hm cmake not happy: "cannot create target "gtest" because another target of the same name exists" | 13:46 |
| * alan_g suspects a conflict with miral/test | 13:46 | |
| alan_g | greyback: it works on its own, but conflicts with miral/test's gtest stuff. | 13:49 |
| greyback | alan_g: you're on yakkety, right? | 13:50 |
| alan_g | yes | 13:50 |
| alan_g | At least for that trial | 13:51 |
| greyback | it works well for me on xenial+overlay, no conflict. I'll try yakkety | 13:51 |
| alan_g | Oops I mean you can't have both -DMIRAL_ENABLE_TESTS=on and -DMIRAL_ENABLE_QT=ON | 13:53 |
| greyback | alan_g: ah, I see what you mean | 13:54 |
| greyback | yeah, that's step 2 | 13:54 |
| greyback | for me, I just hit the fact that Ninja doesn't like the GMock/test script shipped in miral | 13:54 |
| alan_g | Anyway, you just need to hack your mirtest.pc file to build for yourself | 13:55 |
| * alan_g switches back to xenial (without overlay) | 13:57 | |
| alan_g | greyback: are you planning to fix the conflict with miral-qt? | 14:00 |
| greyback | alan_g: I'm working on it now | 14:01 |
| === dandrader is now known as dandrader|afk | ||
| === dandrader|afk is now known as dandrader | ||
| === JanC is now known as Guest7844 | ||
| === JanC_ is now known as JanC | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!