=== chihchun_afk is now known as chihchun === hikiko is now known as hikiko|ln [10:51] greyback: have you looked at this? (I'm tempted to update, but won't if a review is already in progress) https://code.launchpad.net/~alan-griffiths/miral/spike-miral-qt-integration/+merge/303165 [10:52] alan_g: I had a brief look this morning over coffee, was going to review proper after lunch. [10:52] welcome to update it [10:52] I mostly was thinking of plan for action to test it out [10:55] greyback: updated, now you plan can test the combined changes [10:56] ack === chihchun is now known as chihchun_afk [11:42] greyback: did you ever look into the crash I see when apps close? [11:43] alan_g: not yet, but the current work I'm doing touches that code so I hope to fix it that way [11:44] OK, I was thinking of poking around, but it clearly isn't the right time just now. === hikiko|ln is now known as hikiko [13:36] alan_g: could you do me a favour and check if this compiles ok for you (with MIRAL_ENABLE_TESTS=1): lp:~gerboland/miral/use-cmake-extras [13:37] GRE [13:37] greyback: sure. 2 min [13:38] ta [13:39] I'm getting http://pastebin.ubuntu.com/23067425/ which I'm presuming is due to my custom mir build (with test LTO disabled) [13:40] greyback: that's bug 1603080 [13:40] bug 1603080 in mir (Ubuntu) "mirtest-dev provides an incorrect .pc file" [Undecided,New] https://launchpad.net/bugs/1603080 [13:40] aha [13:41] It's your own fault for not reporting mirtest-dev bugs when you got it. [13:41] I only got that now! [13:41] instead I was getting fail on gtest.a not existing [13:46] Hm cmake not happy: "cannot create target "gtest" because another target of the same name exists" [13:46] * alan_g suspects a conflict with miral/test [13:49] greyback: it works on its own, but conflicts with miral/test's gtest stuff. [13:50] alan_g: you're on yakkety, right? [13:50] yes [13:51] At least for that trial [13:51] it works well for me on xenial+overlay, no conflict. I'll try yakkety [13:53] Oops I mean you can't have both -DMIRAL_ENABLE_TESTS=on and -DMIRAL_ENABLE_QT=ON [13:54] alan_g: ah, I see what you mean [13:54] yeah, that's step 2 [13:54] for me, I just hit the fact that Ninja doesn't like the GMock/test script shipped in miral [13:55] Anyway, you just need to hack your mirtest.pc file to build for yourself [13:57] * alan_g switches back to xenial (without overlay) [14:00] greyback: are you planning to fix the conflict with miral-qt? [14:01] alan_g: I'm working on it now === dandrader is now known as dandrader|afk === dandrader|afk is now known as dandrader === JanC is now known as Guest7844 === JanC_ is now known as JanC