| === rtheis__ is now known as rtheis | ||
| === rangerpbzzzz is now known as rangerpb | ||
| smoser | harmw, https://code.launchpad.net/~harmw/cloud-init/growfs-gpart-fixes_for_fbsd/+merge/246075 | 14:02 |
|---|---|---|
| smoser | still needed ? | 14:02 |
| smoser | rangerpb, hey. | 16:18 |
| smoser | one more question... | 16:18 |
| rangerpb | yessir smoser | 16:18 |
| smoser | config/cloud.cf | 16:19 |
| smoser | you set dhclient_lease to null i guess | 16:19 |
| smoser | i dont think that should be necessary | 16:19 |
| smoser | i think i need to revert the other changes to that file too | 16:20 |
| smoser | Odd_Bloke, around ? | 16:32 |
| Odd_Bloke | smoser: In half an hour. | 16:33 |
| smoser | Odd_Bloke, https://git.launchpad.net/cloud-init/commit/?id=648dbbf6b090c81e989f1ab70bf99f4de16a6a70 | 16:33 |
| smoser | rangerpb set the 'agent_command' to __builtin__ | 16:35 |
| smoser | which, you had (i believe) added that support, but as far as i can tell its not used in ubuntu | 16:35 |
| rangerpb | smoser, the __builtin__ was the key/value that lets it go down the route of discovery on azure | 16:48 |
| rangerpb | without it, none of the code is used | 16:48 |
| smoser | yeah. | 16:48 |
| rangerpb | dhclient_lease should probably be set to something distro specific | 16:48 |
| rangerpb | it allows fallback to a lease file which at present was only defined for ubuntu | 16:49 |
| Odd_Bloke | The __builtin__ code there was written when we were building all-snaps images for Ubuntu Core Series 15, where walinuxagent wouldn't run. | 16:49 |
| Odd_Bloke | We aren't presently using it for anything, as we don't publish Series 15 images any more. | 16:50 |
| rangerpb | fine but it is a conditional in the current code | 16:50 |
| rangerpb | totally open to change | 16:50 |
| rangerpb | i never much liked the conditional which was there, it seems in cloud-init we chase down every possible avenue | 16:51 |
| rangerpb | smoser, u follow? | 16:51 |
| smoser | i have no idea what a series 15 image is | 16:52 |
| rharper | ubuntu-core | 16:53 |
| rharper | based on 15.04/10 IIRC | 16:53 |
| smoser | oh. ok. | 16:53 |
| smoser | rangerpb, does fedora/centos run the agent ? | 16:53 |
| smoser | Odd_Bloke, what does the agent do for us ? why not use the new path. | 16:54 |
| rangerpb | the agent still has some upside over the current | 16:54 |
| rangerpb | not really in provisioning but more in configuration, etc | 16:54 |
| rangerpb | for example, you can pass a script "through" the agent and it will end up getting executed on the vm | 16:54 |
| smoser | well, cloud-init does that too :) | 16:55 |
| Odd_Bloke | smoser: I think just because we've always been relying on walinuxagent. | 16:55 |
| rangerpb | smoser, i think the agent can do it anytime, not just on boot | 16:55 |
| Odd_Bloke | We will still need to run walinuxagent in Ubuntu images (for other Azure-specific things to work), so we'd have to check that the two don't conflict. | 16:55 |
| Odd_Bloke | But walinuxagent is reasonably configurable, so if it isn't already possible to stop it doing things that we want to do, we could probably request it. | 16:56 |
| smoser | Odd_Bloke, but does the agent start itself ? | 16:56 |
| smoser | cloud-init starts it, but is that necessary ? | 16:57 |
| rangerpb | the answer is it depends on what you are trying to do imho | 16:57 |
| rangerpb | https://git.launchpad.net/cloud-init/tree/cloudinit/sources/DataSourceAzure.py#n231 <-- this was the conditional i was referring to | 16:57 |
| rangerpb | basically two paths to do the same thing, agree Odd_Bloke ? | 16:58 |
| Odd_Bloke | Yeah, but __builtin__ doesn't rely on walinuxagent. | 16:58 |
| rangerpb | yeah | 16:58 |
| rangerpb | so it might be better? that the conditional check for the existance of the agent? | 16:59 |
| Odd_Bloke | But it was only ever used in an environment where walinuxagent _would not_ run, so we don't actually know how it works in an environment where we do __builtin__ _and_ walinuxagent runs. | 16:59 |
| rangerpb | well i do | 16:59 |
| rangerpb | i didnt see any harm in running both | 16:59 |
| Odd_Bloke | Yeah, I don't see any harm in it. | 16:59 |
| Odd_Bloke | Unless it breaks. ;) | 17:00 |
| Odd_Bloke | But, fundamentally, the two should be fine side-by-side. | 17:00 |
| Odd_Bloke | It's just whether or not there's something unconsidered that needs to be cleaned up. | 17:00 |
| Odd_Bloke | It sounds like there isn't. | 17:00 |
| Odd_Bloke | So that's good. | 17:00 |
| rangerpb | the problem is that the one path *requires* an agent, which might not be there | 17:00 |
| rangerpb | which is why i said, if the agent is present, prob prefer it; if not, go the "newer" route | 17:01 |
| rangerpb | then there is no collision on provision | 17:01 |
| rangerpb | smoser, Odd_Bloke however, if you prefer, I can run this by MS | 17:01 |
| smoser | rangerpb, sure. i'll have a few changes to my dhclient hook cleanup that i'll point you at. | 17:02 |
| Odd_Bloke | I thought you just said you'd identified that you had run the two and there wasn't a collision? Did I misunderstand? | 17:02 |
| smoser | we can have the default behavior to do as you suggest | 17:02 |
| Odd_Bloke | (Or just being cautious?) | 17:02 |
| rangerpb | being cautious | 17:02 |
| Odd_Bloke | OK, cool. | 17:02 |
| smoser | but still want it to be configurable | 17:02 |
| rangerpb | sort of like, where does provisioning start/stop and other stuff begin | 17:02 |
| smoser | so that you could set the agent command | 17:02 |
| smoser | Odd_Bloke, in our images, if cluod-init did not start the agent... | 17:03 |
| smoser | would it not run ? | 17:03 |
| rangerpb | i would like to see the configuration have something like azure_provision: cloud-init|agent | 17:03 |
| rangerpb | or one is override, perhaps better | 17:03 |
| rangerpb | i.e. default is still agent and override with cloud-init | 17:04 |
| rangerpb | i gotta grab some vittles, will read back when i return | 17:04 |
| Odd_Bloke | So I think the only restriction we would need is that it be easy for the default to be cloud-init. | 17:04 |
| Odd_Bloke | So that we can backport changes more easily, without having to carry a large patch to do that. | 17:05 |
| Odd_Bloke | But even that isn't a hard blocker. | 17:05 |
| Odd_Bloke | smoser: http://paste.ubuntu.com/23070971/ is the walinuxagent unit file, which I believe means it would come up anyway. | 17:07 |
| Odd_Bloke | We just start it earlier. | 17:07 |
| smoser | ok | 17:07 |
| smoser | http://paste.ubuntu.com/23070985/ | 17:15 |
| smoser | rangerpb, Odd_Bloke ^ is what i'm looking at | 17:27 |
| smoser | rangerpb, that'd mean that right now fedora would have to carry the agent_command setting | 17:28 |
| smoser | but i'm open to "if agent is installed" logic | 17:28 |
| rangerpb | ok | 18:15 |
| === rangerpb is now known as rangerpbzzzz | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!