[06:41] <duflu> RAOF: Would it make sense for us to clarify to API users that subpixel order is only valid for the native resolution? (ie. all modes with resolution == the preferred mode)
[06:41] <duflu> I have seen enough buggy code that keeps subpixel rendering even when not at the native pixel size
[06:42] <duflu> Although that's a function you could write in the client/toolkit
[06:42] <RAOF> Yeah.
[06:43] <RAOF> I'm ambivalent about adding that to the comments.
[06:43] <duflu> Comments would suffice. Don't hold it wrong
[06:44] <duflu> ... unless we encountered the situation where a large number of backends attached subpixel information to the mode instead of the output
[06:44] <RAOF> Which would seem to be bonkers, but whatever.
[06:44] <duflu> RAOF: True. It's an attribute of the output. But only valid in a small number of modes
[06:45] <duflu> which is 100% of modes while we don't let Unity8 users change it :)
[11:20] <alan_g> greyback: got time to review two easy ones? https://code.launchpad.net/miral/+activereviews lp:~alan-griffiths/miral/fix*
[11:20] <alan_g> Would be good to land them
[11:20] <greyback> alan_g: yep. And thanks for spotting my error with qtmir/use-mir-test-dev
[11:20] <alan_g> yw
[14:00] <alan_g> greyback_: ready for another look: https://code.launchpad.net/~alan-griffiths/miral/fix-for-clang/+merge/303535
[14:01] <greyback_> alan_g: ack
[15:20] <alan_g> greyback__: is "Ok for me." a vote for abort()?
[15:23] <greyback__> alan_g: nah, I'm happy with the current code
[15:23] <greyback__> ok to "land this and discuss later"
[15:24]  * greyback__ actually approves the branch
[15:24]  * alan_g makes it happen