| Odd_Bloke | smoser: I haven't looked at it, but my recollection of test_exception_fetching_fabric_data_doesnt_propagate is that data sources shouldn't raise exceptions. | 08:15 |
|---|---|---|
| Odd_Bloke | Reading cloudinit.sources.find_source, that isn't true. | 08:22 |
| Odd_Bloke | But I believe that was the motivation behind it. | 08:22 |
| smoser | prometheanfire, there is one question for you at https://code.launchpad.net/~prometheanfire/cloud-init/+git/cloud-init/+merge/303339 | 16:13 |
| smoser | i'd pull that, but would ike to know why we need that change | 16:15 |
| smoser | harlowja, around ? | 16:15 |
| smoser | https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301731 | 16:15 |
| smoser | try: | 16:15 |
| smoser | from unittest import mock | 16:15 |
| smoser | except ImportError: | 16:15 |
| smoser | import mock | 16:15 |
| smoser | why do we need that ? | 16:15 |
| smoser | (we have it lots of palc). | 16:15 |
| nacc | smoser: python3 and python2 compat? | 16:16 |
| nacc | (possibly) | 16:16 |
| smoser | nacc, well, yes, but we do not do it in other places | 16:17 |
| smoser | and it works happily | 16:17 |
| smoser | or i'm oblivious to the failure :) | 16:17 |
| smoser | mgagne_, i'm going to pull bond_name | 16:18 |
| mgagne_ | smoser: cool, it fixes all known issues described in the bug report | 16:18 |
| nacc | smoser: heh could be -- it looks like maybe unittest.mock has been backported, unclear | 16:18 |
| mgagne_ | smoser: I couldn't find the root cause of the race condition we talked about yesterday, rebooted 20x times and no luck | 16:18 |
| smoser | rharper, around ? | 16:53 |
| smoser | given http://paste.ubuntu.com/23082413/ | 16:53 |
| smoser | should enp0s1 have 'auto' on line 253 ? | 16:54 |
| smoser | i think it probably should | 16:55 |
| rharper | smoser: here | 17:23 |
| rharper | smoser: let me compare to the curtin vlan tests | 17:24 |
| rharper | I don't think so as the vlan config will raise the underlying iface | 17:25 |
| rharper | smoser: so, if you put auto, and manual, networking-online check fails | 17:27 |
| rharper | ifquery --list --allow-auto will show the iface | 17:27 |
| rharper | but since it has a manual config, there's nothing to ifup | 17:27 |
| rharper | this will break the wait on all ifaces to be online | 17:27 |
| smoser | rharper, ok. i actually didnt' see 'inet manual' | 17:40 |
| smoser | so you think that is ok ? | 17:40 |
| rharper | it's required | 17:40 |
| rharper | vlan hooks do an up on the raw interface | 17:41 |
| rharper | before applying the vlan config | 17:41 |
| rharper | we don't want manual interfaces in the auto list or networking service fails to come up | 17:41 |
| rharper | (ie, nothing is going to "up" a manual interface) | 17:41 |
| rharper | hence the manual part | 17:41 |
| rharper | explicitly, we do not auto $IFACE on underlying devices unless they also have a network config (subnet) | 17:42 |
| rharper | the hooks for bond, vlan and bridge handle bringing up the lower interface, if needed | 17:42 |
| harlowja | i don't think unittest.mock got backported | 17:55 |
| smoser | harlowja, so how does tests/unittests/test_datasource/test_configdrive.py work ? | 17:57 |
| smoser | it just does | 17:57 |
| smoser | from ..helpers import TestCase, ExitStack, mock | 17:57 |
| smoser | and 'mock' from helpers is just 'import mock' | 17:58 |
| harlowja | hmmm, whats in our requirements for that | 17:59 |
| harlowja | https://git.launchpad.net/cloud-init/tree/test-requirements.txt#n3 | 18:00 |
| harlowja | i think we can just do import mock | 18:00 |
| harlowja | it should be fine | 18:00 |
| harlowja | thats more or less what the openstack folks did | 18:00 |
| harlowja | because mock is maintained such that its equivalent to the py3.x one | 18:01 |
| harlowja | equivalent or better | 18:01 |
| harlowja | but overall yes smoser we should do some test cleanup | 18:01 |
| harlowja | it needs it :-P | 18:01 |
| harlowja | *its needed | 18:01 |
| smoser | harlowja, ok. | 18:05 |
| smoser | so can you | 18:05 |
| smoser | a.) just rebase that thing oncurrent tip | 18:05 |
| smoser | and then push | 18:05 |
| smoser | (no more changes necessary) | 18:05 |
| smoser | then i can merge and push and the MP will know it got pulled | 18:05 |
| smoser | b.) go ahead and fix those import mock things everywhere. | 18:05 |
| harlowja | hmmmm, k | 18:07 |
| harlowja | why rebase needed :-P | 18:07 |
| harlowja | just wondering | 18:07 |
| harlowja | usually if there aren't conflicts then rebase shouldn't be needed? | 18:08 |
| smoser | harlowja, you either have to rebase and push or i have to merge and accept the 'merge commit' | 18:15 |
| harlowja | k | 18:15 |
| harlowja | hmmm, intersting | 18:16 |
| smoser | its same as anywhere. | 18:16 |
| smoser | if you're full fast foward, then i can just pull and still use your commit hashes | 18:16 |
| harlowja | kk | 18:16 |
| smoser | and thus the merge proposal can just magically "know" that your merge got pulled | 18:16 |
| harlowja | gotcha | 18:16 |
| harlowja | ok, good to know | 18:16 |
| smoser | if do 'merge' and its not a FF then i get a "merge commit" | 18:17 |
| smoser | Merge remote-tracking branch 'harlowja/space' | 18:17 |
| smoser | and i hate looking at those things :) | 18:17 |
| harlowja | :-P | 18:19 |
| harlowja | fair nuff | 18:19 |
| harlowja | anything to make the scott happy | 18:19 |
| harlowja | lol | 18:19 |
| harlowja | i'll get around to that soonish | 18:23 |
| harlowja | btw | 18:23 |
| smoser | harlowja, i'll take care of it. | 18:24 |
| smoser | you do 'b' instead. | 18:25 |
| smoser | thanks | 18:25 |
| harlowja | lol | 18:25 |
| harlowja | k | 18:25 |
| harlowja | but i wanted to do a | 18:25 |
| harlowja | lol | 18:25 |
| prometheanfire | :D | 18:29 |
| dccunha | Hi | 19:55 |
| dccunha | I'm having some trouble to use vendor-data for setting up instances. There is any config at cloud-init that must be done for this to work? | 19:55 |
| dccunha | I getting vendor-data from an OpenStack's datasource and it's been saved like this: | 19:55 |
| dccunha | cat /var/lib/cloud/instances/d1a0a861-e386-444c-aea8-196e2540cfc4/vendor-data.txt | 19:56 |
| dccunha | #cloud-config | 19:56 |
| dccunha | package_update: true | 19:56 |
| dccunha | packages: | 19:56 |
| dccunha | - htop | 19:56 |
| cn28h | how can I enable logging for cloud-init? smoser mentioned being interested to see the contents of /var/log/cloud-init.log if I am able to reproduce an error (and we do seem to be reproducing it) but the log file is always empty. | 20:41 |
| cn28h | haven't been able to track down any docs saying how to set log levels or anything | 20:41 |
| smoser | cn28h, change logging to only go to a file. | 20:41 |
| smoser | https://code.launchpad.net/~harlowja/cloud-init/+git/cloud-init/+merge/301729 | 20:42 |
| cn28h | aha | 20:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!