=== JanC is now known as Guest36120 | ||
=== JanC_ is now known as JanC | ||
=== marcusto_ is now known as marcustomlinson | ||
mterry | tsdgeos: if you're still chewing through my MPs, can you prioritize default-wallpaper please? It's part of an MP trifecta, one of which happens to fix a recent crasher in USS. One possible strategy for fixing that crash is just to hurry up and land all the default-wallpaper branches | 13:49 |
---|---|---|
tsdgeos | ok | 13:50 |
mterry | tsdgeos: we don't know why it fixes the recent crash :P investigation continues, but landing it may be a fix | 13:50 |
tsdgeos | mterry: hehe | 14:01 |
tsdgeos | mterry: the wallpapers branch looks relatively ok from a code pov | 14:18 |
tsdgeos | i'll awit for CI to give me a .deb to try though | 14:18 |
mterry | tsdgeos: silo 23 has the trifecta for you | 14:18 |
tsdgeos | ah ok | 14:18 |
josharenson | tsdgeos: just fyi, I'm making the extraPanel a popover. Should solve the issue with the test (I hope) and should make it look visually the same as before (it was slightly off previously) | 14:20 |
josharenson | tsdgeos: so if thats a terrible idea, let me know | 14:21 |
tsdgeos | josharenson: is that how design wants it? popover also has a stupid max height limit | 14:21 |
josharenson | tsdgeos: ugh, why? | 14:22 |
josharenson | tsdgeos: I can ask design, but other than the height limitation, it literally looks and behaves the same (so far) | 14:22 |
tsdgeos | josharenson: why what? | 14:22 |
josharenson | tsdgeos: why does it have a max height :-p ? | 14:23 |
tsdgeos | i don't know | 14:23 |
tsdgeos | see the filters code | 14:23 |
josharenson | tsdgeos: ok. I mean, I can also put it back like before, but that destroys the pretty encapsulation and essentially defeats the purpose of this all | 14:24 |
josharenson | tsdgeos: ah the filters popover seems to have a work around then? | 14:25 |
tsdgeos | josharenson: yes | 14:25 |
josharenson | ok | 14:25 |
tsdgeos | josharenson: maybe it's not needed anymore, you could double check | 14:25 |
josharenson | ok | 14:25 |
=== marcusto_ is now known as marcustomlinson | ||
=== dandrader is now known as dandrader|afk | ||
=== dandrader|afk is now known as dandrader | ||
=== dandrader is now known as dandrader|afk | ||
=== dandrader|afk is now known as dandrader | ||
mterry | Saviq: ugh. You asked me about not unloading the greeter in the emergency dialer ... I looked into it and I came up against some Loader qml behavior I don't understand :( So not so easy for me so far | 19:30 |
mterry | I'll poke some qml wizards tomorrow | 19:30 |
Saviq | mterry, try me (no promises!) ;) | 19:30 |
mterry | Saviq: it *seems* that having anything loaded in the Loader (even just a bare Item) makes the whole Greeter black (and covering the dialer). Even if visibility and opacity is false/0. Even if the Loader is only supposed to take up half the screen. | 19:32 |
Saviq | mterry, maybe one of our darkening layers comes in? | 19:33 |
mterry | Saviq: I took out all the contents of the Greeter view so it's just a bare Item (with required property stubs and methods) | 19:34 |
mterry | Saviq: does a Loader have any black magic in it? I even made it only take up half the screen, but the bottom half of the screen continued to be black when the top had contnet | 19:35 |
Saviq | mterry, no, it doesn't have any black magic in it, it's just blank (transparent) if there's nothing in it | 19:35 |
Saviq | which is why I'm thinking there's something else on top of it | 19:35 |
Saviq | that we use(d?) for when launcher or indicators are on screen | 19:36 |
mterry | Saviq: try it yourself -- make it active: no vs active: yes but visible: false | 19:36 |
mterry | I would *think* those would be visibly identical | 19:36 |
mterry | But I get a black box in the second case | 19:36 |
Saviq | mterry, they should be, with the exception that something might be looking at either of those props | 19:42 |
mterry | Saviq: a couple Greeter properties do pull from the loaded item (fullyShown and animating), but have graceful fallbacks and don't seem to be used for anything useful | 19:43 |
Saviq | mterry, FWIW the greeter, after being destroyed, looks very much black when reloading, so it must be the black from behind it (didn't we add a "security" black layer that's always there, otherwise the session was visible through?) | 22:40 |
Saviq | right, but that's inside {Wide,Narrow}View | 22:42 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!