[15:50] <krytarik> So I just committed a fix for LP bug 1617846.
[16:47] <zequence> krytarik: Any other planned changes soonish? Or, should I go ahead and upload?
[16:48] <krytarik> zequence: Not immediately, nope - please do.
[17:02] <zequence> krytarik: Did I forget to update the changelog in the bzr branch last time, or something? In the diff I see some small changes to the debian/changelog
[17:03] <krytarik> Yeeep.
[17:04] <zequence> Right. I sometimes do that, unfortunately..
[18:40] <OvenWerks> krytarik: Wow does it actually work like that with just the icon line in the override *desktop files?
[18:42]  * OvenWerks is talking about the hexter.desktop and hdspmixer.desktop files just changes a few hours ago
[18:44] <krytarik> OvenWerks: Look at the other ones in there, for example - 'icon' is just another key.
[18:45] <OvenWerks> krytarik: I understand that much, I was wondering if the menu then takes the rest from the original desktop file
[18:45] <OvenWerks> Does the application actually start? I guess if the name shows it means everything else works.
[18:57] <OvenWerks> krytarik: It looks like the generic alsa icon is missing.
[18:58] <OvenWerks> alsa-tools is the icon name in 16.04
[19:07] <OvenWerks> alsa-tools-gui should have the alsa-tools.xpm file in it.
[19:17] <krytarik> OvenWerks: Yeeah, apparently someone confused Debian menu with .desktop files.. :P - https://anonscm.debian.org/viewvc/pkg-alsa?view=revision&revision=2877
[19:22] <OvenWerks> krytarik: Sp does that mean it is coming back?
[19:24] <krytarik> Nope, it means someone will have to file a bug report. :P
[19:25] <OvenWerks> krytarik: ok I will do that... at least in ubuntu
[19:26] <OvenWerks> should we create an icon in the meantime?
[19:28] <OvenWerks> alsa-tools.pxm is not a very nice icon in any case... It is quite low res.
[19:29] <krytarik> Either way, could ship one in -icon-theme too in the meantime indeed.
[19:46] <krytarik> OvenWerks: I don't know why SVN sucks so much, but there the full changes.. :P - http://launchpadlibrarian.net/256772632/alsa-tools_1.1.0-0ubuntu1_1.1.0-1.diff.gz
[19:47] <krytarik> I see LP bug 1619779.
[19:51] <zequence> krytarik: Think SVN sucks because of branch management and the lack of integrity check
[19:52] <zequence> Or, the way it does branch management, that is
[19:54] <OvenWerks> krytarik: That looks like the bug I filed :)
[19:54] <krytarik> hahaha
[19:55] <krytarik> (Of course it does.)
[19:56] <OvenWerks> I have 16.10 running on an old P4 hooked up to one of my monitors so I can switch back and forth.
[19:57] <zequence> OvenWerks: Adding icons to ALSA should be done upstream. Not in Ubuntu Studio
[19:57] <zequence> At the very least, it should be done in Debian packaging
[19:57] <OvenWerks> zequence: in general yes.
[19:57] <OvenWerks> it was removed upstream (see above) and should be readded.
[19:58] <OvenWerks> my thought was that the one they do include is rather poor, so an alternate is not a bad thing either.
[19:58] <krytarik> Actually, it's just a packaging issue in Debian - plus the file is still there in the source.
[19:58] <OvenWerks> So long as it doesn't try to overwrite the package icon it is fine.
[19:59] <OvenWerks> Good, will it make it in time to be added to 16.10?
[20:00] <zequence> alsa-tools is maintained by Debian ALSA maintainers
[20:00] <zequence> So, I can't push any changes there
[20:00] <zequence> The bug should be filed in Debian as well though
[20:00] <zequence> And, the bug fix in Ubuntu needs to be a patch, if not a sync from a fixed Debian package
[20:01] <zequence> Actually, who packages the alsa-tools package in Ubuntu?
[20:01]  * zequence is not on Ubuntu right now
[20:01] <zequence> Seems like it's packaged in Debian
[20:04] <OvenWerks> So including a patch to the bug will not help unless done in debian. (actually it looks like a simple revert)
[20:04] <zequence> After Debian Import Freeze patching the Ubuntu package is ok
[20:04] <zequence> But, it needs to be in the form of a patch, since the packagin is done upstream
[20:05] <zequence> It would be better to fix it in Debian first, and the sync from there, to not having to do the same thing twice
[20:05] <OvenWerks> I agree.
[20:06] <zequence> krytarik: Do you spot what the error is, more exactly?
[20:06] <zequence> It's easy enough to get the source from Debian, and check if it is still there, or someone fixed it recently
[20:07] <zequence> If not fixed in Debian, I might be able to do a bug report, but not for a couple of days at least (getting late, and tomorrow I have plans)
[20:10]  * zequence is disappearing for a while
[20:10] <krytarik> zequence: Yes - the change in 'debian/alsa-tools-gui.install', more specifically.
[20:11] <zequence> krytarik: Thanks